{"thread":{"id":"4990","subject":"[PATCH 3/5] git-instaweb: store parameters in config","startedAt":"2006-07-26T14:33:43Z","lastAt":"2006-07-26T21:13:53Z","messageCount":4,"participants":["Johannes Schindelin","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":5},"messages":[{"id":"24132","messageId":"Pine.LNX.4.63.0607261633320.29667@wbgn013.biozentrum.uni-wuerzburg.de","threadId":"4990","inReplyTo":null,"subject":"[PATCH 3/5] git-instaweb: store parameters in config","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2006-07-26T14:33:43Z","receivedAt":"2006-07-26T14:33:43Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"\nIt already reads the config for defaults, and now it also stores\nthe last passed parameters in the config.\n\nSigned-off-by: Johannes Schindelin \n---\n git-instaweb.sh | 5 +++++\n 1 files changed, 5 insertions(+), 0 deletions(-)\n\ndiff --git a/git-instaweb.sh b/git-instaweb.sh\nindex 9829c59..1d3ea73 100755\n--- a/git-instaweb.sh\n+++ b/git-instaweb.sh\n@@ -78,6 +78,7 @@ do\n \t\t;;\n \t--local|-l)\n \t\tlocal=true\n+\t\tgit repo-config instaweb.local true\n \t\t;;\n \t-d|--httpd|--httpd=*)\n \t\tcase \"$#,$1\" in\n@@ -89,6 +90,7 @@ do\n \t\t\thttpd=\"$2\"\n \t\t\tshift ;;\n \t\tesac\n+\t\tgit-repo-config instaweb.httpd \"$httpd\"\n \t\t;;\n \t-b|--browser|--browser=*)\n \t\tcase \"$#,$1\" in\n@@ -100,6 +102,7 @@ do\n \t\t\tbrowser=\"$2\"\n \t\t\tshift ;;\n \t\tesac\n+\t\tgit-repo-config instaweb.browser \"$browser\"\n \t\t;;\n \t-p|--port|--port=*)\n \t\tcase \"$#,$1\" in\n@@ -111,6 +114,7 @@ do\n \t\t\tport=\"$2\"\n \t\t\tshift ;;\n \t\tesac\n+\t\tgit-repo-config instaweb.port \"$port\"\n \t\t;;\n \t-m|--module-path=*|--module-path)\n \t\tcase \"$#,$1\" in\n@@ -122,6 +126,7 @@ do\n \t\t\tmodule_path=\"$2\"\n \t\t\tshift ;;\n \t\tesac\n+\t\tgit-repo-config instaweb.modulepath \"$module_path\"\n \t\t;;\n \t*)\n \t\tusage\n-- \n1.4.2.rc2.g6a4e\n"},{"id":"24155","messageId":"7v3bcorxbd.fsf@assigned-by-dhcp.cox.net","threadId":"4990","inReplyTo":"Pine.LNX.4.63.0607261633320.29667@wbgn013.biozentrum.uni-wuerzburg.de","subject":"Re: [PATCH 3/5] git-instaweb: store parameters in config","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-07-26T19:16:38Z","receivedAt":"2006-07-26T19:16:38Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Johannes Schindelin writes:\n\n> It already reads the config for defaults, and now it also stores\n> the last passed parameters in the config.\n\nThis might need to be conditional -- usually people override the\ndefault from the command line as a one-shot thing, and storing\nthem in the configuration file would upset them.\n"},{"id":"24158","messageId":"Pine.LNX.4.63.0607262147280.29667@wbgn013.biozentrum.uni-wuerzburg.de","threadId":"4990","inReplyTo":"7v3bcorxbd.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH 3/5] git-instaweb: store parameters in config","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2006-07-26T19:53:30Z","receivedAt":"2006-07-26T19:53:30Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Wed, 26 Jul 2006, Junio C Hamano wrote:\n\n> Johannes Schindelin writes:\n> \n> > It already reads the config for defaults, and now it also stores\n> > the last passed parameters in the config.\n> \n> This might need to be conditional -- usually people override the\n> default from the command line as a one-shot thing, and storing\n> them in the configuration file would upset them.\n\nI agree that this should be conditional, but the other way round, no? \ngit-instaweb is meant as a one-shot install thing, so I would like to do \nthis in some arbitrary repo:\n\n\tgit-instaweb\n\nand see a browser. Okay, so it does not work: I do not have LigHTTP, and \nmy apache is not in the path (and you need to specify the modules-path \nanyway, if it is different than /usr/lib/apache2/modules), so I do\n\n\tgit-instaweb --httpd=/usr/local/apache2/bin/httpd\\ -f \\\n\t\t--module-path=/usr/local/apache2/modules\n\nWorks! After I played a little with it (or rebooted the computer), I would \nlike to start it again:\n\n\tgit-instaweb\n\nMy point being: you do not really need a different configuration with \ngit-instaweb, once you got it right.\n\nCiao,\nDscho\n"},{"id":"24166","messageId":"Pine.LNX.4.63.0607262311560.29667@wbgn013.biozentrum.uni-wuerzburg.de","threadId":"4990","inReplyTo":"Pine.LNX.4.63.0607262147280.29667@wbgn013.biozentrum.uni-wuerzburg.de","subject":"Re: [PATCH 3/5] git-instaweb: store parameters in config","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2006-07-26T21:13:53Z","receivedAt":"2006-07-26T21:13:53Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Wed, 26 Jul 2006, Johannes Schindelin wrote:\n\n> On Wed, 26 Jul 2006, Junio C Hamano wrote:\n> \n> > Johannes Schindelin writes:\n> > \n> > > It already reads the config for defaults, and now it also stores\n> > > the last passed parameters in the config.\n> > \n> > This might need to be conditional -- usually people override the\n> > default from the command line as a one-shot thing, and storing\n> > them in the configuration file would upset them.\n> \n> I agree that this should be conditional, but the other way round, no? \n\nBeing bitten by my own words. It is plain dumb to store parameters for \nwhich instaweb fails. And my patch did that. Oh, well.\n\nSo, I'd say: just forget about patches [3-5]/5.\n\nCiao,\nDscho\n"}]}