{"thread":{"id":"49794","subject":"[PATCH] Fix broken command-list.h generation with core.autocrlf","startedAt":"2018-11-10T18:23:32Z","lastAt":"2018-11-10T18:23:32Z","messageCount":1,"participants":["Nguyễn Thái Ngọc Duy"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"362895","messageId":"20181110182323.26053-1-pclouds@gmail.com","threadId":"49794","inReplyTo":null,"subject":"[PATCH] Fix broken command-list.h generation with core.autocrlf","fromName":"Nguyễn Thái Ngọc Duy","fromEmail":"pclouds@gmail.com","sentAt":"2018-11-10T18:23:23Z","receivedAt":"2018-11-10T18:23:32Z","isPatch":true,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"The script generate-cmdlist.sh needs input text files in UNIX line\nending to work correctly. It's been fine even with core.autocrlf set\nbecause Documentation/git-*.txt is forced LF conversion.\n\nBut this leaves out gitk.txt and also Documentation/*config.txt that\nrecently becomes new input for this script. Update the attribute file\nto force LF on all *.txt files to be on the safe side.\n\nFor more details, please see 00ddc9d13c (Fix build with\ncore.autocrlf=true - 2017-05-09)\n\nSigned-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>\n---\n Some tests must have broken out of the test repo and set\n core.autocrlf on my $GIT_DIR/config. Fun was not had.\n\n .gitattributes | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/.gitattributes b/.gitattributes\nindex 49b3051641..acf853e029 100644\n--- a/.gitattributes\n+++ b/.gitattributes\n@@ -5,7 +5,7 @@\n *.pl eof=lf diff=perl\n *.pm eol=lf diff=perl\n *.py eol=lf diff=python\n-/Documentation/git-*.txt eol=lf\n+/Documentation/**/*.txt eol=lf\n /command-list.txt eol=lf\n /GIT-VERSION-GEN eol=lf\n /mergetools/* eol=lf\n-- \n2.19.1.1231.g84aef82467\n\n"}]}