{"thread":{"id":"4979","subject":"[PATCH] cvsserver: suppress warnings","startedAt":"2006-07-25T10:48:52Z","lastAt":"2006-07-25T20:23:59Z","messageCount":9,"participants":["Johannes Schindelin","Martin Langhoff (CatalystIT)","Martin Langhoff","Mike Galbraith","Ryan Anderson"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"24084","messageId":"Pine.LNX.4.63.0607251247040.29667@wbgn013.biozentrum.uni-wuerzburg.de","threadId":"4979","inReplyTo":null,"subject":"[PATCH] cvsserver: suppress warnings","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2006-07-25T10:48:52Z","receivedAt":"2006-07-25T10:48:52Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"\nThis patch defines $state->{prependdir} as the empty string, so that\nquite a few warnings are avoided.\n\nSigned-off-by: Johannes Schindelin \n---\n\n\tI still get this warning:\n\n\t\tclosing dbh with active statement handles\n\n git-cvsserver.perl | 2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/git-cvsserver.perl b/git-cvsserver.perl\nindex 9c9f21b..981b6ba 100755\n--- a/git-cvsserver.perl\n+++ b/git-cvsserver.perl\n@@ -81,7 +81,7 @@ ########################################\n \n # $state holds all the bits of information the clients sends us that could\n # potentially be useful when it comes to actually _doing_ something.\n-my $state = {};\n+my $state = { prependdir => '' };\n $log->info(\"--------------- STARTING -----------------\");\n \n my $TEMP_DIR = tempdir( CLEANUP => 1 );\n-- \n1.4.2.rc1.gc123\n"},{"id":"24085","messageId":"44C5FB3E.9020301@catalyst.net.nz","threadId":"4979","inReplyTo":"Pine.LNX.4.63.0607251247040.29667@wbgn013.biozentrum.uni-wuerzburg.de","subject":"Re: [PATCH] cvsserver: suppress warnings","fromName":"Martin Langhoff (CatalystIT)","fromEmail":"martin@catalyst.net.nz","sentAt":"2006-07-25T11:06:38Z","receivedAt":"2006-07-25T11:06:38Z","isPatch":true,"sender":{"key":"martin@laptop.org","avatar":null},"body":"Johannes Schindelin wrote:\n\n> This patch defines $state->{prependdir} as the empty string, so that\n> quite a few warnings are avoided.\n\nAck.\n\n> \tI still get this warning:\n> \n> \t\tclosing dbh with active statement handles\n\nAck to that too. Perhaps an END block would help? A quick check of man \nDBI tells me that $dbh->CachedKids will be a hashref where the values \nare refs to the cached statement handles.\n\nIMHO it's a DBI bug -- statement handles only referenced by \n$dbh->CachedKids should cleanup silently. prepare_cached() is a \nconvenience method so that you _don't_ have to keep track of the handles \nmanually. Forcing a manual cleanup throws a good part of the convenience \nout.\n\ncheers,\n\n\n\nmartin\n-- \n-----------------------------------------------------------------------\nMartin @ Catalyst .Net .NZ Ltd, PO Box 11-053, Manners St, Wellington\nWEB: http://catalyst.net.nz/ PHYS: Level 2, 150-154 Willis St\nOFFICE: +64(4)916-7224 MOB: +64(21)364-017\n Make things as simple as possible, but no simpler - Einstein\n-----------------------------------------------------------------------\n"},{"id":"24086","messageId":"Pine.LNX.4.63.0607251308380.29667@wbgn013.biozentrum.uni-wuerzburg.de","threadId":"4979","inReplyTo":"44C5FB3E.9020301@catalyst.net.nz","subject":"Re: [PATCH] cvsserver: suppress warnings","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2006-07-25T11:11:35Z","receivedAt":"2006-07-25T11:11:35Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Tue, 25 Jul 2006, Martin Langhoff (CatalystIT) wrote:\n\n> Johannes Schindelin wrote:\n> \n> > \tI still get this warning:\n> > \n> > \t\tclosing dbh with active statement handles\n> \n> Ack to that too. Perhaps an END block would help?\n\nSince my BASIC days on a VC-20 (no, not the airplane), I hardly used an \nEND statement ;-) Well, maybe in that Pascal course, but not in Perl, \nanyway. So, I do not understand...\n\n> A quick check of man DBI tells me that $dbh->CachedKids will be a \n> hashref where the values are refs to the cached statement handles.\n> \n> IMHO it's a DBI bug -- statement handles only referenced by $dbh->CachedKids\n> should cleanup silently. prepare_cached() is a convenience method so that you\n> _don't_ have to keep track of the handles manually. Forcing a manual cleanup\n> throws a good part of the convenience out.\n\nI agree fully.\n\nCiao,\nDscho\n"},{"id":"24087","messageId":"46a038f90607250450l643f97e4sbece300fa5b2d509@mail.gmail.com","threadId":"4979","inReplyTo":"Pine.LNX.4.63.0607251308380.29667@wbgn013.biozentrum.uni-wuerzburg.de","subject":"Re: [PATCH] cvsserver: suppress warnings","fromName":"Martin Langhoff","fromEmail":"martin.langhoff@gmail.com","sentAt":"2006-07-25T11:50:03Z","receivedAt":"2006-07-25T11:50:03Z","isPatch":true,"sender":{"key":"martin.langhoff@gmail.com","avatar":"https://gravatar.com/avatar/1e3f311b6c4c15836501901ca58f8c0b0667246488084ba524d8bc9867e22fd9?d=mp&s=160"},"body":"On 7/25/06, Johannes Schindelin wrote:\n\n> > Ack to that too. Perhaps an END block would help?\n>\n> Since my BASIC days on a VC-20 (no, not the airplane), I hardly used an\n> END statement ;-) Well, maybe in that Pascal course, but not in Perl,\n> anyway. So, I do not understand...\n\nOh, it's a code block you can declare that gets called when the\nprogram is exiting. More info at\nhttp://search.cpan.org/dist/perl/pod/perlmod.pod#BEGIN%2C_CHECK%2C_INIT_and_END____\n\nNo relation to BASIC's END ;-)\n\n\nmartin\n"},{"id":"24088","messageId":"Pine.LNX.4.63.0607251355360.29667@wbgn013.biozentrum.uni-wuerzburg.de","threadId":"4979","inReplyTo":"46a038f90607250450l643f97e4sbece300fa5b2d509@mail.gmail.com","subject":"Re: [PATCH] cvsserver: suppress warnings","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2006-07-25T11:56:41Z","receivedAt":"2006-07-25T11:56:41Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Tue, 25 Jul 2006, Martin Langhoff wrote:\n\n> On 7/25/06, Johannes Schindelin wrote:\n> \n> > > Ack to that too. Perhaps an END block would help?\n> > \n> > Since my BASIC days on a VC-20 (no, not the airplane), I hardly used an\n> > END statement ;-) Well, maybe in that Pascal course, but not in Perl,\n> > anyway. So, I do not understand...\n> \n> Oh, it's a code block you can declare that gets called when the\n> program is exiting. More info at\n> http://search.cpan.org/dist/perl/pod/perlmod.pod#BEGIN%2C_CHECK%2C_INIT_and_END____\n\nAh! Something like \"atexit()\".\n\n> No relation to BASIC's END ;-)\n\n;-)\n\nBTW I will send out a proper patch for that warning shortly.\n\nCiao,\nDscho\n"},{"id":"24090","messageId":"1153829608.2258.32.camel@Homer.simpson.net","threadId":"4979","inReplyTo":"Pine.LNX.4.63.0607251247040.29667@wbgn013.biozentrum.uni-wuerzburg.de","subject":"git-1.4.1.1-1 git-clone-pack: unable to read from git-index-pack","fromName":"Mike Galbraith","fromEmail":"efault@gmx.de","sentAt":"2006-07-25T12:13:28Z","receivedAt":"2006-07-25T12:13:28Z","isPatch":false,"sender":{"key":"efault@gmx.de","avatar":null},"body":"Greetings,\n\nHaving finally acquired DSL (only 400kbps, but at least I'm in the\ntwentieth century [not typo]), I decided to finally give git a try. I\ninstalled git-1.4.1.1-1, and armed myself with Jeff's how-to. I didn't\nget far before git saved me the trouble of truly testing my resolve :)\n\n\t-Mike\n\ngit clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git linux-2.6\nerror: git-clone-pack: unable to read from git-index-pack\nerror: git-index-pack died with error code 128\nclone-pack from 'git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git' failed\n"},{"id":"24092","messageId":"1153829908.2258.34.camel@Homer.simpson.net","threadId":"4979","inReplyTo":"1153829608.2258.32.camel@Homer.simpson.net","subject":"Re: git-1.4.1.1-1 git-clone-pack: unable to read from git-index-pack","fromName":"Mike Galbraith","fromEmail":"efault@gmx.de","sentAt":"2006-07-25T12:18:28Z","receivedAt":"2006-07-25T12:18:28Z","isPatch":false,"sender":{"key":"efault@gmx.de","avatar":null},"body":"On Tue, 2006-07-25 at 14:13 +0200, Mike Galbraith wrote:\n> Greetings,\n> \n> Having finally acquired DSL (only 400kbps, but at least I'm in the\n> twentieth century [not typo]), I decided to finally give git a try. I\n> installed git-1.4.1.1-1, and armed myself with Jeff's how-to. I didn't\n> get far before git saved me the trouble of truly testing my resolve :)\n> \n> \t-Mike\n> \n> git clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git linux-2.6\n\nOops, missed a line.\n\nfatal: packfile '/usr/local/src/tmp/linux-2.6/.git/objects/pack/tmp-nE9k3G' SHA1 mismatch\n\n> error: git-clone-pack: unable to read from git-index-pack\n> error: git-index-pack died with error code 128\n> clone-pack from 'git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git' failed\n"},{"id":"24094","messageId":"Pine.LNX.4.63.0607251655360.29667@wbgn013.biozentrum.uni-wuerzburg.de","threadId":"4979","inReplyTo":"1153829908.2258.34.camel@Homer.simpson.net","subject":"Re: git-1.4.1.1-1 git-clone-pack: unable to read from git-index-pack","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2006-07-25T14:57:39Z","receivedAt":"2006-07-25T14:57:39Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Tue, 25 Jul 2006, Mike Galbraith wrote:\n\n> On Tue, 2006-07-25 at 14:13 +0200, Mike Galbraith wrote:\n> > Greetings,\n> > \n> > Having finally acquired DSL (only 400kbps, but at least I'm in the\n> > twentieth century [not typo]), I decided to finally give git a try. I\n> > installed git-1.4.1.1-1, and armed myself with Jeff's how-to. I didn't\n> > get far before git saved me the trouble of truly testing my resolve :)\n> > \n> > \t-Mike\n> > \n> > git clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git linux-2.6\n> \n> Oops, missed a line.\n> \n> fatal: packfile '/usr/local/src/tmp/linux-2.6/.git/objects/pack/tmp-nE9k3G' SHA1 mismatch\n> \n> > error: git-clone-pack: unable to read from git-index-pack\n> > error: git-index-pack died with error code 128\n> > clone-pack from 'git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git' failed\n\nWas this after about 10 minutes? I had the impression that this was fixed \nwith the 1.4.1.1 version _on the server side_. See\n\nhttp://www.kernel.org/git/gitweb.cgi?p=git/git.git;a=commit;h=a0764cb838c2f1885fb58ca794c21523fb05c825\n\nfor details. So, please be patient until kernel.org's server is updated.\n\nHth,\nDscho\n"},{"id":"24102","messageId":"20060725202358.GI23286@h4x0r5.com","threadId":"4979","inReplyTo":"Pine.LNX.4.63.0607251655360.29667@wbgn013.biozentrum.uni-wuerzburg.de","subject":"Re: git-1.4.1.1-1 git-clone-pack: unable to read from git-index-pack","fromName":"Ryan Anderson","fromEmail":"ryan@michonline.com","sentAt":"2006-07-25T20:23:59Z","receivedAt":"2006-07-25T20:23:59Z","isPatch":false,"sender":{"key":"ryan@michonline.com","avatar":null},"body":"On Tue, Jul 25, 2006 at 04:57:39PM +0200, Johannes Schindelin wrote:\n> On Tue, 25 Jul 2006, Mike Galbraith wrote:\n> \n> > On Tue, 2006-07-25 at 14:13 +0200, Mike Galbraith wrote:\n> > > Greetings,\n> > > \n> > > Having finally acquired DSL (only 400kbps, but at least I'm in the\n> > > twentieth century [not typo]), I decided to finally give git a try. I\n> > > installed git-1.4.1.1-1, and armed myself with Jeff's how-to. I didn't\n> > > get far before git saved me the trouble of truly testing my resolve :)\n> > > \n> > > \t-Mike\n> > > \n> > > git clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git linux-2.6\n> > \n> > Oops, missed a line.\n> > \n> > fatal: packfile '/usr/local/src/tmp/linux-2.6/.git/objects/pack/tmp-nE9k3G' SHA1 mismatch\n> > \n> > > error: git-clone-pack: unable to read from git-index-pack\n> > > error: git-index-pack died with error code 128\n> > > clone-pack from 'git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git' failed\n> \n> Was this after about 10 minutes? I had the impression that this was fixed \n> with the 1.4.1.1 version _on the server side_. See\n> \n> http://www.kernel.org/git/gitweb.cgi?p=git/git.git;a=commit;h=a0764cb838c2f1885fb58ca794c21523fb05c825\n> \n> for details. So, please be patient until kernel.org's server is updated.\n\nOr do your initial clone as:\n\ngit clone rsync://rsync.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git linux-2.6\ncd linux-2.6 && sed -i -e 's/rsync/git/g' .git/remotes/origin\n\n(The preferred thing is for the method you used to work, but the above\nwill avoid the bug for the moment.)\n-- \n\nRyan Anderson\n sometimes Pug Majere\n"}]}