{"thread":{"id":"49700","subject":"[PATCH] update git-http-backend doc for lighttpd","startedAt":"2018-10-28T00:17:35Z","lastAt":"2018-10-29T03:19:33Z","messageCount":2,"participants":["Glenn Strauss","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"361821","messageId":"01020166b80743cd-0b220d55-a283-456b-a3c3-bdea8aafed8a-000000@eu-west-1.amazonses.com","threadId":"49700","inReplyTo":null,"subject":"[PATCH] update git-http-backend doc for lighttpd","fromName":"Glenn Strauss","fromEmail":"gstrauss@gluelogic.com","sentAt":"2018-10-28T00:16:15Z","receivedAt":"2018-10-28T00:17:35Z","isPatch":true,"sender":{"key":"gstrauss@gluelogic.com","avatar":null},"body":"use \"GIT_HTTP_EXPORT_ALL\" => \"1\" with a value for best compatiblity.\nlighttpd 1.4.51 setenv.add-environment does add vars with empty value.\nlighttpd setenv.set-environment does, but was only introduced in 1.4.46\n\ngit-http-backend may be found at /usr/libexec/git-core/git-http-backend\n\nscope lighttpd config directives for git-http-backend under \"^/git\"\n\nSigned-off-by: Glenn Strauss <gstrauss@gluelogic.com>\n---\n Documentation/git-http-backend.txt | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/Documentation/git-http-backend.txt b/Documentation/git-http-backend.txt\nindex bb0db195cebd6..905aa1056d26f 100644\n--- a/Documentation/git-http-backend.txt\n+++ b/Documentation/git-http-backend.txt\n@@ -192,16 +192,16 @@ ScriptAlias /git/ /var/www/cgi-bin/gitweb.cgi/\n \n Lighttpd::\n \tEnsure that `mod_cgi`, `mod_alias`, `mod_auth`, `mod_setenv` are\n-\tloaded, then set `GIT_PROJECT_ROOT` appropriately and redirect\n-\tall requests to the CGI:\n+\tloaded, then set path to git-http-backend, set `GIT_PROJECT_ROOT`\n+\tappropriately, and redirect all requests to the CGI:\n +\n ----------------------------------------------------------------\n-alias.url += ( \"/git\" => \"/usr/lib/git-core/git-http-backend\" )\n $HTTP[\"url\"] =~ \"^/git\" {\n+\talias.url += (\"/git\" => \"/usr/libexec/git-core/git-http-backend\")\n \tcgi.assign = (\"\" => \"\")\n \tsetenv.add-environment = (\n \t\t\"GIT_PROJECT_ROOT\" => \"/var/www/git\",\n-\t\t\"GIT_HTTP_EXPORT_ALL\" => \"\"\n+\t\t\"GIT_HTTP_EXPORT_ALL\" => \"1\"\n \t)\n }\n ----------------------------------------------------------------\n\n--\nhttps://github.com/git/git/pull/546\n"},{"id":"361863","messageId":"xmqq8t2h8mo0.fsf@gitster-ct.c.googlers.com","threadId":"49700","inReplyTo":"01020166b80743cd-0b220d55-a283-456b-a3c3-bdea8aafed8a-000000@eu-west-1.amazonses.com","subject":"Re: [PATCH] update git-http-backend doc for lighttpd","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2018-10-29T03:19:27Z","receivedAt":"2018-10-29T03:19:33Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Glenn Strauss <gstrauss@gluelogic.com> writes:\n\n> use \"GIT_HTTP_EXPORT_ALL\" => \"1\" with a value for best compatiblity.\n> lighttpd 1.4.51 setenv.add-environment does add vars with empty value.\n> lighttpd setenv.set-environment does, but was only introduced in 1.4.46\n>\n> git-http-backend may be found at /usr/libexec/git-core/git-http-backend\n>\n> scope lighttpd config directives for git-http-backend under \"^/git\"\n>\n> Signed-off-by: Glenn Strauss <gstrauss@gluelogic.com>\n> ---\n>  Documentation/git-http-backend.txt | 8 ++++----\n>  1 file changed, 4 insertions(+), 4 deletions(-)\n>\n> diff --git a/Documentation/git-http-backend.txt b/Documentation/git-http-backend.txt\n> index bb0db195cebd6..905aa1056d26f 100644\n> --- a/Documentation/git-http-backend.txt\n> +++ b/Documentation/git-http-backend.txt\n> @@ -192,16 +192,16 @@ ScriptAlias /git/ /var/www/cgi-bin/gitweb.cgi/\n>  \n>  Lighttpd::\n>  \tEnsure that `mod_cgi`, `mod_alias`, `mod_auth`, `mod_setenv` are\n> -\tloaded, then set `GIT_PROJECT_ROOT` appropriately and redirect\n> -\tall requests to the CGI:\n> +\tloaded, then set path to git-http-backend, set `GIT_PROJECT_ROOT`\n> +\tappropriately, and redirect all requests to the CGI:\n\nThe addition here is\n\n\tset path to git-http-backend\n\nThat reads as if you are telling the reader to do this\n\n\tGIT_PROJECT_ROOT => \"/var/www/git\",\n\tpath => \"/usr/libexec/git-core/git-http-backend\"\n\nbecause the descriptions for these two are next to each other and so\nsimilar, but I somehow do not think you meant there is a variable\nwhose name is `path` (note that I do not use lighttpd and am not an\nexpert on its configuration---which makes me the ideal guinea pig to\njudge if your update makes sense to the target audience).\n\nDo you mean something like\n\n\tuse `alias.url` to mark that `/git` hierarchy is handled by\n\tthe `git-http-backend` binary (use the full path to the\n\tprogram).\n\nI do not see any quoting in your updated text, but many of what the\nend-user needs to type literally must be `quoted for monospace`, I\nwould think.\n\n>  +\n>  ----------------------------------------------------------------\n> -alias.url += ( \"/git\" => \"/usr/lib/git-core/git-http-backend\" )\n>  $HTTP[\"url\"] =~ \"^/git\" {\n> +\talias.url += (\"/git\" => \"/usr/libexec/git-core/git-http-backend\")\n>  \tcgi.assign = (\"\" => \"\")\n>  \tsetenv.add-environment = (\n>  \t\t\"GIT_PROJECT_ROOT\" => \"/var/www/git\",\n> -\t\t\"GIT_HTTP_EXPORT_ALL\" => \"\"\n> +\t\t\"GIT_HTTP_EXPORT_ALL\" => \"1\"\n>  \t)\n>  }\n>  ----------------------------------------------------------------\n>\n> --\n> https://github.com/git/git/pull/546\n\nThanks.\n"}]}