{"thread":{"id":"4966","subject":"[PATCH] gitweb.cgi: git_blame2: slight optimization reading the blame lines","startedAt":"2006-07-23T21:17:48Z","lastAt":"2006-07-23T21:17:48Z","messageCount":1,"participants":["Luben Tuikov"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"24028","messageId":"20060723211748.77065.qmail@web31814.mail.mud.yahoo.com","threadId":"4966","inReplyTo":null,"subject":"[PATCH] gitweb.cgi: git_blame2: slight optimization reading the blame lines","fromName":"Luben Tuikov","fromEmail":"ltuikov@yahoo.com","sentAt":"2006-07-23T21:17:48Z","receivedAt":"2006-07-23T21:17:48Z","isPatch":true,"sender":{"key":"ltuikov@yahoo.com","avatar":null},"body":"Eliminate git_read_blame_line() -- move that code inline and\noptimize it.\n\nSigned-off-by: Luben Tuikov <ltuikov@yahoo.com>\n---\n gitweb/gitweb.cgi |   19 +++++--------------\n 1 files changed, 5 insertions(+), 14 deletions(-)\n\ndiff --git a/gitweb/gitweb.cgi b/gitweb/gitweb.cgi\nindex 16340f2..7fbfc0d 100755\n--- a/gitweb/gitweb.cgi\n+++ b/gitweb/gitweb.cgi\n@@ -1252,15 +1252,6 @@ sub git_tag {\n \tgit_footer_html();\n }\n \n-sub git_read_blame_line {\n-\tmy %bl;\n-\t$_ = shift;\n-\n-\t($bl{'hash'}, $bl{'lineno'}, $bl{'data'}) = /^([0-9a-fA-F]{40}).*?(\\d+)\\)\\s{1}(\\s*.*)/;\n-\n-\treturn %bl;\n-}\n-\n sub git_blame2 {\n \tmy $fd;\n \tmy $ftype;\n@@ -1302,13 +1293,12 @@ sub git_blame2 {\n \tprint \"<div class=\\\"page_body\\\">\\n\";\n \tprint \"<table class=\\\"blame\\\">\\n\";\n \tprint \"<tr><th>Commit</th><th>Line</th><th>Data</th></tr>\\n\";\n-\twhile (my $line = <$fd>) {\n-\t\tmy %blame_line = git_read_blame_line($line);\n-\t\tmy $full_rev = $blame_line{'hash'};\n+\twhile (<$fd>) {\n+\t\t/^([0-9a-fA-F]{40}).*?(\\d+)\\)\\s{1}(\\s*.*)/;\n+\t\tmy $full_rev = $1;\n \t\tmy $rev = substr($full_rev, 0, 8);\n-\t\tmy $lineno = $blame_line{'lineno'};\n-\t\tmy $data = $blame_line{'data'};\n+\t\tmy $lineno = $2;\n+\t\tmy $data = $3;\n \n \t\tif (!defined $last_rev) {\n \t\t\t$last_rev = $full_rev;\n-- \n1.4.2.rc1.g9b54\n\n"}]}