{"thread":{"id":"49629","subject":"[PATCH] gitk: Do not mistake unchanged lines with submodule changes","startedAt":"2018-10-21T16:34:25Z","lastAt":"2018-10-21T16:40:59Z","messageCount":2,"participants":["Dummy Name","Gabriele Mazzotta"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"361097","messageId":"20181021163401.4458-1-dummy@example.com","threadId":"49629","inReplyTo":null,"subject":"[PATCH] gitk: Do not mistake unchanged lines with submodule changes","fromName":"Dummy Name","fromEmail":"gabriele.mzt@gmail.com","sentAt":"2018-10-21T16:34:01Z","receivedAt":"2018-10-21T16:34:25Z","isPatch":true,"sender":{"key":"gabriele.mzt@gmail.com","avatar":"https://avatars.githubusercontent.com/u/54670603?v=4"},"body":"From: Gabriele Mazzotta <gabriele.mzt@gmail.com>\n\nUnchanged lines are prefixed with a white-space, thus unchanged lines\nstarting with either \" <\" or \" >\" are mistaken for submodule changes.\nCheck if a line starts with either \"  <\" or \"  >\" only if we listing\nthe changes of a submodule.\n\nSigned-off-by: Gabriele Mazzotta <gabriele.mzt@gmail.com>\n---\n gitk | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/gitk b/gitk\nindex a14d7a1..dd4bbbf 100755\n--- a/gitk\n+++ b/gitk\n@@ -8191,11 +8191,11 @@ proc parseblobdiffline {ids line} {\n \t} else {\n \t    $ctext insert end \"$line\\n\" filesep\n \t}\n-    } elseif {![string compare -length 3 \"  >\" $line]} {\n+    } elseif {$currdiffsubmod != \"\" && ![string compare -length 3 \"  >\" $line]} {\n \tset $currdiffsubmod \"\"\n \tset line [encoding convertfrom $diffencoding $line]\n \t$ctext insert end \"$line\\n\" dresult\n-    } elseif {![string compare -length 3 \"  <\" $line]} {\n+    } elseif {$currdiffsubmod != \"\" && ![string compare -length 3 \"  <\" $line]} {\n \tset $currdiffsubmod \"\"\n \tset line [encoding convertfrom $diffencoding $line]\n \t$ctext insert end \"$line\\n\" d0\n-- \n2.19.1\n\n"},{"id":"361098","messageId":"fcef23d5-e2b3-cb3a-9ccf-75a0cc126d0b@gmail.com","threadId":"49629","inReplyTo":"20181021163401.4458-1-dummy@example.com","subject":"Re: [PATCH] gitk: Do not mistake unchanged lines with submodule changes","fromName":"Gabriele Mazzotta","fromEmail":"gabriele.mzt@gmail.com","sentAt":"2018-10-21T16:39:39Z","receivedAt":"2018-10-21T16:40:59Z","isPatch":true,"sender":{"key":"gabriele.mzt@gmail.com","avatar":"https://avatars.githubusercontent.com/u/54670603?v=4"},"body":"On 21/10/18 18:34, Dummy Name wrote:\n> From: Gabriele Mazzotta <gabriele.mzt@gmail.com>\n> \n> Unchanged lines are prefixed with a white-space, thus unchanged lines\n> starting with either \" <\" or \" >\" are mistaken for submodule changes.\n> Check if a line starts with either \"  <\" or \"  >\" only if we listing\n> the changes of a submodule.\n> \n> Signed-off-by: Gabriele Mazzotta <gabriele.mzt@gmail.com>\n\nHi,\n\nI accidentally pressed Enter before I could set the committer\nto the correct value. I can resend the patch if necessary.\n\nRegards,\nGabriele\n"}]}