{"thread":{"id":"49601","subject":"[PATCH v2] headers: normalize the spelling of some header guards","startedAt":"2018-10-17T22:13:31Z","lastAt":"2018-10-18T04:40:32Z","messageCount":2,"participants":["Ramsay Jones","Junio C Hamano"],"isPatch":true,"patchVersion":2,"patchTotal":null},"messages":[{"id":"360789","messageId":"b33346d2-88bb-989a-356b-43a7c357a7dd@ramsayjones.plus.com","threadId":"49601","inReplyTo":null,"subject":"[PATCH v2] headers: normalize the spelling of some header guards","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2018-10-17T22:13:26Z","receivedAt":"2018-10-17T22:13:31Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nSigned-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n---\n\nHi Junio,\n\nSince I didn't get any adverse comments, this version has the RFC\nlabel removed. Also, given that it seems the vcs-svn directory is\nnot going away soon, I have included those headers this time as well.\n\n[Note: my email client (thunderbird) was updated yesterday to 60.2.1.\nAs a result of recent reports, I sent this patch to myself and applied\nit with 'git am' and ... the results seem to be fine! ;-) Famous last\nwords!]\n\nThanks.\n\nATB,\nRamsay Jones\n\n alias.h                  | 4 ++--\n commit-reach.h           | 4 ++--\n fetch-negotiator.h       | 4 ++--\n midx.h                   | 4 ++--\n t/helper/test-tool.h     | 4 ++--\n vcs-svn/fast_export.h    | 4 ++--\n vcs-svn/line_buffer.h    | 4 ++--\n vcs-svn/sliding_window.h | 4 ++--\n vcs-svn/svndiff.h        | 4 ++--\n vcs-svn/svndump.h        | 4 ++--\n 10 files changed, 20 insertions(+), 20 deletions(-)\n\ndiff --git a/alias.h b/alias.h\nindex 79933f2457..aef4843bb7 100644\n--- a/alias.h\n+++ b/alias.h\n@@ -1,5 +1,5 @@\n-#ifndef __ALIAS_H__\n-#define __ALIAS_H__\n+#ifndef ALIAS_H\n+#define ALIAS_H\n \n struct string_list;\n \ndiff --git a/commit-reach.h b/commit-reach.h\nindex 7d313e2975..122a23a24d 100644\n--- a/commit-reach.h\n+++ b/commit-reach.h\n@@ -1,5 +1,5 @@\n-#ifndef __COMMIT_REACH_H__\n-#define __COMMIT_REACH_H__\n+#ifndef COMMIT_REACH_H\n+#define COMMIT_REACH_H\n \n #include \"commit-slab.h\"\n \ndiff --git a/fetch-negotiator.h b/fetch-negotiator.h\nindex ddb44a22dc..9e3967ce66 100644\n--- a/fetch-negotiator.h\n+++ b/fetch-negotiator.h\n@@ -1,5 +1,5 @@\n-#ifndef FETCH_NEGOTIATOR\n-#define FETCH_NEGOTIATOR\n+#ifndef FETCH_NEGOTIATOR_H\n+#define FETCH_NEGOTIATOR_H\n \n struct commit;\n \ndiff --git a/midx.h b/midx.h\nindex ce80b91c68..ee83702309 100644\n--- a/midx.h\n+++ b/midx.h\n@@ -1,5 +1,5 @@\n-#ifndef __MIDX_H__\n-#define __MIDX_H__\n+#ifndef MIDX_H\n+#define MIDX_H\n \n #include \"repository.h\"\n \ndiff --git a/t/helper/test-tool.h b/t/helper/test-tool.h\nindex e4890566da..71f470b871 100644\n--- a/t/helper/test-tool.h\n+++ b/t/helper/test-tool.h\n@@ -1,5 +1,5 @@\n-#ifndef __TEST_TOOL_H__\n-#define __TEST_TOOL_H__\n+#ifndef TEST_TOOL_H\n+#define TEST_TOOL_H\n \n #include \"git-compat-util.h\"\n \ndiff --git a/vcs-svn/fast_export.h b/vcs-svn/fast_export.h\nindex 60b79c35b9..9dcf9337c1 100644\n--- a/vcs-svn/fast_export.h\n+++ b/vcs-svn/fast_export.h\n@@ -1,5 +1,5 @@\n-#ifndef FAST_EXPORT_H_\n-#define FAST_EXPORT_H_\n+#ifndef FAST_EXPORT_H\n+#define FAST_EXPORT_H\n \n struct strbuf;\n struct line_buffer;\ndiff --git a/vcs-svn/line_buffer.h b/vcs-svn/line_buffer.h\nindex ee23b4f490..e192aedea2 100644\n--- a/vcs-svn/line_buffer.h\n+++ b/vcs-svn/line_buffer.h\n@@ -1,5 +1,5 @@\n-#ifndef LINE_BUFFER_H_\n-#define LINE_BUFFER_H_\n+#ifndef LINE_BUFFER_H\n+#define LINE_BUFFER_H\n \n #include \"strbuf.h\"\n \ndiff --git a/vcs-svn/sliding_window.h b/vcs-svn/sliding_window.h\nindex b43a825cba..189c32d84c 100644\n--- a/vcs-svn/sliding_window.h\n+++ b/vcs-svn/sliding_window.h\n@@ -1,5 +1,5 @@\n-#ifndef SLIDING_WINDOW_H_\n-#define SLIDING_WINDOW_H_\n+#ifndef SLIDING_WINDOW_H\n+#define SLIDING_WINDOW_H\n \n #include \"strbuf.h\"\n \ndiff --git a/vcs-svn/svndiff.h b/vcs-svn/svndiff.h\nindex 74eb464bab..10a2cbc40e 100644\n--- a/vcs-svn/svndiff.h\n+++ b/vcs-svn/svndiff.h\n@@ -1,5 +1,5 @@\n-#ifndef SVNDIFF_H_\n-#define SVNDIFF_H_\n+#ifndef SVNDIFF_H\n+#define SVNDIFF_H\n \n struct line_buffer;\n struct sliding_view;\ndiff --git a/vcs-svn/svndump.h b/vcs-svn/svndump.h\nindex b8eb12954e..26faed5968 100644\n--- a/vcs-svn/svndump.h\n+++ b/vcs-svn/svndump.h\n@@ -1,5 +1,5 @@\n-#ifndef SVNDUMP_H_\n-#define SVNDUMP_H_\n+#ifndef SVNDUMP_H\n+#define SVNDUMP_H\n \n int svndump_init(const char *filename);\n int svndump_init_fd(int in_fd, int back_fd);\n-- \n2.19.0\n"},{"id":"360813","messageId":"xmqqd0s7vpdw.fsf@gitster-ct.c.googlers.com","threadId":"49601","inReplyTo":"b33346d2-88bb-989a-356b-43a7c357a7dd@ramsayjones.plus.com","subject":"Re: [PATCH v2] headers: normalize the spelling of some header guards","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2018-10-18T04:40:27Z","receivedAt":"2018-10-18T04:40:32Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Ramsay Jones <ramsay@ramsayjones.plus.com> writes:\n\n> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n> ---\n>\n> Hi Junio,\n>\n> Since I didn't get any adverse comments, this version has the RFC\n> label removed. Also, given that it seems the vcs-svn directory is\n> not going away soon, I have included those headers this time as well.\n>\n> [Note: my email client (thunderbird) was updated yesterday to 60.2.1.\n> As a result of recent reports, I sent this patch to myself and applied\n> it with 'git am' and ... the results seem to be fine! ;-) Famous last\n> words!]\n\nThanks, will queue.\n"}]}