{"thread":{"id":"49589","subject":"[PATCH 0/1] Run GIT_TEST_COMMIT_GRAPH and GIT_TEST_MULTI_PACK_INDEX during CI","startedAt":"2018-10-17T13:00:35Z","lastAt":"2018-10-17T13:04:17Z","messageCount":3,"participants":["Derrick Stolee via GitGitGadget","Derrick Stolee"],"isPatch":true,"patchVersion":1,"patchTotal":1},"messages":[{"id":"360744","messageId":"pull.49.git.gitgitgadget@gmail.com","threadId":"49589","inReplyTo":null,"subject":"[PATCH 0/1] Run GIT_TEST_COMMIT_GRAPH and GIT_TEST_MULTI_PACK_INDEX during CI","fromName":"Derrick Stolee via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2018-10-17T13:00:32Z","receivedAt":"2018-10-17T13:00:35Z","isPatch":true,"sender":{"key":"stolee@gmail.com","avatar":"https://avatars.githubusercontent.com/u/570044?v=4"},"body":"Our CI scripts include a step to run the test suite with certain optional\nvariables enabled. Now that all branches should build and have tests succeed\nwith GIT_TEST_COMMIT_GRAPH and GIT_TEST_MULTI_PACK_INDEX enabled, add those\nvariables to that stage.\n\nNote: the GIT_TEST_MULTI_PACK_INDEX variable has not merged all the way\ndown, so will be ignored if this series is merged faster than that one.\nHowever, it is safe to make these changes orthogonally as all (known) test\nbreaks with GIT_TEST_MULTI_PACK_INDEX=1 are fixed in the topic that\nintroduces the variable.\n\nI also created a build definition on Azure Pipelines that runs the test\nsuite with different subsets of the test variables, split by the following\ntypes:\n\n1) Index options 2) Commit-graph 3) Multi-pack-index\n\nThese builds are found at [1]. There are benefits to testing the variables\nall together but also separately. I didn't want to create new stages in the\nCI scripts to avoid consuming extra resources.\n\nThis series is based on js/vsts-ci to avoid conflicts with that series, but\nis not necessarily a hard dependence.\n\nThanks, -Stolee\n\n[1] https://git.visualstudio.com/git/_build?definitionId=4Build definition\nthat tests Git with different arrangements of GIT_TEST_* variables.\n\nDerrick Stolee (1):\n  ci: add optional test variables\n\n ci/run-build-and-tests.sh | 2 ++\n 1 file changed, 2 insertions(+)\n\n\nbase-commit: d82963f34cf6921ed29d1fc2d96b16acf9005159\nPublished-As: https://github.com/gitgitgadget/git/releases/tags/pr-49%2Fderrickstolee%2Fci-vars-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-49/derrickstolee/ci-vars-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/49\n-- \ngitgitgadget\n"},{"id":"360745","messageId":"9363be0b9d6d06ec14cdcda37ca4dab72e69e3bb.1539781230.git.gitgitgadget@gmail.com","threadId":"49589","inReplyTo":"pull.49.git.gitgitgadget@gmail.com","subject":"[PATCH 1/1] ci: add optional test variables","fromName":"Derrick Stolee via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2018-10-17T13:00:34Z","receivedAt":"2018-10-17T13:00:37Z","isPatch":true,"sender":{"key":"stolee@gmail.com","avatar":"https://avatars.githubusercontent.com/u/570044?v=4"},"body":"From: Derrick Stolee <dstolee@microsoft.com>\n\nThe commit-graph and multi-pack-index features introduce optional\ndata structures that are not required for normal Git operations.\nIt is important to run the normal test suite without them enabled,\nbut it is helpful to also run the test suite using them.\n\nOur continuous integration scripts include a second test stage that\nruns with optional GIT_TEST_* variables enabled. Add the following\ntwo variables to that stage:\n\n  GIT_TEST_COMMIT_GRAPH\n  GIT_TEST_MULTI_PACK_INDEX\n\nThis will slow down the operation, as we build a commit-graph file\nafter every 'git commit' operation and build a multi-pack-index\nduring every 'git repack' operation. However, it is important that\nfuture changes are compatible with these features.\n\nSigned-off-by: Derrick Stolee <dstolee@microsoft.com>\n---\n ci/run-build-and-tests.sh | 2 ++\n 1 file changed, 2 insertions(+)\n\ndiff --git a/ci/run-build-and-tests.sh b/ci/run-build-and-tests.sh\nindex e28ac2fb9a..db342bb6a8 100755\n--- a/ci/run-build-and-tests.sh\n+++ b/ci/run-build-and-tests.sh\n@@ -15,6 +15,8 @@ then\n \texport GIT_TEST_FULL_IN_PACK_ARRAY=true\n \texport GIT_TEST_OE_SIZE=10\n \texport GIT_TEST_OE_DELTA_SIZE=5\n+\texport GIT_TEST_COMMIT_GRAPH=1\n+\texport GIT_TEST_MULTI_PACK_INDEX=1\n \tmake --quiet test\n fi\n \n-- \ngitgitgadget\n"},{"id":"360747","messageId":"d0a90195-5e13-8c12-f04e-ae0705a512b7@gmail.com","threadId":"49589","inReplyTo":"pull.49.git.gitgitgadget@gmail.com","subject":"Re: [PATCH 0/1] Run GIT_TEST_COMMIT_GRAPH and GIT_TEST_MULTI_PACK_INDEX during CI","fromName":"Derrick Stolee","fromEmail":"stolee@gmail.com","sentAt":"2018-10-17T13:04:11Z","receivedAt":"2018-10-17T13:04:17Z","isPatch":true,"sender":{"key":"stolee@gmail.com","avatar":"https://avatars.githubusercontent.com/u/570044?v=4"},"body":"On 10/17/2018 9:00 AM, Derrick Stolee via GitGitGadget wrote:\n> [1] https://git.visualstudio.com/git/_build?definitionId=4\nNewlines are hard. Sorry for the formatting issues when translating from \na PR description.\n> Build definition\n> that tests Git with different arrangements of GIT_TEST_* variables.\nThanks,\n-Stolee\n"}]}