{"thread":{"id":"49584","subject":"[PATCH] builtin/submodule--helper: remove debugging leftover tracing","startedAt":"2018-10-16T23:45:57Z","lastAt":"2018-10-17T02:52:18Z","messageCount":2,"participants":["Stefan Beller","Jonathan Nieder"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"360721","messageId":"20181016234550.216587-1-sbeller@google.com","threadId":"49584","inReplyTo":null,"subject":"[PATCH] builtin/submodule--helper: remove debugging leftover tracing","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2018-10-16T23:45:50Z","receivedAt":"2018-10-16T23:45:57Z","isPatch":true,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"I noticed 74d4731da1 (submodule--helper: replace connect-gitdir-workingtree\nby ensure-core-worktree, 2018-08-13) had two leftover debugging statements\nwhen reading The coverage report [1]. Remove them.\n\nhttps://public-inbox.org/git/e30a9c05-87d8-1f2b-182c-6d6a5fefe43c@gmail.com/\n\nSigned-off-by: Stefan Beller <sbeller@google.com>\n---\n\nTo be applied on (or squashed into the tip of)\n  sb/submodule-update-in-c\n\n builtin/submodule--helper.c | 2 --\n 1 file changed, 2 deletions(-)\n\ndiff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c\nindex 5c9d1fb496..c7d3841ffc 100644\n--- a/builtin/submodule--helper.c\n+++ b/builtin/submodule--helper.c\n@@ -1459,7 +1459,6 @@ static void determine_submodule_update_strategy(struct repository *r,\n \tkey = xstrfmt(\"submodule.%s.update\", sub->name);\n \n \tif (update) {\n-\t\ttrace_printf(\"parsing update\");\n \t\tif (parse_submodule_update_strategy(update, out) < 0)\n \t\t\tdie(_(\"Invalid update mode '%s' for submodule path '%s'\"),\n \t\t\t\tupdate, path);\n@@ -1468,7 +1467,6 @@ static void determine_submodule_update_strategy(struct repository *r,\n \t\t\tdie(_(\"Invalid update mode '%s' configured for submodule path '%s'\"),\n \t\t\t\tval, path);\n \t} else if (sub->update_strategy.type != SM_UPDATE_UNSPECIFIED) {\n-\t\ttrace_printf(\"loaded thing\");\n \t\tout->type = sub->update_strategy.type;\n \t\tout->command = sub->update_strategy.command;\n \t} else\n-- \n2.19.0\n\n"},{"id":"360726","messageId":"20181017025213.GB117170@aiede.svl.corp.google.com","threadId":"49584","inReplyTo":"20181016234550.216587-1-sbeller@google.com","subject":"Re: [PATCH] builtin/submodule--helper: remove debugging leftover tracing","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2018-10-17T02:52:13Z","receivedAt":"2018-10-17T02:52:18Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Stefan Beller wrote:\n\n> I noticed 74d4731da1 (submodule--helper: replace connect-gitdir-workingtree\n> by ensure-core-worktree, 2018-08-13) had two leftover debugging statements\n> when reading The coverage report [1]. Remove them.\n>\n> https://public-inbox.org/git/e30a9c05-87d8-1f2b-182c-6d6a5fefe43c@gmail.com/\n>\n> Signed-off-by: Stefan Beller <sbeller@google.com>\n> ---\n>  builtin/submodule--helper.c | 2 --\n>  1 file changed, 2 deletions(-)\n\nDoh.  Glad you caught it!\n\nIs there some reference for The Coverage Report other than the mailing\nlist?  E.g. I suspect a reference to\n\n\tmake coverage-test\n\tmake coverage-report\n\nwould be useful to readers finding this commit later.\n\n> To be applied on (or squashed into the tip of)\n>   sb/submodule-update-in-c\n\nLooks like that's already in \"master\", so not a candidate for\nsquashing.\n\nReviewed-by: Jonathan Nieder <jrnieder@gmail.com>\n"}]}