{"thread":{"id":"49552","subject":"[PATCH] config.mak.dev: add -Wformat","startedAt":"2018-10-12T18:40:44Z","lastAt":"2019-01-07T21:17:00Z","messageCount":11,"participants":["Thomas Gummerer","Jeff King","Jonathan Nieder","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"360332","messageId":"20181012184037.15076-1-t.gummerer@gmail.com","threadId":"49552","inReplyTo":null,"subject":"[PATCH] config.mak.dev: add -Wformat","fromName":"Thomas Gummerer","fromEmail":"t.gummerer@gmail.com","sentAt":"2018-10-12T18:40:37Z","receivedAt":"2018-10-12T18:40:44Z","isPatch":true,"sender":{"key":"t.gummerer@gmail.com","avatar":"https://avatars.githubusercontent.com/u/191004?v=4"},"body":"801fa63a90 (\"config.mak.dev: add -Wformat-security\", 2018-09-08) added\nthe -Wformat-security to the flags set in config.mak.dev. In the gcc\nman page this is documented as:\n\n If -Wformat is specified, also warn about uses of format\n functions that represent possible security problems. [...]\n\nThat commit did however not add the -Wformat flag, and -Wformat is not\nspecified anywhere else by default, so the added -Wformat-security had\nno effect. Newer versions of gcc (gcc 8.2.1 in this particular case)\nwarn about this and thus compilation fails with this option set.\n\nFix that, and make -Wformat-security actually useful by adding the\n-Wformat flag as well. git compiles cleanly with both these flags\napplied.\n\nSigned-off-by: Thomas Gummerer \n---\n\nSorry for not catching this before the patch made it to next. \n\n config.mak.dev | 1 +\n 1 file changed, 1 insertion(+)\n\ndiff --git a/config.mak.dev b/config.mak.dev\nindex 92d268137f..bf6f943452 100644\n--- a/config.mak.dev\n+++ b/config.mak.dev\n@@ -7,6 +7,7 @@ CFLAGS += -pedantic\n CFLAGS += -DUSE_PARENS_AROUND_GETTEXT_N=0\n endif\n CFLAGS += -Wdeclaration-after-statement\n+CFLAGS += -Wformat\n CFLAGS += -Wformat-security\n CFLAGS += -Wno-format-zero-length\n CFLAGS += -Wold-style-definition\n-- \n2.19.1.937.g12227c8702.dirty\n\n"},{"id":"360333","messageId":"20181012184549.GC4917@sigill.intra.peff.net","threadId":"49552","inReplyTo":"20181012184037.15076-1-t.gummerer@gmail.com","subject":"Re: [PATCH] config.mak.dev: add -Wformat","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2018-10-12T18:45:49Z","receivedAt":"2018-10-12T18:45:53Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Fri, Oct 12, 2018 at 07:40:37PM +0100, Thomas Gummerer wrote:\n\n> 801fa63a90 (\"config.mak.dev: add -Wformat-security\", 2018-09-08) added\n> the -Wformat-security to the flags set in config.mak.dev. In the gcc\n> man page this is documented as:\n> \n> If -Wformat is specified, also warn about uses of format\n> functions that represent possible security problems. [...]\n> \n> That commit did however not add the -Wformat flag, and -Wformat is not\n> specified anywhere else by default, so the added -Wformat-security had\n> no effect. Newer versions of gcc (gcc 8.2.1 in this particular case)\n> warn about this and thus compilation fails with this option set.\n> \n> Fix that, and make -Wformat-security actually useful by adding the\n> -Wformat flag as well. git compiles cleanly with both these flags\n> applied.\n\n-Wformat is part of -Wall, which we already turn on by default (even for\nnon-developer builds).\n\nSo I don't think we need to do anything more, though I'm puzzled that\nyou saw a failure. Do you set CFLAGS explicitly in your config.mak to\nsomething that doesn't include -Wall?\n\nI'm not opposed to making config.mak.dev a bit more redundant to handle\nthis case, but we'd probably want to include all of -Wall, since it\ncontains many other warnings we'd want to make sure are enabled.\n\n-Peff\n"},{"id":"360335","messageId":"20181012185450.GB52080@aiede.svl.corp.google.com","threadId":"49552","inReplyTo":"20181012184549.GC4917@sigill.intra.peff.net","subject":"Re: [PATCH] config.mak.dev: add -Wformat","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2018-10-12T18:54:50Z","receivedAt":"2018-10-12T18:54:55Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Jeff King wrote:\n> On Fri, Oct 12, 2018 at 07:40:37PM +0100, Thomas Gummerer wrote:\n\n>> 801fa63a90 (\"config.mak.dev: add -Wformat-security\", 2018-09-08) added\n>> the -Wformat-security to the flags set in config.mak.dev. In the gcc\n>> man page this is documented as:\n>>\n>> If -Wformat is specified, also warn about uses of format\n>> functions that represent possible security problems. [...]\n>>\n>> That commit did however not add the -Wformat flag, and -Wformat is not\n>> specified anywhere else by default, so the added -Wformat-security had\n>> no effect. Newer versions of gcc (gcc 8.2.1 in this particular case)\n>> warn about this and thus compilation fails with this option set.\n[...]\n> -Wformat is part of -Wall, which we already turn on by default (even for\n> non-developer builds).\n>\n> So I don't think we need to do anything more, though I'm puzzled that\n> you saw a failure. Do you set CFLAGS explicitly in your config.mak to\n> something that doesn't include -Wall?\n\nThomas, do you use autoconf to generate config.mak.autogen? I'm\nwondering if that produces a CFLAGS that doesn't include -Wall.\n\n> I'm not opposed to making config.mak.dev a bit more redundant to handle\n> this case, but we'd probably want to include all of -Wall, since it\n> contains many other warnings we'd want to make sure are enabled.\n\nDo you mean putting -Wall instead of -Wformat?\n\nShould we add -Wextra too? From a quick test, it seems to build okay.\n\nThanks,\nJonathan\n"},{"id":"360337","messageId":"20181012191134.GE4917@sigill.intra.peff.net","threadId":"49552","inReplyTo":"20181012185450.GB52080@aiede.svl.corp.google.com","subject":"Re: [PATCH] config.mak.dev: add -Wformat","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2018-10-12T19:11:35Z","receivedAt":"2018-10-12T19:11:38Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Fri, Oct 12, 2018 at 11:54:50AM -0700, Jonathan Nieder wrote:\n\n> > I'm not opposed to making config.mak.dev a bit more redundant to handle\n> > this case, but we'd probably want to include all of -Wall, since it\n> > contains many other warnings we'd want to make sure are enabled.\n> \n> Do you mean putting -Wall instead of -Wformat?\n\nYes.\n\n> Should we add -Wextra too? From a quick test, it seems to build okay.\n\nWe already do (though we have to then manually disable a few warnings\nthat we're not ready for -- see config.mak.dev).\n\n-Peff\n"},{"id":"360338","messageId":"20181012191531.GA22611@hank.intra.tgummerer.com","threadId":"49552","inReplyTo":"20181012185450.GB52080@aiede.svl.corp.google.com","subject":"Re: [PATCH] config.mak.dev: add -Wformat","fromName":"Thomas Gummerer","fromEmail":"t.gummerer@gmail.com","sentAt":"2018-10-12T19:15:31Z","receivedAt":"2018-10-12T19:15:36Z","isPatch":true,"sender":{"key":"t.gummerer@gmail.com","avatar":"https://avatars.githubusercontent.com/u/191004?v=4"},"body":"On 10/12, Jonathan Nieder wrote:\n> Jeff King wrote:\n> > On Fri, Oct 12, 2018 at 07:40:37PM +0100, Thomas Gummerer wrote:\n> \n> >> 801fa63a90 (\"config.mak.dev: add -Wformat-security\", 2018-09-08) added\n> >> the -Wformat-security to the flags set in config.mak.dev. In the gcc\n> >> man page this is documented as:\n> >>\n> >> If -Wformat is specified, also warn about uses of format\n> >> functions that represent possible security problems. [...]\n> >>\n> >> That commit did however not add the -Wformat flag, and -Wformat is not\n> >> specified anywhere else by default, so the added -Wformat-security had\n> >> no effect. Newer versions of gcc (gcc 8.2.1 in this particular case)\n> >> warn about this and thus compilation fails with this option set.\n> [...]\n> > -Wformat is part of -Wall, which we already turn on by default (even for\n> > non-developer builds).\n> >\n> > So I don't think we need to do anything more, though I'm puzzled that\n> > you saw a failure. Do you set CFLAGS explicitly in your config.mak to\n> > something that doesn't include -Wall?\n\nWhoops embarrassing. I had this set in my config.mak:\n\n CFLAGS = -O$(O) -g $(EXTRA_CFLAGS)\n\nWhat happened is that I had included -Wall in an old config.mak that I\ncopied from Thomas Rast when I started with my GSoC project. Then\nwhen \"DEVELOPER=1\" came around I switched to that at some point and\njust removed everything from CFLAGS, except the possibility to\noverride the optimization level, the ability to add extra flags and\nincluding debug symbols, but failed to notice that I had lost -Wall.\n\nMaybe it would still be a good to add -Wall to avoid the surprise for\nothers. But then again if someone overrides CFLAGS they should at\nleast check better what they're overriding ;)\n\n> Thomas, do you use autoconf to generate config.mak.autogen? I'm\n> wondering if that produces a CFLAGS that doesn't include -Wall.\n\nNo, this was all my mistake :)\n\n> > I'm not opposed to making config.mak.dev a bit more redundant to handle\n> > this case, but we'd probably want to include all of -Wall, since it\n> > contains many other warnings we'd want to make sure are enabled.\n> \n> Do you mean putting -Wall instead of -Wformat?\n> \n> Should we add -Wextra too? From a quick test, it seems to build okay.\n\nWe do have that with setting DEVELOPER=extra-all.\n\n> Thanks,\n> Jonathan\n"},{"id":"365878","messageId":"20181227185900.GE146609@google.com","threadId":"49552","inReplyTo":"20181012191531.GA22611@hank.intra.tgummerer.com","subject":"Re: [PATCH] config.mak.dev: add -Wformat","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2018-12-27T18:59:00Z","receivedAt":"2018-12-27T18:59:06Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"+cc: Masaya Suzuki\nIn October, Thomas Gummerer wrote:\n> On 10/12, Jonathan Nieder wrote:\n>> Jeff King wrote:\n>>> On Fri, Oct 12, 2018 at 07:40:37PM +0100, Thomas Gummerer wrote:\n\n>>>> 801fa63a90 (\"config.mak.dev: add -Wformat-security\", 2018-09-08) added\n>>>> the -Wformat-security to the flags set in config.mak.dev. In the gcc\n>>>> man page this is documented as:\n>>>>\n>>>> If -Wformat is specified, also warn about uses of format\n>>>> functions that represent possible security problems. [...]\n>>>>\n>>>> That commit did however not add the -Wformat flag, and -Wformat is not\n>>>> specified anywhere else by default, so the added -Wformat-security had\n>>>> no effect. Newer versions of gcc (gcc 8.2.1 in this particular case)\n>>>> warn about this and thus compilation fails with this option set.\n>> [...]\n>>> -Wformat is part of -Wall, which we already turn on by default (even for\n>>> non-developer builds).\n[...]\n>> Thomas, do you use autoconf to generate config.mak.autogen? I'm\n>> wondering if that produces a CFLAGS that doesn't include -Wall.\n>\n> No, this was all my mistake :)\n\nAs discussed in [1], autoconf appears to not put -Wall in CFLAGS:\n\n $ make configure\n GEN configure\n $ ./configure\n[...]\n config.status: creating config.mak.autogen\n config.status: executing config.mak.autogen commands\n $ grep CFLAGS config.mak.autogen\n CFLAGS = -g -O2\n PTHREAD_CFLAGS=-pthread\n\nSo this trap for the unwary is still around.\n\nCan we revive this patch? Does it just need a clearer commit message,\nor were there other objections?\n\n>>> I'm not opposed to making config.mak.dev a bit more redundant to handle\n>>> this case, but we'd probably want to include all of -Wall, since it\n>>> contains many other warnings we'd want to make sure are enabled.\n>>\n>> Do you mean putting -Wall instead of -Wformat?\n>>\n>> Should we add -Wextra too? From a quick test, it seems to build okay.\n>\n> We do have that with setting DEVELOPER=extra-all.\n\nEven better. What do you think of making DEVELOPER=YesPlease imply\nthat?\n\nThanks,\nJonathan\n\n[1] https://public-inbox.org/git/CAJB1erVmZQd_kLU1fqL7cURrEUz2EJ4Br0kgVQt7T-mk3s95dQ@mail.gmail.com/\n"},{"id":"366093","messageId":"xmqqa7khisue.fsf@gitster-ct.c.googlers.com","threadId":"49552","inReplyTo":"20181227185900.GE146609@google.com","subject":"Re: [PATCH] config.mak.dev: add -Wformat","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2019-01-03T16:55:21Z","receivedAt":"2019-01-03T16:55:27Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jonathan Nieder writes:\n\n> In October, Thomas Gummerer wrote:\n>> On 10/12, Jonathan Nieder wrote:\n>>> Jeff King wrote:\n>>> ...\n>>>> -Wformat is part of -Wall, which we already turn on by default (even for\n>>>> non-developer builds).\n> ...\n> As discussed in [1], autoconf appears to not put -Wall in CFLAGS:\n>\n> $ make configure\n> GEN configure\n> $ ./configure\n> [...]\n> config.status: creating config.mak.autogen\n> config.status: executing config.mak.autogen commands\n> $ grep CFLAGS config.mak.autogen\n> CFLAGS = -g -O2\n> PTHREAD_CFLAGS=-pthread\n>\n> So this trap for the unwary is still around.\n>\n> Can we revive this patch? Does it just need a clearer commit message,\n> or were there other objections?\n\nI think it is a good idea to give fallback/redundancy for this\ncase. I do not have strong opinion between -Wall and -Wformat,\nbut I'd probably vote for the former if pressed.\n\n-- >8 --\nFrom: Thomas Gummerer \nDate: Fri, 12 Oct 2018 19:40:37 +0100\nSubject: [PATCH] config.mak.dev: add -Wformat\n\n801fa63a90 (\"config.mak.dev: add -Wformat-security\", 2018-09-08)\nadded the \"-Wformat-security\" to the flags set in config.mak.dev.\nIn the gcc man page this is documented as:\n\n If -Wformat is specified, also warn about uses of format\n functions that represent possible security problems. [...]\n\nThe commit did however not add the \"-Wformat\" flag, but instead\nrelied on the fact that \"-Wall\" is set in the Makefile by default\nand that \"-Wformat\" is part of \"-Wall\".\n\nUnfortunately, those who use config.mak.autogen generated with the\nautoconf to configure toolchain do *not* get \"-Wall\" in their CFLAGS\nand the added -Wformat-security had no effect. Worse yet, newer\nversions of gcc (gcc 8.2.1 in this particular case) warn about the\nlack of \"-Wformat\" and thus compilation fails only with this option\nset.\n\nWe could fix it by adding \"-Wformat\", but in general we do want all\nchecks included in \"-Wall\", so let's add it to config.mak.dev to\ncover more cases.\n\nSigned-off-by: Thomas Gummerer \nHelped-by: Jeff King \nHelped-by: Jonathan Nieder \n[jc: s/-Wformat/-Wall/]\nSigned-off-by: Junio C Hamano \n---\n config.mak.dev | 1 +\n 1 file changed, 1 insertion(+)\n\ndiff --git a/config.mak.dev b/config.mak.dev\nindex bfbd3df4e8..74337f1f92 100644\n--- a/config.mak.dev\n+++ b/config.mak.dev\n@@ -1,6 +1,7 @@\n ifeq ($(filter no-error,$(DEVOPTS)),)\n CFLAGS += -Werror\n endif\n+CFLAGS += -Wall\n CFLAGS += -Wdeclaration-after-statement\n CFLAGS += -Wformat-security\n CFLAGS += -Wno-format-zero-length\n-- \n2.20.1-2-gb21ebb671b\n\n"},{"id":"366096","messageId":"20190103185427.GA237830@google.com","threadId":"49552","inReplyTo":"xmqqa7khisue.fsf@gitster-ct.c.googlers.com","subject":"Re: [PATCH] config.mak.dev: add -Wformat","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2019-01-03T18:54:27Z","receivedAt":"2019-01-03T18:54:33Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Hi,\n\nJunio C Hamano wrote:\n\n> I think it is a good idea to give fallback/redundancy for this\n> case. I do not have strong opinion between -Wall and -Wformat,\n> but I'd probably vote for the former if pressed.\n>\n> -- >8 --\n> From: Thomas Gummerer \n> Date: Fri, 12 Oct 2018 19:40:37 +0100\n> Subject: [PATCH] config.mak.dev: add -Wformat\n>\n> 801fa63a90 (\"config.mak.dev: add -Wformat-security\", 2018-09-08)\n> added the \"-Wformat-security\" to the flags set in config.mak.dev.\n> In the gcc man page this is documented as:\n>\n> If -Wformat is specified, also warn about uses of format\n> functions that represent possible security problems. [...]\n>\n> The commit did however not add the \"-Wformat\" flag, but instead\n> relied on the fact that \"-Wall\" is set in the Makefile by default\n> and that \"-Wformat\" is part of \"-Wall\".\n>\n> Unfortunately, those who use config.mak.autogen generated with the\n> autoconf to configure toolchain do *not* get \"-Wall\" in their CFLAGS\n> and the added -Wformat-security had no effect. Worse yet, newer\n> versions of gcc (gcc 8.2.1 in this particular case) warn about the\n> lack of \"-Wformat\" and thus compilation fails only with this option\n> set.\n>\n> We could fix it by adding \"-Wformat\", but in general we do want all\n> checks included in \"-Wall\", so let's add it to config.mak.dev to\n> cover more cases.\n>\n> Signed-off-by: Thomas Gummerer \n> Helped-by: Jeff King \n> Helped-by: Jonathan Nieder \n> [jc: s/-Wformat/-Wall/]\n> Signed-off-by: Junio C Hamano \n> ---\n> config.mak.dev | 1 +\n> 1 file changed, 1 insertion(+)\n\nReviewed-by: Jonathan Nieder \n\nThanks for tying up this loose end.\n"},{"id":"366220","messageId":"20190106181758.GF25639@hank.intra.tgummerer.com","threadId":"49552","inReplyTo":"xmqqa7khisue.fsf@gitster-ct.c.googlers.com","subject":"Re: [PATCH] config.mak.dev: add -Wformat","fromName":"Thomas Gummerer","fromEmail":"t.gummerer@gmail.com","sentAt":"2019-01-06T18:17:58Z","receivedAt":"2019-01-06T18:18:05Z","isPatch":true,"sender":{"key":"t.gummerer@gmail.com","avatar":"https://avatars.githubusercontent.com/u/191004?v=4"},"body":"On 01/03, Junio C Hamano wrote:\n> Jonathan Nieder writes:\n> \n> > In October, Thomas Gummerer wrote:\n> >> On 10/12, Jonathan Nieder wrote:\n> >>> Jeff King wrote:\n> >>> ...\n> >>>> -Wformat is part of -Wall, which we already turn on by default (even for\n> >>>> non-developer builds).\n> > ...\n> > As discussed in [1], autoconf appears to not put -Wall in CFLAGS:\n> >\n> > $ make configure\n> > GEN configure\n> > $ ./configure\n> > [...]\n> > config.status: creating config.mak.autogen\n> > config.status: executing config.mak.autogen commands\n> > $ grep CFLAGS config.mak.autogen\n> > CFLAGS = -g -O2\n> > PTHREAD_CFLAGS=-pthread\n> >\n> > So this trap for the unwary is still around.\n> >\n> > Can we revive this patch? Does it just need a clearer commit message,\n> > or were there other objections?\n> \n> I think it is a good idea to give fallback/redundancy for this\n> case. I do not have strong opinion between -Wall and -Wformat,\n> but I'd probably vote for the former if pressed.\n\nJust catching up after some time off over Christmas, thanks for tying\nthis up!\n\nI agree with the choice of adding -Wall to the CFLAGS here, so even if\nit is not added to the CFLAGS generated by autoconf (or in mnually set\nup CFLAGS such as in my original case), we still get a complete set of\nwarnings when DEVELOPER=YesPlease is set.\n\n> -- >8 --\n> From: Thomas Gummerer \n> Date: Fri, 12 Oct 2018 19:40:37 +0100\n> Subject: [PATCH] config.mak.dev: add -Wformat\n> \n> 801fa63a90 (\"config.mak.dev: add -Wformat-security\", 2018-09-08)\n> added the \"-Wformat-security\" to the flags set in config.mak.dev.\n> In the gcc man page this is documented as:\n> \n> If -Wformat is specified, also warn about uses of format\n> functions that represent possible security problems. [...]\n> \n> The commit did however not add the \"-Wformat\" flag, but instead\n> relied on the fact that \"-Wall\" is set in the Makefile by default\n> and that \"-Wformat\" is part of \"-Wall\".\n> \n> Unfortunately, those who use config.mak.autogen generated with the\n> autoconf to configure toolchain do *not* get \"-Wall\" in their CFLAGS\n> and the added -Wformat-security had no effect. Worse yet, newer\n> versions of gcc (gcc 8.2.1 in this particular case) warn about the\n> lack of \"-Wformat\" and thus compilation fails only with this option\n> set.\n> \n> We could fix it by adding \"-Wformat\", but in general we do want all\n> checks included in \"-Wall\", so let's add it to config.mak.dev to\n> cover more cases.\n> \n> Signed-off-by: Thomas Gummerer \n> Helped-by: Jeff King \n> Helped-by: Jonathan Nieder \n> [jc: s/-Wformat/-Wall/]\n> Signed-off-by: Junio C Hamano \n> ---\n> config.mak.dev | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/config.mak.dev b/config.mak.dev\n> index bfbd3df4e8..74337f1f92 100644\n> --- a/config.mak.dev\n> +++ b/config.mak.dev\n> @@ -1,6 +1,7 @@\n> ifeq ($(filter no-error,$(DEVOPTS)),)\n> CFLAGS += -Werror\n> endif\n> +CFLAGS += -Wall\n> CFLAGS += -Wdeclaration-after-statement\n> CFLAGS += -Wformat-security\n> CFLAGS += -Wno-format-zero-length\n> -- \n> 2.20.1-2-gb21ebb671b\n> \n"},{"id":"366264","messageId":"xmqqtvik9z69.fsf@gitster-ct.c.googlers.com","threadId":"49552","inReplyTo":"20190106181758.GF25639@hank.intra.tgummerer.com","subject":"Re: [PATCH] config.mak.dev: add -Wformat","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2019-01-07T17:04:46Z","receivedAt":"2019-01-07T17:04:51Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thomas Gummerer writes:\n\n> I agree with the choice of adding -Wall to the CFLAGS here, so even if\n> it is not added to the CFLAGS generated by autoconf (or in mnually set\n> up CFLAGS such as in my original case), we still get a complete set of\n> warnings when DEVELOPER=YesPlease is set.\n>\n>> -- >8 --\n>> From: Thomas Gummerer \n>> Date: Fri, 12 Oct 2018 19:40:37 +0100\n>> Subject: [PATCH] config.mak.dev: add -Wformat\n\nThanks. I noticed, before merging the topic to 'next', that I\nneeded to retitle this further. I'd use something like this.\n\nSubject: config.mak.dev: add -Wall to help autoconf users\n\n\n\n\n"},{"id":"366289","messageId":"20190107211655.GA192553@google.com","threadId":"49552","inReplyTo":"xmqqtvik9z69.fsf@gitster-ct.c.googlers.com","subject":"Re: [PATCH] config.mak.dev: add -Wformat","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2019-01-07T21:16:55Z","receivedAt":"2019-01-07T21:17:00Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Junio C Hamano wrote:\n> Thomas Gummerer writes:\n\n>>> From: Thomas Gummerer \n>>> Date: Fri, 12 Oct 2018 19:40:37 +0100\n>>> Subject: [PATCH] config.mak.dev: add -Wformat\n>\n> Thanks. I noticed, before merging the topic to 'next', that I\n> needed to retitle this further. I'd use something like this.\n>\n> Subject: config.mak.dev: add -Wall to help autoconf users\n\nWith that change, it would still be\nReviewed-by: Jonathan Nieder \n\n:)\n\nThanks.\n"}]}