{"thread":{"id":"49540","subject":"[PATCH] doc: move git-cherry to plumbing","startedAt":"2018-10-11T18:34:07Z","lastAt":"2018-11-01T17:13:29Z","messageCount":2,"participants":["Daniels Umanovskis","Duy Nguyen"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"360199","messageId":"20181011183350.14584-1-daniels@umanovskis.se","threadId":"49540","inReplyTo":null,"subject":"[PATCH] doc: move git-cherry to plumbing","fromName":"Daniels Umanovskis","fromEmail":"daniels@umanovskis.se","sentAt":"2018-10-11T18:33:50Z","receivedAt":"2018-10-11T18:34:07Z","isPatch":true,"sender":{"key":"daniels@umanovskis.se","avatar":"https://avatars.githubusercontent.com/u/5055233?v=4"},"body":"Also remove git-cherry from Bash completion because plumbing\ncommands do not belong there.\n\nSigned-off-by: Daniels Umanovskis <daniels@umanovskis.se>\n---\n\nUp to discussion whether cherry should be considered plumbing.\nI lean towards considering it a rarely-used porcelain command, but\na case could be made either way so let's see what the list thinks.\n\n command-list.txt                       |  2 +-\n contrib/completion/git-completion.bash | 11 -----------\n 2 files changed, 1 insertion(+), 12 deletions(-)\n\ndiff --git a/command-list.txt b/command-list.txt\nindex c36ea3c18..bdca6e3d3 100644\n--- a/command-list.txt\n+++ b/command-list.txt\n@@ -62,7 +62,7 @@ git-check-mailmap                       purehelpers\n git-checkout                            mainporcelain           history\n git-checkout-index                      plumbingmanipulators\n git-check-ref-format                    purehelpers\n-git-cherry                              ancillaryinterrogators          complete\n+git-cherry                              plumbinginterrogators          complete\n git-cherry-pick                         mainporcelain\n git-citool                              mainporcelain\n git-clean                               mainporcelain\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex d63d2dffd..12f7ce0c5 100644\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -1340,17 +1340,6 @@ _git_checkout ()\n \tesac\n }\n \n-_git_cherry ()\n-{\n-\tcase \"$cur\" in\n-\t--*)\n-\t\t__gitcomp_builtin cherry\n-\t\treturn\n-\tesac\n-\n-\t__git_complete_refs\n-}\n-\n __git_cherry_pick_inprogress_options=\"--continue --quit --abort\"\n \n _git_cherry_pick ()\n-- \n2.19.1.330.g93276587c.dirty\n\n"},{"id":"362201","messageId":"CACsJy8AVGbS_NTZsUj_hD9D+t4YV1_S4KTD25Kda85syvoowyg@mail.gmail.com","threadId":"49540","inReplyTo":"20181011183350.14584-1-daniels@umanovskis.se","subject":"Re: [PATCH] doc: move git-cherry to plumbing","fromName":"Duy Nguyen","fromEmail":"pclouds@gmail.com","sentAt":"2018-11-01T17:13:00Z","receivedAt":"2018-11-01T17:13:29Z","isPatch":true,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"On Thu, Oct 11, 2018 at 9:38 PM Daniels Umanovskis\n<daniels@umanovskis.se> wrote:\n>\n> Also remove git-cherry from Bash completion because plumbing\n> commands do not belong there.\n\nEr.. why?\n\n>\n> Signed-off-by: Daniels Umanovskis <daniels@umanovskis.se>\n> ---\n>\n> Up to discussion whether cherry should be considered plumbing.\n> I lean towards considering it a rarely-used porcelain command, but\n> a case could be made either way so let's see what the list thinks.\n>\n>  command-list.txt                       |  2 +-\n>  contrib/completion/git-completion.bash | 11 -----------\n>  2 files changed, 1 insertion(+), 12 deletions(-)\n>\n> diff --git a/command-list.txt b/command-list.txt\n> index c36ea3c18..bdca6e3d3 100644\n> --- a/command-list.txt\n> +++ b/command-list.txt\n> @@ -62,7 +62,7 @@ git-check-mailmap                       purehelpers\n>  git-checkout                            mainporcelain           history\n>  git-checkout-index                      plumbingmanipulators\n>  git-check-ref-format                    purehelpers\n> -git-cherry                              ancillaryinterrogators          complete\n> +git-cherry                              plumbinginterrogators          complete\n>  git-cherry-pick                         mainporcelain\n>  git-citool                              mainporcelain\n>  git-clean                               mainporcelain\n> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\n> index d63d2dffd..12f7ce0c5 100644\n> --- a/contrib/completion/git-completion.bash\n> +++ b/contrib/completion/git-completion.bash\n> @@ -1340,17 +1340,6 @@ _git_checkout ()\n>         esac\n>  }\n>\n> -_git_cherry ()\n> -{\n> -       case \"$cur\" in\n> -       --*)\n> -               __gitcomp_builtin cherry\n> -               return\n> -       esac\n> -\n> -       __git_complete_refs\n\nI think this is a regression. Because now \"git cherry <tab>\" will not\ncomplete refs (the default completer can still complete \"git cherry\n--<tab>\" fine). We support option completion of all commands no matter\nwhat categeory they are. The category is mostly to hide them from \"git\n<tab>\".\n\nIf you just want to hide \"git cherry\" from the \"git <tab>\" list, then\nyou could remove the \"complete\" tag in command-list.txt above.\n\n> -}\n> -\n>  __git_cherry_pick_inprogress_options=\"--continue --quit --abort\"\n>\n>  _git_cherry_pick ()\n> --\n> 2.19.1.330.g93276587c.dirty\n>\n\n\n-- \nDuy\n"}]}