{"thread":{"id":"49532","subject":"[PATCH] doc: move git-rev-parse from porcelain to plumbing","startedAt":"2018-10-10T21:38:57Z","lastAt":"2018-10-10T23:40:47Z","messageCount":4,"participants":["Daniels Umanovskis","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"360078","messageId":"20181010213726.26111-1-daniels@umanovskis.se","threadId":"49532","inReplyTo":null,"subject":"[PATCH] doc: move git-rev-parse from porcelain to plumbing","fromName":"Daniels Umanovskis","fromEmail":"daniels@umanovskis.se","sentAt":"2018-10-10T21:37:26Z","receivedAt":"2018-10-10T21:38:57Z","isPatch":true,"sender":{"key":"daniels@umanovskis.se","avatar":"https://avatars.githubusercontent.com/u/5055233?v=4"},"body":"git-rev-parse mostly seems like plumbing, and is more usd in\nscripts than in regular use. Online it's often mentioned as\na plumbing command. Nonetheless it's listed under porcelain\ninterrogators in `man git`. It seems appropriate to formally\nmove git-rev-parse to plumbing interrogators.\n\nSigned-off-by: Daniels Umanovskis <daniels@umanovskis.se>\n---\n command-list.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/command-list.txt b/command-list.txt\nindex c36ea3c18..e6364e167 100644\n--- a/command-list.txt\n+++ b/command-list.txt\n@@ -153,7 +153,7 @@ git-rerere                              ancillaryinterrogators\n git-reset                               mainporcelain           worktree\n git-revert                              mainporcelain\n git-rev-list                            plumbinginterrogators\n-git-rev-parse                           ancillaryinterrogators\n+git-rev-parse                           plumbinginterrogators\n git-rm                                  mainporcelain           worktree\n git-send-email                          foreignscminterface             complete\n git-send-pack                           synchingrepositories\n-- \n2.19.1.330.g93276587c.dirty\n\n"},{"id":"360098","messageId":"xmqqy3b5jv5p.fsf@gitster-ct.c.googlers.com","threadId":"49532","inReplyTo":"20181010213726.26111-1-daniels@umanovskis.se","subject":"Re: [PATCH] doc: move git-rev-parse from porcelain to plumbing","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2018-10-10T22:26:10Z","receivedAt":"2018-10-10T22:26:14Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Daniels Umanovskis <daniels@umanovskis.se> writes:\n\n> git-rev-parse mostly seems like plumbing, and is more usd in\n> scripts than in regular use. Online it's often mentioned as\n> a plumbing command. Nonetheless it's listed under porcelain\n> interrogators in `man git`. It seems appropriate to formally\n> move git-rev-parse to plumbing interrogators.\n\nCorrect.  \"ancillary\" category ended up with full of Porcelain, it\nseems, but there still are plumbing commands there, and this is a\nprime example that should not be mixed up with Porcelain commands.\n\nAmong the remaining ones in the list, cherry and get-tar-commit-id\nare probably better classified as plumbing.  I do not know why\ncherry is marked for completion; perhaps some crazy people use that\non the command line?\n"},{"id":"360104","messageId":"7c08fd68-9a0a-ab2a-0667-f51726fa691b@umanovskis.se","threadId":"49532","inReplyTo":"xmqqy3b5jv5p.fsf@gitster-ct.c.googlers.com","subject":"Re: [PATCH] doc: move git-rev-parse from porcelain to plumbing","fromName":"Daniels Umanovskis","fromEmail":"daniels@umanovskis.se","sentAt":"2018-10-10T22:56:08Z","receivedAt":"2018-10-10T22:56:13Z","isPatch":true,"sender":{"key":"daniels@umanovskis.se","avatar":"https://avatars.githubusercontent.com/u/5055233?v=4"},"body":"On 10/11/18 12:26 AM, Junio C Hamano wrote:\n> Among the remaining ones in the list, cherry and get-tar-commit-id\n> are probably better classified as plumbing.  I do not know why\n> cherry is marked for completion; perhaps some crazy people use that\n> on the command line?\n\nI think cherry could go either way, get-tar-commit-id is definitely\nplumbing. Would you like me to fix those two on the same patch then?\n\n"},{"id":"360110","messageId":"xmqqftxdjrph.fsf@gitster-ct.c.googlers.com","threadId":"49532","inReplyTo":"7c08fd68-9a0a-ab2a-0667-f51726fa691b@umanovskis.se","subject":"Re: [PATCH] doc: move git-rev-parse from porcelain to plumbing","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2018-10-10T23:40:42Z","receivedAt":"2018-10-10T23:40:47Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Daniels Umanovskis <daniels@umanovskis.se> writes:\n\n> On 10/11/18 12:26 AM, Junio C Hamano wrote:\n>> Among the remaining ones in the list, cherry and get-tar-commit-id\n>> are probably better classified as plumbing.  I do not know why\n>> cherry is marked for completion; perhaps some crazy people use that\n>> on the command line?\n>\n> I think cherry could go either way, get-tar-commit-id is definitely\n> plumbing. Would you like me to fix those two on the same patch then?\n\nNo, what you sent for rev-parse is already good.  A separate patch\nthat addresses other ones can be discussed as an orthogonal matter.\nIt even may deserve to make them two separate patches, as I\nanticipate that some people would resist marking \"cherry\" as\nplumbing, so that only one can be applied while dropping the other\nas/if needed.\n\nThanks.\n\n"}]}