{"thread":{"id":"49443","subject":"[PATCH] fetch: fix compilation warning","startedAt":"2018-09-27T22:08:45Z","lastAt":"2018-09-29T18:35:03Z","messageCount":2,"participants":["Ramsay Jones","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"359149","messageId":"4d868114-a7a5-a39b-d6d4-5a436419f105@ramsayjones.plus.com","threadId":"49443","inReplyTo":null,"subject":"[PATCH] fetch: fix compilation warning","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2018-09-27T22:08:38Z","receivedAt":"2018-09-27T22:08:45Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\ncommit 440fc7c0729 (\"fetch: replace string-list used as a look-up\ntable with a hashmap\", 2018-09-25) renamed a string-list variable\n(while adding a hashmap of the same name) and forgot to rename the\nstring-list variable in a call to string_list_clear().\n\nSigned-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n---\n\nHi Junio,\n\nYou probably already know, but I had to add this on top of the 'pu'\nbranch to get a clean compile tonight (your 'jc/war-on-string-list'\nbranch).\n\nThanks!\n\nATB,\nRamsay Jones\n\n builtin/fetch.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/builtin/fetch.c b/builtin/fetch.c\nindex 0a71953bc5..aea2e10364 100644\n--- a/builtin/fetch.c\n+++ b/builtin/fetch.c\n@@ -391,7 +391,7 @@ static void find_non_local_tags(const struct ref *refs,\n \t\t}\n \t}\n \thashmap_free(&remote_refs, 1);\n-\tstring_list_clear(&remote_refs, 0);\n+\tstring_list_clear(&remote_refs_list, 0);\n }\n \n static struct ref *get_ref_map(struct remote *remote,\n-- \n2.19.0\n"},{"id":"359305","messageId":"xmqqr2hc884s.fsf@gitster-ct.c.googlers.com","threadId":"49443","inReplyTo":"4d868114-a7a5-a39b-d6d4-5a436419f105@ramsayjones.plus.com","subject":"Re: [PATCH] fetch: fix compilation warning","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2018-09-29T18:34:59Z","receivedAt":"2018-09-29T18:35:03Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Ramsay Jones <ramsay@ramsayjones.plus.com> writes:\n\n> You probably already know, but I had to add this on top of the 'pu'\n> branch to get a clean compile tonight (your 'jc/war-on-string-list'\n> branch).\n\nIt was not just about squelching a warning but simply broken code\nthat deserved to be warned/errored.  I think what we have in 'pu'\nnow is already fixed.\n\nThanks.\n\n>  \t}\n>  \thashmap_free(&remote_refs, 1);\n> -\tstring_list_clear(&remote_refs, 0);\n> +\tstring_list_clear(&remote_refs_list, 0);\n>  }\n>  \n>  static struct ref *get_ref_map(struct remote *remote,\n"}]}