{"thread":{"id":"49434","subject":"[PATCH] doc: clarify gitcredentials path component matching","startedAt":"2018-09-26T22:42:33Z","lastAt":"2018-09-27T05:19:15Z","messageCount":2,"participants":["Zych, David M","Jeff King"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"359018","messageId":"1538000558-25523-1-git-send-email-dmrz@illinois.edu","threadId":"49434","inReplyTo":null,"subject":"[PATCH] doc: clarify gitcredentials path component matching","fromName":"Zych, David M","fromEmail":"dmrz@illinois.edu","sentAt":"2018-09-26T22:23:11Z","receivedAt":"2018-09-26T22:42:33Z","isPatch":true,"sender":{"key":"dmrz@illinois.edu","avatar":null},"body":"The gitcredentials documentation implied that the config file's\n\"pattern\" URL might include a path component, but did not explain that\nit must match exactly (potentially leaving readers with the false hope\nthat it would support a more flexible prefix match).\n\nSigned-off-by: David Zych <dmrz@illinois.edu>\n---\n Documentation/gitcredentials.txt | 6 ++++++\n 1 file changed, 6 insertions(+)\n\ndiff --git a/Documentation/gitcredentials.txt b/Documentation/gitcredentials.txt\nindex f970196..adc7596 100644\n--- a/Documentation/gitcredentials.txt\n+++ b/Documentation/gitcredentials.txt\n@@ -133,6 +133,12 @@ compares hostnames exactly, without considering whether two hosts are part of\n the same domain. Likewise, a config entry for `http://example.com` would not\n match: Git compares the protocols exactly.\n \n+If the \"pattern\" URL does include a path component, then this too must match\n+exactly: the context `https://example.com/bar/baz.git` will match a config\n+entry for `https://example.com/bar/baz.git` (in addition to matching the config\n+entry for `https://example.com`) but will not match a config entry for\n+`https://example.com/bar`.\n+\n \n CONFIGURATION OPTIONS\n ---------------------\n-- \n2.7.4\n\n"},{"id":"359028","messageId":"20180927051911.GA14178@sigill.intra.peff.net","threadId":"49434","inReplyTo":"1538000558-25523-1-git-send-email-dmrz@illinois.edu","subject":"Re: [PATCH] doc: clarify gitcredentials path component matching","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2018-09-27T05:19:12Z","receivedAt":"2018-09-27T05:19:15Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Wed, Sep 26, 2018 at 10:23:11PM +0000, Zych, David M wrote:\n\n> The gitcredentials documentation implied that the config file's\n> \"pattern\" URL might include a path component, but did not explain that\n> it must match exactly (potentially leaving readers with the false hope\n> that it would support a more flexible prefix match).\n> [...]\n\nThanks, the proposed text looks perfect to me.\n\n-Peff\n"}]}