{"thread":{"id":"49401","subject":"[PATCH] receive-pack: update comment with check_everything_connected","startedAt":"2018-09-21T23:04:48Z","lastAt":"2018-09-24T15:46:10Z","messageCount":2,"participants":["Jeff King","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"358683","messageId":"20180921230444.GA2713@sigill.intra.peff.net","threadId":"49401","inReplyTo":null,"subject":"[PATCH] receive-pack: update comment with check_everything_connected","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2018-09-21T23:04:45Z","receivedAt":"2018-09-21T23:04:48Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"That function is now called \"check_connected()\", but we forgot to update\nthis comment in 7043c7071c (check_everything_connected: use a struct\nwith named options, 2016-07-15).\n\nSigned-off-by: Jeff King <peff@peff.net>\n---\nJust a minor annoyance I happened to notice while discussing in another\nthread. I notice both of us still called it check-everything-connected\nin our emails; old habits die hard, I suppose. ;)\n\n builtin/receive-pack.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/builtin/receive-pack.c b/builtin/receive-pack.c\nindex a3bb13af10..3b7432c8e4 100644\n--- a/builtin/receive-pack.c\n+++ b/builtin/receive-pack.c\n@@ -1834,7 +1834,7 @@ static void prepare_shallow_update(struct command *commands,\n \t/*\n \t * keep hooks happy by forcing a temporary shallow file via\n \t * env variable because we can't add --shallow-file to every\n-\t * command. check_everything_connected() will be done with\n+\t * command. check_connected() will be done with\n \t * true .git/shallow though.\n \t */\n \tsetenv(GIT_SHALLOW_FILE_ENVIRONMENT, alt_shallow_file, 1);\n-- \n2.19.0.762.gbd1f43ccbf\n"},{"id":"358761","messageId":"xmqqbm8muceb.fsf@gitster-ct.c.googlers.com","threadId":"49401","inReplyTo":"20180921230444.GA2713@sigill.intra.peff.net","subject":"Re: [PATCH] receive-pack: update comment with check_everything_connected","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2018-09-24T15:46:04Z","receivedAt":"2018-09-24T15:46:10Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jeff King <peff@peff.net> writes:\n\n> That function is now called \"check_connected()\", but we forgot to update\n> this comment in 7043c7071c (check_everything_connected: use a struct\n> with named options, 2016-07-15).\n>\n> Signed-off-by: Jeff King <peff@peff.net>\n> ---\n> Just a minor annoyance I happened to notice while discussing in another\n> thread. I notice both of us still called it check-everything-connected\n> in our emails; old habits die hard, I suppose. ;)\n\nYup, and now I think I caught up ;-)  Thanks.\n\n>\n>  builtin/receive-pack.c | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/builtin/receive-pack.c b/builtin/receive-pack.c\n> index a3bb13af10..3b7432c8e4 100644\n> --- a/builtin/receive-pack.c\n> +++ b/builtin/receive-pack.c\n> @@ -1834,7 +1834,7 @@ static void prepare_shallow_update(struct command *commands,\n>  \t/*\n>  \t * keep hooks happy by forcing a temporary shallow file via\n>  \t * env variable because we can't add --shallow-file to every\n> -\t * command. check_everything_connected() will be done with\n> +\t * command. check_connected() will be done with\n>  \t * true .git/shallow though.\n>  \t */\n>  \tsetenv(GIT_SHALLOW_FILE_ENVIRONMENT, alt_shallow_file, 1);\n"}]}