{"thread":{"id":"49387","subject":"[PATCH 1/3] git-archimport.1: specify what kind of Arch we're talking about","startedAt":"2018-09-19T20:44:24Z","lastAt":"2018-09-21T16:48:29Z","messageCount":15,"participants":["Frederick Eaton","Junio C Hamano","frederik@ofb.net","Duy Nguyen","Eric Sunshine"],"isPatch":true,"patchVersion":1,"patchTotal":3},"messages":[{"id":"358486","messageId":"20180919201231.609-2-frederik@ofb.net","threadId":"49387","inReplyTo":"20180919201231.609-1-frederik@ofb.net","subject":"[PATCH 1/3] git-archimport.1: specify what kind of Arch we're talking about","fromName":"Frederick Eaton","fromEmail":"frederik@ofb.net","sentAt":"2018-09-19T20:12:29Z","receivedAt":"2018-09-19T20:44:24Z","isPatch":true,"sender":{"key":"frederik@ofb.net","avatar":null},"body":"Is it a CPU architecture? Is it Arch Linux? If you search for \"arch\nrepository\", nothing relevant comes up. Let's call it GNU Arch so\npeople can find it with search engines.\n\nSigned-off-by: Frederick Eaton \n---\n Documentation/git-archimport.txt | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)\n\ndiff --git a/Documentation/git-archimport.txt b/Documentation/git-archimport.txt\nindex ea7065336..a595a0ffe 100644\n--- a/Documentation/git-archimport.txt\n+++ b/Documentation/git-archimport.txt\n@@ -3,7 +3,7 @@ git-archimport(1)\n \n NAME\n ----\n-git-archimport - Import an Arch repository into Git\n+git-archimport - Import a GNU Arch repository into Git\n \n \n SYNOPSIS\n@@ -14,7 +14,8 @@ SYNOPSIS\n \n DESCRIPTION\n -----------\n-Imports a project from one or more Arch repositories. It will follow branches\n+Imports a project from one or more GNU Arch repositories.\n+It will follow branches\n and repositories within the namespaces defined by the \n parameters supplied. If it cannot find the remote branch a merge comes from\n it will just import it as a regular commit. If it can find it, it will mark it\n-- \n2.19.0\n\n"},{"id":"358487","messageId":"20180919201231.609-1-frederik@ofb.net","threadId":"49387","inReplyTo":null,"subject":"[PATCH 0/3] some documentation changes from the beginning of the alphabet","fromName":"Frederick Eaton","fromEmail":"frederik@ofb.net","sentAt":"2018-09-19T20:12:28Z","receivedAt":"2018-09-19T20:44:44Z","isPatch":true,"sender":{"key":"frederik@ofb.net","avatar":null},"body":"I've never sent patches using git before so I thought it would be\nuseful to make a small test.\n\nI read ./Documentation/SubmittingPatches and I sent these to myself\nand practiced applying them using `git am`, and I also compiled and\nchecked the revised manual pages to see that they format correctly.\nUnfortunately it was too late to run 'git diff --check' because I had\nalready committed the changes to my repo, but I don't see any\nwhitespace highlighted when I run 'git log -p'.\n\nI'm sure I'm doing something wrong, so please let me know what it is!\n\nHere's the command I'll use to send the messages (without --dry-run):\n\ngit send-email --to \"Junio C Hamano \" --cc git@vger.kernel.org --cc-cmd ./contrib/contacts/git-contacts outgoing/ --dry-run\n\nBy the way for some reason git-contacts shows more names when I run it\non the patch hash than when I give it the patch name:\n\n$ ./contrib/contacts/git-contacts 222580cb60ee64f7b81fed64ec8fbfc81952557f\nSébastien Guimmara \nNguyễn Thái Ngọc Duy \nEric Sunshine \nJunio C Hamano \n$ ./contrib/contacts/git-contacts ./outgoing/0002-git-column.1-clarify-initial-description-provide-exa.patch \nJunio C Hamano \n\nNot sure what's going on here, but the changes I propose seem fairly\nstraightforward...(?)\n\nFrederick Eaton (3):\n git-archimport.1: specify what kind of Arch we're talking about\n git-column.1: clarify initial description, provide examples\n git-describe.1: clarify that \"human readable\" is also git-readable\n\n Documentation/git-archimport.txt | 5 +++--\n Documentation/git-column.txt | 35 ++++++++++++++++++++++++++++++--\n Documentation/git-describe.txt | 4 +++-\n 3 files changed, 39 insertions(+), 5 deletions(-)\n\n-- \n2.19.0\n\n"},{"id":"358488","messageId":"20180919201231.609-4-frederik@ofb.net","threadId":"49387","inReplyTo":"20180919201231.609-1-frederik@ofb.net","subject":"[PATCH 3/3] git-describe.1: clarify that \"human readable\" is also git-readable","fromName":"Frederick Eaton","fromEmail":"frederik@ofb.net","sentAt":"2018-09-19T20:12:31Z","receivedAt":"2018-09-19T20:53:35Z","isPatch":true,"sender":{"key":"frederik@ofb.net","avatar":null},"body":"The caption uses the term \"human readable\", but the DESCRIPTION did\nnot explain this in context.\n\nSigned-off-by: Frederick Eaton \n---\n Documentation/git-describe.txt | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)\n\ndiff --git a/Documentation/git-describe.txt b/Documentation/git-describe.txt\nindex e027fb8c4..ccdc5f83d 100644\n--- a/Documentation/git-describe.txt\n+++ b/Documentation/git-describe.txt\n@@ -18,7 +18,9 @@ The command finds the most recent tag that is reachable from a\n commit. If the tag points to the commit, then only the tag is\n shown. Otherwise, it suffixes the tag name with the number of\n additional commits on top of the tagged object and the\n-abbreviated object name of the most recent commit.\n+abbreviated object name of the most recent commit. The result\n+is a \"human-readable\" object name which can also be used to\n+identify the commit to other git commands.\n \n By default (without --all or --tags) `git describe` only shows\n annotated tags. For more information about creating annotated tags\n-- \n2.19.0\n\n"},{"id":"358489","messageId":"20180919201231.609-3-frederik@ofb.net","threadId":"49387","inReplyTo":"20180919201231.609-1-frederik@ofb.net","subject":"[PATCH 2/3] git-column.1: clarify initial description, provide examples","fromName":"Frederick Eaton","fromEmail":"frederik@ofb.net","sentAt":"2018-09-19T20:12:30Z","receivedAt":"2018-09-19T20:53:49Z","isPatch":true,"sender":{"key":"frederik@ofb.net","avatar":null},"body":"When I read this man page I couldn't figure out what kind of input it\nwas referring to, or how input was being put into columns, or where I\nshould look for the syntax of the --mode option.\n\nSigned-off-by: Frederick Eaton \n---\n Documentation/git-column.txt | 35 +++++++++++++++++++++++++++++++++--\n 1 file changed, 33 insertions(+), 2 deletions(-)\n\ndiff --git a/Documentation/git-column.txt b/Documentation/git-column.txt\nindex 03d18465d..5bbb51068 100644\n--- a/Documentation/git-column.txt\n+++ b/Documentation/git-column.txt\n@@ -13,7 +13,10 @@ SYNOPSIS\n \n DESCRIPTION\n -----------\n-This command formats its input into multiple columns.\n+This command formats the lines of its standard input into a table with\n+multiple columns. Each input line occupies one cell of the table. It\n+is used internally by other git commands to format output into\n+columns.\n \n OPTIONS\n -------\n@@ -23,7 +26,7 @@ OPTIONS\n \n --mode=::\n \tSpecify layout mode. See configuration variable column.ui for option\n-\tsyntax.\n+\tsyntax (in git-config(1)).\n \n --raw-mode=::\n \tSame as --mode but take mode encoded as a number. This is mainly used\n@@ -43,6 +46,34 @@ OPTIONS\n --padding=::\n \tThe number of spaces between columns. One space by default.\n \n+EXAMPLES\n+------\n+\n+Format data by columns:\n+------------\n+$ seq 1 24 | git column --mode=column --padding=5\n+1 4 7 10 13 16 19 22\n+2 5 8 11 14 17 20 23\n+3 6 9 12 15 18 21 24\n+------------\n+\n+Format data by rows:\n+------------\n+$ seq 1 21 | git column --mode=row --padding=5\n+1 2 3 4 5 6 7\n+8 9 10 11 12 13 14\n+15 16 17 18 19 20 21\n+------------\n+\n+List some tags in a table with unequal column widths:\n+------------\n+$ git tag --list 'v2.4.*' --column=row,dense\n+v2.4.0 v2.4.0-rc0 v2.4.0-rc1 v2.4.0-rc2 v2.4.0-rc3\n+v2.4.1 v2.4.10 v2.4.11 v2.4.12 v2.4.2\n+v2.4.3 v2.4.4 v2.4.5 v2.4.6 v2.4.7\n+v2.4.8 v2.4.9\n+------------\n+\n GIT\n ---\n Part of the linkgit:git[1] suite\n-- \n2.19.0\n\n"},{"id":"358493","messageId":"xmqqzhwd2jcq.fsf@gitster-ct.c.googlers.com","threadId":"49387","inReplyTo":"20180919201231.609-1-frederik@ofb.net","subject":"Re: [PATCH 0/3] some documentation changes from the beginning of the alphabet","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2018-09-19T22:49:41Z","receivedAt":"2018-09-19T22:49:47Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Frederick Eaton writes:\n\n> I've never sent patches using git before so I thought it would be\n> useful to make a small test.\n\n... eh, welcome ;-)\n\n> I read ./Documentation/SubmittingPatches and I sent these to myself\n> and practiced applying them using `git am`, and I also compiled and\n> checked the revised manual pages to see that they format correctly.\n> Unfortunately it was too late to run 'git diff --check' because I had\n> already committed the changes to my repo, but I don't see any\n> whitespace highlighted when I run 'git log -p'.\n\nThanks for being diligent.\n\n> By the way for some reason git-contacts shows more names when I run it\n> on the patch hash than when I give it the patch name:\n>\n> $ ./contrib/contacts/git-contacts 222580cb60ee64f7b81fed64ec8fbfc81952557f\n> Sébastien Guimmara \n> Nguyễn Thái Ngọc Duy \n> Eric Sunshine \n> Junio C Hamano \n> $ ./contrib/contacts/git-contacts ./outgoing/0002-git-column.1-clarify-initial-description-provide-exa.patch \n> Junio C Hamano \n\nI've never trusted what git-contacts say, but the latter one\ncertainly looks strange, as\n\n\tgit log --no-merges Documentation/git-column.txt\n\nmakes it clear that I have nothing to do with it ;-). Perhaps the\ntool gives too much credit for Signed-off-by: footer, or something.\n"},{"id":"358494","messageId":"xmqqsh252iwp.fsf@gitster-ct.c.googlers.com","threadId":"49387","inReplyTo":"20180919201231.609-2-frederik@ofb.net","subject":"Re: [PATCH 1/3] git-archimport.1: specify what kind of Arch we're talking about","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2018-09-19T22:59:18Z","receivedAt":"2018-09-19T22:59:23Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Frederick Eaton writes:\n\n> Is it a CPU architecture? Is it Arch Linux? If you search for \"arch\n> repository\", nothing relevant comes up. Let's call it GNU Arch so\n> people can find it with search engines.\n>\n> Signed-off-by: Frederick Eaton \n> ---\n> Documentation/git-archimport.txt | 5 +++--\n> 1 file changed, 3 insertions(+), 2 deletions(-)\n\nI think \"Is it a CPU archtecture?\" is a red-herring, but between\n\"What is an Arch Repository?\" and \"What is GNU Arch?\" there indeed\nis a vast difference in the quality of information readers would\nget; with the proposed commit log message that ends with \"so people\ncan find it with search engines\", I am reasonably sure this is an\nimprovement worth having.\n\nThanks.\n\n>\n> diff --git a/Documentation/git-archimport.txt b/Documentation/git-archimport.txt\n> index ea7065336..a595a0ffe 100644\n> --- a/Documentation/git-archimport.txt\n> +++ b/Documentation/git-archimport.txt\n> @@ -3,7 +3,7 @@ git-archimport(1)\n> \n> NAME\n> ----\n> -git-archimport - Import an Arch repository into Git\n> +git-archimport - Import a GNU Arch repository into Git\n> \n> \n> SYNOPSIS\n> @@ -14,7 +14,8 @@ SYNOPSIS\n> \n> DESCRIPTION\n> -----------\n> -Imports a project from one or more Arch repositories. It will follow branches\n> +Imports a project from one or more GNU Arch repositories.\n> +It will follow branches\n> and repositories within the namespaces defined by the \n> parameters supplied. If it cannot find the remote branch a merge comes from\n> it will just import it as a regular commit. If it can find it, it will mark it\n"},{"id":"358495","messageId":"xmqqo9ct2ivl.fsf@gitster-ct.c.googlers.com","threadId":"49387","inReplyTo":"20180919201231.609-3-frederik@ofb.net","subject":"Re: [PATCH 2/3] git-column.1: clarify initial description, provide examples","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2018-09-19T22:59:58Z","receivedAt":"2018-09-19T23:00:03Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Frederick Eaton writes:\n\n> When I read this man page I couldn't figure out what kind of input it\n> was referring to, or how input was being put into columns, or where I\n> should look for the syntax of the --mode option.\n>\n> Signed-off-by: Frederick Eaton \n> ---\n> Documentation/git-column.txt | 35 +++++++++++++++++++++++++++++++++--\n> 1 file changed, 33 insertions(+), 2 deletions(-)\n\nI'll defer this to its primary author.\n\n>\n> diff --git a/Documentation/git-column.txt b/Documentation/git-column.txt\n> index 03d18465d..5bbb51068 100644\n> --- a/Documentation/git-column.txt\n> +++ b/Documentation/git-column.txt\n> @@ -13,7 +13,10 @@ SYNOPSIS\n> \n> DESCRIPTION\n> -----------\n> -This command formats its input into multiple columns.\n> +This command formats the lines of its standard input into a table with\n> +multiple columns. Each input line occupies one cell of the table. It\n> +is used internally by other git commands to format output into\n> +columns.\n> \n> OPTIONS\n> -------\n> @@ -23,7 +26,7 @@ OPTIONS\n> \n> --mode=::\n> \tSpecify layout mode. See configuration variable column.ui for option\n> -\tsyntax.\n> +\tsyntax (in git-config(1)).\n> \n> --raw-mode=::\n> \tSame as --mode but take mode encoded as a number. This is mainly used\n> @@ -43,6 +46,34 @@ OPTIONS\n> --padding=::\n> \tThe number of spaces between columns. One space by default.\n> \n> +EXAMPLES\n> +------\n> +\n> +Format data by columns:\n> +------------\n> +$ seq 1 24 | git column --mode=column --padding=5\n> +1 4 7 10 13 16 19 22\n> +2 5 8 11 14 17 20 23\n> +3 6 9 12 15 18 21 24\n> +------------\n> +\n> +Format data by rows:\n> +------------\n> +$ seq 1 21 | git column --mode=row --padding=5\n> +1 2 3 4 5 6 7\n> +8 9 10 11 12 13 14\n> +15 16 17 18 19 20 21\n> +------------\n> +\n> +List some tags in a table with unequal column widths:\n> +------------\n> +$ git tag --list 'v2.4.*' --column=row,dense\n> +v2.4.0 v2.4.0-rc0 v2.4.0-rc1 v2.4.0-rc2 v2.4.0-rc3\n> +v2.4.1 v2.4.10 v2.4.11 v2.4.12 v2.4.2\n> +v2.4.3 v2.4.4 v2.4.5 v2.4.6 v2.4.7\n> +v2.4.8 v2.4.9\n> +------------\n> +\n> GIT\n> ---\n> Part of the linkgit:git[1] suite\n"},{"id":"358496","messageId":"20180919231326.GG22921@ofb.net","threadId":"49387","inReplyTo":"xmqqsh252iwp.fsf@gitster-ct.c.googlers.com","subject":"Re: [PATCH 1/3] git-archimport.1: specify what kind of Arch we're talking about","fromName":"","fromEmail":"frederik@ofb.net","sentAt":"2018-09-19T23:13:26Z","receivedAt":"2018-09-19T23:13:34Z","isPatch":true,"sender":{"key":"frederik@ofb.net","avatar":null},"body":"> I think \"Is it a CPU archtecture?\" is a red-herring, but between\n\nIt wasn't meant to be a red-herring though. Plenty of Linux\ndistributions have different architecture-specific package repos, and\narch is a common abbreviation for architecture. This only comes up if\nyou search for the full word e.g. \"linux architecture repository\"\nsince other wise Arch Linux dominates all the search results.\n\nA bit of a tangent...\n\nFrederick\n\n> \"What is an Arch Repository?\" and \"What is GNU Arch?\" there indeed\n> is a vast difference in the quality of information readers would\n> get; with the proposed commit log message that ends with \"so people\n> can find it with search engines\", I am reasonably sure this is an\n> improvement worth having.\n> \n> Thanks.\n"},{"id":"358518","messageId":"20180920162302.GB13379@duynguyen.home","threadId":"49387","inReplyTo":"xmqqo9ct2ivl.fsf@gitster-ct.c.googlers.com","subject":"Re: [PATCH 2/3] git-column.1: clarify initial description, provide examples","fromName":"Duy Nguyen","fromEmail":"pclouds@gmail.com","sentAt":"2018-09-20T16:23:03Z","receivedAt":"2018-09-20T16:23:10Z","isPatch":true,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"On Wed, Sep 19, 2018 at 03:59:58PM -0700, Junio C Hamano wrote:\n> > @@ -23,7 +26,7 @@ OPTIONS\n> > \n> > --mode=::\n> > \tSpecify layout mode. See configuration variable column.ui for option\n> > -\tsyntax.\n> > +\tsyntax (in git-config(1)).\n\nI think we usually link to other commands with \"linkgit\", like\nlinkgit:git-config[1]\n\nOther than that, the rest looks good.\n--\nDuy\n"},{"id":"358522","messageId":"20180920174722.GH22921@ofb.net","threadId":"49387","inReplyTo":"20180920162302.GB13379@duynguyen.home","subject":"Re: [PATCH 2/3] git-column.1: clarify initial description, provide examples","fromName":"","fromEmail":"frederik@ofb.net","sentAt":"2018-09-20T17:47:22Z","receivedAt":"2018-09-20T17:47:32Z","isPatch":true,"sender":{"key":"frederik@ofb.net","avatar":null},"body":"On Thu, Sep 20, 2018 at 06:23:03PM +0200, Duy Nguyen wrote:\n> On Wed, Sep 19, 2018 at 03:59:58PM -0700, Junio C Hamano wrote:\n> > > @@ -23,7 +26,7 @@ OPTIONS\n> > > \n> > > --mode=::\n> > > \tSpecify layout mode. See configuration variable column.ui for option\n> > > -\tsyntax.\n> > > +\tsyntax (in git-config(1)).\n> \n> I think we usually link to other commands with \"linkgit\", like\n> linkgit:git-config[1]\n> \n> Other than that, the rest looks good.\n\nThank you, then do I edit the patch and resubmit as PATCH v2 with the\nmessage ID and all that?\n\nFrederick\n"},{"id":"358558","messageId":"CAPig+cR04cjf-D_hUgKhOSUAhHd8py7BM4-HOyE3VttV_ufXFQ@mail.gmail.com","threadId":"49387","inReplyTo":"xmqqzhwd2jcq.fsf@gitster-ct.c.googlers.com","subject":"Re: [PATCH 0/3] some documentation changes from the beginning of the alphabet","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2018-09-21T05:18:30Z","receivedAt":"2018-09-21T05:18:44Z","isPatch":true,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Wed, Sep 19, 2018 at 6:49 PM Junio C Hamano wrote:\n> Frederick Eaton writes:\n> > By the way for some reason git-contacts shows more names when I run it\n> > on the patch hash than when I give it the patch name:\n> >\n> > $ ./contrib/contacts/git-contacts 222580cb60ee64f7b81fed64ec8fbfc81952557f\n> > Sébastien Guimmara \n> > Nguyễn Thái Ngọc Duy \n> > Eric Sunshine \n> > Junio C Hamano \n> > $ ./contrib/contacts/git-contacts ./outgoing/0002-git-column.1-clarify-initial-description-provide-exa.patch\n> > Junio C Hamano \n>\n> I've never trusted what git-contacts say, but the latter one\n> certainly looks strange [...]\n\nI don't use git-contacts, but the first invocation isn't consulting\njust a single commit but rather a range of commits. From git-contacts\ndocumentation:\n\n Input consists of one or more patch files or revision arguments.\n A revision argument can be a range or a single `` which is\n interpreted as `..HEAD`, thus the same revision arguments\n are accepted as for linkgit:git-format-patch[1]. Patch files and\n revision arguments can be combined in the same invocation.\n\nSo, you are actually running git-contacts on the range 222580cb..HEAD,\nand 222580cb isn't even one of the patches being consulted (due to how\nthe range syntax does not include the argument to the left of \"..\").\nTo consult just that one commit, you'd want perhaps:\n\n git-contacts 222580cb^..222580cb\n\n> [...] as,\n>\n> git log --no-merges Documentation/git-column.txt\n>\n> makes it clear that I have nothing to do with it ;-). Perhaps the\n> tool gives too much credit for Signed-off-by: footer, or something.\n\nSince git-contacts can be used as git-send-email's --cc-cmd, it can\npotentially be invoked many times, and it's a slow command (due to all\nthe \"blaming\" via git-blame). As an optimization, git-contacts limits\nthe timeframe of the blame via git-blame's --since option, with a\nhardcoded limit of 5 years. So, the git-blame invocation made by\ngit-contacts for this patch file is:\n\n git blame --porcelain -C -L13,+7 -L23,+7 -L43,+6 \\\n --since 5-years-ago \\\n 4a189fff51b1^ -- Documentation/git-column.txt\n\nSince the lines changed by the patch have not been touched within that\ntimeframe, git-blame assigns those lines to boundary commit 128a96c984\n(Update draft release notes to 1.8.5 for the fifth batch of topics,\n2013-09-20), which was authored by Junio, which is why he shows up as\nthe only \"contact\".\n\nIf we remove the --since restriction:\n\n git blame --porcelain -C -L13,+7 -L23,+7 -L43,+6 \\\n 4a189fff51b1^ -- Documentation/git-column.txt\n\nthen the lines are correctly \"blamed\" to Duy via commit 7e29b8254f\n(Add column layout skeleton and git-column, 2012-04-21).\n\nThe \"Limitations\" section of the git-contacts documentation says this:\n\n Several conditions controlling a person's significance are\n currently hard-coded, such as minimum participation level (10%),\n blame date-limiting (5 years), and `-C` level for detecting moved\n and copied lines (a single `-C`). In the future, these conditions\n may become configurable.\n\nSo, this sort of potential issue was understood. Felipe's\ngit-related[1], from which git-contacts arose, eventually grew the\nability to tweak these hard-coded values via command-line options. The\nsame could be done for git-contacts. Patches are welcome.\n\n[1]: https://github.com/felipec/git-related\n"},{"id":"358560","messageId":"CAPig+cQA5O_Zhe0wKzpppaQji997z2hfevnRMLW2nLRgce-YzQ@mail.gmail.com","threadId":"49387","inReplyTo":"20180920174722.GH22921@ofb.net","subject":"Re: [PATCH 2/3] git-column.1: clarify initial description, provide examples","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2018-09-21T05:32:12Z","receivedAt":"2018-09-21T05:32:25Z","isPatch":true,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Thu, Sep 20, 2018 at 1:47 PM wrote:\n> On Thu, Sep 20, 2018 at 06:23:03PM +0200, Duy Nguyen wrote:\n> > On Wed, Sep 19, 2018 at 03:59:58PM -0700, Junio C Hamano wrote:\n> > > > @@ -23,7 +26,7 @@ OPTIONS\n> > > >\n> > > > --mode=::\n> > > > Specify layout mode. See configuration variable column.ui for option\n> > > > - syntax.\n> > > > + syntax (in git-config(1)).\n> >\n> > I think we usually link to other commands with \"linkgit\", like\n> > linkgit:git-config[1]\n>\n> Thank you, then do I edit the patch and resubmit as PATCH v2 with the\n> message ID and all that?\n\nEditing the patch directly is not recommended. More typical would be\nto use \"git rebase -i\" and/or \"git commit --amend\" to make changes to\nthe commits themselves (that is, rewrite history), taking review\ncomments into account (and generally polishing the changes). Once the\nedits are complete, re-generate the patches with git-format-patch and\nre-send the entire series as v2 with git-send-email (or some people\nskip git-format-patch and go directly to git-send-email to both format\nand send the patches as one step).\n\nYou can use the -v option of git-format-patch to mark the series as v2.\n\nWhen sending v2 via git-send-email, you can use the --in-reply-to\noption with the message ID of the v1 cover letter to tie the re-roll\nto the original. (The message ID of the v1 cover letter is\n\"20180919201231.609-1-frederik@ofb.net\".)\n"},{"id":"358561","messageId":"20180921054546.GA11082@ofb.net","threadId":"49387","inReplyTo":"CAPig+cR04cjf-D_hUgKhOSUAhHd8py7BM4-HOyE3VttV_ufXFQ@mail.gmail.com","subject":"Re: [PATCH 0/3] some documentation changes from the beginning of the alphabet","fromName":"","fromEmail":"frederik@ofb.net","sentAt":"2018-09-21T05:45:46Z","receivedAt":"2018-09-21T05:45:57Z","isPatch":true,"sender":{"key":"frederik@ofb.net","avatar":null},"body":"> Patches are welcome.\n\nI'd be happy to patch git-contacts to link to the message you just\nsent, then maybe someone more qualified would know where to start... :)\n\nFrederick\n\nOn Fri, Sep 21, 2018 at 01:18:30AM -0400, Eric Sunshine wrote:\n> On Wed, Sep 19, 2018 at 6:49 PM Junio C Hamano wrote:\n> > Frederick Eaton writes:\n> > > By the way for some reason git-contacts shows more names when I run it\n> > > on the patch hash than when I give it the patch name:\n> > >\n> > > $ ./contrib/contacts/git-contacts 222580cb60ee64f7b81fed64ec8fbfc81952557f\n> > > Sébastien Guimmara \n> > > Nguyễn Thái Ngọc Duy \n> > > Eric Sunshine \n> > > Junio C Hamano \n> > > $ ./contrib/contacts/git-contacts ./outgoing/0002-git-column.1-clarify-initial-description-provide-exa.patch\n> > > Junio C Hamano \n> >\n> > I've never trusted what git-contacts say, but the latter one\n> > certainly looks strange [...]\n> \n> I don't use git-contacts, but the first invocation isn't consulting\n> just a single commit but rather a range of commits. From git-contacts\n> documentation:\n> \n> Input consists of one or more patch files or revision arguments.\n> A revision argument can be a range or a single `` which is\n> interpreted as `..HEAD`, thus the same revision arguments\n> are accepted as for linkgit:git-format-patch[1]. Patch files and\n> revision arguments can be combined in the same invocation.\n> \n> So, you are actually running git-contacts on the range 222580cb..HEAD,\n> and 222580cb isn't even one of the patches being consulted (due to how\n> the range syntax does not include the argument to the left of \"..\").\n> To consult just that one commit, you'd want perhaps:\n> \n> git-contacts 222580cb^..222580cb\n> \n> > [...] as,\n> >\n> > git log --no-merges Documentation/git-column.txt\n> >\n> > makes it clear that I have nothing to do with it ;-). Perhaps the\n> > tool gives too much credit for Signed-off-by: footer, or something.\n> \n> Since git-contacts can be used as git-send-email's --cc-cmd, it can\n> potentially be invoked many times, and it's a slow command (due to all\n> the \"blaming\" via git-blame). As an optimization, git-contacts limits\n> the timeframe of the blame via git-blame's --since option, with a\n> hardcoded limit of 5 years. So, the git-blame invocation made by\n> git-contacts for this patch file is:\n> \n> git blame --porcelain -C -L13,+7 -L23,+7 -L43,+6 \\\n> --since 5-years-ago \\\n> 4a189fff51b1^ -- Documentation/git-column.txt\n> \n> Since the lines changed by the patch have not been touched within that\n> timeframe, git-blame assigns those lines to boundary commit 128a96c984\n> (Update draft release notes to 1.8.5 for the fifth batch of topics,\n> 2013-09-20), which was authored by Junio, which is why he shows up as\n> the only \"contact\".\n> \n> If we remove the --since restriction:\n> \n> git blame --porcelain -C -L13,+7 -L23,+7 -L43,+6 \\\n> 4a189fff51b1^ -- Documentation/git-column.txt\n> \n> then the lines are correctly \"blamed\" to Duy via commit 7e29b8254f\n> (Add column layout skeleton and git-column, 2012-04-21).\n> \n> The \"Limitations\" section of the git-contacts documentation says this:\n> \n> Several conditions controlling a person's significance are\n> currently hard-coded, such as minimum participation level (10%),\n> blame date-limiting (5 years), and `-C` level for detecting moved\n> and copied lines (a single `-C`). In the future, these conditions\n> may become configurable.\n> \n> So, this sort of potential issue was understood. Felipe's\n> git-related[1], from which git-contacts arose, eventually grew the\n> ability to tweak these hard-coded values via command-line options. The\n> same could be done for git-contacts. Patches are welcome.\n> \n> [1]: https://github.com/felipec/git-related\n> \n"},{"id":"358609","messageId":"xmqqsh22x14v.fsf@gitster-ct.c.googlers.com","threadId":"49387","inReplyTo":"20180920174722.GH22921@ofb.net","subject":"Re: [PATCH 2/3] git-column.1: clarify initial description, provide examples","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2018-09-21T16:32:00Z","receivedAt":"2018-09-21T16:32:06Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"frederik@ofb.net writes:\n\n> On Thu, Sep 20, 2018 at 06:23:03PM +0200, Duy Nguyen wrote:\n>> On Wed, Sep 19, 2018 at 03:59:58PM -0700, Junio C Hamano wrote:\n>> > > @@ -23,7 +26,7 @@ OPTIONS\n>> > > \n>> > > --mode=::\n>> > > \tSpecify layout mode. See configuration variable column.ui for option\n>> > > -\tsyntax.\n>> > > +\tsyntax (in git-config(1)).\n>> \n>> I think we usually link to other commands with \"linkgit\", like\n>> linkgit:git-config[1]\n>> \n>> Other than that, the rest looks good.\n>\n> Thank you, then do I edit the patch and resubmit as PATCH v2 with the\n> message ID and all that?\n>\n> Frederick\n\nIf this is the only change in the whole 3 patches, then I can just\nsquash in the following to save one round-trip.\n\n Documentation/git-column.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/git-column.txt b/Documentation/git-column.txt\nindex 5bbb51068e..763afabb6d 100644\n--- a/Documentation/git-column.txt\n+++ b/Documentation/git-column.txt\n@@ -26,7 +26,7 @@ OPTIONS\n \n --mode=::\n \tSpecify layout mode. See configuration variable column.ui for option\n-\tsyntax (in git-config(1)).\n+\tsyntax in linkgit:git-config[1].\n \n --raw-mode=::\n \tSame as --mode but take mode encoded as a number. This is mainly used\n"},{"id":"358615","messageId":"20180921164802.GB11082@ofb.net","threadId":"49387","inReplyTo":"xmqqsh22x14v.fsf@gitster-ct.c.googlers.com","subject":"Re: [PATCH 2/3] git-column.1: clarify initial description, provide examples","fromName":"","fromEmail":"frederik@ofb.net","sentAt":"2018-09-21T16:48:16Z","receivedAt":"2018-09-21T16:48:29Z","isPatch":true,"sender":{"key":"frederik@ofb.net","avatar":null},"body":"Thank you Junio, maybe I will have another chance to get practice\nsending a v2 patch.\n\nOn Fri, Sep 21, 2018 at 09:32:00AM -0700, Junio C Hamano wrote:\n> frederik@ofb.net writes:\n> \n> > On Thu, Sep 20, 2018 at 06:23:03PM +0200, Duy Nguyen wrote:\n> >> On Wed, Sep 19, 2018 at 03:59:58PM -0700, Junio C Hamano wrote:\n> >> > > @@ -23,7 +26,7 @@ OPTIONS\n> >> > > \n> >> > > --mode=::\n> >> > > \tSpecify layout mode. See configuration variable column.ui for option\n> >> > > -\tsyntax.\n> >> > > +\tsyntax (in git-config(1)).\n> >> \n> >> I think we usually link to other commands with \"linkgit\", like\n> >> linkgit:git-config[1]\n> >> \n> >> Other than that, the rest looks good.\n> >\n> > Thank you, then do I edit the patch and resubmit as PATCH v2 with the\n> > message ID and all that?\n> >\n> > Frederick\n> \n> If this is the only change in the whole 3 patches, then I can just\n> squash in the following to save one round-trip.\n> \n> Documentation/git-column.txt | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/Documentation/git-column.txt b/Documentation/git-column.txt\n> index 5bbb51068e..763afabb6d 100644\n> --- a/Documentation/git-column.txt\n> +++ b/Documentation/git-column.txt\n> @@ -26,7 +26,7 @@ OPTIONS\n> \n> --mode=::\n> \tSpecify layout mode. See configuration variable column.ui for option\n> -\tsyntax (in git-config(1)).\n> +\tsyntax in linkgit:git-config[1].\n> \n> --raw-mode=::\n> \tSame as --mode but take mode encoded as a number. This is mainly used\n> \n"}]}