{"thread":{"id":"49384","subject":"[PATCH 1/2] Doc: use `--type=bool` instead of `--bool`","startedAt":"2018-09-19T16:38:38Z","lastAt":"2018-09-19T17:55:33Z","messageCount":4,"participants":["Martin Ågren","Taylor Blau"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"358463","messageId":"e81bbd0e714221aac47b387e7d1e1572af32aa8f.1537375024.git.martin.agren@gmail.com","threadId":"49384","inReplyTo":null,"subject":"[PATCH 1/2] Doc: use `--type=bool` instead of `--bool`","fromName":"Martin Ågren","fromEmail":"martin.agren@gmail.com","sentAt":"2018-09-19T16:38:18Z","receivedAt":"2018-09-19T16:38:38Z","isPatch":true,"sender":{"key":"martin.agren@gmail.com","avatar":null},"body":"After fb0dc3bac1 (builtin/config.c: support `--type=` as preferred\nalias for `--`, 2018-04-18) we have a more modern way of spelling\n`--bool`.\n\nUpdate all instances except those that explicitly document the\n\"historical options\" in git-config.txt. The other old-style\ntype-specifiers already seem to be gone except for in that list of\nhistorical options.\n\nTweak the grammar a little in config.txt while we are there.\n\nSigned-off-by: Martin Ågren \n---\n Documentation/config.txt | 2 +-\n Documentation/git-config.txt | 4 ++--\n Documentation/git.txt | 2 +-\n 3 files changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/Documentation/config.txt b/Documentation/config.txt\nindex 112041f407..088cbefecc 100644\n--- a/Documentation/config.txt\n+++ b/Documentation/config.txt\n@@ -225,7 +225,7 @@ boolean::\n \tfalse;; Boolean false literals are `no`, `off`, `false`,\n \t\t`0` and the empty string.\n +\n-When converting value to the canonical form using `--bool` type\n+When converting a value to its canonical form using the `--type=bool` type\n specifier, 'git config' will ensure that the output is \"true\" or\n \"false\" (spelled in lowercase).\n \ndiff --git a/Documentation/git-config.txt b/Documentation/git-config.txt\nindex 8e240435be..9d8cea72dd 100644\n--- a/Documentation/git-config.txt\n+++ b/Documentation/git-config.txt\n@@ -442,9 +442,9 @@ For URLs in `https://weak.example.com`, `http.sslVerify` is set to\n false, while it is set to `true` for all others:\n \n ------------\n-% git config --bool --get-urlmatch http.sslverify https://good.example.com\n+% git config --type=bool --get-urlmatch http.sslverify https://good.example.com\n true\n-% git config --bool --get-urlmatch http.sslverify https://weak.example.com\n+% git config --type=bool --get-urlmatch http.sslverify https://weak.example.com\n false\n % git config --get-urlmatch http https://weak.example.com\n http.cookieFile /tmp/cookie.txt\ndiff --git a/Documentation/git.txt b/Documentation/git.txt\nindex 74a9d7edb4..08e533d62b 100644\n--- a/Documentation/git.txt\n+++ b/Documentation/git.txt\n@@ -76,7 +76,7 @@ Note that omitting the `=` in `git -c foo.bar ...` is allowed and sets\n `foo.bar` to the boolean true value (just like `[foo]bar` would in a\n config file). Including the equals but with an empty value (like `git -c\n foo.bar= ...`) sets `foo.bar` to the empty string which `git config\n---bool` will convert to `false`.\n+--type=bool` will convert to `false`.\n \n --exec-path[=]::\n \tPath to wherever your core Git programs are installed.\n-- \n2.19.0.216.g2d3b1c576c\n\n"},{"id":"358464","messageId":"377b7cfa36c3b23150005f7faec02bbc4a325bd7.1537375024.git.martin.agren@gmail.com","threadId":"49384","inReplyTo":"e81bbd0e714221aac47b387e7d1e1572af32aa8f.1537375024.git.martin.agren@gmail.com","subject":"[PATCH 2/2] git-config.txt: fix 'see: above' note","fromName":"Martin Ågren","fromEmail":"martin.agren@gmail.com","sentAt":"2018-09-19T16:38:19Z","receivedAt":"2018-09-19T16:38:47Z","isPatch":true,"sender":{"key":"martin.agren@gmail.com","avatar":null},"body":"Rather than saying \"(see: above)\", drop the colon. Also drop the comma\nbefore this note.\n\nSigned-off-by: Martin Ågren \n---\n Documentation/git-config.txt | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/Documentation/git-config.txt b/Documentation/git-config.txt\nindex 9d8cea72dd..5e87d82933 100644\n--- a/Documentation/git-config.txt\n+++ b/Documentation/git-config.txt\n@@ -188,8 +188,8 @@ Valid ``'s include:\n --bool-or-int::\n --path::\n --expiry-date::\n- Historical options for selecting a type specifier. Prefer instead `--type`,\n- (see: above).\n+ Historical options for selecting a type specifier. Prefer instead `--type`\n+ (see above).\n \n --no-type::\n Un-sets the previously set type specifier (if one was previously set). This\n-- \n2.19.0.216.g2d3b1c576c\n\n"},{"id":"358466","messageId":"20180919172143.GA60492@syl","threadId":"49384","inReplyTo":"377b7cfa36c3b23150005f7faec02bbc4a325bd7.1537375024.git.martin.agren@gmail.com","subject":"Re: [PATCH 2/2] git-config.txt: fix 'see: above' note","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2018-09-19T17:21:43Z","receivedAt":"2018-09-19T17:21:49Z","isPatch":true,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"Hi Martin,\n\nOn Wed, Sep 19, 2018 at 06:38:19PM +0200, Martin Ågren wrote:\n> Rather than saying \"(see: above)\", drop the colon. Also drop the comma\n> before this note.\n>\n> Signed-off-by: Martin Ågren \n\nThanks for both of these. I should have at least taken care of 1/2\nmyself, but I am appreciative of you doing it, too :-).\n\nI could take or leave 2/2, since I usually write \", (see: above)\", but\nI'm not sure if that's grammatically correct or not.\n\nBut, either approach is fine with me, so both of these have my:\n\n Reviewed-by: Taylor Blau \n\nThanks,\nTaylor\n"},{"id":"358472","messageId":"CAN0heSq7T=t7A9_jzTmNvj8SEfS0E6xWs-SFFwZjb2U1Ryqd2w@mail.gmail.com","threadId":"49384","inReplyTo":"20180919172143.GA60492@syl","subject":"Re: [PATCH 2/2] git-config.txt: fix 'see: above' note","fromName":"Martin Ågren","fromEmail":"martin.agren@gmail.com","sentAt":"2018-09-19T17:55:19Z","receivedAt":"2018-09-19T17:55:33Z","isPatch":true,"sender":{"key":"martin.agren@gmail.com","avatar":null},"body":"Hi Taylor,\n\nOn Wed, 19 Sep 2018 at 19:21, Taylor Blau wrote:\n> I could take or leave 2/2, since I usually write \", (see: above)\", but\n> I'm not sure if that's grammatically correct or not.\n\nWell, I sure ain't no grammar expert too... This is not a patch I feel\nstrongly about, so I'll be happy to defer to others.\n\nThanks for reviewing,\nMartin\n"}]}