{"thread":{"id":"49367","subject":"Subject: [PATCH 0/9] hdr-check","startedAt":"2018-09-19T00:05:36Z","lastAt":"2018-09-19T03:44:45Z","messageCount":2,"participants":["Ramsay Jones","Elijah Newren"],"isPatch":true,"patchVersion":1,"patchTotal":9},"messages":[{"id":"358424","messageId":"466296e7-6462-d5c1-2d57-2a636309054c@ramsayjones.plus.com","threadId":"49367","inReplyTo":null,"subject":"Subject: [PATCH 0/9] hdr-check","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2018-09-19T00:05:31Z","receivedAt":"2018-09-19T00:05:36Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\n\nThis series follows on from a quick \"just before bedtime\" exercise\nrecently[1]. The new 'hdr-check' target essentially automates what\nElijah did by hand. I tend to run:\n\n  $ make -h hdr-check >hcout 2>&1\n  $ vim hcout\n\n... and I only just realised that if somebody wanted to add this to\nan travis CI job (it won't be me), then it would be a good idea to\nadd '-Werror' to the compiler command; otherwise 'make' would not\nexit with an error if the compiler only issues warnings.\n\nThis series was built on the current 'master' branch (@2d3b1c576c),\nalthough patches #1-6 apply on v2.19.0. (The last three patches used\nto be on 'next' until last night!).\n\nIf I merge this to 'next', I have to add an additional patch for a\nclean 'hdr-check'. Exactly the same comment for the current 'pu'\nbranch.\n\n[1] https://public-inbox.org/git/b8553a50-6b97-2b45-2f7b-cfe2576548cb@ramsayjones.plus.com/\n\nATB,\nRamsay Jones\n\nRamsay Jones (9):\n  Makefile: add a hdr-check target\n  json-writer.h: add missing include (hdr-check)\n  ewah/ewok_rlw.h: add missing include (hdr-check)\n  refs/ref-cache.h: add missing declarations (hdr-check)\n  refs/packed-backend.h: add missing declaration (hdr-check)\n  refs/refs-internal.h: add missing declarations (hdr-check)\n  midx.h: add missing forward declarations (hdr-check)\n  delta-islands.h: add missing forward declarations (hdr-check)\n  commit-reach.h: add missing declarations (hdr-check)\n\n Makefile              | 12 ++++++++++++\n commit-reach.h        |  5 +++--\n delta-islands.h       |  4 ++++\n ewah/ewok_rlw.h       |  2 ++\n json-writer.h         |  2 ++\n midx.h                |  3 +++\n refs/packed-backend.h |  2 ++\n refs/ref-cache.h      |  3 +++\n refs/refs-internal.h  |  4 ++++\n 9 files changed, 35 insertions(+), 2 deletions(-)\n\n-- \n2.19.0\n"},{"id":"358440","messageId":"CABPp-BFZMKCxjuZvNQRgyj2MAqV2FjoTZ=z7p6aX6EWad4i70w@mail.gmail.com","threadId":"49367","inReplyTo":"466296e7-6462-d5c1-2d57-2a636309054c@ramsayjones.plus.com","subject":"Re: Subject: [PATCH 0/9] hdr-check","fromName":"Elijah Newren","fromEmail":"newren@gmail.com","sentAt":"2018-09-19T03:44:23Z","receivedAt":"2018-09-19T03:44:45Z","isPatch":true,"sender":{"key":"newren@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5455730?v=4"},"body":"Hi Ramsay,\n\nOn Tue, Sep 18, 2018 at 5:09 PM Ramsay Jones\n<ramsay@ramsayjones.plus.com> wrote;\n> This series follows on from a quick \"just before bedtime\" exercise\n> recently[1]. The new 'hdr-check' target essentially automates what\n> Elijah did by hand.\n\nCool, thanks for doing this.  I believe I only tried to directly check\nthe toplevel header files (any fixes I made to headers in\nsubdirectories were just due to their indirect inclusion), so it's not\nsurprising to see that you needed to fix up some headers in\nsubdirectories.  It is slightly surprising to me that we've already\ngained 6 cases of toplevel header files that needed fixes; that\nsuggests this hdr-check is even more useful than I would have\nsuspected.\n\nThe Make-fu in patch 1 is beyond the make I know, but the other\npatches are all pretty simple and look good to me.\n"}]}