{"thread":{"id":"49350","subject":"[PATCH] midx.c: mark a file-local symbol as static","startedAt":"2018-09-14T23:26:42Z","lastAt":"2018-09-17T20:48:01Z","messageCount":4,"participants":["Ramsay Jones","Derrick Stolee","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"358170","messageId":"63d480c7-0312-3b1d-59bc-7b9996facea0@ramsayjones.plus.com","threadId":"49350","inReplyTo":null,"subject":"[PATCH] midx.c: mark a file-local symbol as static","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2018-09-14T23:26:37Z","receivedAt":"2018-09-14T23:26:42Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nSigned-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n---\n\nHi Derrick,\n\nIf you need to re-roll your 'ds/multi-pack-verify' branch, could you\nplease squash this into the relevant patch (commit 64cbf3df21,\n\"multi-pack-index: add 'verify' verb\", 2018-09-13).\n\n[noticed by sparse].\n\nThanks.\n\nATB,\nRamsay Jones\n\n midx.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/midx.c b/midx.c\nindex 4d4c930522..713d6f9dde 100644\n--- a/midx.c\n+++ b/midx.c\n@@ -926,7 +926,7 @@ void clear_midx_file(const char *object_dir)\n \tfree(midx);\n }\n \n-int verify_midx_error;\n+static int verify_midx_error;\n \n static void midx_report(const char *fmt, ...)\n {\n-- \n2.19.0\n"},{"id":"358329","messageId":"d4b88c9e-9d02-f361-922e-f85caf3994e1@gmail.com","threadId":"49350","inReplyTo":"63d480c7-0312-3b1d-59bc-7b9996facea0@ramsayjones.plus.com","subject":"Re: [PATCH] midx.c: mark a file-local symbol as static","fromName":"Derrick Stolee","fromEmail":"stolee@gmail.com","sentAt":"2018-09-17T20:11:59Z","receivedAt":"2018-09-17T20:12:09Z","isPatch":true,"sender":{"key":"stolee@gmail.com","avatar":"https://avatars.githubusercontent.com/u/570044?v=4"},"body":"On 9/14/2018 7:26 PM, Ramsay Jones wrote:\n> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n> ---\n>\n> Hi Derrick,\n>\n> If you need to re-roll your 'ds/multi-pack-verify' branch, could you\n> please squash this into the relevant patch (commit 64cbf3df21,\n> \"multi-pack-index: add 'verify' verb\", 2018-09-13).\n>\n> [noticed by sparse].\n>\n> Thanks.\n>\n> ATB,\n> Ramsay Jones\n\nThanks for catching this, Ramsay. Sorry for the mistake.\n\nds/multi-pack-verify is currently queued for 'next', so I wasn't \nplanning on sending another version.\n\nJunio, could you add this commit to the tip, or squash it into 64cbf3df2 \n\"multi-pack-index: add 'verify' verb\"?\n\nThanks,\n-Stolee\n\n>\n>   midx.c | 2 +-\n>   1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/midx.c b/midx.c\n> index 4d4c930522..713d6f9dde 100644\n> --- a/midx.c\n> +++ b/midx.c\n> @@ -926,7 +926,7 @@ void clear_midx_file(const char *object_dir)\n>   \tfree(midx);\n>   }\n>   \n> -int verify_midx_error;\n> +static int verify_midx_error;\n>   \n>   static void midx_report(const char *fmt, ...)\n>   {\n\n"},{"id":"358332","messageId":"xmqqpnxb6ei2.fsf@gitster-ct.c.googlers.com","threadId":"49350","inReplyTo":"d4b88c9e-9d02-f361-922e-f85caf3994e1@gmail.com","subject":"Re: [PATCH] midx.c: mark a file-local symbol as static","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2018-09-17T20:44:05Z","receivedAt":"2018-09-17T20:44:10Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Derrick Stolee <stolee@gmail.com> writes:\n\n> ds/multi-pack-verify is currently queued for 'next', so I wasn't\n> planning on sending another version.\n>\n> Junio, could you add this commit to the tip, or squash it into\n> 64cbf3df2 \"multi-pack-index: add 'verify' verb\"?\n\nI think it makes sense to queue this on top.  Thanks.\n"},{"id":"358333","messageId":"xmqqlg7z6ebm.fsf@gitster-ct.c.googlers.com","threadId":"49350","inReplyTo":"d4b88c9e-9d02-f361-922e-f85caf3994e1@gmail.com","subject":"Re: [PATCH] midx.c: mark a file-local symbol as static","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2018-09-17T20:47:57Z","receivedAt":"2018-09-17T20:48:01Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Derrick Stolee <stolee@gmail.com> writes:\n\n> Thanks for catching this, Ramsay. Sorry for the mistake.\n>\n> ds/multi-pack-verify is currently queued for 'next', so I wasn't\n> planning on sending another version.\n\nMarked for 'next' does not mean we cannot touch it.  It merely means\n\"so far no issue that requires a reroll has been raised afaik\", and\nthe whole point of marking it is to give people a chance to stop it\nbefore getting merged to 'next' with known issues.\n\nAs the problematic commit is not in 'next', let's squash the fix in.\n\nThanks, both.\n\n"}]}