{"thread":{"id":"49327","subject":"Gitattributes not properly supported with add command","startedAt":"2018-09-12T13:53:46Z","lastAt":"2018-09-12T13:53:46Z","messageCount":1,"participants":["smaudet@sebastianaudet.com"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"357963","messageId":"20180912131625.GA7736@sebastianaudet.com","threadId":"49327","inReplyTo":null,"subject":"Gitattributes not properly supported with add command","fromName":"","fromEmail":"smaudet@sebastianaudet.com","sentAt":"2018-09-12T13:16:25Z","receivedAt":"2018-09-12T13:53:46Z","isPatch":false,"sender":{"key":"smaudet@sebastianaudet.com","avatar":null},"body":"The following:\n\ngit add -u :\\(glob,attr:-someAttr\\):src/**\n\nProduces an error that, according to the source code, should never be visible to the user. This attribute/pathspec *should* be supported according to the documentation provided by git:\n\nfatal: BUG:builtin/add.c:498: unsupported magic 40\n\nIt looks like the documentation claims more features than the source code supports, perhaps incorrectly because I think you shouldn't be restricted to a set of attributes, and the source code \ndoesn't properly do its job anyways and never handles this scenario.\n\nThis should be fixed, if I have any time I'll look into what it would take to submit a patch, but I don't have the time for this right now.\n\n\n"}]}