{"thread":{"id":"49297","subject":"Old submodules broken in 2.19rc1 and 2.19rc2","startedAt":"2018-09-07T09:53:48Z","lastAt":"2018-09-11T19:49:17Z","messageCount":14,"participants":["Allan Sandfeld Jensen","Jeff King","Stefan Beller","Jonathan Nieder","Junio C Hamano","Johannes Sixt"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"357617","messageId":"2659750.rG6xLiZASK@twilight","threadId":"49297","inReplyTo":null,"subject":"Old submodules broken in 2.19rc1 and 2.19rc2","fromName":"Allan Sandfeld Jensen","fromEmail":"allan.jensen@qt.io","sentAt":"2018-09-07T09:52:58Z","receivedAt":"2018-09-07T09:53:48Z","isPatch":false,"sender":{"key":"allan.jensen@qt.io","avatar":null},"body":"Submodules checked out with older versions of git not longer works in the \nlatest 2.19 releases. A \"git submodule update --recursive\" command wil fail \nfor each submodule with a line saying \"fatal: could not open \n'/.git' for writing> Is a directory.\n\nI checked the release notes so far, and they do not say the old submodules \nfrom git 2.16- were no longer supported, so I assume it is a bug?\n\n'Allan\n\n\n"},{"id":"357625","messageId":"20180907150327.GB26719@sigill.intra.peff.net","threadId":"49297","inReplyTo":"2659750.rG6xLiZASK@twilight","subject":"Re: Old submodules broken in 2.19rc1 and 2.19rc2","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2018-09-07T15:03:27Z","receivedAt":"2018-09-07T15:03:30Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Fri, Sep 07, 2018 at 11:52:58AM +0200, Allan Sandfeld Jensen wrote:\n\n> Submodules checked out with older versions of git not longer works in the \n> latest 2.19 releases. A \"git submodule update --recursive\" command wil fail \n> for each submodule with a line saying \"fatal: could not open \n> '/.git' for writing> Is a directory.\n\nI couldn't reproduce after cloning with v1.6.6.3 (which creates \".git\"\nas a directory in the tree). Is it possible for you to bisect (or\nperhaps share with us the broken example)?\n\n> I checked the release notes so far, and they do not say the old submodules \n> from git 2.16- were no longer supported, so I assume it is a bug?\n\nI don't think it was intentional. +cc Stefan for submodule expertise.\n\n-Peff\n"},{"id":"357627","messageId":"1591523.hyI6sBWrkQ@twilight","threadId":"49297","inReplyTo":"20180907150327.GB26719@sigill.intra.peff.net","subject":"Re: Old submodules broken in 2.19rc1 and 2.19rc2","fromName":"Allan Sandfeld Jensen","fromEmail":"allan.jensen@qt.io","sentAt":"2018-09-07T15:18:52Z","receivedAt":"2018-09-07T15:19:01Z","isPatch":false,"sender":{"key":"allan.jensen@qt.io","avatar":null},"body":"On Freitag, 7. September 2018 17:03:27 CEST Jeff King wrote:\n> On Fri, Sep 07, 2018 at 11:52:58AM +0200, Allan Sandfeld Jensen wrote:\n> > Submodules checked out with older versions of git not longer works in the\n> > latest 2.19 releases. A \"git submodule update --recursive\" command wil\n> > fail\n> > for each submodule with a line saying \"fatal: could not open\n> > '/.git' for writing> Is a directory.\n> \n> I couldn't reproduce after cloning with v1.6.6.3 (which creates \".git\"\n> as a directory in the tree). Is it possible for you to bisect (or\n> perhaps share with us the broken example)?\n> \nI discovered it by using Debian testing, and it is shipping the 2.17rcs for \nsome reason. The example is just an old checkout of qt5.git with submodules, \nit is rather large.\n\nI could try bisecting, but I am not sure I have the time anytime soon, I just \nwanted to report it to you first incase you knew of a change that suddenly \nassumed the new structure.\n\n'Allan\n\n\n\n"},{"id":"357632","messageId":"CAGZ79kaVQ0T=acpviOoD+8XVxYsefNkO7c5d+d0Wc0iCbr2Evw@mail.gmail.com","threadId":"49297","inReplyTo":"2659750.rG6xLiZASK@twilight","subject":"Re: Old submodules broken in 2.19rc1 and 2.19rc2","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2018-09-07T17:08:43Z","receivedAt":"2018-09-07T17:08:57Z","isPatch":false,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"On Fri, Sep 7, 2018 at 2:53 AM Allan Sandfeld Jensen wrote:\n>\n> Submodules checked out with older versions of git not longer works in the\n> latest 2.19 releases. A \"git submodule update --recursive\" command wil fail\n> for each submodule with a line saying \"fatal: could not open\n> '/.git' for writing> Is a directory.\n\nCan you run the update again with\n\n GIT_TRACE=1 git submodule update ....\n\nand post the output?\n\nI have the suspicion that e98317508c0 (submodule:\nensure core.worktree is set after update, 2018-06-18)\nmight be the offender.\n\nCould you try reverting that commit and check as well?\n\n git clone https://github.com/git/git && cd git\n git revert e98317508c0\n make install # installs to you home dir at ~/bin\n\nand then try again, as well?\n(though bisection may be more fruitful if this doesn't pan out)\n"},{"id":"357651","messageId":"20180907201440.GB103699@aiede.svl.corp.google.com","threadId":"49297","inReplyTo":"1591523.hyI6sBWrkQ@twilight","subject":"Re: Old submodules broken in 2.19rc1 and 2.19rc2","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2018-09-07T20:14:40Z","receivedAt":"2018-09-07T20:14:44Z","isPatch":false,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Hi,\n\nAllan Sandfeld Jensen wrote:\n\n> I discovered it by using Debian testing, and it is shipping the 2.17rcs for\n> some reason.\n\nI believe you mean Debian unstable. Debian testing has 2.18.0.\n\n> The example is just an old checkout of qt5.git with submodules, \n> it is rather large.\n\nDo you have a reproduction recipe I can use (starting with a \"git clone\"\ncommand I would run using an old version of Git, etc)?\n\n> I could try bisecting, but I am not sure I have the time anytime soon, I just \n> wanted to report it to you first incase you knew of a change that suddenly \n> assumed the new structure.\n\nThis is definitely not an intentional change, so more details would be\nvery welcome.\n\nThanks,\nJonathan\n"},{"id":"357652","messageId":"20180907202007.GC103699@aiede.svl.corp.google.com","threadId":"49297","inReplyTo":"CAGZ79kaVQ0T=acpviOoD+8XVxYsefNkO7c5d+d0Wc0iCbr2Evw@mail.gmail.com","subject":"Re: Old submodules broken in 2.19rc1 and 2.19rc2","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2018-09-07T20:20:07Z","receivedAt":"2018-09-07T20:20:12Z","isPatch":false,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Stefan Beller wrote:\n> On Fri, Sep 7, 2018 at 2:53 AM Allan Sandfeld Jensen wrote:\n\n>> A \"git submodule update --recursive\" command wil fail\n>> for each submodule with a line saying \"fatal: could not open\n>> '/.git' for writing> Is a directory.\n[...]\n> I have the suspicion that e98317508c0 (submodule:\n> ensure core.worktree is set after update, 2018-06-18)\n> might be the offender.\n\nOh! That seems likely.\n\nAllan, output from \"strace -f git submodule update --init\" would also\nbe interesting.\n\nJonathan\n"},{"id":"357661","messageId":"20180907223515.GD103699@aiede.svl.corp.google.com","threadId":"49297","inReplyTo":"CAGZ79kaVQ0T=acpviOoD+8XVxYsefNkO7c5d+d0Wc0iCbr2Evw@mail.gmail.com","subject":"Re: Old submodules broken in 2.19rc1 and 2.19rc2","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2018-09-07T22:35:15Z","receivedAt":"2018-09-07T22:35:20Z","isPatch":false,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Stefan Beller wrote:\n> On Fri, Sep 7, 2018 at 2:53 AM Allan Sandfeld Jensen wrote:\n\n>> Submodules checked out with older versions of git not longer works in the\n>> latest 2.19 releases. A \"git submodule update --recursive\" command wil fail\n>> for each submodule with a line saying \"fatal: could not open\n>> '/.git' for writing> Is a directory.\n[...]\n> I have the suspicion that e98317508c0 (submodule:\n> ensure core.worktree is set after update, 2018-06-18)\n> might be the offender.\n\nI still was not able to reproduce it, but after a bit of staring at\nthe code, I'm pretty sure I just did something wrong in the\nreproduction process. That commit is indeed the offender.\n\nIt introduces the following code (rewrapped for clarity) in\ngit-submodule.sh:\n\n\tif ! $(\n\t\tgit config -f \\\n\t\t\t\"$(git rev-parse --git-common-dir)/modules/$name/config\" \\\n\t\t\tcore.worktree\n\t) 2>/dev/null\n\tthen\n\t\tgit submodule--helper connect-gitdir-workingtree \"$name\" \"$sm_path\"\n\tfi\n\nStaring at it for a while, you can see one problem: the 'if ! $(git\nconfig)' should be simply 'if ! git config'. This ends up trying to\nrun the core.worktree value as a command, which would usually fail.\n\nThat brings us into connect_work_tree_and_git_dir, which does\n\n\t/* Prepare .git file */\n\tstrbuf_addf(&gitfile_sb, \"%s/.git\", work_tree_);\n\tif (safe_create_leading_directories_const(gitfile_sb.buf))\n\t\tdie(_(\"could not create directories for %s\"), gitfile_sb.buf);\n\n\t/* Prepare config file */\n\tstrbuf_addf(&cfg_sb, \"%s/config\", git_dir_);\n\tif (safe_create_leading_directories_const(cfg_sb.buf))\n\t\tdie(_(\"could not create directories for %s\"), cfg_sb.buf);\n\n\tgit_dir = real_pathdup(git_dir_, 1);\n\twork_tree = real_pathdup(work_tree_, 1);\n\n\t/* Write .git file */\n\twrite_file(gitfile_sb.buf, \"gitdir: %s\",\n\t\t relative_path(git_dir, work_tree, &rel_path));\n\nThe write_file runs into .git already existing as a directory, failing\nwith the message Allan saw.\n\nThis would happen in at least two cases:\n\n- if the submodule exists both in .git/modules/ *and* in the worktree\n (due to flipping between Git versions and branches with and without\n the submodule), the above will happen\n\n- likewise if the submodule exists only in the worktree, like for Allan.\n\nIn \"next\" there is 74d4731d (submodule--helper: replace\nconnect-gitdir-workingtree by ensure-core-worktree, 2018-08-13) which\nuses robust helpers in C that handle this much better. I think we\nshould revert e98317508c0 in \"master\" (for 2.19) and keep making use\nof that 'second try' in \"next\" (for 2.20).\n\nI'll try to pin down a reproduction case and send a revert + testsuite\npatch.\n\nThanks again,\nJonathan\n"},{"id":"357662","messageId":"1612976.VLH7GnMWUR@twilight","threadId":"49297","inReplyTo":"CAGZ79kaVQ0T=acpviOoD+8XVxYsefNkO7c5d+d0Wc0iCbr2Evw@mail.gmail.com","subject":"Re: Old submodules broken in 2.19rc1 and 2.19rc2","fromName":"Allan Sandfeld Jensen","fromEmail":"allan.jensen@qt.io","sentAt":"2018-09-07T22:33:25Z","receivedAt":"2018-09-07T22:38:04Z","isPatch":false,"sender":{"key":"allan.jensen@qt.io","avatar":null},"body":"On Freitag, 7. September 2018 19:08:43 CEST Stefan Beller wrote:\n> On Fri, Sep 7, 2018 at 2:53 AM Allan Sandfeld Jensen \nwrote:\n> > Submodules checked out with older versions of git not longer works in the\n> > latest 2.19 releases. A \"git submodule update --recursive\" command wil\n> > fail\n> > for each submodule with a line saying \"fatal: could not open\n> > '/.git' for writing> Is a directory.\n> \n> Can you run the update again with\n> \n> GIT_TRACE=1 git submodule update ....\n> \n> and post the output?\n> \n> I have the suspicion that e98317508c0 (submodule:\n> ensure core.worktree is set after update, 2018-06-18)\n> might be the offender.\n> \n> Could you try reverting that commit and check as well?\n> \n> git clone https://github.com/git/git && cd git\n> git revert e98317508c0\n> make install # installs to you home dir at ~/bin\n> \n> and then try again, as well?\n> (though bisection may be more fruitful if this doesn't pan out)\n\nOkay. I had the issue on my workstation at work which I won't be back to until \nfriday next week, but I managed to reproduce the exact same issue on separate \nmachine running Ubuntu, and a freshly built git from git master, on another \nroughly one year old checkout of qt5.git with submodules\n\n\n\n\n[127] carewolf@twilight% GIT_TRACE=1 ~src/git/git submodule update --recursive [5.11.2] ~qt5\n00:28:32.234453 git.c:659 trace: exec: git-submodule update --recursive\n00:28:32.234491 run-command.c:637 trace: run_command: git-submodule update --recursive\n00:28:32.240792 git.c:415 trace: built-in: git rev-parse --git-dir\n00:28:32.241981 git.c:415 trace: built-in: git rev-parse --git-path objects\n00:28:32.242905 git.c:415 trace: built-in: git rev-parse -q --git-dir\n00:28:32.244794 git.c:415 trace: built-in: git rev-parse --show-prefix\n00:28:32.245699 git.c:415 trace: built-in: git rev-parse --show-toplevel\n00:28:32.247181 git.c:415 trace: built-in: git submodule--helper update-clone\n00:28:32.247463 run-command.c:1553 run_processes_parallel: preparing to run up to 1 tasks\n00:28:32.247764 run-command.c:1585 run_processes_parallel: done\n00:28:32.248626 git.c:415 trace: built-in: git submodule--helper name qt3d\n00:28:32.249751 git.c:415 trace: built-in: git config submodule.qt3d.update\n00:28:32.250608 git.c:415 trace: built-in: git submodule--helper relative-path qt3d \n00:28:32.251399 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.252120 git.c:415 trace: built-in: git rev-parse --verify HEAD\n00:28:32.253096 git.c:415 trace: built-in: git rev-parse --git-common-dir\n00:28:32.253982 git.c:415 trace: built-in: git config -f .git/modules/qt3d/config core.worktree\n00:28:32.254771 git.c:415 trace: built-in: git submodule--helper connect-gitdir-workingtree qt3d qt3d\nfatal: could not open 'qt3d/.git' for writing: Is a directory\n00:28:32.255930 git.c:415 trace: built-in: git submodule--helper relative-path qt3d/ \n00:28:32.256712 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.257878 git.c:415 trace: built-in: git submodule--helper update-clone --recursive-prefix qt3d/\n00:28:32.258510 run-command.c:1553 run_processes_parallel: preparing to run up to 1 tasks\n00:28:32.258544 run-command.c:1585 run_processes_parallel: done\n00:28:32.260356 git.c:415 trace: built-in: git submodule--helper name qtactiveqt\n00:28:32.261475 git.c:415 trace: built-in: git config submodule.qtactiveqt.update\n00:28:32.262321 git.c:415 trace: built-in: git submodule--helper relative-path qtactiveqt \n00:28:32.263259 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.263987 git.c:415 trace: built-in: git rev-parse --verify HEAD\n00:28:32.264929 git.c:415 trace: built-in: git rev-parse --git-common-dir\n00:28:32.265775 git.c:415 trace: built-in: git config -f .git/modules/qtactiveqt/config core.worktree\n00:28:32.266563 git.c:415 trace: built-in: git submodule--helper connect-gitdir-workingtree qtactiveqt qtactiveqt\nfatal: could not open 'qtactiveqt/.git' for writing: Is a directory\n00:28:32.267595 git.c:415 trace: built-in: git submodule--helper relative-path qtactiveqt/ \n00:28:32.268310 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.269481 git.c:415 trace: built-in: git submodule--helper update-clone --recursive-prefix qtactiveqt/\n00:28:32.269626 run-command.c:1553 run_processes_parallel: preparing to run up to 1 tasks\n00:28:32.269652 run-command.c:1585 run_processes_parallel: done\n00:28:32.270893 git.c:415 trace: built-in: git submodule--helper name qtandroidextras\n00:28:32.272151 git.c:415 trace: built-in: git config submodule.qtandroidextras.update\n00:28:32.273213 git.c:415 trace: built-in: git submodule--helper relative-path qtandroidextras \n00:28:32.274162 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.274856 git.c:415 trace: built-in: git rev-parse --verify HEAD\n00:28:32.275879 git.c:415 trace: built-in: git rev-parse --git-common-dir\n00:28:32.276995 git.c:415 trace: built-in: git config -f .git/modules/qtandroidextras/config core.worktree\n00:28:32.277883 git.c:415 trace: built-in: git submodule--helper connect-gitdir-workingtree qtandroidextras qtandroidextras\nfatal: could not open 'qtandroidextras/.git' for writing: Is a directory\n00:28:32.278974 git.c:415 trace: built-in: git submodule--helper relative-path qtandroidextras/ \n00:28:32.279721 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.280735 git.c:415 trace: built-in: git submodule--helper update-clone --recursive-prefix qtandroidextras/\n00:28:32.280854 run-command.c:1553 run_processes_parallel: preparing to run up to 1 tasks\n00:28:32.280881 run-command.c:1585 run_processes_parallel: done\n00:28:32.281938 git.c:415 trace: built-in: git submodule--helper name qtbase\n00:28:32.283009 git.c:415 trace: built-in: git config submodule.qtbase.update\n00:28:32.283947 git.c:415 trace: built-in: git submodule--helper relative-path qtbase \n00:28:32.284835 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.285594 git.c:415 trace: built-in: git rev-parse --verify HEAD\n00:28:32.286639 git.c:415 trace: built-in: git rev-parse --git-common-dir\n00:28:32.287548 git.c:415 trace: built-in: git config -f .git/modules/qtbase/config core.worktree\n00:28:32.288399 git.c:415 trace: built-in: git submodule--helper connect-gitdir-workingtree qtbase qtbase\nfatal: could not open 'qtbase/.git' for writing: Is a directory\n00:28:32.289379 git.c:415 trace: built-in: git submodule--helper relative-path qtbase/ \n00:28:32.290073 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.291003 git.c:415 trace: built-in: git submodule--helper update-clone --recursive-prefix qtbase/\n00:28:32.293437 run-command.c:1553 run_processes_parallel: preparing to run up to 1 tasks\n00:28:32.293450 run-command.c:1585 run_processes_parallel: done\n00:28:32.294761 git.c:415 trace: built-in: git submodule--helper name qtcanvas3d\n00:28:32.295955 git.c:415 trace: built-in: git config submodule.qtcanvas3d.update\n00:28:32.296830 git.c:415 trace: built-in: git submodule--helper relative-path qtcanvas3d \n00:28:32.297737 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.298323 git.c:415 trace: built-in: git rev-parse --verify HEAD\n00:28:32.299308 git.c:415 trace: built-in: git rev-parse --git-common-dir\n00:28:32.300424 git.c:415 trace: built-in: git config -f .git/modules/qtcanvas3d/config core.worktree\n00:28:32.301219 git.c:415 trace: built-in: git submodule--helper connect-gitdir-workingtree qtcanvas3d qtcanvas3d\nfatal: could not open 'qtcanvas3d/.git' for writing: Is a directory\n00:28:32.302298 git.c:415 trace: built-in: git submodule--helper relative-path qtcanvas3d/ \n00:28:32.303135 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.304144 git.c:415 trace: built-in: git submodule--helper update-clone --recursive-prefix qtcanvas3d/\n00:28:32.304305 run-command.c:1553 run_processes_parallel: preparing to run up to 1 tasks\n00:28:32.304312 run-command.c:1585 run_processes_parallel: done\n00:28:32.305436 git.c:415 trace: built-in: git submodule--helper name qtcharts\n00:28:32.306623 git.c:415 trace: built-in: git config submodule.qtcharts.update\n00:28:32.307733 git.c:415 trace: built-in: git submodule--helper relative-path qtcharts \n00:28:32.309132 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.309953 git.c:415 trace: built-in: git rev-parse --verify HEAD\n00:28:32.310872 git.c:415 trace: built-in: git rev-parse --git-common-dir\n00:28:32.311715 git.c:415 trace: built-in: git config -f .git/modules/qtcharts/config core.worktree\n00:28:32.312694 git.c:415 trace: built-in: git submodule--helper connect-gitdir-workingtree qtcharts qtcharts\nfatal: could not open 'qtcharts/.git' for writing: Is a directory\n00:28:32.313739 git.c:415 trace: built-in: git submodule--helper relative-path qtcharts/ \n00:28:32.314476 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.315474 git.c:415 trace: built-in: git submodule--helper update-clone --recursive-prefix qtcharts/\n00:28:32.315706 run-command.c:1553 run_processes_parallel: preparing to run up to 1 tasks\n00:28:32.315714 run-command.c:1585 run_processes_parallel: done\n00:28:32.317048 git.c:415 trace: built-in: git submodule--helper name qtconnectivity\n00:28:32.318220 git.c:415 trace: built-in: git config submodule.qtconnectivity.update\n00:28:32.319278 git.c:415 trace: built-in: git submodule--helper relative-path qtconnectivity \n00:28:32.320454 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.321200 git.c:415 trace: built-in: git rev-parse --verify HEAD\n00:28:32.322107 git.c:415 trace: built-in: git rev-parse --git-common-dir\n00:28:32.323086 git.c:415 trace: built-in: git config -f .git/modules/qtconnectivity/config core.worktree\n00:28:32.323983 git.c:415 trace: built-in: git submodule--helper connect-gitdir-workingtree qtconnectivity qtconnectivity\nfatal: could not open 'qtconnectivity/.git' for writing: Is a directory\n00:28:32.325043 git.c:415 trace: built-in: git submodule--helper relative-path qtconnectivity/ \n00:28:32.325810 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.326789 git.c:415 trace: built-in: git submodule--helper update-clone --recursive-prefix qtconnectivity/\n00:28:32.326978 run-command.c:1553 run_processes_parallel: preparing to run up to 1 tasks\n00:28:32.326987 run-command.c:1585 run_processes_parallel: done\n00:28:32.328155 git.c:415 trace: built-in: git submodule--helper name qtdatavis3d\n00:28:32.329275 git.c:415 trace: built-in: git config submodule.qtdatavis3d.update\n00:28:32.330125 git.c:415 trace: built-in: git submodule--helper relative-path qtdatavis3d \n00:28:32.331069 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.331678 git.c:415 trace: built-in: git rev-parse --verify HEAD\n00:28:32.332616 git.c:415 trace: built-in: git rev-parse --git-common-dir\n00:28:32.333516 git.c:415 trace: built-in: git config -f .git/modules/qtdatavis3d/config core.worktree\n00:28:32.334445 git.c:415 trace: built-in: git submodule--helper connect-gitdir-workingtree qtdatavis3d qtdatavis3d\nfatal: could not open 'qtdatavis3d/.git' for writing: Is a directory\n00:28:32.335636 git.c:415 trace: built-in: git submodule--helper relative-path qtdatavis3d/ \n00:28:32.336442 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.337468 git.c:415 trace: built-in: git submodule--helper update-clone --recursive-prefix qtdatavis3d/\n00:28:32.337696 run-command.c:1553 run_processes_parallel: preparing to run up to 1 tasks\n00:28:32.337724 run-command.c:1585 run_processes_parallel: done\n00:28:32.338780 git.c:415 trace: built-in: git submodule--helper name qtdeclarative\n00:28:32.339940 git.c:415 trace: built-in: git config submodule.qtdeclarative.update\n00:28:32.340751 git.c:415 trace: built-in: git submodule--helper relative-path qtdeclarative \n00:28:32.341537 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.342183 git.c:415 trace: built-in: git rev-parse --verify HEAD\n00:28:32.343111 git.c:415 trace: built-in: git rev-parse --git-common-dir\n00:28:32.343997 git.c:415 trace: built-in: git config -f .git/modules/qtdeclarative/config core.worktree\n00:28:32.344743 git.c:415 trace: built-in: git submodule--helper connect-gitdir-workingtree qtdeclarative qtdeclarative\nfatal: could not open 'qtdeclarative/.git' for writing: Is a directory\n00:28:32.345732 git.c:415 trace: built-in: git submodule--helper relative-path qtdeclarative/ \n00:28:32.346490 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.347495 git.c:415 trace: built-in: git submodule--helper update-clone --recursive-prefix qtdeclarative/\n00:28:32.348619 run-command.c:1553 run_processes_parallel: preparing to run up to 1 tasks\n00:28:32.348690 run-command.c:1585 run_processes_parallel: done\n00:28:32.349524 git.c:415 trace: built-in: git submodule--helper name tests/auto/qml/ecmascripttests/test262\n00:28:32.351213 git.c:415 trace: built-in: git config submodule.tests/auto/qml/ecmascripttests/test262.update\n00:28:32.352106 git.c:415 trace: built-in: git submodule--helper relative-path qtdeclarative/tests/auto/qml/ecmascripttests/test262 \n00:28:32.352996 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.353646 git.c:415 trace: built-in: git rev-parse --verify HEAD\n00:28:32.354640 git.c:415 trace: built-in: git rev-parse --git-common-dir\n00:28:32.355437 git.c:415 trace: built-in: git config -f .git/modules/tests/auto/qml/ecmascripttests/test262/config core.worktree\n00:28:32.356344 git.c:415 trace: built-in: git submodule--helper connect-gitdir-workingtree tests/auto/qml/ecmascripttests/test262 tests/auto/qml/ecmascripttests/test262\n00:28:32.357659 git.c:415 trace: built-in: git submodule--helper relative-path qtdeclarative/tests/auto/qml/ecmascripttests/test262/ \n00:28:32.358693 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.360070 git.c:415 trace: built-in: git submodule--helper update-clone --recursive-prefix qtdeclarative/tests/auto/qml/ecmascripttests/test262/\n00:28:32.361641 run-command.c:1553 run_processes_parallel: preparing to run up to 1 tasks\n00:28:32.361673 run-command.c:1585 run_processes_parallel: done\n00:28:32.363347 git.c:415 trace: built-in: git submodule--helper name qtdoc\n00:28:32.364557 git.c:415 trace: built-in: git config submodule.qtdoc.update\n00:28:32.365526 git.c:415 trace: built-in: git submodule--helper relative-path qtdoc \n00:28:32.366413 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.367022 git.c:415 trace: built-in: git rev-parse --verify HEAD\n00:28:32.368012 git.c:415 trace: built-in: git rev-parse --git-common-dir\n00:28:32.368810 git.c:415 trace: built-in: git config -f .git/modules/qtdoc/config core.worktree\n00:28:32.369720 git.c:415 trace: built-in: git submodule--helper connect-gitdir-workingtree qtdoc qtdoc\nfatal: could not open 'qtdoc/.git' for writing: Is a directory\n00:28:32.370824 git.c:415 trace: built-in: git submodule--helper relative-path qtdoc/ \n00:28:32.371573 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.372563 git.c:415 trace: built-in: git submodule--helper update-clone --recursive-prefix qtdoc/\n00:28:32.372766 run-command.c:1553 run_processes_parallel: preparing to run up to 1 tasks\n00:28:32.372775 run-command.c:1585 run_processes_parallel: done\n00:28:32.373799 git.c:415 trace: built-in: git submodule--helper name qtdocgallery\n00:28:32.374757 git.c:415 trace: built-in: git config submodule.qtdocgallery.update\n00:28:32.375489 git.c:415 trace: built-in: git submodule--helper relative-path qtdocgallery \n00:28:32.376272 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.376930 git.c:415 trace: built-in: git rev-parse --verify HEAD\n00:28:32.377819 git.c:415 trace: built-in: git rev-parse --git-common-dir\n00:28:32.378643 git.c:415 trace: built-in: git config -f .git/modules/qtdocgallery/config core.worktree\n00:28:32.379545 git.c:415 trace: built-in: git submodule--helper connect-gitdir-workingtree qtdocgallery qtdocgallery\n00:28:32.380811 git.c:415 trace: built-in: git submodule--helper relative-path qtdocgallery/ \n00:28:32.381563 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.382596 git.c:415 trace: built-in: git submodule--helper update-clone --recursive-prefix qtdocgallery/\n00:28:32.382712 run-command.c:1553 run_processes_parallel: preparing to run up to 1 tasks\n00:28:32.382738 run-command.c:1585 run_processes_parallel: done\n00:28:32.383858 git.c:415 trace: built-in: git submodule--helper name qtfeedback\n00:28:32.384939 git.c:415 trace: built-in: git config submodule.qtfeedback.update\n00:28:32.385747 git.c:415 trace: built-in: git submodule--helper relative-path qtfeedback \n00:28:32.386554 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.387206 git.c:415 trace: built-in: git rev-parse --verify HEAD\n00:28:32.388173 git.c:415 trace: built-in: git rev-parse --git-common-dir\n00:28:32.388989 git.c:415 trace: built-in: git config -f .git/modules/qtfeedback/config core.worktree\n00:28:32.389997 git.c:415 trace: built-in: git submodule--helper connect-gitdir-workingtree qtfeedback qtfeedback\n00:28:32.391155 git.c:415 trace: built-in: git submodule--helper relative-path qtfeedback/ \n00:28:32.391946 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.392937 git.c:415 trace: built-in: git submodule--helper update-clone --recursive-prefix qtfeedback/\n00:28:32.393042 run-command.c:1553 run_processes_parallel: preparing to run up to 1 tasks\n00:28:32.393053 run-command.c:1585 run_processes_parallel: done\n00:28:32.394070 git.c:415 trace: built-in: git submodule--helper name qtgamepad\n00:28:32.395037 git.c:415 trace: built-in: git config submodule.qtgamepad.update\n00:28:32.395778 git.c:415 trace: built-in: git submodule--helper relative-path qtgamepad \n00:28:32.396736 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.397423 git.c:415 trace: built-in: git rev-parse --verify HEAD\n00:28:32.398334 git.c:415 trace: built-in: git rev-parse --git-common-dir\n00:28:32.399191 git.c:415 trace: built-in: git config -f .git/modules/qtgamepad/config core.worktree\n00:28:32.400069 git.c:415 trace: built-in: git submodule--helper connect-gitdir-workingtree qtgamepad qtgamepad\nfatal: could not open 'qtgamepad/.git' for writing: Is a directory\n00:28:32.401080 git.c:415 trace: built-in: git submodule--helper relative-path qtgamepad/ \n00:28:32.401843 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.402868 git.c:415 trace: built-in: git submodule--helper update-clone --recursive-prefix qtgamepad/\n00:28:32.402976 run-command.c:1553 run_processes_parallel: preparing to run up to 1 tasks\n00:28:32.402988 run-command.c:1585 run_processes_parallel: done\n00:28:32.404108 git.c:415 trace: built-in: git submodule--helper name qtgraphicaleffects\n00:28:32.405122 git.c:415 trace: built-in: git config submodule.qtgraphicaleffects.update\n00:28:32.406006 git.c:415 trace: built-in: git submodule--helper relative-path qtgraphicaleffects \n00:28:32.407290 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.408276 git.c:415 trace: built-in: git rev-parse --verify HEAD\n00:28:32.409773 git.c:415 trace: built-in: git rev-parse --git-common-dir\n00:28:32.410889 git.c:415 trace: built-in: git config -f .git/modules/qtgraphicaleffects/config core.worktree\n00:28:32.411702 git.c:415 trace: built-in: git submodule--helper connect-gitdir-workingtree qtgraphicaleffects qtgraphicaleffects\nfatal: could not open 'qtgraphicaleffects/.git' for writing: Is a directory\n00:28:32.412798 git.c:415 trace: built-in: git submodule--helper relative-path qtgraphicaleffects/ \n00:28:32.413551 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.414577 git.c:415 trace: built-in: git submodule--helper update-clone --recursive-prefix qtgraphicaleffects/\n00:28:32.414724 run-command.c:1553 run_processes_parallel: preparing to run up to 1 tasks\n00:28:32.414732 run-command.c:1585 run_processes_parallel: done\n00:28:32.416013 git.c:415 trace: built-in: git submodule--helper name qtimageformats\n00:28:32.417100 git.c:415 trace: built-in: git config submodule.qtimageformats.update\n00:28:32.418063 git.c:415 trace: built-in: git submodule--helper relative-path qtimageformats \n00:28:32.419038 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.419763 git.c:415 trace: built-in: git rev-parse --verify HEAD\n00:28:32.420765 git.c:415 trace: built-in: git rev-parse --git-common-dir\n00:28:32.421611 git.c:415 trace: built-in: git config -f .git/modules/qtimageformats/config core.worktree\n00:28:32.422395 git.c:415 trace: built-in: git submodule--helper connect-gitdir-workingtree qtimageformats qtimageformats\nfatal: could not open 'qtimageformats/.git' for writing: Is a directory\n00:28:32.423463 git.c:415 trace: built-in: git submodule--helper relative-path qtimageformats/ \n00:28:32.424255 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.425276 git.c:415 trace: built-in: git submodule--helper update-clone --recursive-prefix qtimageformats/\n00:28:32.425454 run-command.c:1553 run_processes_parallel: preparing to run up to 1 tasks\n00:28:32.425462 run-command.c:1585 run_processes_parallel: done\n00:28:32.426548 git.c:415 trace: built-in: git submodule--helper name qtlocation\n00:28:32.427653 git.c:415 trace: built-in: git config submodule.qtlocation.update\n00:28:32.428520 git.c:415 trace: built-in: git submodule--helper relative-path qtlocation \n00:28:32.429392 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.430081 git.c:415 trace: built-in: git rev-parse --verify HEAD\n00:28:32.430948 git.c:415 trace: built-in: git rev-parse --git-common-dir\n00:28:32.431883 git.c:415 trace: built-in: git config -f .git/modules/qtlocation/config core.worktree\n00:28:32.432644 git.c:415 trace: built-in: git submodule--helper connect-gitdir-workingtree qtlocation qtlocation\nfatal: could not open 'qtlocation/.git' for writing: Is a directory\n00:28:32.433659 git.c:415 trace: built-in: git submodule--helper relative-path qtlocation/ \n00:28:32.434425 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.435419 git.c:415 trace: built-in: git submodule--helper update-clone --recursive-prefix qtlocation/\n00:28:32.435658 run-command.c:1553 run_processes_parallel: preparing to run up to 1 tasks\n00:28:32.435689 run-command.c:1585 run_processes_parallel: done\n00:28:32.436536 git.c:415 trace: built-in: git submodule--helper name src/3rdparty/mapbox-gl-native\n00:28:32.437460 git.c:415 trace: built-in: git config submodule.src/3rdparty/mapbox-gl-native.update\n00:28:32.438238 git.c:415 trace: built-in: git submodule--helper relative-path qtlocation/src/3rdparty/mapbox-gl-native \n00:28:32.439093 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.439705 git.c:415 trace: built-in: git rev-parse --verify HEAD\n00:28:32.440802 git.c:415 trace: built-in: git rev-parse --git-common-dir\n00:28:32.441577 git.c:415 trace: built-in: git config -f .git/modules/src/3rdparty/mapbox-gl-native/config core.worktree\n00:28:32.442548 git.c:415 trace: built-in: git submodule--helper connect-gitdir-workingtree src/3rdparty/mapbox-gl-native src/3rdparty/mapbox-gl-native\n00:28:32.443595 git.c:415 trace: built-in: git submodule--helper relative-path qtlocation/src/3rdparty/mapbox-gl-native/ \n00:28:32.444333 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.445350 git.c:415 trace: built-in: git submodule--helper update-clone --recursive-prefix qtlocation/src/3rdparty/mapbox-gl-native/\n00:28:32.445928 run-command.c:1553 run_processes_parallel: preparing to run up to 1 tasks\n00:28:32.445938 run-command.c:1585 run_processes_parallel: done\n00:28:32.447234 git.c:415 trace: built-in: git submodule--helper name qtmacextras\n00:28:32.448286 git.c:415 trace: built-in: git config submodule.qtmacextras.update\n00:28:32.449142 git.c:415 trace: built-in: git submodule--helper relative-path qtmacextras \n00:28:32.450001 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.450815 git.c:415 trace: built-in: git rev-parse --verify HEAD\n00:28:32.451994 git.c:415 trace: built-in: git rev-parse --git-common-dir\n00:28:32.452936 git.c:415 trace: built-in: git config -f .git/modules/qtmacextras/config core.worktree\n00:28:32.453738 git.c:415 trace: built-in: git submodule--helper connect-gitdir-workingtree qtmacextras qtmacextras\nfatal: could not open 'qtmacextras/.git' for writing: Is a directory\n00:28:32.454821 git.c:415 trace: built-in: git submodule--helper relative-path qtmacextras/ \n00:28:32.455618 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.456636 git.c:415 trace: built-in: git submodule--helper update-clone --recursive-prefix qtmacextras/\n00:28:32.456803 run-command.c:1553 run_processes_parallel: preparing to run up to 1 tasks\n00:28:32.456812 run-command.c:1585 run_processes_parallel: done\n00:28:32.458217 git.c:415 trace: built-in: git submodule--helper name qtmultimedia\n00:28:32.459897 git.c:415 trace: built-in: git config submodule.qtmultimedia.update\n00:28:32.460908 git.c:415 trace: built-in: git submodule--helper relative-path qtmultimedia \n00:28:32.461787 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.462588 git.c:415 trace: built-in: git rev-parse --verify HEAD\n00:28:32.463611 git.c:415 trace: built-in: git rev-parse --git-common-dir\n00:28:32.464496 git.c:415 trace: built-in: git config -f .git/modules/qtmultimedia/config core.worktree\n00:28:32.465265 git.c:415 trace: built-in: git submodule--helper connect-gitdir-workingtree qtmultimedia qtmultimedia\nfatal: could not open 'qtmultimedia/.git' for writing: Is a directory\n00:28:32.466329 git.c:415 trace: built-in: git submodule--helper relative-path qtmultimedia/ \n00:28:32.467121 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.468129 git.c:415 trace: built-in: git submodule--helper update-clone --recursive-prefix qtmultimedia/\n00:28:32.468431 run-command.c:1553 run_processes_parallel: preparing to run up to 1 tasks\n00:28:32.468441 run-command.c:1585 run_processes_parallel: done\n00:28:32.469470 git.c:415 trace: built-in: git submodule--helper name qtnetworkauth\n00:28:32.470535 git.c:415 trace: built-in: git config submodule.qtnetworkauth.update\n00:28:32.471371 git.c:415 trace: built-in: git submodule--helper relative-path qtnetworkauth \n00:28:32.472263 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.472913 git.c:415 trace: built-in: git rev-parse --verify HEAD\n00:28:32.473816 git.c:415 trace: built-in: git rev-parse --git-common-dir\n00:28:32.474659 git.c:415 trace: built-in: git config -f .git/modules/qtnetworkauth/config core.worktree\n00:28:32.475434 git.c:415 trace: built-in: git submodule--helper connect-gitdir-workingtree qtnetworkauth qtnetworkauth\nfatal: could not open 'qtnetworkauth/.git' for writing: Is a directory\n00:28:32.476461 git.c:415 trace: built-in: git submodule--helper relative-path qtnetworkauth/ \n00:28:32.477322 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.478451 git.c:415 trace: built-in: git submodule--helper update-clone --recursive-prefix qtnetworkauth/\n00:28:32.478570 run-command.c:1553 run_processes_parallel: preparing to run up to 1 tasks\n00:28:32.478597 run-command.c:1585 run_processes_parallel: done\n00:28:32.479732 git.c:415 trace: built-in: git submodule--helper name qtpim\n00:28:32.480914 git.c:415 trace: built-in: git config submodule.qtpim.update\n00:28:32.481850 git.c:415 trace: built-in: git submodule--helper relative-path qtpim \n00:28:32.482689 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.483373 git.c:415 trace: built-in: git rev-parse --verify HEAD\n00:28:32.484330 git.c:415 trace: built-in: git rev-parse --git-common-dir\n00:28:32.485198 git.c:415 trace: built-in: git config -f .git/modules/qtpim/config core.worktree\n00:28:32.486164 git.c:415 trace: built-in: git submodule--helper connect-gitdir-workingtree qtpim qtpim\n00:28:32.487302 git.c:415 trace: built-in: git submodule--helper relative-path qtpim/ \n00:28:32.488150 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.489140 git.c:415 trace: built-in: git submodule--helper update-clone --recursive-prefix qtpim/\n00:28:32.489344 run-command.c:1553 run_processes_parallel: preparing to run up to 1 tasks\n00:28:32.489352 run-command.c:1585 run_processes_parallel: done\n00:28:32.490484 git.c:415 trace: built-in: git submodule--helper name qtpurchasing\n00:28:32.491559 git.c:415 trace: built-in: git config submodule.qtpurchasing.update\n00:28:32.492429 git.c:415 trace: built-in: git submodule--helper relative-path qtpurchasing \n00:28:32.493215 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.493847 git.c:415 trace: built-in: git rev-parse --verify HEAD\n00:28:32.495112 git.c:415 trace: built-in: git rev-parse --git-common-dir\n00:28:32.496041 git.c:415 trace: built-in: git config -f .git/modules/qtpurchasing/config core.worktree\n00:28:32.496843 git.c:415 trace: built-in: git submodule--helper connect-gitdir-workingtree qtpurchasing qtpurchasing\nfatal: could not open 'qtpurchasing/.git' for writing: Is a directory\n00:28:32.497956 git.c:415 trace: built-in: git submodule--helper relative-path qtpurchasing/ \n00:28:32.498768 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.499883 git.c:415 trace: built-in: git submodule--helper update-clone --recursive-prefix qtpurchasing/\n00:28:32.500003 run-command.c:1553 run_processes_parallel: preparing to run up to 1 tasks\n00:28:32.500011 run-command.c:1585 run_processes_parallel: done\n00:28:32.501056 git.c:415 trace: built-in: git submodule--helper name qtqa\n00:28:32.502126 git.c:415 trace: built-in: git config submodule.qtqa.update\n00:28:32.502974 git.c:415 trace: built-in: git submodule--helper relative-path qtqa \n00:28:32.503773 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.504591 git.c:415 trace: built-in: git rev-parse --verify HEAD\n00:28:32.505645 git.c:415 trace: built-in: git rev-parse --git-common-dir\n00:28:32.506732 git.c:415 trace: built-in: git config -f .git/modules/qtqa/config core.worktree\n00:28:32.507875 git.c:415 trace: built-in: git submodule--helper connect-gitdir-workingtree qtqa qtqa\nfatal: could not open 'qtqa/.git' for writing: Is a directory\n00:28:32.509175 git.c:415 trace: built-in: git submodule--helper relative-path qtqa/ \n00:28:32.509985 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.510882 git.c:415 trace: built-in: git submodule--helper update-clone --recursive-prefix qtqa/\n00:28:32.511002 run-command.c:1553 run_processes_parallel: preparing to run up to 1 tasks\n00:28:32.511010 run-command.c:1585 run_processes_parallel: done\n00:28:32.512184 git.c:415 trace: built-in: git submodule--helper name qtquickcontrols\n00:28:32.513251 git.c:415 trace: built-in: git config submodule.qtquickcontrols.update\n00:28:32.514082 git.c:415 trace: built-in: git submodule--helper relative-path qtquickcontrols \n00:28:32.514961 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.515611 git.c:415 trace: built-in: git rev-parse --verify HEAD\n00:28:32.516612 git.c:415 trace: built-in: git rev-parse --git-common-dir\n00:28:32.517380 git.c:415 trace: built-in: git config -f .git/modules/qtquickcontrols/config core.worktree\n00:28:32.518168 git.c:415 trace: built-in: git submodule--helper connect-gitdir-workingtree qtquickcontrols qtquickcontrols\nfatal: could not open 'qtquickcontrols/.git' for writing: Is a directory\n00:28:32.519164 git.c:415 trace: built-in: git submodule--helper relative-path qtquickcontrols/ \n00:28:32.519987 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.521262 git.c:415 trace: built-in: git submodule--helper update-clone --recursive-prefix qtquickcontrols/\n00:28:32.521463 run-command.c:1553 run_processes_parallel: preparing to run up to 1 tasks\n00:28:32.521472 run-command.c:1585 run_processes_parallel: done\n00:28:32.522591 git.c:415 trace: built-in: git submodule--helper name qtquickcontrols2\n00:28:32.523636 git.c:415 trace: built-in: git config submodule.qtquickcontrols2.update\n00:28:32.524524 git.c:415 trace: built-in: git submodule--helper relative-path qtquickcontrols2 \n00:28:32.525398 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.526081 git.c:415 trace: built-in: git rev-parse --verify HEAD\n00:28:32.527044 git.c:415 trace: built-in: git rev-parse --git-common-dir\n00:28:32.527925 git.c:415 trace: built-in: git config -f .git/modules/qtquickcontrols2/config core.worktree\n00:28:32.528793 git.c:415 trace: built-in: git submodule--helper connect-gitdir-workingtree qtquickcontrols2 qtquickcontrols2\nfatal: could not open 'qtquickcontrols2/.git' for writing: Is a directory\n00:28:32.529877 git.c:415 trace: built-in: git submodule--helper relative-path qtquickcontrols2/ \n00:28:32.530626 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.531571 git.c:415 trace: built-in: git submodule--helper update-clone --recursive-prefix qtquickcontrols2/\n00:28:32.532079 run-command.c:1553 run_processes_parallel: preparing to run up to 1 tasks\n00:28:32.532090 run-command.c:1585 run_processes_parallel: done\n00:28:32.533173 git.c:415 trace: built-in: git submodule--helper name qtremoteobjects\n00:28:32.534263 git.c:415 trace: built-in: git config submodule.qtremoteobjects.update\n00:28:32.535105 git.c:415 trace: built-in: git submodule--helper relative-path qtremoteobjects \n00:28:32.536033 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.536725 git.c:415 trace: built-in: git rev-parse --verify HEAD\n00:28:32.537674 git.c:415 trace: built-in: git rev-parse --git-common-dir\n00:28:32.538553 git.c:415 trace: built-in: git config -f .git/modules/qtremoteobjects/config core.worktree\n00:28:32.539863 git.c:415 trace: built-in: git submodule--helper connect-gitdir-workingtree qtremoteobjects qtremoteobjects\n00:28:32.541153 git.c:415 trace: built-in: git submodule--helper relative-path qtremoteobjects/ \n00:28:32.541930 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.543141 git.c:415 trace: built-in: git submodule--helper update-clone --recursive-prefix qtremoteobjects/\n00:28:32.543315 run-command.c:1553 run_processes_parallel: preparing to run up to 1 tasks\n00:28:32.543323 run-command.c:1585 run_processes_parallel: done\n00:28:32.544545 git.c:415 trace: built-in: git submodule--helper name qtrepotools\n00:28:32.545673 git.c:415 trace: built-in: git config submodule.qtrepotools.update\n00:28:32.546525 git.c:415 trace: built-in: git submodule--helper relative-path qtrepotools \n00:28:32.547372 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.548026 git.c:415 trace: built-in: git rev-parse --verify HEAD\n00:28:32.548941 git.c:415 trace: built-in: git rev-parse --git-common-dir\n00:28:32.550163 git.c:415 trace: built-in: git config -f .git/modules/qtrepotools/config core.worktree\n00:28:32.551057 git.c:415 trace: built-in: git submodule--helper connect-gitdir-workingtree qtrepotools qtrepotools\nfatal: could not open 'qtrepotools/.git' for writing: Is a directory\n00:28:32.552245 git.c:415 trace: built-in: git submodule--helper relative-path qtrepotools/ \n00:28:32.552994 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.553990 git.c:415 trace: built-in: git submodule--helper update-clone --recursive-prefix qtrepotools/\n00:28:32.554068 run-command.c:1553 run_processes_parallel: preparing to run up to 1 tasks\n00:28:32.554078 run-command.c:1585 run_processes_parallel: done\n00:28:32.555115 git.c:415 trace: built-in: git submodule--helper name qtscript\n00:28:32.556249 git.c:415 trace: built-in: git config submodule.qtscript.update\n00:28:32.557242 git.c:415 trace: built-in: git submodule--helper relative-path qtscript \n00:28:32.558261 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.559396 git.c:415 trace: built-in: git rev-parse --verify HEAD\n00:28:32.560545 git.c:415 trace: built-in: git rev-parse --git-common-dir\n00:28:32.561380 git.c:415 trace: built-in: git config -f .git/modules/qtscript/config core.worktree\n00:28:32.562155 git.c:415 trace: built-in: git submodule--helper connect-gitdir-workingtree qtscript qtscript\nfatal: could not open 'qtscript/.git' for writing: Is a directory\n00:28:32.563124 git.c:415 trace: built-in: git submodule--helper relative-path qtscript/ \n00:28:32.563927 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.564905 git.c:415 trace: built-in: git submodule--helper update-clone --recursive-prefix qtscript/\n00:28:32.565221 run-command.c:1553 run_processes_parallel: preparing to run up to 1 tasks\n00:28:32.565231 run-command.c:1585 run_processes_parallel: done\n00:28:32.566411 git.c:415 trace: built-in: git submodule--helper name qtscxml\n00:28:32.567548 git.c:415 trace: built-in: git config submodule.qtscxml.update\n00:28:32.568436 git.c:415 trace: built-in: git submodule--helper relative-path qtscxml \n00:28:32.569265 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.569916 git.c:415 trace: built-in: git rev-parse --verify HEAD\n00:28:32.570831 git.c:415 trace: built-in: git rev-parse --git-common-dir\n00:28:32.571669 git.c:415 trace: built-in: git config -f .git/modules/qtscxml/config core.worktree\n00:28:32.572460 git.c:415 trace: built-in: git submodule--helper connect-gitdir-workingtree qtscxml qtscxml\nfatal: could not open 'qtscxml/.git' for writing: Is a directory\n00:28:32.573413 git.c:415 trace: built-in: git submodule--helper relative-path qtscxml/ \n00:28:32.574148 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.575136 git.c:415 trace: built-in: git submodule--helper update-clone --recursive-prefix qtscxml/\n00:28:32.575381 run-command.c:1553 run_processes_parallel: preparing to run up to 1 tasks\n00:28:32.575389 run-command.c:1585 run_processes_parallel: done\n00:28:32.576437 git.c:415 trace: built-in: git submodule--helper name qtsensors\n00:28:32.577525 git.c:415 trace: built-in: git config submodule.qtsensors.update\n00:28:32.578342 git.c:415 trace: built-in: git submodule--helper relative-path qtsensors \n00:28:32.579090 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.579769 git.c:415 trace: built-in: git rev-parse --verify HEAD\n00:28:32.580707 git.c:415 trace: built-in: git rev-parse --git-common-dir\n00:28:32.581594 git.c:415 trace: built-in: git config -f .git/modules/qtsensors/config core.worktree\n00:28:32.582376 git.c:415 trace: built-in: git submodule--helper connect-gitdir-workingtree qtsensors qtsensors\nfatal: could not open 'qtsensors/.git' for writing: Is a directory\n00:28:32.583481 git.c:415 trace: built-in: git submodule--helper relative-path qtsensors/ \n00:28:32.584231 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.585326 git.c:415 trace: built-in: git submodule--helper update-clone --recursive-prefix qtsensors/\n00:28:32.585508 run-command.c:1553 run_processes_parallel: preparing to run up to 1 tasks\n00:28:32.585534 run-command.c:1585 run_processes_parallel: done\n00:28:32.586897 git.c:415 trace: built-in: git submodule--helper name qtserialbus\n00:28:32.588337 git.c:415 trace: built-in: git config submodule.qtserialbus.update\n00:28:32.589209 git.c:415 trace: built-in: git submodule--helper relative-path qtserialbus \n00:28:32.590098 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.590756 git.c:415 trace: built-in: git rev-parse --verify HEAD\n00:28:32.591667 git.c:415 trace: built-in: git rev-parse --git-common-dir\n00:28:32.592607 git.c:415 trace: built-in: git config -f .git/modules/qtserialbus/config core.worktree\n00:28:32.593610 git.c:415 trace: built-in: git submodule--helper connect-gitdir-workingtree qtserialbus qtserialbus\nfatal: could not open 'qtserialbus/.git' for writing: Is a directory\n00:28:32.594737 git.c:415 trace: built-in: git submodule--helper relative-path qtserialbus/ \n00:28:32.595530 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.596573 git.c:415 trace: built-in: git submodule--helper update-clone --recursive-prefix qtserialbus/\n00:28:32.596704 run-command.c:1553 run_processes_parallel: preparing to run up to 1 tasks\n00:28:32.596713 run-command.c:1585 run_processes_parallel: done\n00:28:32.597783 git.c:415 trace: built-in: git submodule--helper name qtserialport\n00:28:32.598892 git.c:415 trace: built-in: git config submodule.qtserialport.update\n00:28:32.599733 git.c:415 trace: built-in: git submodule--helper relative-path qtserialport \n00:28:32.600596 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.601270 git.c:415 trace: built-in: git rev-parse --verify HEAD\n00:28:32.602151 git.c:415 trace: built-in: git rev-parse --git-common-dir\n00:28:32.603026 git.c:415 trace: built-in: git config -f .git/modules/qtserialport/config core.worktree\n00:28:32.603836 git.c:415 trace: built-in: git submodule--helper connect-gitdir-workingtree qtserialport qtserialport\nfatal: could not open 'qtserialport/.git' for writing: Is a directory\n00:28:32.604865 git.c:415 trace: built-in: git submodule--helper relative-path qtserialport/ \n00:28:32.605611 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.606636 git.c:415 trace: built-in: git submodule--helper update-clone --recursive-prefix qtserialport/\n00:28:32.606810 run-command.c:1553 run_processes_parallel: preparing to run up to 1 tasks\n00:28:32.606839 run-command.c:1585 run_processes_parallel: done\n00:28:32.608349 git.c:415 trace: built-in: git submodule--helper name qtspeech\n00:28:32.609706 git.c:415 trace: built-in: git config submodule.qtspeech.update\n00:28:32.610607 git.c:415 trace: built-in: git submodule--helper relative-path qtspeech \n00:28:32.611487 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.612204 git.c:415 trace: built-in: git rev-parse --verify HEAD\n00:28:32.613232 git.c:415 trace: built-in: git rev-parse --git-common-dir\n00:28:32.614108 git.c:415 trace: built-in: git config -f .git/modules/qtspeech/config core.worktree\n00:28:32.614933 git.c:415 trace: built-in: git submodule--helper connect-gitdir-workingtree qtspeech qtspeech\nfatal: could not open 'qtspeech/.git' for writing: Is a directory\n00:28:32.616036 git.c:415 trace: built-in: git submodule--helper relative-path qtspeech/ \n00:28:32.616776 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.617739 git.c:415 trace: built-in: git submodule--helper update-clone --recursive-prefix qtspeech/\n00:28:32.617837 run-command.c:1553 run_processes_parallel: preparing to run up to 1 tasks\n00:28:32.617848 run-command.c:1585 run_processes_parallel: done\n00:28:32.619008 git.c:415 trace: built-in: git submodule--helper name qtsvg\n00:28:32.620270 git.c:415 trace: built-in: git config submodule.qtsvg.update\n00:28:32.621128 git.c:415 trace: built-in: git submodule--helper relative-path qtsvg \n00:28:32.622013 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.622629 git.c:415 trace: built-in: git rev-parse --verify HEAD\n00:28:32.623561 git.c:415 trace: built-in: git rev-parse --git-common-dir\n00:28:32.624515 git.c:415 trace: built-in: git config -f .git/modules/qtsvg/config core.worktree\n00:28:32.625298 git.c:415 trace: built-in: git submodule--helper connect-gitdir-workingtree qtsvg qtsvg\nfatal: could not open 'qtsvg/.git' for writing: Is a directory\n00:28:32.626287 git.c:415 trace: built-in: git submodule--helper relative-path qtsvg/ \n00:28:32.627145 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.628338 git.c:415 trace: built-in: git submodule--helper update-clone --recursive-prefix qtsvg/\n00:28:32.628495 run-command.c:1553 run_processes_parallel: preparing to run up to 1 tasks\n00:28:32.628506 run-command.c:1585 run_processes_parallel: done\n00:28:32.629807 git.c:415 trace: built-in: git submodule--helper name qtsystems\n00:28:32.631235 git.c:415 trace: built-in: git config submodule.qtsystems.update\n00:28:32.632216 git.c:415 trace: built-in: git submodule--helper relative-path qtsystems \n00:28:32.633090 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.633793 git.c:415 trace: built-in: git rev-parse --verify HEAD\n00:28:32.634746 git.c:415 trace: built-in: git rev-parse --git-common-dir\n00:28:32.635733 git.c:415 trace: built-in: git config -f .git/modules/qtsystems/config core.worktree\n00:28:32.636868 git.c:415 trace: built-in: git submodule--helper connect-gitdir-workingtree qtsystems qtsystems\n00:28:32.638098 git.c:415 trace: built-in: git submodule--helper relative-path qtsystems/ \n00:28:32.638884 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.640013 git.c:415 trace: built-in: git submodule--helper update-clone --recursive-prefix qtsystems/\n00:28:32.640214 run-command.c:1553 run_processes_parallel: preparing to run up to 1 tasks\n00:28:32.640223 run-command.c:1585 run_processes_parallel: done\n00:28:32.641300 git.c:415 trace: built-in: git submodule--helper name qttools\n00:28:32.642395 git.c:415 trace: built-in: git config submodule.qttools.update\n00:28:32.643236 git.c:415 trace: built-in: git submodule--helper relative-path qttools \n00:28:32.644077 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.644769 git.c:415 trace: built-in: git rev-parse --verify HEAD\n00:28:32.645713 git.c:415 trace: built-in: git rev-parse --git-common-dir\n00:28:32.646548 git.c:415 trace: built-in: git config -f .git/modules/qttools/config core.worktree\n00:28:32.647334 git.c:415 trace: built-in: git submodule--helper connect-gitdir-workingtree qttools qttools\nfatal: could not open 'qttools/.git' for writing: Is a directory\n00:28:32.648349 git.c:415 trace: built-in: git submodule--helper relative-path qttools/ \n00:28:32.649095 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.650073 git.c:415 trace: built-in: git submodule--helper update-clone --recursive-prefix qttools/\n00:28:32.650421 run-command.c:1553 run_processes_parallel: preparing to run up to 1 tasks\n00:28:32.650430 run-command.c:1585 run_processes_parallel: done\n00:28:32.651506 git.c:415 trace: built-in: git submodule--helper name qttranslations\n00:28:32.652684 git.c:415 trace: built-in: git config submodule.qttranslations.update\n00:28:32.653475 git.c:415 trace: built-in: git submodule--helper relative-path qttranslations \n00:28:32.654350 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.654959 git.c:415 trace: built-in: git rev-parse --verify HEAD\n00:28:32.656013 git.c:415 trace: built-in: git rev-parse --git-common-dir\n00:28:32.656890 git.c:415 trace: built-in: git config -f .git/modules/qttranslations/config core.worktree\n00:28:32.657870 git.c:415 trace: built-in: git submodule--helper connect-gitdir-workingtree qttranslations qttranslations\nfatal: could not open 'qttranslations/.git' for writing: Is a directory\n00:28:32.659252 git.c:415 trace: built-in: git submodule--helper relative-path qttranslations/ \n00:28:32.660213 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.661187 git.c:415 trace: built-in: git submodule--helper update-clone --recursive-prefix qttranslations/\n00:28:32.661332 run-command.c:1553 run_processes_parallel: preparing to run up to 1 tasks\n00:28:32.661361 run-command.c:1585 run_processes_parallel: done\n00:28:32.662521 git.c:415 trace: built-in: git submodule--helper name qtvirtualkeyboard\n00:28:32.663699 git.c:415 trace: built-in: git config submodule.qtvirtualkeyboard.update\n00:28:32.664602 git.c:415 trace: built-in: git submodule--helper relative-path qtvirtualkeyboard \n00:28:32.665572 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.666259 git.c:415 trace: built-in: git rev-parse --verify HEAD\n00:28:32.667181 git.c:415 trace: built-in: git rev-parse --git-common-dir\n00:28:32.668119 git.c:415 trace: built-in: git config -f .git/modules/qtvirtualkeyboard/config core.worktree\n00:28:32.669040 git.c:415 trace: built-in: git submodule--helper connect-gitdir-workingtree qtvirtualkeyboard qtvirtualkeyboard\nfatal: could not open 'qtvirtualkeyboard/.git' for writing: Is a directory\n00:28:32.670111 git.c:415 trace: built-in: git submodule--helper relative-path qtvirtualkeyboard/ \n00:28:32.671037 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.672260 git.c:415 trace: built-in: git submodule--helper update-clone --recursive-prefix qtvirtualkeyboard/\n00:28:32.672510 run-command.c:1553 run_processes_parallel: preparing to run up to 1 tasks\n00:28:32.672522 run-command.c:1585 run_processes_parallel: done\n00:28:32.673824 git.c:415 trace: built-in: git submodule--helper name qtwayland\n00:28:32.675254 git.c:415 trace: built-in: git config submodule.qtwayland.update\n00:28:32.676254 git.c:415 trace: built-in: git submodule--helper relative-path qtwayland \n00:28:32.677149 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.677815 git.c:415 trace: built-in: git rev-parse --verify HEAD\n00:28:32.678705 git.c:415 trace: built-in: git rev-parse --git-common-dir\n00:28:32.679515 git.c:415 trace: built-in: git config -f .git/modules/qtwayland/config core.worktree\n00:28:32.680378 git.c:415 trace: built-in: git submodule--helper connect-gitdir-workingtree qtwayland qtwayland\nfatal: could not open 'qtwayland/.git' for writing: Is a directory\n00:28:32.681349 git.c:415 trace: built-in: git submodule--helper relative-path qtwayland/ \n00:28:32.682068 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.683020 git.c:415 trace: built-in: git submodule--helper update-clone --recursive-prefix qtwayland/\n00:28:32.683211 run-command.c:1553 run_processes_parallel: preparing to run up to 1 tasks\n00:28:32.683220 run-command.c:1585 run_processes_parallel: done\n00:28:32.684288 git.c:415 trace: built-in: git submodule--helper name qtwebchannel\n00:28:32.685365 git.c:415 trace: built-in: git config submodule.qtwebchannel.update\n00:28:32.686197 git.c:415 trace: built-in: git submodule--helper relative-path qtwebchannel \n00:28:32.687250 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.688053 git.c:415 trace: built-in: git rev-parse --verify HEAD\n00:28:32.689027 git.c:415 trace: built-in: git rev-parse --git-common-dir\n00:28:32.689828 git.c:415 trace: built-in: git config -f .git/modules/qtwebchannel/config core.worktree\n00:28:32.690649 git.c:415 trace: built-in: git submodule--helper connect-gitdir-workingtree qtwebchannel qtwebchannel\nfatal: could not open 'qtwebchannel/.git' for writing: Is a directory\n00:28:32.691673 git.c:415 trace: built-in: git submodule--helper relative-path qtwebchannel/ \n00:28:32.692395 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.693337 git.c:415 trace: built-in: git submodule--helper update-clone --recursive-prefix qtwebchannel/\n00:28:32.693440 run-command.c:1553 run_processes_parallel: preparing to run up to 1 tasks\n00:28:32.693450 run-command.c:1585 run_processes_parallel: done\n00:28:32.694513 git.c:415 trace: built-in: git submodule--helper name qtwebengine\n00:28:32.695558 git.c:415 trace: built-in: git config submodule.qtwebengine.update\n00:28:32.696394 git.c:415 trace: built-in: git submodule--helper relative-path qtwebengine \n00:28:32.697128 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.697813 git.c:415 trace: built-in: git rev-parse --verify HEAD\n00:28:32.698713 git.c:415 trace: built-in: git rev-parse --git-common-dir\n00:28:32.699550 git.c:415 trace: built-in: git config -f .git/modules/qtwebengine/config core.worktree\n00:28:32.700365 git.c:415 trace: built-in: git submodule--helper connect-gitdir-workingtree qtwebengine qtwebengine\nfatal: could not open 'qtwebengine/.git' for writing: Is a directory\n00:28:32.701368 git.c:415 trace: built-in: git submodule--helper relative-path qtwebengine/ \n00:28:32.702128 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.703122 git.c:415 trace: built-in: git submodule--helper update-clone --recursive-prefix qtwebengine/\n00:28:32.703383 run-command.c:1553 run_processes_parallel: preparing to run up to 1 tasks\n00:28:32.703414 run-command.c:1585 run_processes_parallel: done\n00:28:32.704307 git.c:415 trace: built-in: git submodule--helper name src/3rdparty\n00:28:32.705228 git.c:415 trace: built-in: git config submodule.src/3rdparty.update\n00:28:32.706067 git.c:415 trace: built-in: git submodule--helper relative-path qtwebengine/src/3rdparty \n00:28:32.707040 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.707919 git.c:415 trace: built-in: git rev-parse --verify HEAD\n00:28:32.709130 git.c:415 trace: built-in: git rev-parse --git-common-dir\n00:28:32.709996 git.c:415 trace: built-in: git config -f .git/modules/src/3rdparty/config core.worktree\n00:28:32.710800 git.c:415 trace: built-in: git submodule--helper connect-gitdir-workingtree src/3rdparty src/3rdparty\nfatal: could not open 'src/3rdparty/.git' for writing: Is a directory\n00:28:32.711881 git.c:415 trace: built-in: git submodule--helper relative-path qtwebengine/src/3rdparty/ \n00:28:32.712760 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.713700 git.c:415 trace: built-in: git submodule--helper update-clone --recursive-prefix qtwebengine/src/3rdparty/\n00:28:32.725343 run-command.c:1553 run_processes_parallel: preparing to run up to 1 tasks\n00:28:32.725361 run-command.c:1585 run_processes_parallel: done\n00:28:32.727259 git.c:415 trace: built-in: git submodule--helper name qtwebglplugin\n00:28:32.728403 git.c:415 trace: built-in: git config submodule.qtwebglplugin.update\n00:28:32.729247 git.c:415 trace: built-in: git submodule--helper relative-path qtwebglplugin \n00:28:32.730030 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.730647 git.c:415 trace: built-in: git rev-parse --verify HEAD\n00:28:32.731663 git.c:415 trace: built-in: git rev-parse --git-common-dir\n00:28:32.732627 git.c:415 trace: built-in: git config -f .git/modules/qtwebglplugin/config core.worktree\n00:28:32.733597 git.c:415 trace: built-in: git submodule--helper connect-gitdir-workingtree qtwebglplugin qtwebglplugin\n00:28:32.734749 git.c:415 trace: built-in: git submodule--helper relative-path qtwebglplugin/ \n00:28:32.735528 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.736522 git.c:415 trace: built-in: git submodule--helper update-clone --recursive-prefix qtwebglplugin/\n00:28:32.736647 run-command.c:1553 run_processes_parallel: preparing to run up to 1 tasks\n00:28:32.736675 run-command.c:1585 run_processes_parallel: done\n00:28:32.737777 git.c:415 trace: built-in: git submodule--helper name qtwebsockets\n00:28:32.738846 git.c:415 trace: built-in: git config submodule.qtwebsockets.update\n00:28:32.739635 git.c:415 trace: built-in: git submodule--helper relative-path qtwebsockets \n00:28:32.740495 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.741177 git.c:415 trace: built-in: git rev-parse --verify HEAD\n00:28:32.742182 git.c:415 trace: built-in: git rev-parse --git-common-dir\n00:28:32.742995 git.c:415 trace: built-in: git config -f .git/modules/qtwebsockets/config core.worktree\n00:28:32.743886 git.c:415 trace: built-in: git submodule--helper connect-gitdir-workingtree qtwebsockets qtwebsockets\nfatal: could not open 'qtwebsockets/.git' for writing: Is a directory\n00:28:32.744957 git.c:415 trace: built-in: git submodule--helper relative-path qtwebsockets/ \n00:28:32.745717 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.746692 git.c:415 trace: built-in: git submodule--helper update-clone --recursive-prefix qtwebsockets/\n00:28:32.746840 run-command.c:1553 run_processes_parallel: preparing to run up to 1 tasks\n00:28:32.746866 run-command.c:1585 run_processes_parallel: done\n00:28:32.748007 git.c:415 trace: built-in: git submodule--helper name qtwebview\n00:28:32.749097 git.c:415 trace: built-in: git config submodule.qtwebview.update\n00:28:32.749954 git.c:415 trace: built-in: git submodule--helper relative-path qtwebview \n00:28:32.750826 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.751483 git.c:415 trace: built-in: git rev-parse --verify HEAD\n00:28:32.752413 git.c:415 trace: built-in: git rev-parse --git-common-dir\n00:28:32.753361 git.c:415 trace: built-in: git config -f .git/modules/qtwebview/config core.worktree\n00:28:32.754127 git.c:415 trace: built-in: git submodule--helper connect-gitdir-workingtree qtwebview qtwebview\nfatal: could not open 'qtwebview/.git' for writing: Is a directory\n00:28:32.755139 git.c:415 trace: built-in: git submodule--helper relative-path qtwebview/ \n00:28:32.755984 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.757138 git.c:415 trace: built-in: git submodule--helper update-clone --recursive-prefix qtwebview/\n00:28:32.757282 run-command.c:1553 run_processes_parallel: preparing to run up to 1 tasks\n00:28:32.757296 run-command.c:1585 run_processes_parallel: done\n00:28:32.758804 git.c:415 trace: built-in: git submodule--helper name qtwinextras\n00:28:32.760424 git.c:415 trace: built-in: git config submodule.qtwinextras.update\n00:28:32.761271 git.c:415 trace: built-in: git submodule--helper relative-path qtwinextras \n00:28:32.762207 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.762894 git.c:415 trace: built-in: git rev-parse --verify HEAD\n00:28:32.763791 git.c:415 trace: built-in: git rev-parse --git-common-dir\n00:28:32.764976 git.c:415 trace: built-in: git config -f .git/modules/qtwinextras/config core.worktree\n00:28:32.765725 git.c:415 trace: built-in: git submodule--helper connect-gitdir-workingtree qtwinextras qtwinextras\nfatal: could not open 'qtwinextras/.git' for writing: Is a directory\n00:28:32.766885 git.c:415 trace: built-in: git submodule--helper relative-path qtwinextras/ \n00:28:32.767774 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.768941 git.c:415 trace: built-in: git submodule--helper update-clone --recursive-prefix qtwinextras/\n00:28:32.769102 run-command.c:1553 run_processes_parallel: preparing to run up to 1 tasks\n00:28:32.769131 run-command.c:1585 run_processes_parallel: done\n00:28:32.770438 git.c:415 trace: built-in: git submodule--helper name qtx11extras\n00:28:32.771952 git.c:415 trace: built-in: git config submodule.qtx11extras.update\n00:28:32.772819 git.c:415 trace: built-in: git submodule--helper relative-path qtx11extras \n00:28:32.773589 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.774251 git.c:415 trace: built-in: git rev-parse --verify HEAD\n00:28:32.775162 git.c:415 trace: built-in: git rev-parse --git-common-dir\n00:28:32.776071 git.c:415 trace: built-in: git config -f .git/modules/qtx11extras/config core.worktree\n00:28:32.776842 git.c:415 trace: built-in: git submodule--helper connect-gitdir-workingtree qtx11extras qtx11extras\nfatal: could not open 'qtx11extras/.git' for writing: Is a directory\n00:28:32.777843 git.c:415 trace: built-in: git submodule--helper relative-path qtx11extras/ \n00:28:32.778635 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.779692 git.c:415 trace: built-in: git submodule--helper update-clone --recursive-prefix qtx11extras/\n00:28:32.779869 run-command.c:1553 run_processes_parallel: preparing to run up to 1 tasks\n00:28:32.779879 run-command.c:1585 run_processes_parallel: done\n00:28:32.780894 git.c:415 trace: built-in: git submodule--helper name qtxmlpatterns\n00:28:32.781947 git.c:415 trace: built-in: git config submodule.qtxmlpatterns.update\n00:28:32.782800 git.c:415 trace: built-in: git submodule--helper relative-path qtxmlpatterns\n00:28:32.784034 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.784739 git.c:415 trace: built-in: git rev-parse --verify HEAD\n00:28:32.785617 git.c:415 trace: built-in: git rev-parse --git-common-dir\n00:28:32.786458 git.c:415 trace: built-in: git config -f .git/modules/qtxmlpatterns/config core.worktree\n00:28:32.787263 git.c:415 trace: built-in: git submodule--helper connect-gitdir-workingtree qtxmlpatterns qtxmlpatterns\nfatal: could not open 'qtxmlpatterns/.git' for writing: Is a directory\n00:28:32.788317 git.c:415 trace: built-in: git submodule--helper relative-path qtxmlpatterns/\n00:28:32.789011 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.789985 git.c:415 trace: built-in: git submodule--helper update-clone --recursive-prefix qtxmlpatterns/\n00:28:32.790227 run-command.c:1553 run_processes_parallel: preparing to run up to 1 tasks\n00:28:32.790256 run-command.c:1585 run_processes_parallel: done\n00:28:32.791071 git.c:415 trace: built-in: git submodule--helper name tests/auto/3rdparty/testsuites\n00:28:32.792081 git.c:415 trace: built-in: git config submodule.testsuites.update\n00:28:32.792875 git.c:415 trace: built-in: git submodule--helper relative-path qtxmlpatterns/tests/auto/3rdparty/testsuites\n00:28:32.793713 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.794363 git.c:415 trace: built-in: git rev-parse --verify HEAD\n00:28:32.795249 git.c:415 trace: built-in: git rev-parse --git-common-dir\n00:28:32.796074 git.c:415 trace: built-in: git config -f .git/modules/testsuites/config core.worktree\n00:28:32.796861 git.c:415 trace: built-in: git submodule--helper connect-gitdir-workingtree testsuites tests/auto/3rdparty/testsuites\nfatal: could not open 'tests/auto/3rdparty/testsuites/.git' for writing: Is a directory\n00:28:32.798041 git.c:415 trace: built-in: git submodule--helper relative-path qtxmlpatterns/tests/auto/3rdparty/testsuites/\n00:28:32.798785 git.c:415 trace: built-in: git rev-parse --local-env-vars\n00:28:32.799766 git.c:415 trace: built-in: git submodule--helper update-clone --recursive-prefix qtxmlpatterns/tests/auto/3rdparty/testsuites/\n00:28:32.805569 run-command.c:1553 run_processes_parallel: preparing to run up to 1 tasks\n00:28:32.805586 run-command.c:1585 run_processes_parallel: done\n"},{"id":"357666","messageId":"CAGZ79kZvuGEPOSTUqT+y6nxs6W5qaP-BbHT_WQQE7+n=RVNsrw@mail.gmail.com","threadId":"49297","inReplyTo":"20180907223515.GD103699@aiede.svl.corp.google.com","subject":"Re: Old submodules broken in 2.19rc1 and 2.19rc2","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2018-09-07T22:45:25Z","receivedAt":"2018-09-07T22:45:38Z","isPatch":false,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":" I think we\n> should revert e98317508c0 in \"master\" (for 2.19) and keep making use\n> of that 'second try' in \"next\" (for 2.20).\n\nActually I'd rather revert the whole topic leading up to\n7e25437d35a (Merge branch 'sb/submodule-core-worktree', 2018-07-18)\nas the last patch in there doesn't work well without e98317508c0 IIRC.\n\nAnd having only the first patch would bring an inconsistent state as\nthen different commands behave differently w.r.t. setting core.worktree.\n\nSo for this release we'd\n\n git revert 984cd77ddbf0 e98317508c 4fa4f90ccd85\n\nand then can\n\n git cherry-pick 4fa4f90ccd8 984cd77ddbf0\n\non top of sb/submodule-update-in-c, as that re-instates the behavior\ngoing forward.\n\nThoughts?\n\nThanks,\nStefan\n"},{"id":"357671","messageId":"20180908000946.GA225427@aiede.svl.corp.google.com","threadId":"49297","inReplyTo":"CAGZ79kZvuGEPOSTUqT+y6nxs6W5qaP-BbHT_WQQE7+n=RVNsrw@mail.gmail.com","subject":"[PATCH] Revert \"Merge branch 'sb/submodule-core-worktree'\" (was Re: Old submodules broken in 2.19rc1 and 2.19rc2)","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2018-09-08T00:09:46Z","receivedAt":"2018-09-08T00:09:51Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Subject: Revert \"Merge branch 'sb/submodule-core-worktree'\"\n\nThis reverts commit 7e25437d35a70791b345872af202eabfb3e1a8bc, reversing\nchanges made to 00624d608cc69bd62801c93e74d1ea7a7ddd6598.\n\nv2.19.0-rc0~165^2~1 (submodule: ensure core.worktree is set after\nupdate, 2018-06-18) assumes an \"absorbed\" submodule layout, where the\nsubmodule's Git directory is in the superproject's .git/modules/\ndirectory and .git in the submodule worktree is a .git file pointing\nthere. In particular, it uses $GIT_DIR/modules/$name to find the\nsubmodule to find out whether it already has core.worktree set, and it\nuses connect_work_tree_and_git_dir if not, resulting in\n\n\tfatal: could not open sub/.git for writing\n\nThe context behind that patch: v2.19.0-rc0~165^2~2 (submodule: unset\ncore.worktree if no working tree is present, 2018-06-12) unsets\ncore.worktree when running commands like \"git checkout\n--recurse-submodules\" to switch to a branch without the submodule. If\na user then uses \"git checkout --no-recurse-submodules\" to switch back\nto a branch with the submodule and runs \"git submodule update\", this\npatch is needed to ensure that commands using the submodule directly\nare aware of the path to the worktree.\n\nIt is late in the release cycle, so revert the whole 3-patch series.\nWe can try again later for 2.20.\n\nReported-by: Allan Sandfeld Jensen \nHelped-by: Stefan Beller \nSigned-off-by: Jonathan Nieder \n---\nStefan Beller wrote:\n> Jonathan Nieder wrote:\n\n>> I think we\n>> should revert e98317508c0 in \"master\" (for 2.19) and keep making use\n>> of that 'second try' in \"next\" (for 2.20).\n>\n> Actually I'd rather revert the whole topic leading up to\n> 7e25437d35a (Merge branch 'sb/submodule-core-worktree', 2018-07-18)\n> as the last patch in there doesn't work well without e98317508c0 IIRC.\n>\n> And having only the first patch would bring an inconsistent state as\n> then different commands behave differently w.r.t. setting core.worktree.\n\nLike this (generated using \"git revert -m1)?\n\n builtin/submodule--helper.c | 26 --------------------------\n git-submodule.sh | 5 -----\n submodule.c | 14 --------------\n submodule.h | 2 --\n t/lib-submodule-update.sh | 5 ++---\n t/t7400-submodule-basic.sh | 5 -----\n 6 files changed, 2 insertions(+), 55 deletions(-)\n\ndiff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c\nindex b56028ba9d..f6fb8991f3 100644\n--- a/builtin/submodule--helper.c\n+++ b/builtin/submodule--helper.c\n@@ -1123,8 +1123,6 @@ static void deinit_submodule(const char *path, const char *prefix,\n \t\tif (!(flags & OPT_QUIET))\n \t\t\tprintf(format, displaypath);\n \n-\t\tsubmodule_unset_core_worktree(sub);\n-\n \t\tstrbuf_release(&sb_rm);\n \t}\n \n@@ -2005,29 +2003,6 @@ static int check_name(int argc, const char **argv, const char *prefix)\n \treturn 0;\n }\n \n-static int connect_gitdir_workingtree(int argc, const char **argv, const char *prefix)\n-{\n-\tstruct strbuf sb = STRBUF_INIT;\n-\tconst char *name, *path;\n-\tchar *sm_gitdir;\n-\n-\tif (argc != 3)\n-\t\tBUG(\"submodule--helper connect-gitdir-workingtree \");\n-\n-\tname = argv[1];\n-\tpath = argv[2];\n-\n-\tstrbuf_addf(&sb, \"%s/modules/%s\", get_git_dir(), name);\n-\tsm_gitdir = absolute_pathdup(sb.buf);\n-\n-\tconnect_work_tree_and_git_dir(path, sm_gitdir, 0);\n-\n-\tstrbuf_release(&sb);\n-\tfree(sm_gitdir);\n-\n-\treturn 0;\n-}\n-\n #define SUPPORT_SUPER_PREFIX (1<<0)\n \n struct cmd_struct {\n@@ -2041,7 +2016,6 @@ static struct cmd_struct commands[] = {\n \t{\"name\", module_name, 0},\n \t{\"clone\", module_clone, 0},\n \t{\"update-clone\", update_clone, 0},\n-\t{\"connect-gitdir-workingtree\", connect_gitdir_workingtree, 0},\n \t{\"relative-path\", resolve_relative_path, 0},\n \t{\"resolve-relative-url\", resolve_relative_url, 0},\n \t{\"resolve-relative-url-test\", resolve_relative_url_test, 0},\ndiff --git a/git-submodule.sh b/git-submodule.sh\nindex f7fd80345c..1cb2c0a31b 100755\n--- a/git-submodule.sh\n+++ b/git-submodule.sh\n@@ -580,11 +580,6 @@ cmd_update()\n \t\t\tdie \"$(eval_gettext \"Unable to find current \\${remote_name}/\\${branch} revision in submodule path '\\$sm_path'\")\"\n \t\tfi\n \n-\t\tif ! $(git config -f \"$(git rev-parse --git-common-dir)/modules/$name/config\" core.worktree) 2>/dev/null\n-\t\tthen\n-\t\t\tgit submodule--helper connect-gitdir-workingtree \"$name\" \"$sm_path\"\n-\t\tfi\n-\n \t\tif test \"$subsha1\" != \"$sha1\" || test -n \"$force\"\n \t\tthen\n \t\t\tsubforce=$force\ndiff --git a/submodule.c b/submodule.c\nindex 50cbf5f13e..a2b266fbfa 100644\n--- a/submodule.c\n+++ b/submodule.c\n@@ -1534,18 +1534,6 @@ int bad_to_remove_submodule(const char *path, unsigned flags)\n \treturn ret;\n }\n \n-void submodule_unset_core_worktree(const struct submodule *sub)\n-{\n-\tchar *config_path = xstrfmt(\"%s/modules/%s/config\",\n-\t\t\t\t get_git_common_dir(), sub->name);\n-\n-\tif (git_config_set_in_file_gently(config_path, \"core.worktree\", NULL))\n-\t\twarning(_(\"Could not unset core.worktree setting in submodule '%s'\"),\n-\t\t\t sub->path);\n-\n-\tfree(config_path);\n-}\n-\n static const char *get_super_prefix_or_empty(void)\n {\n \tconst char *s = get_super_prefix();\n@@ -1711,8 +1699,6 @@ int submodule_move_head(const char *path,\n \n \t\t\tif (is_empty_dir(path))\n \t\t\t\trmdir_or_warn(path);\n-\n-\t\t\tsubmodule_unset_core_worktree(sub);\n \t\t}\n \t}\n out:\ndiff --git a/submodule.h b/submodule.h\nindex 7d476cefa7..e452919aa4 100644\n--- a/submodule.h\n+++ b/submodule.h\n@@ -127,8 +127,6 @@ int submodule_move_head(const char *path,\n \t\t\tconst char *new_head,\n \t\t\tunsigned flags);\n \n-void submodule_unset_core_worktree(const struct submodule *sub);\n-\n /*\n * Prepare the \"env_array\" parameter of a \"struct child_process\" for executing\n * a submodule by clearing any repo-specific environment variables, but\ndiff --git a/t/lib-submodule-update.sh b/t/lib-submodule-update.sh\nindex 5b56b23166..016391723c 100755\n--- a/t/lib-submodule-update.sh\n+++ b/t/lib-submodule-update.sh\n@@ -235,7 +235,7 @@ reset_work_tree_to_interested () {\n \tthen\n \t\tmkdir -p submodule_update/.git/modules/sub1/modules &&\n \t\tcp -r submodule_update_repo/.git/modules/sub1/modules/sub2 submodule_update/.git/modules/sub1/modules/sub2\n-\t\t# core.worktree is unset for sub2 as it is not checked out\n+\t\tGIT_WORK_TREE=. git -C submodule_update/.git/modules/sub1/modules/sub2 config --unset core.worktree\n \tfi &&\n \t# indicate we are interested in the submodule:\n \tgit -C submodule_update config submodule.sub1.url \"bogus\" &&\n@@ -709,8 +709,7 @@ test_submodule_recursing_with_args_common() {\n \t\t\tgit branch -t remove_sub1 origin/remove_sub1 &&\n \t\t\t$command remove_sub1 &&\n \t\t\ttest_superproject_content origin/remove_sub1 &&\n-\t\t\t! test -e sub1 &&\n-\t\t\ttest_must_fail git config -f .git/modules/sub1/config core.worktree\n+\t\t\t! test -e sub1\n \t\t)\n \t'\n \t# ... absorbing a .git directory along the way.\ndiff --git a/t/t7400-submodule-basic.sh b/t/t7400-submodule-basic.sh\nindex 7d3d984210..c0ffc1022a 100755\n--- a/t/t7400-submodule-basic.sh\n+++ b/t/t7400-submodule-basic.sh\n@@ -984,11 +984,6 @@ test_expect_success 'submodule deinit should remove the whole submodule section\n \trmdir init\n '\n \n-test_expect_success 'submodule deinit should unset core.worktree' '\n-\ttest_path_is_file .git/modules/example/config &&\n-\ttest_must_fail git config -f .git/modules/example/config core.worktree\n-'\n-\n test_expect_success 'submodule deinit from subdirectory' '\n \tgit submodule update --init &&\n \tgit config submodule.example.foo bar &&\n-- \n2.19.0.rc2.392.g5ba43deb5a\n\n"},{"id":"357674","messageId":"xmqqmussvj72.fsf@gitster-ct.c.googlers.com","threadId":"49297","inReplyTo":"20180908000946.GA225427@aiede.svl.corp.google.com","subject":"Re: [PATCH] Revert \"Merge branch 'sb/submodule-core-worktree'\" (was Re: Old submodules broken in 2.19rc1 and 2.19rc2)","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2018-09-08T02:04:01Z","receivedAt":"2018-09-08T02:06:23Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jonathan Nieder writes:\n\n> It is late in the release cycle, so revert the whole 3-patch series.\n> We can try again later for 2.20.\n>\n> Reported-by: Allan Sandfeld Jensen \n> Helped-by: Stefan Beller \n> Signed-off-by: Jonathan Nieder \n> ---\n> Stefan Beller wrote:\n>> Jonathan Nieder wrote:\n>\n>>> I think we\n>>> should revert e98317508c0 in \"master\" (for 2.19) and keep making use\n>>> of that 'second try' in \"next\" (for 2.20).\n>>\n>> Actually I'd rather revert the whole topic leading up to\n>> 7e25437d35a (Merge branch 'sb/submodule-core-worktree', 2018-07-18)\n>> as the last patch in there doesn't work well without e98317508c0 IIRC.\n>>\n>> And having only the first patch would bring an inconsistent state as\n>> then different commands behave differently w.r.t. setting core.worktree.\n>\n> Like this (generated using \"git revert -m1)?\n\nOK. Thanks for taking care of it.\n\n>\n> builtin/submodule--helper.c | 26 --------------------------\n> git-submodule.sh | 5 -----\n> submodule.c | 14 --------------\n> submodule.h | 2 --\n> t/lib-submodule-update.sh | 5 ++---\n> t/t7400-submodule-basic.sh | 5 -----\n> 6 files changed, 2 insertions(+), 55 deletions(-)\n>\n> diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c\n> index b56028ba9d..f6fb8991f3 100644\n> --- a/builtin/submodule--helper.c\n> +++ b/builtin/submodule--helper.c\n> @@ -1123,8 +1123,6 @@ static void deinit_submodule(const char *path, const char *prefix,\n> \t\tif (!(flags & OPT_QUIET))\n> \t\t\tprintf(format, displaypath);\n> \n> -\t\tsubmodule_unset_core_worktree(sub);\n> -\n> \t\tstrbuf_release(&sb_rm);\n> \t}\n> \n> @@ -2005,29 +2003,6 @@ static int check_name(int argc, const char **argv, const char *prefix)\n> \treturn 0;\n> }\n> \n> -static int connect_gitdir_workingtree(int argc, const char **argv, const char *prefix)\n> -{\n> -\tstruct strbuf sb = STRBUF_INIT;\n> -\tconst char *name, *path;\n> -\tchar *sm_gitdir;\n> -\n> -\tif (argc != 3)\n> -\t\tBUG(\"submodule--helper connect-gitdir-workingtree \");\n> -\n> -\tname = argv[1];\n> -\tpath = argv[2];\n> -\n> -\tstrbuf_addf(&sb, \"%s/modules/%s\", get_git_dir(), name);\n> -\tsm_gitdir = absolute_pathdup(sb.buf);\n> -\n> -\tconnect_work_tree_and_git_dir(path, sm_gitdir, 0);\n> -\n> -\tstrbuf_release(&sb);\n> -\tfree(sm_gitdir);\n> -\n> -\treturn 0;\n> -}\n> -\n> #define SUPPORT_SUPER_PREFIX (1<<0)\n> \n> struct cmd_struct {\n> @@ -2041,7 +2016,6 @@ static struct cmd_struct commands[] = {\n> \t{\"name\", module_name, 0},\n> \t{\"clone\", module_clone, 0},\n> \t{\"update-clone\", update_clone, 0},\n> -\t{\"connect-gitdir-workingtree\", connect_gitdir_workingtree, 0},\n> \t{\"relative-path\", resolve_relative_path, 0},\n> \t{\"resolve-relative-url\", resolve_relative_url, 0},\n> \t{\"resolve-relative-url-test\", resolve_relative_url_test, 0},\n> diff --git a/git-submodule.sh b/git-submodule.sh\n> index f7fd80345c..1cb2c0a31b 100755\n> --- a/git-submodule.sh\n> +++ b/git-submodule.sh\n> @@ -580,11 +580,6 @@ cmd_update()\n> \t\t\tdie \"$(eval_gettext \"Unable to find current \\${remote_name}/\\${branch} revision in submodule path '\\$sm_path'\")\"\n> \t\tfi\n> \n> -\t\tif ! $(git config -f \"$(git rev-parse --git-common-dir)/modules/$name/config\" core.worktree) 2>/dev/null\n> -\t\tthen\n> -\t\t\tgit submodule--helper connect-gitdir-workingtree \"$name\" \"$sm_path\"\n> -\t\tfi\n> -\n> \t\tif test \"$subsha1\" != \"$sha1\" || test -n \"$force\"\n> \t\tthen\n> \t\t\tsubforce=$force\n> diff --git a/submodule.c b/submodule.c\n> index 50cbf5f13e..a2b266fbfa 100644\n> --- a/submodule.c\n> +++ b/submodule.c\n> @@ -1534,18 +1534,6 @@ int bad_to_remove_submodule(const char *path, unsigned flags)\n> \treturn ret;\n> }\n> \n> -void submodule_unset_core_worktree(const struct submodule *sub)\n> -{\n> -\tchar *config_path = xstrfmt(\"%s/modules/%s/config\",\n> -\t\t\t\t get_git_common_dir(), sub->name);\n> -\n> -\tif (git_config_set_in_file_gently(config_path, \"core.worktree\", NULL))\n> -\t\twarning(_(\"Could not unset core.worktree setting in submodule '%s'\"),\n> -\t\t\t sub->path);\n> -\n> -\tfree(config_path);\n> -}\n> -\n> static const char *get_super_prefix_or_empty(void)\n> {\n> \tconst char *s = get_super_prefix();\n> @@ -1711,8 +1699,6 @@ int submodule_move_head(const char *path,\n> \n> \t\t\tif (is_empty_dir(path))\n> \t\t\t\trmdir_or_warn(path);\n> -\n> -\t\t\tsubmodule_unset_core_worktree(sub);\n> \t\t}\n> \t}\n> out:\n> diff --git a/submodule.h b/submodule.h\n> index 7d476cefa7..e452919aa4 100644\n> --- a/submodule.h\n> +++ b/submodule.h\n> @@ -127,8 +127,6 @@ int submodule_move_head(const char *path,\n> \t\t\tconst char *new_head,\n> \t\t\tunsigned flags);\n> \n> -void submodule_unset_core_worktree(const struct submodule *sub);\n> -\n> /*\n> * Prepare the \"env_array\" parameter of a \"struct child_process\" for executing\n> * a submodule by clearing any repo-specific environment variables, but\n> diff --git a/t/lib-submodule-update.sh b/t/lib-submodule-update.sh\n> index 5b56b23166..016391723c 100755\n> --- a/t/lib-submodule-update.sh\n> +++ b/t/lib-submodule-update.sh\n> @@ -235,7 +235,7 @@ reset_work_tree_to_interested () {\n> \tthen\n> \t\tmkdir -p submodule_update/.git/modules/sub1/modules &&\n> \t\tcp -r submodule_update_repo/.git/modules/sub1/modules/sub2 submodule_update/.git/modules/sub1/modules/sub2\n> -\t\t# core.worktree is unset for sub2 as it is not checked out\n> +\t\tGIT_WORK_TREE=. git -C submodule_update/.git/modules/sub1/modules/sub2 config --unset core.worktree\n> \tfi &&\n> \t# indicate we are interested in the submodule:\n> \tgit -C submodule_update config submodule.sub1.url \"bogus\" &&\n> @@ -709,8 +709,7 @@ test_submodule_recursing_with_args_common() {\n> \t\t\tgit branch -t remove_sub1 origin/remove_sub1 &&\n> \t\t\t$command remove_sub1 &&\n> \t\t\ttest_superproject_content origin/remove_sub1 &&\n> -\t\t\t! test -e sub1 &&\n> -\t\t\ttest_must_fail git config -f .git/modules/sub1/config core.worktree\n> +\t\t\t! test -e sub1\n> \t\t)\n> \t'\n> \t# ... absorbing a .git directory along the way.\n> diff --git a/t/t7400-submodule-basic.sh b/t/t7400-submodule-basic.sh\n> index 7d3d984210..c0ffc1022a 100755\n> --- a/t/t7400-submodule-basic.sh\n> +++ b/t/t7400-submodule-basic.sh\n> @@ -984,11 +984,6 @@ test_expect_success 'submodule deinit should remove the whole submodule section\n> \trmdir init\n> '\n> \n> -test_expect_success 'submodule deinit should unset core.worktree' '\n> -\ttest_path_is_file .git/modules/example/config &&\n> -\ttest_must_fail git config -f .git/modules/example/config core.worktree\n> -'\n> -\n> test_expect_success 'submodule deinit from subdirectory' '\n> \tgit submodule update --init &&\n> \tgit config submodule.example.foo bar &&\n"},{"id":"357707","messageId":"deeaa4d5-3982-b47a-d2da-501d52fa38e1@kdbg.org","threadId":"49297","inReplyTo":"xmqqmussvj72.fsf@gitster-ct.c.googlers.com","subject":"Re: [PATCH] Revert \"Merge branch 'sb/submodule-core-worktree'\" (was Re: Old submodules broken in 2.19rc1 and 2.19rc2)","fromName":"Johannes Sixt","fromEmail":"j6t@kdbg.org","sentAt":"2018-09-08T18:39:43Z","receivedAt":"2018-09-08T18:44:30Z","isPatch":true,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"Am 08.09.2018 um 04:04 schrieb Junio C Hamano:\n> Jonathan Nieder writes:\n> \n>> It is late in the release cycle, so revert the whole 3-patch series.\n>> We can try again later for 2.20.\n>>\n>> Reported-by: Allan Sandfeld Jensen \n>> Helped-by: Stefan Beller \n>> Signed-off-by: Jonathan Nieder \n>> ---\n>> Stefan Beller wrote:\n>>> Jonathan Nieder wrote:\n>>\n>>>> I think we\n>>>> should revert e98317508c0 in \"master\" (for 2.19) and keep making use\n>>>> of that 'second try' in \"next\" (for 2.20).\n>>>\n>>> Actually I'd rather revert the whole topic leading up to\n>>> 7e25437d35a (Merge branch 'sb/submodule-core-worktree', 2018-07-18)\n>>> as the last patch in there doesn't work well without e98317508c0 IIRC.\n>>>\n>>> And having only the first patch would bring an inconsistent state as\n>>> then different commands behave differently w.r.t. setting core.worktree.\n>>\n>> Like this (generated using \"git revert -m1)?\n> \n> OK. Thanks for taking care of it.\n\nPlease don't forget to remove the corresponding release notes entry.\n\ndiff --git a/Documentation/RelNotes/2.19.0.txt b/Documentation/RelNotes/2.19.0.txt\nindex bcbfbc2041..834454ffb9 100644\n--- a/Documentation/RelNotes/2.19.0.txt\n+++ b/Documentation/RelNotes/2.19.0.txt\n@@ -296,12 +296,6 @@ Fixes since v2.18\n to the submodule was changed in the range of commits in the\n superproject, sometimes showing \"(null)\". This has been corrected.\n \n- * \"git submodule\" did not correctly adjust core.worktree setting that\n- indicates whether/where a submodule repository has its associated\n- working tree across various state transitions, which has been\n- corrected.\n- (merge 984cd77ddb sb/submodule-core-worktree later to maint).\n-\n * Bugfix for \"rebase -i\" corner case regression.\n (merge a9279c6785 pw/rebase-i-keep-reword-after-conflict later to maint).\n \n"},{"id":"357803","messageId":"CAGZ79kac0g_zqxW69PVSi+t59O2bOrcJELHOTt7NVWxVbR88iw@mail.gmail.com","threadId":"49297","inReplyTo":"deeaa4d5-3982-b47a-d2da-501d52fa38e1@kdbg.org","subject":"Re: [PATCH] Revert \"Merge branch 'sb/submodule-core-worktree'\" (was Re: Old submodules broken in 2.19rc1 and 2.19rc2)","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2018-09-10T17:11:08Z","receivedAt":"2018-09-10T17:11:22Z","isPatch":true,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"> >> Like this (generated using \"git revert -m1)?\n> >\n> > OK. Thanks for taking care of it.\n\nYes that looks good to me, thanks!\n\n>\n> Please don't forget to remove the corresponding release notes entry.\n\nMakes sense, too.\n\nThanks,\nStefan\n"},{"id":"357900","messageId":"xmqqsh2folvr.fsf@gitster-ct.c.googlers.com","threadId":"49297","inReplyTo":"deeaa4d5-3982-b47a-d2da-501d52fa38e1@kdbg.org","subject":"Re: [PATCH] Revert \"Merge branch 'sb/submodule-core-worktree'\" (was Re: Old submodules broken in 2.19rc1 and 2.19rc2)","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2018-09-11T19:49:12Z","receivedAt":"2018-09-11T19:49:17Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Johannes Sixt writes:\n\n>>> Like this (generated using \"git revert -m1)?\n>> \n>> OK. Thanks for taking care of it.\n>\n> Please don't forget to remove the corresponding release notes entry.\n\nThanks for a reminder. Very much appreciated.\n"}]}