{"thread":{"id":"49132","subject":"[PATCH 0/1] Fix make -C t chainlint with DOS line endings","startedAt":"2018-08-15T14:33:46Z","lastAt":"2018-08-15T16:32:29Z","messageCount":4,"participants":["Johannes Schindelin via GitGitGadget","Junio C Hamano","Eric Sunshine"],"isPatch":true,"patchVersion":1,"patchTotal":1},"messages":[{"id":"355687","messageId":"pull.19.git.gitgitgadget@gmail.com","threadId":"49132","inReplyTo":null,"subject":"[PATCH 0/1] Fix make -C t chainlint with DOS line endings","fromName":"Johannes Schindelin via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2018-08-15T14:33:43Z","receivedAt":"2018-08-15T14:33:46Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Historically, nobody paid attention to our own source code having correct\nGit attributes\n[https://www.edwardthomson.com/blog/git_for_windows_line_endings.html] when\nit comes to line endings. Because historically, we had no good way to\nspecify that ;-)\n\nBut now we do, and so we need to use it. Especially when it would break the\nbuild otherwise.\n\nJohannes Schindelin (1):\n chainlint: fix for core.autocrlf=true\n\n t/.gitattributes | 1 +\n 1 file changed, 1 insertion(+)\n\n\nbase-commit: 1d89318c48d233d52f1db230cf622935ac3c69fa\nPublished-As: https://github.com/gitgitgadget/git/releases/tags/pr-19%2Fdscho%2Ffix-chainlint-on-windows-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-19/dscho/fix-chainlint-on-windows-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/19\n-- \ngitgitgadget\n"},{"id":"355688","messageId":"d0d1d49d6f3e741e9c048041a2f467742bce4bdc.1534343621.git.gitgitgadget@gmail.com","threadId":"49132","inReplyTo":"pull.19.git.gitgitgadget@gmail.com","subject":"[PATCH 1/1] chainlint: fix for core.autocrlf=true","fromName":"Johannes Schindelin via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2018-08-15T14:33:44Z","receivedAt":"2018-08-15T14:33:47Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"From: Johannes Schindelin \n\nThe `chainlint` target compares actual output to expected output, where\nthe actual output is generated from files that are specifically checked\nout with LF-only line endings. So the expected output needs to be\nchecked out with LF-only line endings, too.\n\nSigned-off-by: Johannes Schindelin \n---\n t/.gitattributes | 1 +\n 1 file changed, 1 insertion(+)\n\ndiff --git a/t/.gitattributes b/t/.gitattributes\nindex 3bd959ae5..9d09df5a6 100644\n--- a/t/.gitattributes\n+++ b/t/.gitattributes\n@@ -1,4 +1,5 @@\n t[0-9][0-9][0-9][0-9]/* -whitespace\n+/chainlint/*.expect eol=lf\n /diff-lib/* eol=lf\n /t0110/url-* binary\n /t3900/*.txt eol=lf\n-- \ngitgitgadget\n"},{"id":"355700","messageId":"xmqqmutnk2vv.fsf@gitster-ct.c.googlers.com","threadId":"49132","inReplyTo":"d0d1d49d6f3e741e9c048041a2f467742bce4bdc.1534343621.git.gitgitgadget@gmail.com","subject":"Re: [PATCH 1/1] chainlint: fix for core.autocrlf=true","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2018-08-15T16:31:32Z","receivedAt":"2018-08-15T16:31:36Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Johannes Schindelin via GitGitGadget\" \nwrites:\n\n> From: Johannes Schindelin \n>\n> The `chainlint` target compares actual output to expected output, where\n> the actual output is generated from files that are specifically checked\n> out with LF-only line endings. So the expected output needs to be\n> checked out with LF-only line endings, too.\n>\n> Signed-off-by: Johannes Schindelin \n> ---\n> t/.gitattributes | 1 +\n> 1 file changed, 1 insertion(+)\n\nGood spotting. A help like this from those on different platforms\nthan what the original author uses is the ideal model of how we\ncollaborate together.\n\nWill queue.\n\n>\n> diff --git a/t/.gitattributes b/t/.gitattributes\n> index 3bd959ae5..9d09df5a6 100644\n> --- a/t/.gitattributes\n> +++ b/t/.gitattributes\n> @@ -1,4 +1,5 @@\n> t[0-9][0-9][0-9][0-9]/* -whitespace\n> +/chainlint/*.expect eol=lf\n> /diff-lib/* eol=lf\n> /t0110/url-* binary\n> /t3900/*.txt eol=lf\n"},{"id":"355701","messageId":"CAPig+cQkHiKDUhMJEdOewnEHTiTvdULwhZGd_h_94W0+zzGb0Q@mail.gmail.com","threadId":"49132","inReplyTo":"d0d1d49d6f3e741e9c048041a2f467742bce4bdc.1534343621.git.gitgitgadget@gmail.com","subject":"Re: [PATCH 1/1] chainlint: fix for core.autocrlf=true","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2018-08-15T16:32:16Z","receivedAt":"2018-08-15T16:32:29Z","isPatch":true,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Wed, Aug 15, 2018 at 10:33 AM Johannes Schindelin via GitGitGadget\n wrote:\n> The `chainlint` target compares actual output to expected output, where\n> the actual output is generated from files that are specifically checked\n> out with LF-only line endings. So the expected output needs to be\n> checked out with LF-only line endings, too.\n>\n> Signed-off-by: Johannes Schindelin \n> ---\n> diff --git a/t/.gitattributes b/t/.gitattributes\n> @@ -1,4 +1,5 @@\n> +/chainlint/*.expect eol=lf\n\nMake sense. I did touch t/.gitignore for the chainlint series but\nnever thought to examine t/.gitattributes (and wasn't necessarily\naware of its existence). Had I looked inside .gitattributes, perhaps I\nwould have intuited the need for this change. Thanks for handling it.\n"}]}