{"thread":{"id":"49076","subject":"[GSoC] [PATCH 0/1] default to builtin rebase","startedAt":"2018-08-08T15:53:31Z","lastAt":"2018-08-08T15:53:36Z","messageCount":2,"participants":["Pratik Karki"],"isPatch":true,"patchVersion":1,"patchTotal":1},"messages":[{"id":"354852","messageId":"20180808155302.23814-1-predatoramigo@gmail.com","threadId":"49076","inReplyTo":null,"subject":"[GSoC] [PATCH 0/1] default to builtin rebase","fromName":"Pratik Karki","fromEmail":"predatoramigo@gmail.com","sentAt":"2018-08-08T15:53:01Z","receivedAt":"2018-08-08T15:53:31Z","isPatch":true,"sender":{"key":"predatoramigo@gmail.com","avatar":"https://avatars.githubusercontent.com/u/12194950?v=4"},"body":"Since, all the conversion of shell script version of `git rebase` is done\nas can be seen from the previous patch series, now we can default to the\nbuiltin one. The builtin rebase can now handle every task done by the\noriginal shell script `git rebase`. So, in this patch series, we turn the\nbuiltin rebase `on` so that the rebase operations can be handled it by it.\n\nThis patch series is the continuation of\n(https://public-inbox.org/git/20180808153635.19944-1-predatoramigo@gmail.com/).\n\nThis is the sixth and final patch series for a builtin \"git rebase\".\n\nIf you like to view the development branch, you can view\n(https://github.com/git/git/pull/505), where I have kept my commits up to date\nand leveraged Travis(there is sporadic failures in t5520 for macos gcc and\nisn't due to my patches) for extra testing other than my system.\n\nThese patch series are built on top of each other, i.e. they depend on this\norder.\n\nPratik Karki (1):\n  rebase: default to using the builtin rebase\n\n builtin/rebase.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\n-- \n2.18.0\n"},{"id":"354853","messageId":"20180808155302.23814-2-predatoramigo@gmail.com","threadId":"49076","inReplyTo":"20180808155302.23814-1-predatoramigo@gmail.com","subject":"[PATCH 1/1] rebase: default to using the builtin rebase","fromName":"Pratik Karki","fromEmail":"predatoramigo@gmail.com","sentAt":"2018-08-08T15:53:02Z","receivedAt":"2018-08-08T15:53:36Z","isPatch":true,"sender":{"key":"predatoramigo@gmail.com","avatar":"https://avatars.githubusercontent.com/u/12194950?v=4"},"body":"Now that the builtin rebase is feature-complete, we should use it by\ndefault. Let's keep the legacy scripted version around for the time\nbeing; Once the builtin rebase is well-tested enough, we can remove\n`git-legacy-rebase.sh`.\n\nSigned-off-by: Pratik Karki <predatoramigo@gmail.com>\n---\n builtin/rebase.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/builtin/rebase.c b/builtin/rebase.c\nindex 4e69458161..c8d632b6f4 100644\n--- a/builtin/rebase.c\n+++ b/builtin/rebase.c\n@@ -54,7 +54,7 @@ static int use_builtin_rebase(void)\n \tcp.git_cmd = 1;\n \tif (capture_command(&cp, &out, 6)) {\n \t\tstrbuf_release(&out);\n-\t\treturn 0;\n+\t\treturn 1;\n \t}\n \n \tstrbuf_trim(&out);\n-- \n2.18.0\n\n"}]}