{"thread":{"id":"49048","subject":"[PATCH] Makefile: add missing dependency for command-list.h","startedAt":"2018-08-06T16:34:29Z","lastAt":"2018-08-06T16:34:29Z","messageCount":1,"participants":["Nguyễn Thái Ngọc Duy"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"354639","messageId":"20180806163421.30636-1-pclouds@gmail.com","threadId":"49048","inReplyTo":null,"subject":"[PATCH] Makefile: add missing dependency for command-list.h","fromName":"Nguyễn Thái Ngọc Duy","fromEmail":"pclouds@gmail.com","sentAt":"2018-08-06T16:34:21Z","receivedAt":"2018-08-06T16:34:29Z","isPatch":true,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"Commit 3ac68a93fd (help: add --config to list all available config -\n2018-05-26) makes generate-cmdlist.sh adds a new input source\nconfig.txt but it's not a Makefile dependency. Any changes in\nconfig.txt will not trigger command-list.h regeneration and the config\nlist in this file becomes outdated. Correct the dependency.\n\nSigned-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>\n---\n Makefile | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Makefile b/Makefile\nindex bc4fc8eeab..47ca56d0e2 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -2037,7 +2037,7 @@ $(BUILT_INS): git$X\n \n command-list.h: generate-cmdlist.sh command-list.txt\n \n-command-list.h: $(wildcard Documentation/git*.txt)\n+command-list.h: $(wildcard Documentation/git*.txt) Documentation/config.txt\n \t$(QUIET_GEN)$(SHELL_PATH) ./generate-cmdlist.sh command-list.txt >$@+ && mv $@+ $@\n \n SCRIPT_DEFINES = $(SHELL_PATH_SQ):$(DIFF_SQ):$(GIT_VERSION):\\\n-- \n2.18.0.901.gd528ad0b1c.dirty\n\n"}]}