{"thread":{"id":"48991","subject":"First test of t5552 fails on Windows","startedAt":"2018-07-31T16:33:56Z","lastAt":"2018-07-31T16:33:56Z","messageCount":1,"participants":["Johannes Sixt"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"354057","messageId":"a91ec8ac-a9f3-ba87-f675-5196f859c2dc@kdbg.org","threadId":"48991","inReplyTo":null,"subject":"First test of t5552 fails on Windows","fromName":"Johannes Sixt","fromEmail":"j6t@kdbg.org","sentAt":"2018-07-31T16:33:50Z","receivedAt":"2018-07-31T16:33:56Z","isPatch":false,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"I'm testing origin/next on Windows with a few other topics on top.\n\nThe first test fails like this. Do you see what is wrong?\nWhere should I start looking? Is it perhaps that upload-pack\nis responding too soon so that fetch does not send 'have c1'?\n\n---- this is the console output\n...(truncated)...\n++ git -C client config fetch.negotiationalgorithm skipping\n+++ pwd\n+++ builtin pwd -W\n+++ pwd\n+++ builtin pwd -W\n++ GIT_TRACE_PACKET='D:/Src/mingw-git/t/trash directory.t5552-skipping-fetch-negotiator/trace'\n++ git -C client fetch 'D:/Src/mingw-git/t/trash directory.t5552-skipping-fetch-negotiator/server'\nwarning: no common commits\nremote: Enumerating objects: 3, done.\nremote: Counting objects: 100% (3/3), done.\nremote: Total 3 (delta 0), reused 0 (delta 0)\nUnpacking objects: 100% (3/3), done.\nFrom D:/Src/mingw-git/t/trash directory.t5552-skipping-fetch-negotiator/server\n * branch            HEAD       -> FETCH_HEAD\n++ have_sent c7 c5 c2 c1\n++ test 4 -ne 0\n+++ git -C client rev-parse c7\n++ grep 'fetch> have 9b13844ba1d52a28bb9487107b41cce9916b74c9' trace\npacket:        fetch> have 9b13844ba1d52a28bb9487107b41cce9916b74c9\n++ test 0 -ne 0\n++ shift\n++ test 3 -ne 0\n+++ git -C client rev-parse c5\n++ grep 'fetch> have 0abab022ac7e07f16265106cf36faf7cb5d87ab3' trace\npacket:        fetch> have 0abab022ac7e07f16265106cf36faf7cb5d87ab3\n++ test 0 -ne 0\n++ shift\n++ test 2 -ne 0\n+++ git -C client rev-parse c2\n++ grep 'fetch> have 0d7e994c092abbb0a21e7d243114efa5ba452b8c' trace\npacket:        fetch> have 0d7e994c092abbb0a21e7d243114efa5ba452b8c\n++ test 0 -ne 0\n++ shift\n++ test 1 -ne 0\n+++ git -C client rev-parse c1\n++ grep 'fetch> have 9e22a6c1b441ee1bcd54b8da801261ba8b15eac9' trace\n++ test 1 -ne 0\n+++ git -C client rev-parse c1\n++ echo 'No have 9e22a6c1b441ee1bcd54b8da801261ba8b15eac9 (c1)'\nNo have 9e22a6c1b441ee1bcd54b8da801261ba8b15eac9 (c1)\n++ return 1\nerror: last command exited with $?=1\nnot ok 1 - commits with no parents are sent regardless of skip distance\n#\n#               git init server &&\n#               test_commit -C server to_fetch &&\n#\n#               git init client &&\n#               for i in $(seq 7)\n#               do\n#                       test_commit -C client c$i\n#               done &&\n#\n#               # We send: \"c7\" (skip 1) \"c5\" (skip 2) \"c2\" (skip 4). After that, since\n#               # \"c1\" has no parent, it is still sent as \"have\" even though it would\n#               # normally be skipped.\n#               test_config -C client fetch.negotiationalgorithm skipping &&\n#               GIT_TRACE_PACKET=\"$(pwd)/trace\" git -C client fetch \"$(pwd)/server\" &&\n#               have_sent c7 c5 c2 c1 &&\n#               have_not_sent c6 c4 c3\n#\n\n---- trace file\n\npacket:  upload-pack> 92dc17da106e837e66a07e4815c474bf4fe99dce HEAD\\0multi_ack thin-pack side-band side-band-64k ofs-delta shallow deepen-since deepen-not deepen-relative no-progress include-tag multi_ack_detailed symref=HEAD:refs/heads/master agent=git/2.18.0.721.g75e0872d82\npacket:        fetch< 92dc17da106e837e66a07e4815c474bf4fe99dce HEAD\\0multi_ack thin-pack side-band side-band-64k ofs-delta shallow deepen-since deepen-not deepen-relative no-progress include-tag multi_ack_detailed symref=HEAD:refs/heads/master agent=git/2.18.0.721.g75e0872d82\npacket:  upload-pack> 92dc17da106e837e66a07e4815c474bf4fe99dce refs/heads/master\npacket:  upload-pack> 92dc17da106e837e66a07e4815c474bf4fe99dce refs/tags/to_fetch\npacket:        fetch< 92dc17da106e837e66a07e4815c474bf4fe99dce refs/heads/master\npacket:  upload-pack> 0000\n7da106e837e66a07e4815c474bf4fe99dce refs/tags/to_fetch\npacket:        fetch< 0000\npacket:        fetch> want 92dc17da106e837e66a07e4815c474bf4fe99dce multi_ack_detailed side-band-64k thin-pack ofs-delta deepen-since deepen-not agent=git/2.18.0.721.g75e0872d82\npacket:        fetch> 0000\npacket:        fetch> have 9b13844ba1d52a28bb9487107b41cce9916b74c9\npacket:        fetch> have 0abab022ac7e07f16265106cf36faf7cb5d87ab3\npacket:        fetch> have 0d7e994c092abbb0a21e7d243114efa5ba452b8c\npacket:  upload-pack< want 92dc17da106e837e66a07e4815c474bf4fe99dce multi_ack_detailed side-band-64k thin-pack ofs-delta deepen-since deepen-not agent=git/2.18.0.721.g75e0872d82\npacket:        fetch> done\npacket:  upload-pack< 0000\npacket:  upload-pack< have 9b13844ba1d52a28bb9487107b41cce9916b74c9\npacket:  upload-pack< have 0abab022ac7e07f16265106cf36faf7cb5d87ab3\npacket:  upload-pack< have 0d7e994c092abbb0a21e7d243114efa5ba452b8c\npacket:  upload-pack< have 9e22a6c1b441ee1bcd54b8da801261ba8b15eac9\npacket:  upload-pack< done\npacket:  upload-pack> NAK\npacket:        fetch< NAK\npacket:     sideband< \\2Enumerating objects: 3, done.Counting objects:  33% (1/3)   \\15Counting objects:  66% (2/3)   \\15Counting objects: 100% (3/3)   \\15Co\npacket:     sideband< \\2unting objects: 100% (3/3), done.Total 3 (delta 0), reused 0 (delta 0)\npacket:     sideband< PACK ...\npacket:  upload-pack> 0000\npacket:     sideband< 0000\n\n"}]}