{"thread":{"id":"48988","subject":"[PATCH] t/chainlint.sed: drop extra spaces from regex character class","startedAt":"2018-07-31T05:03:57Z","lastAt":"2018-07-31T05:03:57Z","messageCount":1,"participants":["Eric Sunshine"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"353995","messageId":"20180731050320.29530-1-sunshine@sunshineco.com","threadId":"48988","inReplyTo":null,"subject":"[PATCH] t/chainlint.sed: drop extra spaces from regex character class","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2018-07-31T05:03:20Z","receivedAt":"2018-07-31T05:03:57Z","isPatch":true,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"This character class, like many others in this script, matches\nhorizontal whitespace consisting of spaces and tabs, however, a few\nextra, entirely harmless, spaces somehow slipped into the expression.\nRemoving them is purely a cosmetic fix.\n\nWhile at it, re-indent three lines with a single TAB each which were\nincorrectly indented with six spaces. Also, a purely cosmetic fix.\n\nSigned-off-by: Eric Sunshine <sunshine@sunshineco.com>\n---\n\nJust something I noticed while examining t/chainlint.sed after reading\nJonathan's report[1] of a false-positive.\n\nThis is atop 'es/chain-lint-in-subshell' in 'next'.\n\n[1]: https://public-inbox.org/git/20180730181356.GA156463@aiede.svl.corp.google.com/\n\n t/chainlint.sed | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/t/chainlint.sed b/t/chainlint.sed\nindex a0de8a3882..5f0882cb38 100644\n--- a/t/chainlint.sed\n+++ b/t/chainlint.sed\n@@ -71,9 +71,9 @@\n # incomplete line -- slurp up next line\n :squash\n /\\\\$/ {\n-      N\n-      s/\\\\\\n//\n-      bsquash\n+\tN\n+\ts/\\\\\\n//\n+\tbsquash\n }\n \n # here-doc -- swallow it to avoid false hits within its body (but keep the\n@@ -199,7 +199,7 @@ s/.*\\n//\n # \"$(...)\" -- command substitution; not closing \")\"\n /\\$([^)][^)]*)[^)]*$/bcheckchain\n # multi-line \"$(...\\n...)\" -- command substitution; treat as nested subshell\n-/\\$([ \t     ]*$/bnest\n+/\\$([ \t]*$/bnest\n # \"=(...)\" -- Bash array assignment; not closing \")\"\n /=(/bcheckchain\n # closing \"...) &&\"\n-- \n2.18.0.597.ga71716f1ad\n\n"}]}