{"thread":{"id":"48984","subject":"[PATCH] mw-to-git/t9360: fix broken &&-chain","startedAt":"2018-07-30T20:47:10Z","lastAt":"2018-08-21T19:29:12Z","messageCount":6,"participants":["Eric Sunshine","Jonathan Nieder","Matthieu Moy","Antoine Beaupré"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"353953","messageId":"20180730204646.32312-1-sunshine@sunshineco.com","threadId":"48984","inReplyTo":"https://public-inbox.org/git/20180730190612.GB156463@aiede.svl.corp.google.com/","subject":"[PATCH] mw-to-git/t9360: fix broken &&-chain","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2018-07-30T20:46:46Z","receivedAt":"2018-07-30T20:47:10Z","isPatch":true,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"Signed-off-by: Eric Sunshine \n---\n\nJonathan's discovery[1] of a broken &&-chain in a contrib/subtree test\nprompted me to check other tests bundled in contrib/. This was the\nonly other problem found. Unlike the subtree &&-chain case, this\nbreakage is at the top-level, thus was caught by the normal\n--chain-lint mechanism, not the subshell linter.\n\n[1]: https://public-inbox.org/git/20180730190612.GB156463@aiede.svl.corp.google.\ncom/\n\n contrib/mw-to-git/t/t9360-mw-to-git-clone.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/contrib/mw-to-git/t/t9360-mw-to-git-clone.sh b/contrib/mw-to-git/t/t9360-mw-to-git-clone.sh\nindex 22f069db48..cfbfe7ddf6 100755\n--- a/contrib/mw-to-git/t/t9360-mw-to-git-clone.sh\n+++ b/contrib/mw-to-git/t/t9360-mw-to-git-clone.sh\n@@ -247,7 +247,7 @@ test_expect_success 'Test of resistance to modification of category on wiki for\n \twiki_editpage Notconsidered \"this page will not appear on local\" false &&\n \twiki_editpage Othercategory \"this page will not appear on local\" false -c=Cattwo &&\n \twiki_editpage Tobeedited \"this page have been modified\" true -c=Catone &&\n-\twiki_delete_page Tobedeleted\n+\twiki_delete_page Tobedeleted &&\n \tgit clone -c remote.origin.categories=\"Catone\" \\\n \t\tmediawiki::'\"$WIKI_URL\"' mw_dir_14 &&\n \twiki_getallpage ref_page_14 Catone &&\n-- \n2.18.0.597.ga71716f1ad\n\n"},{"id":"353961","messageId":"20180730210438.GF156463@aiede.svl.corp.google.com","threadId":"48984","inReplyTo":"20180730204646.32312-1-sunshine@sunshineco.com","subject":"Re: [PATCH] mw-to-git/t9360: fix broken &&-chain","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2018-07-30T21:04:38Z","receivedAt":"2018-07-30T21:04:42Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"(+cc: some folks interested in git-remote-mediawiki)\nHi,\n\nEric Sunshine wrote:\n\n> Signed-off-by: Eric Sunshine \n> ---\n> Jonathan's discovery[1] of a broken &&-chain in a contrib/subtree test\n> prompted me to check other tests bundled in contrib/. This was the\n> only other problem found. Unlike the subtree &&-chain case, this\n> breakage is at the top-level, thus was caught by the normal\n> --chain-lint mechanism, not the subshell linter.\n>\n> [1]: https://public-inbox.org/git/20180730190612.GB156463@aiede.svl.corp.google.\n> com/\n\nA small detail from there would be useful to have in the commit\nmessage: namely that this was detected using --chain-lint (and what\ncommand I can run to reproduce it myself).\n\nWith or without such a tweak to the commit message,\n\nReviewed-by: Jonathan Nieder \n\nThanks.\n\n> contrib/mw-to-git/t/t9360-mw-to-git-clone.sh | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/contrib/mw-to-git/t/t9360-mw-to-git-clone.sh b/contrib/mw-to-git/t/t9360-mw-to-git-clone.sh\n> index 22f069db48..cfbfe7ddf6 100755\n> --- a/contrib/mw-to-git/t/t9360-mw-to-git-clone.sh\n> +++ b/contrib/mw-to-git/t/t9360-mw-to-git-clone.sh\n> @@ -247,7 +247,7 @@ test_expect_success 'Test of resistance to modification of category on wiki for\n> \twiki_editpage Notconsidered \"this page will not appear on local\" false &&\n> \twiki_editpage Othercategory \"this page will not appear on local\" false -c=Cattwo &&\n> \twiki_editpage Tobeedited \"this page have been modified\" true -c=Catone &&\n> -\twiki_delete_page Tobedeleted\n> +\twiki_delete_page Tobedeleted &&\n> \tgit clone -c remote.origin.categories=\"Catone\" \\\n> \t\tmediawiki::'\"$WIKI_URL\"' mw_dir_14 &&\n> \twiki_getallpage ref_page_14 Catone &&\n> -- \n> 2.18.0.597.ga71716f1ad\n> \n"},{"id":"354860","messageId":"1760070169.15343864.1533744622227.JavaMail.zimbra@inria.fr","threadId":"48984","inReplyTo":"9a96cf8f5254446fa244e4107cef4f3c@BPMBX2013-01.univ-lyon1.fr","subject":"Re: [PATCH] mw-to-git/t9360: fix broken &&-chain","fromName":"Matthieu Moy","fromEmail":"git@matthieu-moy.fr","sentAt":"2018-08-08T16:10:22Z","receivedAt":"2018-08-08T16:10:32Z","isPatch":true,"sender":{"key":"git@matthieu-moy.fr","avatar":"https://avatars.githubusercontent.com/u/14709?v=4"},"body":"\"jrnieder\" wrote:\n\n> (+cc: some folks interested in git-remote-mediawiki)\n\nThanks.\n\nIn case it still matters, an obvious Acked-by: Matthieu Moy \n\n-- \nMatthieu Moy\n"},{"id":"356183","messageId":"87zhxf5z38.fsf@curie.anarc.at","threadId":"48984","inReplyTo":"1760070169.15343864.1533744622227.JavaMail.zimbra@inria.fr","subject":"Re: [PATCH] mw-to-git/t9360: fix broken &&-chain","fromName":"Antoine Beaupré","fromEmail":"anarcat@debian.org","sentAt":"2018-08-21T18:55:23Z","receivedAt":"2018-08-21T19:01:10Z","isPatch":true,"sender":{"key":"anarcat@debian.org","avatar":"https://avatars.githubusercontent.com/u/796623?v=4"},"body":"On 2018-08-08 18:10:22, Matthieu Moy wrote:\n> \"jrnieder\" wrote:\n>\n>> (+cc: some folks interested in git-remote-mediawiki)\n>\n> Thanks.\n>\n> In case it still matters, an obvious Acked-by: Matthieu Moy \n\nHi,\n\nI seem to have lost context of the original email, and can't find a copy\non public-inbox.org... Is there a patch we should merge back into\ngit-mediawiki already?\n\nThanks!\n\nA.\n\n-- \nYour injured body has become the burden of your digital soul.\n - Yin Aiwen, 2013, The Massage is the Medium\n"},{"id":"356193","messageId":"CAPig+cQVhacEuMmKbB2VMkrga900a97pENRZZbDJ2KUHx3n7gA@mail.gmail.com","threadId":"48984","inReplyTo":"87zhxf5z38.fsf@curie.anarc.at","subject":"Re: [PATCH] mw-to-git/t9360: fix broken &&-chain","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2018-08-21T19:22:43Z","receivedAt":"2018-08-21T19:22:58Z","isPatch":true,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Tue, Aug 21, 2018 at 2:55 PM Antoine Beaupré wrote:\n> On 2018-08-08 18:10:22, Matthieu Moy wrote:\n> > \"jrnieder\" wrote:\n> >> (+cc: some folks interested in git-remote-mediawiki)\n> >\n> > In case it still matters, an obvious Acked-by: Matthieu Moy \n>\n> I seem to have lost context of the original email, and can't find a copy\n> on public-inbox.org... Is there a patch we should merge back into\n> git-mediawiki already?\n\nThe patch is here[1].\n\n[1]: https://public-inbox.org/git/20180730204646.32312-1-sunshine@sunshineco.com/\n"},{"id":"356195","messageId":"87r2ir5xiy.fsf@curie.anarc.at","threadId":"48984","inReplyTo":"CAPig+cQVhacEuMmKbB2VMkrga900a97pENRZZbDJ2KUHx3n7gA@mail.gmail.com","subject":"Re: [PATCH] mw-to-git/t9360: fix broken &&-chain","fromName":"Antoine Beaupré","fromEmail":"anarcat@debian.org","sentAt":"2018-08-21T19:29:09Z","receivedAt":"2018-08-21T19:29:12Z","isPatch":true,"sender":{"key":"anarcat@debian.org","avatar":"https://avatars.githubusercontent.com/u/796623?v=4"},"body":"On 2018-08-21 15:22:43, Eric Sunshine wrote:\n> On Tue, Aug 21, 2018 at 2:55 PM Antoine Beaupré wrote:\n>> On 2018-08-08 18:10:22, Matthieu Moy wrote:\n>> > \"jrnieder\" wrote:\n>> >> (+cc: some folks interested in git-remote-mediawiki)\n>> >\n>> > In case it still matters, an obvious Acked-by: Matthieu Moy \n>>\n>> I seem to have lost context of the original email, and can't find a copy\n>> on public-inbox.org... Is there a patch we should merge back into\n>> git-mediawiki already?\n>\n> The patch is here[1].\n>\n> [1]: https://public-inbox.org/git/20180730204646.32312-1-sunshine@sunshineco.com/\n\nThanks, so\n\nAcked-by: Antoine Beaupré \n\nFWIW. :)\n\nA.\n\n-- \nThe history of any one part of the earth, like the life of a soldier,\nconsists of long periods of boredom and short periods of terror.\n - British geologist Derek V. Ager\n"}]}