{"thread":{"id":"48975","subject":"[PATCH] builtin.h: remove declaration of cmd_rebase__helper","startedAt":"2018-07-29T22:44:55Z","lastAt":"2018-07-30T22:12:11Z","messageCount":2,"participants":["Ramsay Jones","Alban Gruin"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"353850","messageId":"36bfb2da-f163-67b9-4ddd-398ce137f85f@ramsayjones.plus.com","threadId":"48975","inReplyTo":null,"subject":"[PATCH] builtin.h: remove declaration of cmd_rebase__helper","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2018-07-29T22:44:50Z","receivedAt":"2018-07-29T22:44:55Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nCommit 94d4e2fb88 (\"rebase -i: move rebase--helper modes to\nrebase--interactive\", 2018-07-24) removed the definition of the\n'cmd_rebase__helper' symbol, but forgot to remove the corresponding\ndeclaration in the 'builtin.h' header file.\n\nSigned-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n---\n\nHi Alban,\n\nIf you need to re-roll your 'ag/rebase-i-in-c' branch, could you\nplease squash this into the relevant patch (commit 94d4e2fb88).\n\nThanks!\n\nATB,\nRamsay Jones\n\n builtin.h | 1 -\n 1 file changed, 1 deletion(-)\n\ndiff --git a/builtin.h b/builtin.h\nindex aac8f5f340..6538932e99 100644\n--- a/builtin.h\n+++ b/builtin.h\n@@ -206,7 +206,6 @@ extern int cmd_range_diff(int argc, const char **argv, const char *prefix);\n extern int cmd_read_tree(int argc, const char **argv, const char *prefix);\n extern int cmd_rebase(int argc, const char **argv, const char *prefix);\n extern int cmd_rebase__interactive(int argc, const char **argv, const char *prefix);\n-extern int cmd_rebase__helper(int argc, const char **argv, const char *prefix);\n extern int cmd_receive_pack(int argc, const char **argv, const char *prefix);\n extern int cmd_reflog(int argc, const char **argv, const char *prefix);\n extern int cmd_remote(int argc, const char **argv, const char *prefix);\n-- \n2.18.0\n"},{"id":"353968","messageId":"dce8c99b-51e9-4ed1-8ae4-28049cb6e7ec@gmail.com","threadId":"48975","inReplyTo":"36bfb2da-f163-67b9-4ddd-398ce137f85f@ramsayjones.plus.com","subject":"Re: [PATCH] builtin.h: remove declaration of cmd_rebase__helper","fromName":"Alban Gruin","fromEmail":"alban.gruin@gmail.com","sentAt":"2018-07-30T22:12:07Z","receivedAt":"2018-07-30T22:12:11Z","isPatch":true,"sender":{"key":"alban.gruin@gmail.com","avatar":"https://avatars.githubusercontent.com/u/6310153?v=4"},"body":"Hi Ramsay,\n\nLe 30/07/2018 à 00:44, Ramsay Jones a écrit :\n> \n> Commit 94d4e2fb88 (\"rebase -i: move rebase--helper modes to\n> rebase--interactive\", 2018-07-24) removed the definition of the\n> 'cmd_rebase__helper' symbol, but forgot to remove the corresponding\n> declaration in the 'builtin.h' header file.\n> \n> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n> ---\n> \n> Hi Alban,\n> \n> If you need to re-roll your 'ag/rebase-i-in-c' branch, could you\n> please squash this into the relevant patch (commit 94d4e2fb88).\n> \n> Thanks!\n> \n> ATB,\n> Ramsay Jones\n> \n>  builtin.h | 1 -\n>  1 file changed, 1 deletion(-)\n> \n> diff --git a/builtin.h b/builtin.h\n> index aac8f5f340..6538932e99 100644\n> --- a/builtin.h\n> +++ b/builtin.h\n> @@ -206,7 +206,6 @@ extern int cmd_range_diff(int argc, const char **argv, const char *prefix);\n>  extern int cmd_read_tree(int argc, const char **argv, const char *prefix);\n>  extern int cmd_rebase(int argc, const char **argv, const char *prefix);\n>  extern int cmd_rebase__interactive(int argc, const char **argv, const char *prefix);\n> -extern int cmd_rebase__helper(int argc, const char **argv, const char *prefix);\n>  extern int cmd_receive_pack(int argc, const char **argv, const char *prefix);\n>  extern int cmd_reflog(int argc, const char **argv, const char *prefix);\n>  extern int cmd_remote(int argc, const char **argv, const char *prefix);\n> \n\nThank you for pointing this out!  I will include it in my next reroll.\n\nCheers,\nAlban\n\n"}]}