{"thread":{"id":"48968","subject":"[PATCH] doc: fix want-capability separator","startedAt":"2018-07-28T21:16:42Z","lastAt":"2018-07-30T18:26:35Z","messageCount":2,"participants":["Masaya Suzuki","Stefan Beller"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"353803","messageId":"20180728211630.29573-1-masayasuzuki@google.com","threadId":"48968","inReplyTo":null,"subject":"[PATCH] doc: fix want-capability separator","fromName":"Masaya Suzuki","fromEmail":"draftcode@gmail.com","sentAt":"2018-07-28T21:16:30Z","receivedAt":"2018-07-28T21:16:42Z","isPatch":true,"sender":{"key":"masayasuzuki@google.com","avatar":"https://avatars.githubusercontent.com/u/21878?v=4"},"body":"Unlike ref advertisement, client capabilities and the first want are\nseparated by SP, not NUL, in the implementation. Fix the documentation\nto align with the implementation. pack-protocol.txt is already fixed.\n\nSigned-off-by: Masaya Suzuki <masayasuzuki@google.com>\n---\n Documentation/technical/http-protocol.txt | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/Documentation/technical/http-protocol.txt b/Documentation/technical/http-protocol.txt\nindex 64f49d0bb..9c5b6f0fa 100644\n--- a/Documentation/technical/http-protocol.txt\n+++ b/Documentation/technical/http-protocol.txt\n@@ -338,11 +338,11 @@ server advertises capability `allow-tip-sha1-in-want` or\n \t\t       request_end\n   request_end       =  \"0000\" / \"done\"\n \n-  want_list         =  PKT-LINE(want NUL cap_list LF)\n+  want_list         =  PKT-LINE(want SP cap_list LF)\n \t\t       *(want_pkt)\n   want_pkt          =  PKT-LINE(want LF)\n   want              =  \"want\" SP id\n-  cap_list          =  *(SP capability) SP\n+  cap_list          =  capability *(SP capability)\n \n   have_list         =  *PKT-LINE(\"have\" SP id LF)\n \n-- \n2.18.0\n\n"},{"id":"353928","messageId":"CAGZ79kYOqP-8t1r_-NVLA025UP+_Zi5SXHWfc7HxRo9gemWDpQ@mail.gmail.com","threadId":"48968","inReplyTo":"20180728211630.29573-1-masayasuzuki@google.com","subject":"Re: [PATCH] doc: fix want-capability separator","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2018-07-30T18:26:21Z","receivedAt":"2018-07-30T18:26:35Z","isPatch":true,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"On Sat, Jul 28, 2018 at 2:16 PM Masaya Suzuki <draftcode@gmail.com> wrote:\n> Signed-off-by: Masaya Suzuki <masayasuzuki@google.com>\n\nThe email addresses mismatch?\n\n> Unlike ref advertisement, client capabilities and the first want are\n> separated by SP, not NUL, in the implementation. Fix the documentation\n> to align with the implementation.\n\nMakes sense! Thanks for the fix!\n\n> pack-protocol.txt is already fixed.\n\nwhich has\n\n  capability-list  =  capability *(SP capability)\n\nsince b31222cfb7f (Update packfile transfer protocol\ndocumentation, 2009-11-03), which is the first to mention\nthe capability line, so I'd claim it was always correct?\n\n>\n> ---\n>  Documentation/technical/http-protocol.txt | 4 ++--\n>  1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/Documentation/technical/http-protocol.txt b/Documentation/technical/http-protocol.txt\n> index 64f49d0bb..9c5b6f0fa 100644\n> --- a/Documentation/technical/http-protocol.txt\n> +++ b/Documentation/technical/http-protocol.txt\n> @@ -338,11 +338,11 @@ server advertises capability `allow-tip-sha1-in-want` or\n>                        request_end\n>    request_end       =  \"0000\" / \"done\"\n>\n> -  want_list         =  PKT-LINE(want NUL cap_list LF)\n> +  want_list         =  PKT-LINE(want SP cap_list LF)\n>                        *(want_pkt)\n>    want_pkt          =  PKT-LINE(want LF)\n>    want              =  \"want\" SP id\n> -  cap_list          =  *(SP capability) SP\n> +  cap_list          =  capability *(SP capability)\n>\n>    have_list         =  *PKT-LINE(\"have\" SP id LF)\n\nJust after these context lines we have\n\n  TODO: Document this further.\n\nwhich is a good hint that the existing documentation\ncan benefit from patches like these.\n\nThanks,\nStefan\n"}]}