{"thread":{"id":"48953","subject":"[PATCH] git-rebase--interactive.sh: Remove superfluous tab in rebase","startedAt":"2018-07-25T10:19:58Z","lastAt":"2018-07-26T04:16:30Z","messageCount":4,"participants":["Daniel Baumann","Ævar Arnfjörð Bjarmason","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"353557","messageId":"db70d275-584e-3a3b-5201-dc04e4c5950b@daniel-baumann.ch","threadId":"48953","inReplyTo":null,"subject":"[PATCH] git-rebase--interactive.sh: Remove superfluous tab in rebase","fromName":"Daniel Baumann","fromEmail":"mail@daniel-baumann.ch","sentAt":"2018-07-25T10:12:53Z","receivedAt":"2018-07-25T10:19:58Z","isPatch":true,"sender":{"key":"mail@daniel-baumann.ch","avatar":null},"body":"Hi,\n\nthe attached patch removes a superfluous tab indentation in the\ninteractive git-rebase messages.\n\nIt would be nice to get rid of this to avoid visual disturbance with\nwhitespace highlighting editors.\n\nRegards,\nDaniel\n\n\nFrom 353eb1c2c44d5117a3fad1323ca6852b13e4c86a Mon Sep 17 00:00:00 2001\nFrom: Daniel Baumann <mail@daniel-baumann.ch>\nDate: Wed, 25 Jul 2018 11:58:40 +0200\nSubject: [PATCH] git-rebase--interactive.sh: Remove superfluous tab in rebase\n file\n\nRemoving superfluous tab indentation in interactive git-rebase\nfile to avoid visual disturbance with whitespace highlighting editors.\n\nSigned-off-by: Daniel Baumann <mail@daniel-baumann.ch>\n---\n git-rebase--interactive.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh\nindex 299ded213..0bf9eefad 100644\n--- a/git-rebase--interactive.sh\n+++ b/git-rebase--interactive.sh\n@@ -224,7 +224,7 @@ EOF\n \tgettext \"\n \tHowever, if you remove everything, the rebase will be aborted.\n \n-\t\" | git stripspace --comment-lines >>\"$todo\"\n+\" | git stripspace --comment-lines >>\"$todo\"\n \n \tif test -z \"$keep_empty\"\n \tthen\n-- \n2.18.0\n\n"},{"id":"353558","messageId":"87o9evbn6l.fsf@evledraar.gmail.com","threadId":"48953","inReplyTo":"db70d275-584e-3a3b-5201-dc04e4c5950b@daniel-baumann.ch","subject":"Re: [PATCH] git-rebase--interactive.sh: Remove superfluous tab in rebase","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2018-07-25T10:54:26Z","receivedAt":"2018-07-25T10:54:31Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"\nOn Wed, Jul 25 2018, Daniel Baumann wrote:\n\n> the attached patch removes a superfluous tab indentation in the\n> interactive git-rebase messages.\n>\n> It would be nice to get rid of this to avoid visual disturbance with\n> whitespace highlighting editors.\n\nThe code you're modifying doesn't exist in the \"pu\" branch since\n249d626f2c (\"rebase--interactive: rewrite append_todo_help() in C\",\n2018-07-10), rebase is being rewritten in C. From looking at it it seems\nwe no longer have this problem, but perhaps you'd like to check that out\nfor yourself?\n"},{"id":"353606","messageId":"ed377eda-648a-23a5-c400-03602e007a05@daniel-baumann.ch","threadId":"48953","inReplyTo":"87o9evbn6l.fsf@evledraar.gmail.com","subject":"Re: [PATCH] git-rebase--interactive.sh: Remove superfluous tab in rebase","fromName":"Daniel Baumann","fromEmail":"mail@daniel-baumann.ch","sentAt":"2018-07-26T02:21:19Z","receivedAt":"2018-07-26T02:21:29Z","isPatch":true,"sender":{"key":"mail@daniel-baumann.ch","avatar":null},"body":"Hi,\n\nOn 07/25/2018 12:54 PM, Ævar Arnfjörð Bjarmason wrote:\n> The code you're modifying doesn't exist in the \"pu\" branch since\n> 249d626f2c\n\nindeed, thanks.\n\n> From looking at it it seems we no longer have this problem,\n> but perhaps you'd like to check that out for yourself?\nYes, it's not needed anymore at all, yay!\n\nSorry for the noise.\n\nRegards,\nDaniel\n"},{"id":"353609","messageId":"xmqqin52skbq.fsf@gitster-ct.c.googlers.com","threadId":"48953","inReplyTo":"ed377eda-648a-23a5-c400-03602e007a05@daniel-baumann.ch","subject":"Re: [PATCH] git-rebase--interactive.sh: Remove superfluous tab in rebase","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2018-07-26T04:16:25Z","receivedAt":"2018-07-26T04:16:30Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Daniel Baumann <mail@daniel-baumann.ch> writes:\n\n> On 07/25/2018 12:54 PM, Ævar Arnfjörð Bjarmason wrote:\n>> The code you're modifying doesn't exist in the \"pu\" branch since\n>> 249d626f2c\n>\n> indeed, thanks.\n>\n>> From looking at it it seems we no longer have this problem,\n>> but perhaps you'd like to check that out for yourself?\n> Yes, it's not needed anymore at all, yay!\n>\n> Sorry for the noise.\n\nThanks for reporting.  It is 100% better to see occasional\nduplicates than nothing.\n"}]}