{"thread":{"id":"48904","subject":"sed: command garbled: rGIT-PERL-HEADER","startedAt":"2018-07-18T11:53:41Z","lastAt":"2018-07-18T19:12:27Z","messageCount":4,"participants":["Jeffrey Walton","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"352856","messageId":"CAH8yC8nef0iPVLqnkcJ2fh=N8jCM=tK1DXJJe+nx8cOL8K9D6A@mail.gmail.com","threadId":"48904","inReplyTo":null,"subject":"sed: command garbled: rGIT-PERL-HEADER","fromName":"Jeffrey Walton","fromEmail":"noloader@gmail.com","sentAt":"2018-07-18T11:53:38Z","receivedAt":"2018-07-18T11:53:41Z","isPatch":false,"sender":{"key":"noloader@gmail.com","avatar":null},"body":"I'm trying to build Git 2.18 on Solaris 11.3 x86_64.\n\n$ gmake V=1\nrm -f git-add--interactive git-add--interactive+ && \\\nsed -e '1{' \\\n -e ' s|#!.*perl|#!/usr/bin/perl|' \\\n -e ' rGIT-PERL-HEADER' \\\n -e ' G' \\\n -e '}' \\\n -e 's/@@GIT_VERSION@@/2.18.0/g' \\\n git-add--interactive.perl >git-add--interactive+ && \\\nchmod +x git-add--interactive+ && \\\nmv git-add--interactive+ git-add--interactive\nsed: command garbled: rGIT-PERL-HEADER\ngmake: *** [git-add--interactive] Error 2\n\nAnd:\n\n$ perl --version\n\nThis is perl 5, version 12, subversion 5 (v5.12.5) built for i86pc-solaris-64int\n(with 7 registered patches, see perl -V for more detail)\n\nAny ideas how to fix it?\n\nThanks in advance.\n"},{"id":"352931","messageId":"xmqqtvowjuxp.fsf@gitster-ct.c.googlers.com","threadId":"48904","inReplyTo":"CAH8yC8nef0iPVLqnkcJ2fh=N8jCM=tK1DXJJe+nx8cOL8K9D6A@mail.gmail.com","subject":"Re: sed: command garbled: rGIT-PERL-HEADER","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2018-07-18T17:49:22Z","receivedAt":"2018-07-18T17:49:26Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jeffrey Walton writes:\n\n> I'm trying to build Git 2.18 on Solaris 11.3 x86_64.\n>\n> $ gmake V=1\n> rm -f git-add--interactive git-add--interactive+ && \\\n> sed -e '1{' \\\n> -e ' s|#!.*perl|#!/usr/bin/perl|' \\\n> -e ' rGIT-PERL-HEADER' \\\n> -e ' G' \\\n> -e '}' \\\n> -e 's/@@GIT_VERSION@@/2.18.0/g' \\\n> git-add--interactive.perl >git-add--interactive+ && \\\n> chmod +x git-add--interactive+ && \\\n> mv git-add--interactive+ git-add--interactive\n> sed: command garbled: rGIT-PERL-HEADER\n> gmake: *** [git-add--interactive] Error 2\n>\n> And:\n>\n> $ perl --version\n>\n> This is perl 5, version 12, subversion 5 (v5.12.5) built for i86pc-solaris-64int\n> (with 7 registered patches, see perl -V for more detail)\n>\n> Any ideas how to fix it?\n\nThe fix is prepared to become part of the next feature release (and\nalso some maintenance release before that happens). Please try the\nattached patch.\n\nThanks.\n\n\n-- >8 --\n\nFrom: Alejandro R. Sedeño \nDate: Mon, 25 Jun 2018 15:13:25 -0400\nSubject: [PATCH] Makefile: tweak sed invocation\n\nWith GNU sed, the r command doesn't care if a space separates it and\nthe filename it reads from.\n\nWith SunOS sed, the space is required.\n\nSigned-off-by: Alejandro R. Sedeño \nReviewed-by: Eric Sunshine \nSigned-off-by: Junio C Hamano \n---\n Makefile | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Makefile b/Makefile\nindex 2ba24035f5..50138e85eb 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -2086,7 +2086,7 @@ $(SCRIPT_PERL_GEN): % : %.perl GIT-PERL-DEFINES GIT-PERL-HEADER GIT-VERSION-FILE\n \t$(QUIET_GEN)$(RM) $@ $@+ && \\\n \tsed -e '1{' \\\n \t -e '\ts|#!.*perl|#!$(PERL_PATH_SQ)|' \\\n-\t -e '\trGIT-PERL-HEADER' \\\n+\t -e '\tr GIT-PERL-HEADER' \\\n \t -e '\tG' \\\n \t -e '}' \\\n \t -e 's/@@GIT_VERSION@@/$(GIT_VERSION)/g' \\\n-- \n2.18.0-129-ge3331758f1\n\n\n"},{"id":"352944","messageId":"CAH8yC8nRE7+faKbmvM2bHWPE4hzvhL4RF4i5Gxt4mhseDEzdnQ@mail.gmail.com","threadId":"48904","inReplyTo":"xmqqtvowjuxp.fsf@gitster-ct.c.googlers.com","subject":"Re: sed: command garbled: rGIT-PERL-HEADER","fromName":"Jeffrey Walton","fromEmail":"noloader@gmail.com","sentAt":"2018-07-18T18:47:13Z","receivedAt":"2018-07-18T18:47:15Z","isPatch":false,"sender":{"key":"noloader@gmail.com","avatar":null},"body":"On Wed, Jul 18, 2018 at 1:49 PM, Junio C Hamano wrote:\n> Jeffrey Walton writes:\n> ...\n> diff --git a/Makefile b/Makefile\n> index 2ba24035f5..50138e85eb 100644\n> --- a/Makefile\n> +++ b/Makefile\n> @@ -2086,7 +2086,7 @@ $(SCRIPT_PERL_GEN): % : %.perl GIT-PERL-DEFINES GIT-PERL-HEADER GIT-VERSION-FILE\n> $(QUIET_GEN)$(RM) $@ $@+ && \\\n> sed -e '1{' \\\n> -e ' s|#!.*perl|#!$(PERL_PATH_SQ)|' \\\n> - -e ' rGIT-PERL-HEADER' \\\n> + -e ' r GIT-PERL-HEADER' \\\n> -e ' G' \\\n> -e '}' \\\n> -e 's/@@GIT_VERSION@@/$(GIT_VERSION)/g' \\\n\nThanks, that tested good.\n\nHere's another one for FreeBSD 11 x86_64. LDLIBS includes -pthread.\n\n$ cat ~/git-freebsd.txt\n LINK git-credential-store\n/usr/local/bin/ld: libgit.a(name-hash.o): undefined reference to\nsymbol 'pthread_create@@FBSD_1.0'\n//lib/libthr.so.3: error adding symbols: DSO missing from command line\ncollect2: error: ld returned 1 exit status\ngmake: *** [Makefile:2329: git-credential-store] Error 1\n\nJeff\n"},{"id":"352946","messageId":"CAH8yC8=SfFAUhvqPp0f6wgr7yfAKpmNfT3Z61V4QfUVqUUnBYw@mail.gmail.com","threadId":"48904","inReplyTo":"CAH8yC8nRE7+faKbmvM2bHWPE4hzvhL4RF4i5Gxt4mhseDEzdnQ@mail.gmail.com","subject":"Re: sed: command garbled: rGIT-PERL-HEADER","fromName":"Jeffrey Walton","fromEmail":"noloader@gmail.com","sentAt":"2018-07-18T19:12:25Z","receivedAt":"2018-07-18T19:12:27Z","isPatch":false,"sender":{"key":"noloader@gmail.com","avatar":null},"body":"On Wed, Jul 18, 2018 at 2:47 PM, Jeffrey Walton wrote:\n> On Wed, Jul 18, 2018 at 1:49 PM, Junio C Hamano wrote:\n>> Jeffrey Walton writes:\n>> ...\n>> diff --git a/Makefile b/Makefile\n>> index 2ba24035f5..50138e85eb 100644\n>> --- a/Makefile\n>> +++ b/Makefile\n>> @@ -2086,7 +2086,7 @@ $(SCRIPT_PERL_GEN): % : %.perl GIT-PERL-DEFINES GIT-PERL-HEADER GIT-VERSION-FILE\n>> $(QUIET_GEN)$(RM) $@ $@+ && \\\n>> sed -e '1{' \\\n>> -e ' s|#!.*perl|#!$(PERL_PATH_SQ)|' \\\n>> - -e ' rGIT-PERL-HEADER' \\\n>> + -e ' r GIT-PERL-HEADER' \\\n>> -e ' G' \\\n>> -e '}' \\\n>> -e 's/@@GIT_VERSION@@/$(GIT_VERSION)/g' \\\n>\n> Thanks, that tested good.\n>\n> Here's another one for FreeBSD 11 x86_64. LDLIBS includes -pthread.\n>\n> $ cat ~/git-freebsd.txt\n> LINK git-credential-store\n> /usr/local/bin/ld: libgit.a(name-hash.o): undefined reference to\n> symbol 'pthread_create@@FBSD_1.0'\n> //lib/libthr.so.3: error adding symbols: DSO missing from command line\n> collect2: error: ld returned 1 exit status\n> gmake: *** [Makefile:2329: git-credential-store] Error 1\n\nI was able to clear this one with sed (trailing space is important):\n\n sed -e 's|$(LIB_FILE) |$(LIB_FILE) -lpthread |g' \"$file.orig\"\n\nBut I don't know how to fix the missing recipe:\n\n $ gmake\n gmake: *** No rule to make target 'git-daemon', needed by 'all'. Stop.\n\nJeff\n"}]}