{"thread":{"id":"4890","subject":"[PATCH 1/2] Quote all calls to GIT_CONF_APPEND_LINE","startedAt":"2006-07-15T05:29:19Z","lastAt":"2006-07-15T05:29:21Z","messageCount":2,"participants":["Pavel Roskin"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"23850","messageId":"20060715052919.19165.19665.stgit@dv.roinet.com","threadId":"4890","inReplyTo":null,"subject":"[PATCH 1/2] Quote all calls to GIT_CONF_APPEND_LINE","fromName":"Pavel Roskin","fromEmail":"proski@gnu.org","sentAt":"2006-07-15T05:29:19Z","receivedAt":"2006-07-15T05:29:19Z","isPatch":true,"sender":{"key":"proski@gnu.org","avatar":null},"body":"From: Pavel Roskin <proski@gnu.org>\n\nNot quoting macro arguments that contain other macros is a big no-no in\nAutoconf.  It can break at any time.\n\nSigned-off-by: Pavel Roskin <proski@gnu.org>\n---\n\n configure.ac |   24 ++++++++++++------------\n 1 files changed, 12 insertions(+), 12 deletions(-)\n\ndiff --git a/configure.ac b/configure.ac\nindex 2932d0e..c1f7751 100644\n--- a/configure.ac\n+++ b/configure.ac\n@@ -39,30 +39,30 @@ # Define NO_OPENSSL environment variable\n # Define NEEDS_SSL_WITH_CRYPTO if you need -lcrypto with -lssl (Darwin).\n AC_CHECK_LIB([ssl], [SHA1_Init],[],\n [AC_CHECK_LIB([crypto], [SHA1_INIT],\n- GIT_CONF_APPEND_LINE(NEEDS_SSL_WITH_CRYPTO=YesPlease),\n- GIT_CONF_APPEND_LINE(NO_OPENSSL=YesPlease))])\n+ [GIT_CONF_APPEND_LINE(NEEDS_SSL_WITH_CRYPTO=YesPlease)],\n+ [GIT_CONF_APPEND_LINE(NO_OPENSSL=YesPlease)])])\n #\n # Define NO_CURL if you do not have curl installed.  git-http-pull and\n # git-http-push are not built, and you cannot use http:// and https://\n # transports.\n AC_CHECK_LIB([curl], [curl_global_init],[],\n-GIT_CONF_APPEND_LINE(NO_CURL=YesPlease))\n+[GIT_CONF_APPEND_LINE(NO_CURL=YesPlease)])\n #\n # Define NO_EXPAT if you do not have expat installed.  git-http-push is\n # not built, and you cannot push using http:// and https:// transports.\n AC_CHECK_LIB([expat], [XML_ParserCreate],[],\n-GIT_CONF_APPEND_LINE(NO_EXPAT=YesPlease))\n+[GIT_CONF_APPEND_LINE(NO_EXPAT=YesPlease)])\n #\n # Define NEEDS_LIBICONV if linking with libc is not enough (Darwin).\n AC_CHECK_LIB([c], [iconv],[],\n [AC_CHECK_LIB([iconv],[iconv],\n- GIT_CONF_APPEND_LINE(NEEDS_LIBICONV=YesPlease),[])])\n+ [GIT_CONF_APPEND_LINE(NEEDS_LIBICONV=YesPlease)],[])])\n #\n # Define NEEDS_SOCKET if linking with libc is not enough (SunOS,\n # Patrick Mauritz).\n AC_CHECK_LIB([c], [socket],[],\n [AC_CHECK_LIB([socket],[socket],\n- GIT_CONF_APPEND_LINE(NEEDS_SOCKET=YesPlease),[])])\n+ [GIT_CONF_APPEND_LINE(NEEDS_SOCKET=YesPlease)],[])])\n \n \n ## Checks for header files.\n@@ -73,19 +73,19 @@ AC_MSG_NOTICE([CHECKS for typedefs, stru\n #\n # Define NO_D_INO_IN_DIRENT if you don't have d_ino in your struct dirent.\n AC_CHECK_MEMBER(struct dirent.d_ino,[],\n-GIT_CONF_APPEND_LINE(NO_D_INO_IN_DIRENT=YesPlease),\n+[GIT_CONF_APPEND_LINE(NO_D_INO_IN_DIRENT=YesPlease)],\n [#include <dirent.h>])\n #\n # Define NO_D_TYPE_IN_DIRENT if your platform defines DT_UNKNOWN but lacks\n # d_type in struct dirent (latest Cygwin -- will be fixed soonish).\n AC_CHECK_MEMBER(struct dirent.d_type,[],\n-GIT_CONF_APPEND_LINE(NO_D_TYPE_IN_DIRENT=YesPlease),\n+[GIT_CONF_APPEND_LINE(NO_D_TYPE_IN_DIRENT=YesPlease)],\n [#include <dirent.h>])\n #\n # Define NO_SOCKADDR_STORAGE if your platform does not have struct\n # sockaddr_storage.\n AC_CHECK_TYPE(struct sockaddr_storage,[],\n-GIT_CONF_APPEND_LINE(NO_SOCKADDR_STORAGE=YesPlease),\n+[GIT_CONF_APPEND_LINE(NO_SOCKADDR_STORAGE=YesPlease)],\n [#include <netinet/in.h>])\n \n \n@@ -95,15 +95,15 @@ AC_MSG_NOTICE([CHECKS for library functi\n #\n # Define NO_STRCASESTR if you don't have strcasestr.\n AC_CHECK_FUNC(strcasestr,[],\n-GIT_CONF_APPEND_LINE(NO_STRCASESTR=YesPlease))\n+[GIT_CONF_APPEND_LINE(NO_STRCASESTR=YesPlease)])\n #\n # Define NO_STRLCPY if you don't have strlcpy.\n AC_CHECK_FUNC(strlcpy,[],\n-GIT_CONF_APPEND_LINE(NO_STRLCPY=YesPlease))\n+[GIT_CONF_APPEND_LINE(NO_STRLCPY=YesPlease)])\n #\n # Define NO_SETENV if you don't have setenv in the C library.\n AC_CHECK_FUNC(setenv,[],\n-GIT_CONF_APPEND_LINE(NO_SETENV=YesPlease))\n+[GIT_CONF_APPEND_LINE(NO_SETENV=YesPlease)])\n #\n # Define NO_MMAP if you want to avoid mmap.\n #\n"},{"id":"23851","messageId":"20060715052921.19165.66254.stgit@dv.roinet.com","threadId":"4890","inReplyTo":"20060715052919.19165.19665.stgit@dv.roinet.com","subject":"[PATCH 2/2] Set datarootdir in config.mak.in","fromName":"Pavel Roskin","fromEmail":"proski@gnu.org","sentAt":"2006-07-15T05:29:21Z","receivedAt":"2006-07-15T05:29:21Z","isPatch":true,"sender":{"key":"proski@gnu.org","avatar":null},"body":"From: Pavel Roskin <proski@gnu.org>\n\nAutoconf 2.60 expresses datadir in terms of datarootdir.  If datarootdir\nis not substituted, configure issues a warning and uses a compatibility\nsubstitution for datadir.\n\nSigned-off-by: Pavel Roskin <proski@gnu.org>\n---\n\n config.mak.in |    1 +\n 1 files changed, 1 insertions(+), 0 deletions(-)\n\ndiff --git a/config.mak.in b/config.mak.in\nindex 89520eb..04f508a 100644\n--- a/config.mak.in\n+++ b/config.mak.in\n@@ -10,6 +10,7 @@ prefix = @prefix@\n exec_prefix = @exec_prefix@\n bindir = @bindir@\n #gitexecdir = @libexecdir@/git-core/\n+datarootdir = @datarootdir@\n template_dir = @datadir@/git-core/templates/\n GIT_PYTHON_DIR = @datadir@/git-core/python\n \n"}]}