{"thread":{"id":"4887","subject":"[PATCH] argv created by handle_alias should be NULL terminated","startedAt":"2006-07-14T16:37:06Z","lastAt":"2006-07-14T16:37:06Z","messageCount":1,"participants":["Matthias Lederhofer"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"23825","messageId":"E1G1Qf4-0007Ji-MH@moooo.ath.cx","threadId":"4887","inReplyTo":null,"subject":"[PATCH] argv created by handle_alias should be NULL terminated","fromName":"Matthias Lederhofer","fromEmail":"matled@gmx.net","sentAt":"2006-07-14T16:37:06Z","receivedAt":"2006-07-14T16:37:06Z","isPatch":true,"sender":{"key":"matled@gmx.net","avatar":null},"body":"Signed-off-by: Matthias Lederhofer <matled@gmx.net>\n---\nExample:\n% git repo-config alias.test am\n% git test\nerror: cannot open mbox JÜ·JÜ·JÜ·JÜ· JÜ· JÜ·(JÜ·(JÜ [..]\n---\n git.c |   11 +++++------\n 1 files changed, 5 insertions(+), 6 deletions(-)\n\ndiff --git a/git.c b/git.c\nindex 102735a..ee5a0e8 100644\n--- a/git.c\n+++ b/git.c\n@@ -133,13 +133,12 @@ static int handle_alias(int *argcp, cons\n \t\t\t\tfflush(stderr);\n \t\t\t}\n \n+\t\t\tnew_argv = realloc(new_argv, sizeof(char*) *\n+\t\t\t\t\t   (count + *argcp + 1));\n \t\t\t/* insert after command name */\n-\t\t\tif (*argcp > 1) {\n-\t\t\t\tnew_argv = realloc(new_argv, sizeof(char*) *\n-\t\t\t\t\t\t   (count + *argcp));\n-\t\t\t\tmemcpy(new_argv + count, *argv + 1,\n-\t\t\t\t       sizeof(char*) * *argcp);\n-\t\t\t}\n+\t\t\tmemcpy(new_argv + count, *argv + 1,\n+\t\t\t       sizeof(char*) * *argcp);\n+\t\t\tnew_argv[count+*argcp] = NULL;\n \n \t\t\t*argv = new_argv;\n \t\t\t*argcp += count - 1;\n-- \n1.4.1.g8b4b\n"}]}