{"thread":{"id":"48869","subject":"[PATCH] ref-filter: mark some file-local symbols as static","startedAt":"2018-07-12T15:57:48Z","lastAt":"2018-07-12T17:07:16Z","messageCount":2,"participants":["Ramsay Jones","Оля Тележная"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"352356","messageId":"bbd5f6f5-8587-606e-01be-4c5e37609037@ramsayjones.plus.com","threadId":"48869","inReplyTo":null,"subject":"[PATCH] ref-filter: mark some file-local symbols as static","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2018-07-12T15:57:44Z","receivedAt":"2018-07-12T15:57:48Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nSigned-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n---\n\nHi Olga,\n\nIf you need to re-roll your 'ot/ref-filter-object-info' branch,\ncould you please squash this into the relevant patch (commit c5d9a471d6,\n\"ref-filter: use oid_object_info() to get object\", 2018-07-09).\n\n[Both sparse and my static-check.pl script are complaining about\nthe 'oi' and 'oi_deref' symbols.]\n\nThanks!\n\nATB,\nRamsay Jones\n\n ref-filter.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/ref-filter.c b/ref-filter.c\nindex 9aedf29e0..70fb15619 100644\n--- a/ref-filter.c\n+++ b/ref-filter.c\n@@ -63,7 +63,7 @@ struct refname_atom {\n \tint lstrip, rstrip;\n };\n \n-struct expand_data {\n+static struct expand_data {\n \tstruct object_id oid;\n \tenum object_type type;\n \tunsigned long size;\n-- \n2.18.0\n"},{"id":"352368","messageId":"CAL21Bm=eqEV8qXECvXBm5Nqx6Wgbsha7ya=pEvTuqw+F-FncDg@mail.gmail.com","threadId":"48869","inReplyTo":"bbd5f6f5-8587-606e-01be-4c5e37609037@ramsayjones.plus.com","subject":"Re: [PATCH] ref-filter: mark some file-local symbols as static","fromName":"Оля Тележная","fromEmail":"olyatelezhnaya@gmail.com","sentAt":"2018-07-12T17:07:12Z","receivedAt":"2018-07-12T17:07:16Z","isPatch":true,"sender":{"key":"olyatelezhnaya@gmail.com","avatar":"https://avatars.githubusercontent.com/u/11246099?v=4"},"body":"2018-07-12 18:57 GMT+03:00 Ramsay Jones <ramsay@ramsayjones.plus.com>:\n>\n> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n> ---\n>\n> Hi Olga,\n>\n> If you need to re-roll your 'ot/ref-filter-object-info' branch,\n> could you please squash this into the relevant patch (commit c5d9a471d6,\n> \"ref-filter: use oid_object_info() to get object\", 2018-07-09).\n>\n> [Both sparse and my static-check.pl script are complaining about\n> the 'oi' and 'oi_deref' symbols.]\n\nYou are right. Thanks a lot!\n\n>\n> Thanks!\n>\n> ATB,\n> Ramsay Jones\n>\n>  ref-filter.c | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/ref-filter.c b/ref-filter.c\n> index 9aedf29e0..70fb15619 100644\n> --- a/ref-filter.c\n> +++ b/ref-filter.c\n> @@ -63,7 +63,7 @@ struct refname_atom {\n>         int lstrip, rstrip;\n>  };\n>\n> -struct expand_data {\n> +static struct expand_data {\n>         struct object_id oid;\n>         enum object_type type;\n>         unsigned long size;\n> --\n> 2.18.0\n"}]}