{"thread":{"id":"48845","subject":"[PATCH 0/4] Use oid_object_info() instead of read_object_file()","startedAt":"2018-07-09T08:27:26Z","lastAt":"2018-07-18T17:56:16Z","messageCount":6,"participants":["Оля Тележная","Junio C Hamano","Johannes Schindelin"],"isPatch":true,"patchVersion":1,"patchTotal":4},"messages":[{"id":"351934","messageId":"CAL21BmkBohTOVdCO_ENVfzL28aRjoh1MCCF6750AQEYsc7L54w@mail.gmail.com","threadId":"48845","inReplyTo":null,"subject":"[PATCH 0/4] Use oid_object_info() instead of read_object_file()","fromName":"Оля Тележная","fromEmail":"olyatelezhnaya@gmail.com","sentAt":"2018-07-09T08:27:21Z","receivedAt":"2018-07-09T08:27:26Z","isPatch":true,"sender":{"key":"olyatelezhnaya@gmail.com","avatar":"https://avatars.githubusercontent.com/u/11246099?v=4"},"body":"Hello everyone,\nThis is my new attempt to start using oid_object_info_extended() in\nref-filter. You could look at previous one [1] [2] but it is not\nnecessary.\n\nThe goal (still) is to improve performance by avoiding calling expensive\nfunctions when we don't need the information they provide\nor when we could get it by using a cheaper function.\n\nThis patch is a middle step. In the end, I want to add new atoms\n(\"objectsize:disk\" and \"deltabase\") and reuse ref-filter logic in\ncat-file command.\n\nI also know about problems with memory leaks in ref-filter: that would\nbe my next task that I will work on. Since I did not generate any new\nleaks in this patch (just use existing ones), I decided to put this\npart on a review and fix leaks as a separate task.\n\nThank you!\n\n[1] https://github.com/git/git/pull/493\n[2] https://public-inbox.org/git/010201637254c969-a346030e-0b75-41ad-8ef3-2ac7e04ba4fb-000000@eu-west-1.amazonses.com/\n"},{"id":"352046","messageId":"xmqqva9o9gl1.fsf@gitster-ct.c.googlers.com","threadId":"48845","inReplyTo":"CAL21BmkBohTOVdCO_ENVfzL28aRjoh1MCCF6750AQEYsc7L54w@mail.gmail.com","subject":"Re: [PATCH 0/4] Use oid_object_info() instead of read_object_file()","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2018-07-09T22:42:18Z","receivedAt":"2018-07-09T22:42:25Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Оля Тележная writes:\n\n> Hello everyone,\n> This is my new attempt to start using oid_object_info_extended() in\n> ref-filter. You could look at previous one [1] [2] but it is not\n> necessary.\n\nYup, it sounds like a sensible thing to do to try asking object-info\nhelper instead of reading the whole object in-core and inspecting it\nourselves when we can avoid it.\n\n"},{"id":"352079","messageId":"nycvar.QRO.7.76.6.1807101133060.75@tvgsbejvaqbjf.bet","threadId":"48845","inReplyTo":"CAL21BmkBohTOVdCO_ENVfzL28aRjoh1MCCF6750AQEYsc7L54w@mail.gmail.com","subject":"Re: [PATCH 0/4] Use oid_object_info() instead of read_object_file()","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2018-07-10T09:47:29Z","receivedAt":"2018-07-10T09:47:43Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Olga,\n\nOn Mon, 9 Jul 2018, Оля Тележная wrote:\n\n> [2] https://public-inbox.org/git/010201637254c969-a346030e-0b75-41ad-8ef3-2ac7e04ba4fb-000000@eu-west-1.amazonses.com/\n\nThis type of Message-Id makes me think that you used SubmitGit to send\nthis patch series.\n\nThe main problem I see here is that the patches are not sent as replies to\nthis cover letter, and therefore they are seemingly disconnected on the\nmailing list.\n\nIt was also my impression that SubmitGit started supporting sending cover\nletters, in which case you would not have to jump through hoops to thread\nthe mails properly. But for that to work, the PR has to have a description\nwhich is then used as cover letter. I do not see any description in\nhttps://github.com/git/git/pull/520, though. Maybe provide one?\n\nCiao,\nJohannes\n\nP.S.: You might have noticed that I am working (slowly, but steadily) on a\ncontender for SubmitGit that I call GitGitGadget. Originally, I really\nwanted to enhance SubmitGit instead because I am a big believer of *not*\nreinventing the wheel (so much energy gets wasted that way).\n\nHowever, in this case the limitations of the chosen language (I do not\nwant to learn Scala, I have absolutely zero need to know Scala in any of\nmy other endeavors, and my time to learn new things is limited, so I spend\nit wisely) and the limitations of the design (the UI is completely\nseparate from GitHub, you have to allow Amazon to send mails in your name,\nand SubmitGit's design makes it impossible to work bi-directionally, it is\nonly GitHub -> mailing list, while I also want the option to add replies\non the mailing list as comments to the GitHub PR in the future) made me\nreconsider.\n\nIf you want to kick the tires, so to say, I welcome you to give\nGitGitGadget a try. It would require only a couple of things from you:\n\n- You would have to settle for a branch name, and then not open new PRs\n for every iteration you want to send, but force-push the branch instead.\n\n- You would have to open a PR at https://github.com/gitgitgadget/git.\n\n- You would have to provide the cover letter via the PR's description (and\n update that description before sending newer iterations).\n\n- I would have to add you to the list of users allowed to send patches via\n GitGitGadget (GitGitGadget has some really light-weight access control\n to prevent spamming).\n\n- You would then send a new iteration by simply adding a comment to your\n PR that contains this command: /submit\n\n- To integrate well with previous patch series iterations (i.e. to connect\n the threads), I would have to come up with a little bit of tooling to\n add some metadata that I have to reconstruct manually from your\n previously-sent iterations."},{"id":"352468","messageId":"CAL21BmmwRDwWc_4JmFKMA6ZYcx=A4biG+tmrBHPRNAxpSkt_NA@mail.gmail.com","threadId":"48845","inReplyTo":"CAL21BmkBohTOVdCO_ENVfzL28aRjoh1MCCF6750AQEYsc7L54w@mail.gmail.com","subject":"Re: [PATCH 0/4] Use oid_object_info() instead of read_object_file()","fromName":"Оля Тележная","fromEmail":"olyatelezhnaya@gmail.com","sentAt":"2018-07-13T12:46:51Z","receivedAt":"2018-07-13T12:46:55Z","isPatch":true,"sender":{"key":"olyatelezhnaya@gmail.com","avatar":"https://avatars.githubusercontent.com/u/11246099?v=4"},"body":"2018-07-09 11:27 GMT+03:00 Оля Тележная :\n> Hello everyone,\n> This is my new attempt to start using oid_object_info_extended() in\n> ref-filter. You could look at previous one [1] [2] but it is not\n> necessary.\n>\n> The goal (still) is to improve performance by avoiding calling expensive\n> functions when we don't need the information they provide\n> or when we could get it by using a cheaper function.\n>\n> This patch is a middle step. In the end, I want to add new atoms\n> (\"objectsize:disk\" and \"deltabase\") and reuse ref-filter logic in\n> cat-file command.\n>\n> I also know about problems with memory leaks in ref-filter: that would\n> be my next task that I will work on. Since I did not generate any new\n> leaks in this patch (just use existing ones), I decided to put this\n> part on a review and fix leaks as a separate task.\n\nUPDATES since v1:\nadd init to eaten variable (thanks to Szeder Gabor, Johannes Schindelin)\nimprove second commit message (thanks to Junio C Hamano)\nadd static keyword (thanks to Ramsay Jones)\n\n>\n> Thank you!\n>\n> [1] https://github.com/git/git/pull/493\n> [2] https://public-inbox.org/git/010201637254c969-a346030e-0b75-41ad-8ef3-2ac7e04ba4fb-000000@eu-west-1.amazonses.com/\n"},{"id":"352857","messageId":"nycvar.QRO.7.76.6.1807181413200.71@tvgsbejvaqbjf.bet","threadId":"48845","inReplyTo":"CAL21BmmwRDwWc_4JmFKMA6ZYcx=A4biG+tmrBHPRNAxpSkt_NA@mail.gmail.com","subject":"Re: [PATCH 0/4] Use oid_object_info() instead of read_object_file()","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2018-07-18T12:13:54Z","receivedAt":"2018-07-18T12:14:21Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Olga,\n\nOn Fri, 13 Jul 2018, Оля Тележная wrote:\n\n> 2018-07-09 11:27 GMT+03:00 Оля Тележная :\n> > Hello everyone,\n> > This is my new attempt to start using oid_object_info_extended() in\n> > ref-filter. You could look at previous one [1] [2] but it is not\n> > necessary.\n> >\n> > The goal (still) is to improve performance by avoiding calling expensive\n> > functions when we don't need the information they provide\n> > or when we could get it by using a cheaper function.\n> >\n> > This patch is a middle step. In the end, I want to add new atoms\n> > (\"objectsize:disk\" and \"deltabase\") and reuse ref-filter logic in\n> > cat-file command.\n> >\n> > I also know about problems with memory leaks in ref-filter: that would\n> > be my next task that I will work on. Since I did not generate any new\n> > leaks in this patch (just use existing ones), I decided to put this\n> > part on a review and fix leaks as a separate task.\n> \n> UPDATES since v1:\n> add init to eaten variable (thanks to Szeder Gabor, Johannes Schindelin)\n> improve second commit message (thanks to Junio C Hamano)\n> add static keyword (thanks to Ramsay Jones)\n> \n> >\n> > Thank you!\n> >\n> > [1] https://github.com/git/git/pull/493\n\nCould you please populate the description of that PR so that SubmitGit\npicks it up as cover letter?\n\nThanks,\nJohannes\n\n> > [2] https://public-inbox.org/git/010201637254c969-a346030e-0b75-41ad-8ef3-2ac7e04ba4fb-000000@eu-west-1.amazonses.com/\n> "},{"id":"352933","messageId":"xmqqpnzkjumc.fsf@gitster-ct.c.googlers.com","threadId":"48845","inReplyTo":"nycvar.QRO.7.76.6.1807181413200.71@tvgsbejvaqbjf.bet","subject":"Re: [PATCH 0/4] Use oid_object_info() instead of read_object_file()","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2018-07-18T17:56:11Z","receivedAt":"2018-07-18T17:56:16Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Johannes Schindelin writes:\n\n> Hi Olga,\n>\n> On Fri, 13 Jul 2018, Оля Тележная wrote:\n>\n>> 2018-07-09 11:27 GMT+03:00 Оля Тележная :\n>> > Hello everyone,\n>> > This is my new attempt to start using oid_object_info_extended() in\n>> > ref-filter. You could look at previous one [1] [2] but it is not\n>> > necessary.\n>> >\n>> > The goal (still) is to improve performance by avoiding calling expensive\n>> > functions when we don't need the information they provide\n>> > or when we could get it by using a cheaper function.\n>> >\n>> > This patch is a middle step. In the end, I want to add new atoms\n>> > (\"objectsize:disk\" and \"deltabase\") and reuse ref-filter logic in\n>> > cat-file command.\n>> >\n>> > I also know about problems with memory leaks in ref-filter: that would\n>> > be my next task that I will work on. Since I did not generate any new\n>> > leaks in this patch (just use existing ones), I decided to put this\n>> > part on a review and fix leaks as a separate task.\n>> \n>> UPDATES since v1:\n>> add init to eaten variable (thanks to Szeder Gabor, Johannes Schindelin)\n>> improve second commit message (thanks to Junio C Hamano)\n>> add static keyword (thanks to Ramsay Jones)\n>> \n>> >\n>> > Thank you!\n>> >\n>> > [1] https://github.com/git/git/pull/493\n>\n> Could you please populate the description of that PR so that SubmitGit\n> picks it up as cover letter?\n\nThanks for suggesting that. Yes, an updated version of a series,\neven if it is a small one with just 4 or 5 patches, becomes much\neasier to read with a well-written cover letter.\n"}]}