{"thread":{"id":"48752","subject":"[PATCH 2/2] i18n: bisect: mark two supplementary strings for translation","startedAt":"2018-06-21T14:36:10Z","lastAt":"2018-06-30T09:12:28Z","messageCount":7,"participants":["Raphaël Hertzog","Duy Nguyen","Raphael Hertzog"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"350635","messageId":"20180621142742.28575-3-hertzog@debian.org","threadId":"48752","inReplyTo":"20180621142742.28575-1-hertzog@debian.org","subject":"[PATCH 2/2] i18n: bisect: mark two supplementary strings for translation","fromName":"Raphaël Hertzog","fromEmail":"hertzog@debian.org","sentAt":"2018-06-21T14:27:42Z","receivedAt":"2018-06-21T14:36:10Z","isPatch":true,"sender":{"key":"hertzog@debian.org","avatar":"https://avatars.githubusercontent.com/u/1013915?v=4"},"body":"The whole bisect procedure is translated but the last message\nthat the user will see in the process is not translated. Let's fix this.\n\nSigned-off-by: Raphaël Hertzog \n---\n bisect.c | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/bisect.c b/bisect.c\nindex a579b5088..8edc7a7a6 100644\n--- a/bisect.c\n+++ b/bisect.c\n@@ -658,8 +658,8 @@ static void exit_if_skipped_commits(struct commit_list *tried,\n \tif (!tried)\n \t\treturn;\n \n-\tprintf(\"There are only 'skip'ped commits left to test.\\n\"\n-\t \"The first %s commit could be any of:\\n\", term_bad);\n+\tprintf(_(\"There are only 'skip'ped commits left to test.\\n\"\n+\t\t \"The first %s commit could be any of:\\n\"), term_bad);\n \n \tfor ( ; tried; tried = tried->next)\n \t\tprintf(\"%s\\n\", oid_to_hex(&tried->item->object.oid));\n@@ -984,7 +984,7 @@ int bisect_next_all(const char *prefix, int no_checkout)\n \n \tif (!oidcmp(bisect_rev, current_bad_oid)) {\n \t\texit_if_skipped_commits(tried, current_bad_oid);\n-\t\tprintf(\"%s is the first %s commit\\n\", oid_to_hex(bisect_rev),\n+\t\tprintf(_(\"%s is the first %s commit\\n\"), oid_to_hex(bisect_rev),\n \t\t\tterm_bad);\n \t\tshow_diff_tree(prefix, revs.commits->item);\n \t\t/* This means the bisection process succeeded. */\n-- \n2.18.0.rc2\n\n"},{"id":"350636","messageId":"20180621142742.28575-1-hertzog@debian.org","threadId":"48752","inReplyTo":null,"subject":"Two small l10n/i18n patches","fromName":"Raphaël Hertzog","fromEmail":"hertzog@debian.org","sentAt":"2018-06-21T14:27:40Z","receivedAt":"2018-06-21T14:36:13Z","isPatch":false,"sender":{"key":"hertzog@debian.org","avatar":"https://avatars.githubusercontent.com/u/1013915?v=4"},"body":"(I'm not subscribed, please keep me in CC)\n\nHello,\n\nI was reviewing the output of \"git bisect\" with my French locale\nand I saw a clear mistake in the French translation (fixed\nin the first commit) and I also noticed that the last message\nwas still in English. After review of the code, it's not a missing\ntranslation, the problem comes down to two strings which\nare not marked for translation.\n\nSo the second commit marks those strings for translation. But I haven't\nchecked much further than that. The final string is used in many places\nin the test suite and I haven't checked if the locale is properly\nhardcoded in the test suite.\n\nIn any case, \"make test\" is still working after those two commits.\n\nThank you for considering my patches. I leave it tho the regular\ntranslators to add translations for the newly added strings.\n\n\n"},{"id":"350637","messageId":"20180621142742.28575-2-hertzog@debian.org","threadId":"48752","inReplyTo":"20180621142742.28575-1-hertzog@debian.org","subject":"[PATCH 1/2] l10n: fr: fix a message seen in git bisect","fromName":"Raphaël Hertzog","fromEmail":"hertzog@debian.org","sentAt":"2018-06-21T14:27:41Z","receivedAt":"2018-06-21T14:36:15Z","isPatch":true,"sender":{"key":"hertzog@debian.org","avatar":"https://avatars.githubusercontent.com/u/1013915?v=4"},"body":"\"cette\" can be only be used before a word (like in \"cette bouteille\" for\n\"this bottle\"), but here \"this\" refers to the current step and we have\nto use \"ceci\" in French.\n\nSigned-off-by: Raphaël Hertzog \n---\n po/fr.po | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/po/fr.po b/po/fr.po\nindex 2bae75360..eb760686a 100644\n--- a/po/fr.po\n+++ b/po/fr.po\n@@ -1062,8 +1062,8 @@ msgstr[1] \"(à peu près %d étapes)\"\n #, c-format\n msgid \"Bisecting: %d revision left to test after this %s\\n\"\n msgid_plural \"Bisecting: %d revisions left to test after this %s\\n\"\n-msgstr[0] \"Bissection : %d révision à tester après cette %s\\n\"\n-msgstr[1] \"Bissection : %d révisions à tester après cette %s\\n\"\n+msgstr[0] \"Bissection : %d révision à tester après ceci %s\\n\"\n+msgstr[1] \"Bissection : %d révisions à tester après ceci %s\\n\"\n \n #: blame.c:1756\n msgid \"--contents and --reverse do not blend well.\"\n-- \n2.18.0.rc2\n\n"},{"id":"350638","messageId":"CACsJy8DcXo3HURwZXbvGYjrJpfku+RXESP=ErLzYj3NhNabRTQ@mail.gmail.com","threadId":"48752","inReplyTo":"20180621142742.28575-3-hertzog@debian.org","subject":"Re: [PATCH 2/2] i18n: bisect: mark two supplementary strings for translation","fromName":"Duy Nguyen","fromEmail":"pclouds@gmail.com","sentAt":"2018-06-21T14:48:09Z","receivedAt":"2018-06-21T14:48:39Z","isPatch":true,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"On Thu, Jun 21, 2018 at 4:39 PM Raphaël Hertzog wrote:\n>\n> The whole bisect procedure is translated but the last message\n> that the user will see in the process is not translated. Let's fix this.\n\nNice. There's another string in bisect_common() that should also be\ntranslated: \"revision walk setup failed\". Maybe you can mark it too?\nIt's very unlikely to show up, and since it's already marked for\ntranslation in other files, it will not add extra work on translators.\n\n>\n> Signed-off-by: Raphaël Hertzog \n> ---\n> bisect.c | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n>\n> diff --git a/bisect.c b/bisect.c\n> index a579b5088..8edc7a7a6 100644\n> --- a/bisect.c\n> +++ b/bisect.c\n> @@ -658,8 +658,8 @@ static void exit_if_skipped_commits(struct commit_list *tried,\n> if (!tried)\n> return;\n>\n> - printf(\"There are only 'skip'ped commits left to test.\\n\"\n> - \"The first %s commit could be any of:\\n\", term_bad);\n> + printf(_(\"There are only 'skip'ped commits left to test.\\n\"\n> + \"The first %s commit could be any of:\\n\"), term_bad);\n>\n> for ( ; tried; tried = tried->next)\n> printf(\"%s\\n\", oid_to_hex(&tried->item->object.oid));\n> @@ -984,7 +984,7 @@ int bisect_next_all(const char *prefix, int no_checkout)\n>\n> if (!oidcmp(bisect_rev, current_bad_oid)) {\n> exit_if_skipped_commits(tried, current_bad_oid);\n> - printf(\"%s is the first %s commit\\n\", oid_to_hex(bisect_rev),\n> + printf(_(\"%s is the first %s commit\\n\"), oid_to_hex(bisect_rev),\n> term_bad);\n> show_diff_tree(prefix, revs.commits->item);\n> /* This means the bisection process succeeded. */\n> --\n> 2.18.0.rc2\n>\n\n\n-- \nDuy\n"},{"id":"350648","messageId":"20180621152145.GA29912@home.ouaza.com","threadId":"48752","inReplyTo":"CACsJy8DcXo3HURwZXbvGYjrJpfku+RXESP=ErLzYj3NhNabRTQ@mail.gmail.com","subject":"Re: [PATCH 2/2] i18n: bisect: mark two supplementary strings for translation","fromName":"Raphael Hertzog","fromEmail":"hertzog@debian.org","sentAt":"2018-06-21T15:21:45Z","receivedAt":"2018-06-21T15:21:50Z","isPatch":true,"sender":{"key":"hertzog@debian.org","avatar":"https://avatars.githubusercontent.com/u/1013915?v=4"},"body":"Hi,\n\nOn Thu, 21 Jun 2018, Duy Nguyen wrote:\n> Nice. There's another string in bisect_common() that should also be\n> translated: \"revision walk setup failed\". Maybe you can mark it too?\n\nSure. A new version of the second patch is attached.\n\nCheers,\n-- \nRaphaël Hertzog ◈ Debian Developer\n\nSupport Debian LTS: https://www.freexian.com/services/debian-lts.html\nLearn to master Debian: https://debian-handbook.info/get/\n\n\nFrom 9731f23b9e2f47bdb90e552264c9d030b4f40629 Mon Sep 17 00:00:00 2001\nFrom: =?UTF-8?q?Rapha=C3=ABl=20Hertzog?= \nDate: Thu, 21 Jun 2018 16:06:48 +0200\nSubject: [PATCH 2/2] i18n: bisect: mark three supplementary strings for\n translation\nMIME-Version: 1.0\nContent-Type: text/plain; charset=UTF-8\nContent-Transfer-Encoding: 8bit\n\nThe whole bisect procedure is translated but the last message that the\nuser will see in the process is not translated. Let's fix this.\n\nAlso mark the \"revision walk setup failed\" error message for\ntranslation. It's already used in other files so will not generate\nany new string to translate.\n\nSigned-off-by: Raphaël Hertzog \n---\n bisect.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/bisect.c b/bisect.c\nindex a579b5088..4943eb333 100644\n--- a/bisect.c\n+++ b/bisect.c\n@@ -647,7 +647,7 @@ static void bisect_rev_setup(struct rev_info *revs, const char *prefix,\n static void bisect_common(struct rev_info *revs)\n {\n \tif (prepare_revision_walk(revs))\n-\t\tdie(\"revision walk setup failed\");\n+\t\tdie(_(\"revision walk setup failed\"));\n \tif (revs->tree_objects)\n \t\tmark_edges_uninteresting(revs, NULL);\n }\n@@ -658,8 +658,8 @@ static void exit_if_skipped_commits(struct commit_list *tried,\n \tif (!tried)\n \t\treturn;\n \n-\tprintf(\"There are only 'skip'ped commits left to test.\\n\"\n-\t \"The first %s commit could be any of:\\n\", term_bad);\n+\tprintf(_(\"There are only 'skip'ped commits left to test.\\n\"\n+\t\t \"The first %s commit could be any of:\\n\"), term_bad);\n \n \tfor ( ; tried; tried = tried->next)\n \t\tprintf(\"%s\\n\", oid_to_hex(&tried->item->object.oid));\n@@ -984,7 +984,7 @@ int bisect_next_all(const char *prefix, int no_checkout)\n \n \tif (!oidcmp(bisect_rev, current_bad_oid)) {\n \t\texit_if_skipped_commits(tried, current_bad_oid);\n-\t\tprintf(\"%s is the first %s commit\\n\", oid_to_hex(bisect_rev),\n+\t\tprintf(_(\"%s is the first %s commit\\n\"), oid_to_hex(bisect_rev),\n \t\t\tterm_bad);\n \t\tshow_diff_tree(prefix, revs.commits->item);\n \t\t/* This means the bisection process succeeded. */\n-- \n2.18.0.rc2\n\n"},{"id":"350833","messageId":"20180625152922.GB27849@home.ouaza.com","threadId":"48752","inReplyTo":"20180621152145.GA29912@home.ouaza.com","subject":"Re: [PATCH 2/2] i18n: bisect: mark two supplementary strings for translation","fromName":"Raphael Hertzog","fromEmail":"hertzog@debian.org","sentAt":"2018-06-25T15:29:22Z","receivedAt":"2018-06-25T15:29:27Z","isPatch":true,"sender":{"key":"hertzog@debian.org","avatar":"https://avatars.githubusercontent.com/u/1013915?v=4"},"body":"Hi,\n\nOn Thu, 21 Jun 2018, Raphael Hertzog wrote:\n> On Thu, 21 Jun 2018, Duy Nguyen wrote:\n> > Nice. There's another string in bisect_common() that should also be\n> > translated: \"revision walk setup failed\". Maybe you can mark it too?\n> \n> Sure. A new version of the second patch is attached.\n\nI haven't had any other feedback. Is there anything else that I should do\nto get my changes merged?\n\nCheers,\n-- \nRaphaël Hertzog ◈ Debian Developer\n\nSupport Debian LTS: https://www.freexian.com/services/debian-lts.html\nLearn to master Debian: https://debian-handbook.info/get/\n"},{"id":"351436","messageId":"CACsJy8BNVBQFQPKo1SZifS4asi4+_hm_0j4MxQk02aPoQqsisA@mail.gmail.com","threadId":"48752","inReplyTo":"20180625152922.GB27849@home.ouaza.com","subject":"Re: [PATCH 2/2] i18n: bisect: mark two supplementary strings for translation","fromName":"Duy Nguyen","fromEmail":"pclouds@gmail.com","sentAt":"2018-06-30T09:11:57Z","receivedAt":"2018-06-30T09:12:28Z","isPatch":true,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"On Mon, Jun 25, 2018 at 5:29 PM Raphael Hertzog wrote:\n>\n> Hi,\n>\n> On Thu, 21 Jun 2018, Raphael Hertzog wrote:\n> > On Thu, 21 Jun 2018, Duy Nguyen wrote:\n> > > Nice. There's another string in bisect_common() that should also be\n> > > translated: \"revision walk setup failed\". Maybe you can mark it too?\n> >\n> > Sure. A new version of the second patch is attached.\n>\n> I haven't had any other feedback. Is there anything else that I should do\n> to get my changes merged?\n\nIf Junio has not picked up the patches and did not object either,\nthere's a chance he missed this, so just resend and include him\n-- \nDuy\n"}]}