{"thread":{"id":"48661","subject":"[PATCH] docs: link to gitsubmodules","startedAt":"2018-06-05T20:24:56Z","lastAt":"2018-06-21T20:58:36Z","messageCount":8,"participants":["Brandon Williams","Ævar Arnfjörð Bjarmason","Jonathan Nieder","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"349388","messageId":"20180605202449.28810-1-bmwill@google.com","threadId":"48661","inReplyTo":null,"subject":"[PATCH] docs: link to gitsubmodules","fromName":"Brandon Williams","fromEmail":"bmwill@google.com","sentAt":"2018-06-05T20:24:49Z","receivedAt":"2018-06-05T20:24:56Z","isPatch":true,"sender":{"key":"bwilliams.eng@gmail.com","avatar":null},"body":"Add a link to gitsubmodules(7) under the `submodule.active` entry in\ngit-config(1).\n\nSigned-off-by: Brandon Williams <bmwill@google.com>\n---\n Documentation/config.txt | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)\n\ndiff --git a/Documentation/config.txt b/Documentation/config.txt\nindex ab641bf5a..1277731aa 100644\n--- a/Documentation/config.txt\n+++ b/Documentation/config.txt\n@@ -3327,12 +3327,13 @@ submodule.<name>.ignore::\n submodule.<name>.active::\n \tBoolean value indicating if the submodule is of interest to git\n \tcommands.  This config option takes precedence over the\n-\tsubmodule.active config option.\n+\tsubmodule.active config option. See linkgit:git-submodule[1] for\n+\tdetails.\n \n submodule.active::\n \tA repeated field which contains a pathspec used to match against a\n \tsubmodule's path to determine if the submodule is of interest to git\n-\tcommands.\n+\tcommands. See linkgit:git-submodule[1] for details.\n \n submodule.recurse::\n \tSpecifies if commands recurse into submodules by default. This\n-- \n2.17.1.1185.g55be947832-goog\n\n"},{"id":"349390","messageId":"87o9gpynsp.fsf@evledraar.gmail.com","threadId":"48661","inReplyTo":"20180605202449.28810-1-bmwill@google.com","subject":"Re: [PATCH] docs: link to gitsubmodules","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2018-06-05T20:35:18Z","receivedAt":"2018-06-05T20:35:23Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"\nOn Tue, Jun 05 2018, Brandon Williams wrote:\n\n> Add a link to gitsubmodules(7) under the `submodule.active` entry in\n> git-config(1).\n\nDid you mean to change either the subject or content of this patch? Your\nsubject says gitsubmodules(7), but you link to git-submodule(1).\n"},{"id":"349391","messageId":"20180605203704.GA9266@aiede.svl.corp.google.com","threadId":"48661","inReplyTo":"20180605202449.28810-1-bmwill@google.com","subject":"Re: [PATCH] docs: link to gitsubmodules","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2018-06-05T20:37:04Z","receivedAt":"2018-06-05T20:37:34Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Hi,\n\nBrandon Williams wrote:\n\n> Add a link to gitsubmodules(7) under the `submodule.active` entry in\n> git-config(1).\n>\n> Signed-off-by: Brandon Williams <bmwill@google.com>\n> ---\n>  Documentation/config.txt | 5 +++--\n>  1 file changed, 3 insertions(+), 2 deletions(-)\n>\n> diff --git a/Documentation/config.txt b/Documentation/config.txt\n> index ab641bf5a..1277731aa 100644\n> --- a/Documentation/config.txt\n> +++ b/Documentation/config.txt\n> @@ -3327,12 +3327,13 @@ submodule.<name>.ignore::\n>  submodule.<name>.active::\n>  \tBoolean value indicating if the submodule is of interest to git\n>  \tcommands.  This config option takes precedence over the\n> -\tsubmodule.active config option.\n> +\tsubmodule.active config option. See linkgit:git-submodule[1] for\n> +\tdetails.\n\nThis takes the user to gitsubmodules(7), but with a hop to\ngit-submodule(1) along the way there:\n\n\tDESCRIPTION\n\t       Inspects, updates and manages submodules.\n\n\t       For more information about submodules, see gitsubmodules(7).\n\nI suppose I'd prefer that it links directly to\nlinkgit:gitsubmodules[7] just because that would steer people toward\ncommands like \"git checkout --recurse-submodules\" instead of \"git\nsubmodule init\".\n\nWith or without that tweak,\nReviewed-by: Jonathan Nieder <jrnieder@gmail.com>\n\nTested using\n\n\tmake -C Documentation/ git-config.1\n\tman Documentation/git-config.1\n\nThanks,\nJonathan\n\ndiff --git i/Documentation/config.txt w/Documentation/config.txt\nindex 1277731aa4..efbd7e5652 100644\n--- i/Documentation/config.txt\n+++ w/Documentation/config.txt\n@@ -3327,13 +3327,13 @@ submodule.<name>.ignore::\n submodule.<name>.active::\n \tBoolean value indicating if the submodule is of interest to git\n \tcommands.  This config option takes precedence over the\n-\tsubmodule.active config option. See linkgit:git-submodule[1] for\n+\tsubmodule.active config option. See linkgit:gitsubmodules[7] for\n \tdetails.\n \n submodule.active::\n \tA repeated field which contains a pathspec used to match against a\n \tsubmodule's path to determine if the submodule is of interest to git\n-\tcommands. See linkgit:git-submodule[1] for details.\n+\tcommands. See linkgit:gitsubmodule[7] for details.\n \n submodule.recurse::\n \tSpecifies if commands recurse into submodules by default. This\n"},{"id":"349392","messageId":"20180605203906.GD158365@google.com","threadId":"48661","inReplyTo":"87o9gpynsp.fsf@evledraar.gmail.com","subject":"Re: [PATCH] docs: link to gitsubmodules","fromName":"Brandon Williams","fromEmail":"bmwill@google.com","sentAt":"2018-06-05T20:39:06Z","receivedAt":"2018-06-05T20:39:12Z","isPatch":true,"sender":{"key":"bwilliams.eng@gmail.com","avatar":null},"body":"On 06/05, Ævar Arnfjörð Bjarmason wrote:\n> \n> On Tue, Jun 05 2018, Brandon Williams wrote:\n> \n> > Add a link to gitsubmodules(7) under the `submodule.active` entry in\n> > git-config(1).\n> \n> Did you mean to change either the subject or content of this patch? Your\n> subject says gitsubmodules(7), but you link to git-submodule(1).\n\nYep I meant for it to be to gitsubmodules(7), turns out I don't know how\nour documentation is built :)\n\n-- \nBrandon Williams\n"},{"id":"349393","messageId":"20180605203953.GB9266@aiede.svl.corp.google.com","threadId":"48661","inReplyTo":"20180605203704.GA9266@aiede.svl.corp.google.com","subject":"Re: [PATCH] docs: link to gitsubmodules","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2018-06-05T20:39:53Z","receivedAt":"2018-06-05T20:40:00Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Jonathan Nieder wrote:\n\n> --- i/Documentation/config.txt\n> +++ w/Documentation/config.txt\n> @@ -3327,13 +3327,13 @@ submodule.<name>.ignore::\n>  submodule.<name>.active::\n>  \tBoolean value indicating if the submodule is of interest to git\n>  \tcommands.  This config option takes precedence over the\n> -\tsubmodule.active config option. See linkgit:git-submodule[1] for\n> +\tsubmodule.active config option. See linkgit:gitsubmodules[7] for\n>  \tdetails.\n>  \n>  submodule.active::\n>  \tA repeated field which contains a pathspec used to match against a\n>  \tsubmodule's path to determine if the submodule is of interest to git\n> -\tcommands. See linkgit:git-submodule[1] for details.\n> +\tcommands. See linkgit:gitsubmodule[7] for details.\n\nGah, and I can't spell.  This one should have been\nlinkgit:gitsubmodules[7].  Updated diff below.  Tested using\n\n\tmake -C Documentation/ git-config.html gitsubmodules.html\n\tw3m Documentation/git-config.html\n\nThanks and sorry for the noise,\nJonathan\n\ndiff --git i/Documentation/config.txt w/Documentation/config.txt\nindex 1277731aa4..340eb1f3c4 100644\n--- i/Documentation/config.txt\n+++ w/Documentation/config.txt\n@@ -3327,13 +3327,13 @@ submodule.<name>.ignore::\n submodule.<name>.active::\n \tBoolean value indicating if the submodule is of interest to git\n \tcommands.  This config option takes precedence over the\n-\tsubmodule.active config option. See linkgit:git-submodule[1] for\n+\tsubmodule.active config option. See linkgit:gitsubmodules[7] for\n \tdetails.\n \n submodule.active::\n \tA repeated field which contains a pathspec used to match against a\n \tsubmodule's path to determine if the submodule is of interest to git\n-\tcommands. See linkgit:git-submodule[1] for details.\n+\tcommands. See linkgit:gitsubmodules[7] for details.\n \n submodule.recurse::\n \tSpecifies if commands recurse into submodules by default. This\n"},{"id":"349394","messageId":"20180605204023.GE158365@google.com","threadId":"48661","inReplyTo":"20180605203953.GB9266@aiede.svl.corp.google.com","subject":"Re: [PATCH] docs: link to gitsubmodules","fromName":"Brandon Williams","fromEmail":"bmwill@google.com","sentAt":"2018-06-05T20:40:23Z","receivedAt":"2018-06-05T20:40:30Z","isPatch":true,"sender":{"key":"bwilliams.eng@gmail.com","avatar":null},"body":"On 06/05, Jonathan Nieder wrote:\n> Jonathan Nieder wrote:\n> \n> > --- i/Documentation/config.txt\n> > +++ w/Documentation/config.txt\n> > @@ -3327,13 +3327,13 @@ submodule.<name>.ignore::\n> >  submodule.<name>.active::\n> >  \tBoolean value indicating if the submodule is of interest to git\n> >  \tcommands.  This config option takes precedence over the\n> > -\tsubmodule.active config option. See linkgit:git-submodule[1] for\n> > +\tsubmodule.active config option. See linkgit:gitsubmodules[7] for\n> >  \tdetails.\n> >  \n> >  submodule.active::\n> >  \tA repeated field which contains a pathspec used to match against a\n> >  \tsubmodule's path to determine if the submodule is of interest to git\n> > -\tcommands. See linkgit:git-submodule[1] for details.\n> > +\tcommands. See linkgit:gitsubmodule[7] for details.\n> \n> Gah, and I can't spell.  This one should have been\n> linkgit:gitsubmodules[7].  Updated diff below.  Tested using\n> \n> \tmake -C Documentation/ git-config.html gitsubmodules.html\n> \tw3m Documentation/git-config.html\n> \n> Thanks and sorry for the noise,\n> Jonathan\n> \n> diff --git i/Documentation/config.txt w/Documentation/config.txt\n> index 1277731aa4..340eb1f3c4 100644\n> --- i/Documentation/config.txt\n> +++ w/Documentation/config.txt\n> @@ -3327,13 +3327,13 @@ submodule.<name>.ignore::\n>  submodule.<name>.active::\n>  \tBoolean value indicating if the submodule is of interest to git\n>  \tcommands.  This config option takes precedence over the\n> -\tsubmodule.active config option. See linkgit:git-submodule[1] for\n> +\tsubmodule.active config option. See linkgit:gitsubmodules[7] for\n>  \tdetails.\n>  \n>  submodule.active::\n>  \tA repeated field which contains a pathspec used to match against a\n>  \tsubmodule's path to determine if the submodule is of interest to git\n> -\tcommands. See linkgit:git-submodule[1] for details.\n> +\tcommands. See linkgit:gitsubmodules[7] for details.\n>  \n>  submodule.recurse::\n>  \tSpecifies if commands recurse into submodules by default. This\n\nYep this is what I meant.\n\n-- \nBrandon Williams\n"},{"id":"350609","messageId":"20180620215030.21829-1-bmwill@google.com","threadId":"48661","inReplyTo":"20180605202449.28810-1-bmwill@google.com","subject":"[PATCH v2] docs: link to gitsubmodules","fromName":"Brandon Williams","fromEmail":"bmwill@google.com","sentAt":"2018-06-20T21:50:30Z","receivedAt":"2018-06-20T21:50:38Z","isPatch":true,"sender":{"key":"bwilliams.eng@gmail.com","avatar":null},"body":"Add a link to gitsubmodules(7) under the `submodule.active` entry in\ngit-config(1).\n\nSigned-off-by: Brandon Williams <bmwill@google.com>\n---\n Documentation/config.txt | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)\n\ndiff --git a/Documentation/config.txt b/Documentation/config.txt\nindex ab641bf5a..340eb1f3c 100644\n--- a/Documentation/config.txt\n+++ b/Documentation/config.txt\n@@ -3327,12 +3327,13 @@ submodule.<name>.ignore::\n submodule.<name>.active::\n \tBoolean value indicating if the submodule is of interest to git\n \tcommands.  This config option takes precedence over the\n-\tsubmodule.active config option.\n+\tsubmodule.active config option. See linkgit:gitsubmodules[7] for\n+\tdetails.\n \n submodule.active::\n \tA repeated field which contains a pathspec used to match against a\n \tsubmodule's path to determine if the submodule is of interest to git\n-\tcommands.\n+\tcommands. See linkgit:gitsubmodules[7] for details.\n \n submodule.recurse::\n \tSpecifies if commands recurse into submodules by default. This\n-- \n2.18.0.rc1.244.gcf134e6275-goog\n\n"},{"id":"350677","messageId":"xmqqzhznrh55.fsf@gitster-ct.c.googlers.com","threadId":"48661","inReplyTo":"20180620215030.21829-1-bmwill@google.com","subject":"Re: [PATCH v2] docs: link to gitsubmodules","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2018-06-21T20:58:30Z","receivedAt":"2018-06-21T20:58:36Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Brandon Williams <bmwill@google.com> writes:\n\n> Add a link to gitsubmodules(7) under the `submodule.active` entry in\n> git-config(1).\n>\n> Signed-off-by: Brandon Williams <bmwill@google.com>\n> ---\n>  Documentation/config.txt | 5 +++--\n>  1 file changed, 3 insertions(+), 2 deletions(-)\n\nThanks.\n\n>\n> diff --git a/Documentation/config.txt b/Documentation/config.txt\n> index ab641bf5a..340eb1f3c 100644\n> --- a/Documentation/config.txt\n> +++ b/Documentation/config.txt\n> @@ -3327,12 +3327,13 @@ submodule.<name>.ignore::\n>  submodule.<name>.active::\n>  \tBoolean value indicating if the submodule is of interest to git\n>  \tcommands.  This config option takes precedence over the\n> -\tsubmodule.active config option.\n> +\tsubmodule.active config option. See linkgit:gitsubmodules[7] for\n> +\tdetails.\n>  \n>  submodule.active::\n>  \tA repeated field which contains a pathspec used to match against a\n>  \tsubmodule's path to determine if the submodule is of interest to git\n> -\tcommands.\n> +\tcommands. See linkgit:gitsubmodules[7] for details.\n>  \n>  submodule.recurse::\n>  \tSpecifies if commands recurse into submodules by default. This\n"}]}