{"thread":{"id":"48580","subject":"[PATCH] git-rebase--interactive: fix copy-paste mistake","startedAt":"2018-05-27T06:57:03Z","lastAt":"2018-05-28T13:18:56Z","messageCount":3,"participants":["Orgad Shaneh","Johannes Schindelin"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"348618","messageId":"CAGHpTBLGmApTGsjeP2d93CWH=OWBXmbPdRrGxaobFRcSjUiuYw@mail.gmail.com","threadId":"48580","inReplyTo":null,"subject":"[PATCH] git-rebase--interactive: fix copy-paste mistake","fromName":"Orgad Shaneh","fromEmail":"orgads@gmail.com","sentAt":"2018-05-27T06:51:27Z","receivedAt":"2018-05-27T06:57:03Z","isPatch":true,"sender":{"key":"orgads@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1246544?v=4"},"body":"exec argument is a command, not a commit.\n\nSigned-off-by: Orgad Shaneh <orgads@gmail.com>\n---\n  git-rebase--interactive.sh | 2 +-\n  1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh\nindex cbf44f8648..85a72b933e 100644\n--- a/git-rebase--interactive.sh\n+++ b/git-rebase--interactive.sh\n@@ -160,7 +160,7 @@ r, reword <commit> = use commit, but edit the commit\nmessage\n  e, edit <commit> = use commit, but stop for amending\n  s, squash <commit> = use commit, but meld into previous commit\n  f, fixup <commit> = like \\\"squash\\\", but discard this commit's log message\n-x, exec <commit> = run command (the rest of the line) using shell\n+x, exec <command> = run command (the rest of the line) using shell\n  d, drop <commit> = remove commit\n  l, label <label> = label current HEAD with a name\n  t, reset <label> = reset HEAD to a label\n-- \n2.17.0.windows.1\n"},{"id":"348664","messageId":"nycvar.QRO.7.76.6.1805281455210.82@tvgsbejvaqbjf.bet","threadId":"48580","inReplyTo":"CAGHpTBLGmApTGsjeP2d93CWH=OWBXmbPdRrGxaobFRcSjUiuYw@mail.gmail.com","subject":"Re: [PATCH] git-rebase--interactive: fix copy-paste mistake","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2018-05-28T12:56:52Z","receivedAt":"2018-05-28T12:56:59Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Orgad,\n\nOn Sun, 27 May 2018, Orgad Shaneh wrote:\n\n> exec argument is a command, not a commit.\n> \n> Signed-off-by: Orgad Shaneh <orgads@gmail.com>\n> ---\n>   git-rebase--interactive.sh | 2 +-\n>   1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh\n> index cbf44f8648..85a72b933e 100644\n> --- a/git-rebase--interactive.sh\n> +++ b/git-rebase--interactive.sh\n> @@ -160,7 +160,7 @@ r, reword <commit> = use commit, but edit the commit\n> message\n>   e, edit <commit> = use commit, but stop for amending\n>   s, squash <commit> = use commit, but meld into previous commit\n>   f, fixup <commit> = like \\\"squash\\\", but discard this commit's log message\n> -x, exec <commit> = run command (the rest of the line) using shell\n> +x, exec <command> = run command (the rest of the line) using shell\n\nApart from the white-space (which I *think* might make `git apply` barf on\nthis diff), this looks obviously correct to me.\n\nTo make it easier for Junio, maybe you can provide a link to a branch in a\npublic repository, ready to be fetched?\n\n>   d, drop <commit> = remove commit\n>   l, label <label> = label current HEAD with a name\n>   t, reset <label> = reset HEAD to a label\n> -- \n> 2.17.0.windows.1\n\nThank you for cleaning up my mess,\nDscho\n"},{"id":"348666","messageId":"CAGHpTBK-=Q51m37GYJOD4D8wLAOcg=nXD4H8GMfPnDJh8Ld4Yw@mail.gmail.com","threadId":"48580","inReplyTo":"nycvar.QRO.7.76.6.1805281455210.82@tvgsbejvaqbjf.bet","subject":"Re: [PATCH] git-rebase--interactive: fix copy-paste mistake","fromName":"Orgad Shaneh","fromEmail":"orgads@gmail.com","sentAt":"2018-05-28T13:16:39Z","receivedAt":"2018-05-28T13:18:56Z","isPatch":true,"sender":{"key":"orgads@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1246544?v=4"},"body":"On Mon, May 28, 2018 at 3:56 PM Johannes Schindelin <\nJohannes.Schindelin@gmx.de> wrote:\n\n> Hi Orgad,\n\n> On Sun, 27 May 2018, Orgad Shaneh wrote:\n\n> > exec argument is a command, not a commit.\n> >\n> > Signed-off-by: Orgad Shaneh <orgads@gmail.com>\n> > ---\n> >   git-rebase--interactive.sh | 2 +-\n> >   1 file changed, 1 insertion(+), 1 deletion(-)\n> >\n> > diff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh\n> > index cbf44f8648..85a72b933e 100644\n> > --- a/git-rebase--interactive.sh\n> > +++ b/git-rebase--interactive.sh\n> > @@ -160,7 +160,7 @@ r, reword <commit> = use commit, but edit the commit\n> > message\n> >   e, edit <commit> = use commit, but stop for amending\n> >   s, squash <commit> = use commit, but meld into previous commit\n> >   f, fixup <commit> = like \\\"squash\\\", but discard this commit's log\nmessage\n> > -x, exec <commit> = run command (the rest of the line) using shell\n> > +x, exec <command> = run command (the rest of the line) using shell\n\n> Apart from the white-space (which I *think* might make `git apply` barf on\n> this diff), this looks obviously correct to me.\n\nI'm behind a firewall, so I just pasted the patch in gmail, hoping it will\npass correctly :)\n\n> To make it easier for Junio, maybe you can provide a link to a branch in a\n> public repository, ready to be fetched?\n\nPushed to https://github.com/orgads/git -> exec-description branch.\n\n> Thank you for cleaning up my mess,\n\nNo prob :)\n\n- Orgad\n"}]}