{"thread":{"id":"48576","subject":"[PATCH] t990X: use '.git/objects' as 'deep inside .git' path","startedAt":"2018-05-26T06:51:14Z","lastAt":"2018-05-29T11:58:10Z","messageCount":3,"participants":["Christian Couder","Michael Haggerty","Derrick Stolee"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"348581","messageId":"20180526064745.20199-1-chriscool@tuxfamily.org","threadId":"48576","inReplyTo":null,"subject":"[PATCH] t990X: use '.git/objects' as 'deep inside .git' path","fromName":"Christian Couder","fromEmail":"christian.couder@gmail.com","sentAt":"2018-05-26T06:47:45Z","receivedAt":"2018-05-26T06:51:14Z","isPatch":true,"sender":{"key":"christian.couder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/208954?v=4"},"body":"Tests t9902-completion.sh and t9903-bash-prompt.sh each have tests\nthat check what happens when we are \"in the '.git' directory\" and\nwhen we are \"deep inside the '.git' directory\".\n\nTo test the case when we are \"deep inside the '.git' directory\" the\ntest scripts used to perform a `cd .git/refs/heads`.\n\nAs there are plans to implement other ref storage systems, let's\nuse '.git/objects' instead of '.git/refs/heads' as the \"deep inside\nthe '.git' directory\" path.\n\nThis makes it clear to readers that these tests do not depend on\nwhich ref backend is used.\n\nThe internals of the loose refs backend are still tested in\nt1400-update-ref.sh.\n\nHelped-by: SZEDER Gábor <szeder.dev@gmail.com>\nSigned-off-by: David Turner <dturner@twopensource.com>\nSigned-off-by: Christian Couder <chriscool@tuxfamily.org>\n---\n t/t9902-completion.sh  | 2 +-\n t/t9903-bash-prompt.sh | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/t/t9902-completion.sh b/t/t9902-completion.sh\nindex 36deb0b123..a28640ce1a 100755\n--- a/t/t9902-completion.sh\n+++ b/t/t9902-completion.sh\n@@ -181,7 +181,7 @@ test_expect_success '__git_find_repo_path - cwd is a .git directory' '\n test_expect_success '__git_find_repo_path - parent is a .git directory' '\n \techo \"$ROOT/.git\" >expected &&\n \t(\n-\t\tcd .git/refs/heads &&\n+\t\tcd .git/objects &&\n \t\t__git_find_repo_path &&\n \t\techo \"$__git_repo_path\" >\"$actual\"\n \t) &&\ndiff --git a/t/t9903-bash-prompt.sh b/t/t9903-bash-prompt.sh\nindex 8f5c811dd7..c3b89ae783 100755\n--- a/t/t9903-bash-prompt.sh\n+++ b/t/t9903-bash-prompt.sh\n@@ -148,7 +148,7 @@ test_expect_success 'prompt - inside .git directory' '\n test_expect_success 'prompt - deep inside .git directory' '\n \tprintf \" (GIT_DIR!)\" >expected &&\n \t(\n-\t\tcd .git/refs/heads &&\n+\t\tcd .git/objects &&\n \t\t__git_ps1 >\"$actual\"\n \t) &&\n \ttest_cmp expected \"$actual\"\n-- \n2.17.0.1181.g093e983b05.dirty\n\n"},{"id":"348616","messageId":"CAMy9T_H7OVJoDQGFNnM-GrCE9jhSqNDALFL1TM45TMcwPx5nnQ@mail.gmail.com","threadId":"48576","inReplyTo":"20180526064745.20199-1-chriscool@tuxfamily.org","subject":"Re: [PATCH] t990X: use '.git/objects' as 'deep inside .git' path","fromName":"Michael Haggerty","fromEmail":"mhagger@alum.mit.edu","sentAt":"2018-05-27T04:49:38Z","receivedAt":"2018-05-27T05:33:02Z","isPatch":true,"sender":{"key":"mhagger@alum.mit.edu","avatar":"https://avatars.githubusercontent.com/u/119718?v=4"},"body":"On Sat, May 26, 2018 at 8:47 AM, Christian Couder\n<christian.couder@gmail.com> wrote:\n> Tests t9902-completion.sh and t9903-bash-prompt.sh each have tests\n> that check what happens when we are \"in the '.git' directory\" and\n> when we are \"deep inside the '.git' directory\".\n>\n> To test the case when we are \"deep inside the '.git' directory\" the\n> test scripts used to perform a `cd .git/refs/heads`.\n>\n> As there are plans to implement other ref storage systems, let's\n> use '.git/objects' instead of '.git/refs/heads' as the \"deep inside\n> the '.git' directory\" path.\n\nSeems reasonable to me. +1.\n\nMichael\n"},{"id":"348695","messageId":"50c85752-7000-880e-ebfd-44b8e7f71028@gmail.com","threadId":"48576","inReplyTo":"CAMy9T_H7OVJoDQGFNnM-GrCE9jhSqNDALFL1TM45TMcwPx5nnQ@mail.gmail.com","subject":"Re: [PATCH] t990X: use '.git/objects' as 'deep inside .git' path","fromName":"Derrick Stolee","fromEmail":"stolee@gmail.com","sentAt":"2018-05-29T11:58:03Z","receivedAt":"2018-05-29T11:58:10Z","isPatch":true,"sender":{"key":"stolee@gmail.com","avatar":"https://avatars.githubusercontent.com/u/570044?v=4"},"body":"On 5/27/2018 12:49 AM, Michael Haggerty wrote:\n> On Sat, May 26, 2018 at 8:47 AM, Christian Couder\n> <christian.couder@gmail.com> wrote:\n>> Tests t9902-completion.sh and t9903-bash-prompt.sh each have tests\n>> that check what happens when we are \"in the '.git' directory\" and\n>> when we are \"deep inside the '.git' directory\".\n>>\n>> To test the case when we are \"deep inside the '.git' directory\" the\n>> test scripts used to perform a `cd .git/refs/heads`.\n>>\n>> As there are plans to implement other ref storage systems, let's\n>> use '.git/objects' instead of '.git/refs/heads' as the \"deep inside\n>> the '.git' directory\" path.\n> Seems reasonable to me. +1.\n>\n> Michael\nLooks good to me, too.\n\nThanks,\n-Stolee\n"}]}