{"thread":{"id":"48571","subject":"[PATCH] completion: complete remote names too","startedAt":"2018-05-25T10:48:57Z","lastAt":"2018-06-04T08:20:57Z","messageCount":4,"participants":["Łukasz Stelmach","Junio C Hamano","Duy Nguyen"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"348534","messageId":"20180525104842.2930-1-l.stelmach@samsung.com","threadId":"48571","inReplyTo":"CGME20180525104848eucas1p28c88d657362066ea26d4eedaaef71f90@eucas1p2.samsung.com","subject":"[PATCH] completion: complete remote names too","fromName":"Łukasz Stelmach","fromEmail":"l.stelmach@samsung.com","sentAt":"2018-05-25T10:48:42Z","receivedAt":"2018-05-25T10:48:57Z","isPatch":true,"sender":{"key":"l.stelmach@samsung.com","avatar":"https://gravatar.com/avatar/b5f9262ad19b1b6f1e74b8eba816455e059742e8d980fdefa9321976071642fc?d=mp&s=160"},"body":"\"git remote update\" accepts both groups and single remotes.\n\nSigned-off-by: Łukasz Stelmach \n---\n contrib/completion/git-completion.bash | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex 961a0ed76..fb05bb2f9 100644\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -2632,7 +2632,7 @@ _git_remote ()\n \t\t__gitcomp_builtin remote_update\n \t\t;;\n \tupdate,*)\n-\t\t__gitcomp \"$(__git_get_config_variables \"remotes\")\"\n+\t\t__gitcomp \"$(__git_remotes) $(__git_get_config_variables \"remotes\")\"\n \t\t;;\n \tset-url,--*)\n \t\t__gitcomp_builtin remote_set-url\n-- \n2.11.0\n\n"},{"id":"348781","messageId":"xmqqefhtera4.fsf@gitster-ct.c.googlers.com","threadId":"48571","inReplyTo":"20180525104842.2930-1-l.stelmach@samsung.com","subject":"Re: [PATCH] completion: complete remote names too","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2018-05-30T03:49:55Z","receivedAt":"2018-05-30T03:50:01Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Łukasz Stelmach writes:\n\n> \"git remote update\" accepts both groups and single remotes.\n>\n> Signed-off-by: Łukasz Stelmach \n> ---\n> contrib/completion/git-completion.bash | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n\nSoliciting comments from usual suspects around this area...\n\nThanks.\n\n> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\n> index 961a0ed76..fb05bb2f9 100644\n> --- a/contrib/completion/git-completion.bash\n> +++ b/contrib/completion/git-completion.bash\n> @@ -2632,7 +2632,7 @@ _git_remote ()\n> \t\t__gitcomp_builtin remote_update\n> \t\t;;\n> \tupdate,*)\n> -\t\t__gitcomp \"$(__git_get_config_variables \"remotes\")\"\n> +\t\t__gitcomp \"$(__git_remotes) $(__git_get_config_variables \"remotes\")\"\n> \t\t;;\n> \tset-url,--*)\n> \t\t__gitcomp_builtin remote_set-url\n"},{"id":"348809","messageId":"20180530153701.GA23809@duynguyen.home","threadId":"48571","inReplyTo":"20180525104842.2930-1-l.stelmach@samsung.com","subject":"Re: [PATCH] completion: complete remote names too","fromName":"Duy Nguyen","fromEmail":"pclouds@gmail.com","sentAt":"2018-05-30T15:37:01Z","receivedAt":"2018-05-30T15:37:09Z","isPatch":true,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"On Fri, May 25, 2018 at 12:48:42PM +0200, Łukasz Stelmach wrote:\n> \"git remote update\" accepts both groups and single remotes.\n> \n> Signed-off-by: Łukasz Stelmach \n> ---\n> contrib/completion/git-completion.bash | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\n> index 961a0ed76..fb05bb2f9 100644\n> --- a/contrib/completion/git-completion.bash\n> +++ b/contrib/completion/git-completion.bash\n> @@ -2632,7 +2632,7 @@ _git_remote ()\n> \t\t__gitcomp_builtin remote_update\n> \t\t;;\n> \tupdate,*)\n> -\t\t__gitcomp \"$(__git_get_config_variables \"remotes\")\"\n> +\t\t__gitcomp \"$(__git_remotes) $(__git_get_config_variables \"remotes\")\"\n\nReviewed-by: me.\n\nThe short commit description actually made me curious, which led to\nmore digging and finally this follow up patch.\n\n-- 8< --\nSubject: [PATCH] remote.txt: update documentation for 'update' command\n\nCommit b344e1614b (git remote update: Fallback to remote if group does\nnot exist - 2009-04-06) lets \"git remote update\" accept individual\nremotes as well. Previously this command only accepted remote\ngroups. The commit updates the command syntax but not the actual\ndocument of this subcommand. Update it.\n\nSigned-off-by: Nguyễn Thái Ngọc Duy \n---\n Documentation/git-remote.txt | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/Documentation/git-remote.txt b/Documentation/git-remote.txt\nindex 595948da53..dd38587168 100644\n--- a/Documentation/git-remote.txt\n+++ b/Documentation/git-remote.txt\n@@ -186,8 +186,8 @@ actually prune them.\n \n 'update'::\n \n-Fetch updates for a named set of remotes in the repository as defined by\n-remotes.. If a named group is not specified on the command line,\n+Fetch updates for remotes or remote groups in the repository as defined by\n+remotes.. If no group or remote is not specified on the command line,\n the configuration parameter remotes.default will be used; if\n remotes.default is not defined, all remotes which do not have the\n configuration parameter remote..skipDefaultUpdate set to true will\n-- \n2.17.0.705.g3525833791\n\n-- 8< --\n"},{"id":"349221","messageId":"20180604082049eucas1p1a81cdb5ae39a76d4421ccdbce4dcdbba~050M1aPTC1920019200eucas1p1R@eucas1p1.samsung.com","threadId":"48571","inReplyTo":"20180530153701.GA23809@duynguyen.home","subject":"Re: [PATCH] completion: complete remote names too","fromName":"Łukasz Stelmach","fromEmail":"l.stelmach@samsung.com","sentAt":"2018-06-04T08:20:22Z","receivedAt":"2018-06-04T08:20:57Z","isPatch":true,"sender":{"key":"l.stelmach@samsung.com","avatar":"https://gravatar.com/avatar/b5f9262ad19b1b6f1e74b8eba816455e059742e8d980fdefa9321976071642fc?d=mp&s=160"},"body":"It was <2018-05-30 śro 17:37>, when Duy Nguyen wrote:\n> On Fri, May 25, 2018 at 12:48:42PM +0200, Łukasz Stelmach wrote:\n>> \"git remote update\" accepts both groups and single remotes.\n>> \n>> Signed-off-by: Łukasz Stelmach \n>> ---\n>> contrib/completion/git-completion.bash | 2 +-\n>> 1 file changed, 1 insertion(+), 1 deletion(-)\n>> \n>> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\n>> index 961a0ed76..fb05bb2f9 100644\n>> --- a/contrib/completion/git-completion.bash\n>> +++ b/contrib/completion/git-completion.bash\n>> @@ -2632,7 +2632,7 @@ _git_remote ()\n>> \t\t__gitcomp_builtin remote_update\n>> \t\t;;\n>> \tupdate,*)\n>> -\t\t__gitcomp \"$(__git_get_config_variables \"remotes\")\"\n>> +\t\t__gitcomp \"$(__git_remotes) $(__git_get_config_variables \"remotes\")\"\n>\n> Reviewed-by: me.\n>\n> The short commit description actually made me curious, which led to\n> more digging and finally this follow up patch.\n>\n> -- 8< --\n> Subject: [PATCH] remote.txt: update documentation for 'update' command\n>\n> Commit b344e1614b (git remote update: Fallback to remote if group does\n> not exist - 2009-04-06) lets \"git remote update\" accept individual\n> remotes as well. Previously this command only accepted remote\n> groups. The commit updates the command syntax but not the actual\n> document of this subcommand. Update it.\n>\n> Signed-off-by: Nguyễn Thái Ngọc Duy \n> ---\n> Documentation/git-remote.txt | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/Documentation/git-remote.txt b/Documentation/git-remote.txt\n> index 595948da53..dd38587168 100644\n> --- a/Documentation/git-remote.txt\n> +++ b/Documentation/git-remote.txt\n> @@ -186,8 +186,8 @@ actually prune them.\n> \n> 'update'::\n> \n> -Fetch updates for a named set of remotes in the repository as defined by\n> -remotes.. If a named group is not specified on the command line,\n> +Fetch updates for remotes or remote groups in the repository as defined by\n> +remotes.. If no group or remote is not specified on the command line,\n\nIf neither group nor remote is specified on the command line,\n\n> the configuration parameter remotes.default will be used; if\n> remotes.default is not defined, all remotes which do not have the\n> configuration parameter remote..skipDefaultUpdate set to true will\n\n-- \nŁukasz Stelmach\nSamsung R&D Institute Poland\nSamsung Electronics\n"}]}