{"thread":{"id":"48542","subject":"[PATCH] Doc: Mention core.excludesFile in \"man git-clean\"","startedAt":"2018-05-22T07:49:51Z","lastAt":"2018-05-23T01:48:22Z","messageCount":2,"participants":["Robert P. J. Day","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"348285","messageId":"alpine.LFD.2.21.1805220345150.749@localhost.localdomain","threadId":"48542","inReplyTo":null,"subject":"[PATCH] Doc: Mention core.excludesFile in \"man git-clean\"","fromName":"Robert P. J. Day","fromEmail":"rpjday@crashcourse.ca","sentAt":"2018-05-22T07:48:13Z","receivedAt":"2018-05-22T07:49:51Z","isPatch":true,"sender":{"key":"rpjday@crashcourse.ca","avatar":"https://avatars.githubusercontent.com/u/226084077?v=4"},"body":"\nAdd a reference to the configuration setting \"core.excludesFile\" to\nthe man page for git-clean.\n\nSigned-off-by: Robert P. J. Day <rpjday@crashcourse.ca>\n\n---\n\ndiff --git a/Documentation/git-clean.txt b/Documentation/git-clean.txt\nindex 03056dad0..449cbc2af 100644\n--- a/Documentation/git-clean.txt\n+++ b/Documentation/git-clean.txt\n@@ -55,13 +55,15 @@ OPTIONS\n\n -e <pattern>::\n --exclude=<pattern>::\n-\tIn addition to those found in .gitignore (per directory) and\n-\t$GIT_DIR/info/exclude, also consider these patterns to be in the\n-\tset of the ignore rules in effect.\n+\tIn addition to patterns found in any of .gitignore (per directory),\n+\t$GIT_DIR/info/exclude and the exclude file specified by the\n+\tconfiguration variable core.excludesFile, also consider these\n+\tpatterns to be in the set of the ignore rules in effect.\n\n -x::\n \tDon't use the standard ignore rules read from .gitignore (per\n-\tdirectory) and $GIT_DIR/info/exclude, but do still use the ignore\n+\tdirectory), $GIT_DIR/info/exclude and the exclude file specified\n+\tby core.excludesFile, but do still use the ignore\n \trules given with `-e` options.  This allows removing all untracked\n \tfiles, including build products.  This can be used (possibly in\n \tconjunction with 'git reset') to create a pristine\n\n-- \n\n========================================================================\nRobert P. J. Day                                 Ottawa, Ontario, CANADA\n                        http://crashcourse.ca\n\nTwitter:                                       http://twitter.com/rpjday\nLinkedIn:                               http://ca.linkedin.com/in/rpjday\n========================================================================\n"},{"id":"348342","messageId":"xmqqsh6jw3a8.fsf@gitster-ct.c.googlers.com","threadId":"48542","inReplyTo":"alpine.LFD.2.21.1805220345150.749@localhost.localdomain","subject":"Re: [PATCH] Doc: Mention core.excludesFile in \"man git-clean\"","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2018-05-23T01:48:15Z","receivedAt":"2018-05-23T01:48:22Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Robert P. J. Day\" <rpjday@crashcourse.ca> writes:\n\n> Add a reference to the configuration setting \"core.excludesFile\" to\n> the man page for git-clean.\n>\n> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>\n>\n> ---\n\nI understand that you are trying to reduce the source of the\nconfusion you felt, which comes from mentioning only per-directory\n.gitignore and per-repository info/exclude, but I am not sure if the\nproposed solution is a good one that learned from our past mistakes.\n\nWouldn't it make more sense to _avoid_ appearing as if we are giving\na complete list and refer those who want a single authoritative list\nto the source?  For example\n\n\tIn addition to those found in standard places for exclude\n\tpatterns such as `.gitignore` (cf. linkgit:gitignore[5]),\n\talso consider these patterns...\n\nAfter all, having an incomplete list and not hinting that it is\nincomplete is what made you react to the current description.  It is\nunlikely that we stop treating `.gitignore` as one of the standard\nplaces, so phrasing like above will have a lot smaller chance to go\nstale, even accounting for the possibility that we will grow Git\nover time and the standard parttern sources may be updated in the\nfuture.\n\n>\n> diff --git a/Documentation/git-clean.txt b/Documentation/git-clean.txt\n> index 03056dad0..449cbc2af 100644\n> --- a/Documentation/git-clean.txt\n> +++ b/Documentation/git-clean.txt\n> @@ -55,13 +55,15 @@ OPTIONS\n>\n>  -e <pattern>::\n>  --exclude=<pattern>::\n> -\tIn addition to those found in .gitignore (per directory) and\n> -\t$GIT_DIR/info/exclude, also consider these patterns to be in the\n> -\tset of the ignore rules in effect.\n> +\tIn addition to patterns found in any of .gitignore (per directory),\n> +\t$GIT_DIR/info/exclude and the exclude file specified by the\n> +\tconfiguration variable core.excludesFile, also consider these\n> +\tpatterns to be in the set of the ignore rules in effect.\n>\n>  -x::\n>  \tDon't use the standard ignore rules read from .gitignore (per\n> -\tdirectory) and $GIT_DIR/info/exclude, but do still use the ignore\n> +\tdirectory), $GIT_DIR/info/exclude and the exclude file specified\n> +\tby core.excludesFile, but do still use the ignore\n>  \trules given with `-e` options.  This allows removing all untracked\n>  \tfiles, including build products.  This can be used (possibly in\n>  \tconjunction with 'git reset') to create a pristine\n"}]}