{"thread":{"id":"48512","subject":"[PATCH 0/1] Hot fix for js/empty-config-section-fix","startedAt":"2018-05-17T21:47:16Z","lastAt":"2018-05-17T23:00:32Z","messageCount":3,"participants":["Johannes Schindelin","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":1},"messages":[{"id":"347933","messageId":"cover.1526593623.git.johannes.schindelin@gmx.de","threadId":"48512","inReplyTo":null,"subject":"[PATCH 0/1] Hot fix for js/empty-config-section-fix","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2018-05-17T21:47:04Z","receivedAt":"2018-05-17T21:47:16Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"In https://public-inbox.org/git/20180508134248.GA25513@sigill.intra.peff.net/\nJeff King pointed out that an invalid config section is not an indicator\nof a bug, as it is usually provided by the user.\n\nSo we should not throw a fit and tell the user about a bug that they\nmight even report.\n\nInstead, let's just error out.\n\n\nJohannes Schindelin (1):\n  config: a user-provided invalid section is not a BUG\n\n config.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\n\nbase-commit: ccdcbd54c4475c2238b310f7113ab3075b5abc9c\nPublished-As: https://github.com/dscho/git/releases/tag/empty-config-section-fix-v1\nFetch-It-Via: git fetch https://github.com/dscho/git empty-config-section-fix-v1\n-- \n2.17.0.windows.1.42.gaba71d8cd65\n\n"},{"id":"347934","messageId":"7559f3e7e1e5858b0f50afd53da5aafb683b9828.1526593623.git.johannes.schindelin@gmx.de","threadId":"48512","inReplyTo":"cover.1526593623.git.johannes.schindelin@gmx.de","subject":"[PATCH 1/1] config: a user-provided invalid section is not a BUG","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2018-05-17T21:47:06Z","receivedAt":"2018-05-17T21:47:19Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"This was pointed out by Jeff King while the empty-config-section-fix\npatch series was cooking, and was not addressed in time for that patch\nseries to advance to `master`.\n\nSigned-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>\n---\n config.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/config.c b/config.c\nindex 6f8f1d8c113..2392a8076b7 100644\n--- a/config.c\n+++ b/config.c\n@@ -2359,7 +2359,7 @@ static int store_aux_event(enum config_event_t type,\n \n \tif (type == CONFIG_EVENT_SECTION) {\n \t\tif (cf->var.len < 2 || cf->var.buf[cf->var.len - 1] != '.')\n-\t\t\tBUG(\"Invalid section name '%s'\", cf->var.buf);\n+\t\t\treturn error(\"invalid section name '%s'\", cf->var.buf);\n \n \t\t/* Is this the section we were looking for? */\n \t\tstore->is_keys_section =\n-- \n2.17.0.windows.1.42.gaba71d8cd65\n"},{"id":"347964","messageId":"xmqqy3gh51md.fsf@gitster-ct.c.googlers.com","threadId":"48512","inReplyTo":"cover.1526593623.git.johannes.schindelin@gmx.de","subject":"Re: [PATCH 0/1] Hot fix for js/empty-config-section-fix","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2018-05-17T23:00:26Z","receivedAt":"2018-05-17T23:00:32Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Johannes Schindelin <johannes.schindelin@gmx.de> writes:\n\n> In https://public-inbox.org/git/20180508134248.GA25513@sigill.intra.peff.net/\n> Jeff King pointed out that an invalid config section is not an indicator\n> of a bug, as it is usually provided by the user.\n>\n> So we should not throw a fit and tell the user about a bug that they\n> might even report.\n>\n> Instead, let's just error out.\n\nYeah, makes sense.  Thanks for a prompt fix-up.\n\n\n>\n>\n> Johannes Schindelin (1):\n>   config: a user-provided invalid section is not a BUG\n>\n>  config.c | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n>\n> base-commit: ccdcbd54c4475c2238b310f7113ab3075b5abc9c\n> Published-As: https://github.com/dscho/git/releases/tag/empty-config-section-fix-v1\n> Fetch-It-Via: git fetch https://github.com/dscho/git empty-config-section-fix-v1\n"}]}