{"thread":{"id":"48479","subject":"[PATCH] travis-ci: run gcc-7 on linux-gcc jobs","startedAt":"2018-05-13T09:18:02Z","lastAt":"2018-05-21T06:46:38Z","messageCount":4,"participants":["Nguyễn Thái Ngọc Duy","Thomas Braun","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"347533","messageId":"20180513091752.14003-1-pclouds@gmail.com","threadId":"48479","inReplyTo":null,"subject":"[PATCH] travis-ci: run gcc-7 on linux-gcc jobs","fromName":"Nguyễn Thái Ngọc Duy","fromEmail":"pclouds@gmail.com","sentAt":"2018-05-13T09:17:51Z","receivedAt":"2018-05-13T09:18:02Z","isPatch":true,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"Switch from gcc-4.8 to gcc-7. Newer compilers come with more warning\nchecks (usually in -Wextra).  Since -Wextra is enabled in developer\nmode (which is also enabled in travis), this lets travis report more\nwarnings before other people do it.\n\nSigned-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>\n---\n .travis.yml        | 3 +++\n ci/lib-travisci.sh | 3 +++\n 2 files changed, 6 insertions(+)\n\ndiff --git a/.travis.yml b/.travis.yml\nindex 5f5ee4f3bd..a77f5f5bd5 100644\n--- a/.travis.yml\n+++ b/.travis.yml\n@@ -16,10 +16,13 @@ compiler:\n \n addons:\n   apt:\n+    sources:\n+    - ubuntu-toolchain-r-test\n     packages:\n     - language-pack-is\n     - git-svn\n     - apache2\n+    - gcc-7\n \n matrix:\n   include:\ndiff --git a/ci/lib-travisci.sh b/ci/lib-travisci.sh\nindex 109ef280da..ef2848fd45 100755\n--- a/ci/lib-travisci.sh\n+++ b/ci/lib-travisci.sh\n@@ -99,6 +99,9 @@ export DEFAULT_TEST_TARGET=prove\n export GIT_PROVE_OPTS=\"--timer --jobs 3 --state=failed,slow,save\"\n export GIT_TEST_OPTS=\"--verbose-log -x\"\n export GIT_TEST_CLONE_2GB=YesPlease\n+if [ \"$jobname\" = linux-gcc ]; then\n+\texport CC=gcc-7\n+fi\n \n case \"$jobname\" in\n linux-clang|linux-gcc)\n-- \n2.17.0.705.g3525833791\n\n"},{"id":"347546","messageId":"10b243d8-fc81-a172-768d-9b47e94a24b0@virtuell-zuhause.de","threadId":"48479","inReplyTo":"20180513091752.14003-1-pclouds@gmail.com","subject":"Re: [PATCH] travis-ci: run gcc-7 on linux-gcc jobs","fromName":"Thomas Braun","fromEmail":"thomas.braun@virtuell-zuhause.de","sentAt":"2018-05-13T12:45:27Z","receivedAt":"2018-05-13T13:22:12Z","isPatch":true,"sender":{"key":"thomas.braun@virtuell-zuhause.de","avatar":"https://avatars.githubusercontent.com/u/1185677?v=4"},"body":"Am 13.05.2018 um 11:17 schrieb Nguyễn Thái Ngọc Duy:\n> Switch from gcc-4.8 to gcc-7. Newer compilers come with more warning\n> checks (usually in -Wextra).  Since -Wextra is enabled in developer\n> mode (which is also enabled in travis), this lets travis report more\n> warnings before other people do it.\n> \n> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>\n> ---\n>  .travis.yml        | 3 +++\n>  ci/lib-travisci.sh | 3 +++\n>  2 files changed, 6 insertions(+)\n> \n> diff --git a/.travis.yml b/.travis.yml\n> index 5f5ee4f3bd..a77f5f5bd5 100644\n> --- a/.travis.yml\n> +++ b/.travis.yml\n> @@ -16,10 +16,13 @@ compiler:\n>  \n>  addons:\n>    apt:\n> +    sources:\n> +    - ubuntu-toolchain-r-test\n>      packages:\n>      - language-pack-is\n>      - git-svn\n>      - apache2\n> +    - gcc-7\n\nYou could also use gcc-8 here as that is already present according to [1].\n\n[1]:\nhttps://launchpad.net/~ubuntu-toolchain-r/+archive/ubuntu/test/+packages\n\n>  matrix:\n>    include:\n> diff --git a/ci/lib-travisci.sh b/ci/lib-travisci.sh\n> index 109ef280da..ef2848fd45 100755\n> --- a/ci/lib-travisci.sh\n> +++ b/ci/lib-travisci.sh\n> @@ -99,6 +99,9 @@ export DEFAULT_TEST_TARGET=prove\n>  export GIT_PROVE_OPTS=\"--timer --jobs 3 --state=failed,slow,save\"\n>  export GIT_TEST_OPTS=\"--verbose-log -x\"\n>  export GIT_TEST_CLONE_2GB=YesPlease\n> +if [ \"$jobname\" = linux-gcc ]; then\n> +\texport CC=gcc-7\n> +fi\n>  \n>  case \"$jobname\" in\n>  linux-clang|linux-gcc)\n> \n\n"},{"id":"348046","messageId":"20180519043234.9260-1-pclouds@gmail.com","threadId":"48479","inReplyTo":"20180513091752.14003-1-pclouds@gmail.com","subject":"[PATCH v2] travis-ci: run gcc-8 on linux-gcc jobs","fromName":"Nguyễn Thái Ngọc Duy","fromEmail":"pclouds@gmail.com","sentAt":"2018-05-19T04:32:34Z","receivedAt":"2018-05-19T04:32:42Z","isPatch":true,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"Switch from gcc-4.8 to gcc-8. Newer compilers come with more warning\nchecks (usually in -Wextra).  Since -Wextra is enabled in developer\nmode (which is also enabled in travis), this lets travis report more\nwarnings before other people do it.\n\nSigned-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>\n---\n v2 switches from gcc-7 to gcc-8. I initially ignored gcc 8 because it\n was too new. But it built 'pu' ok and 8.1 was already out so the\n first wave of bugs should have been gone by now.\n\n .travis.yml        | 3 +++\n ci/lib-travisci.sh | 3 +++\n 2 files changed, 6 insertions(+)\n\ndiff --git a/.travis.yml b/.travis.yml\nindex 5f5ee4f3bd..4d4e26c9df 100644\n--- a/.travis.yml\n+++ b/.travis.yml\n@@ -16,10 +16,13 @@ compiler:\n \n addons:\n   apt:\n+    sources:\n+    - ubuntu-toolchain-r-test\n     packages:\n     - language-pack-is\n     - git-svn\n     - apache2\n+    - gcc-8\n \n matrix:\n   include:\ndiff --git a/ci/lib-travisci.sh b/ci/lib-travisci.sh\nindex 109ef280da..ceecc889ca 100755\n--- a/ci/lib-travisci.sh\n+++ b/ci/lib-travisci.sh\n@@ -99,6 +99,9 @@ export DEFAULT_TEST_TARGET=prove\n export GIT_PROVE_OPTS=\"--timer --jobs 3 --state=failed,slow,save\"\n export GIT_TEST_OPTS=\"--verbose-log -x\"\n export GIT_TEST_CLONE_2GB=YesPlease\n+if [ \"$jobname\" = linux-gcc ]; then\n+\texport CC=gcc-8\n+fi\n \n case \"$jobname\" in\n linux-clang|linux-gcc)\n-- \n2.17.0.705.g3525833791\n\n"},{"id":"348181","messageId":"xmqqmuwt1p6f.fsf@gitster-ct.c.googlers.com","threadId":"48479","inReplyTo":"20180519043234.9260-1-pclouds@gmail.com","subject":"Re: [PATCH v2] travis-ci: run gcc-8 on linux-gcc jobs","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2018-05-21T06:46:32Z","receivedAt":"2018-05-21T06:46:38Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:\n\n>  v2 switches from gcc-7 to gcc-8. I initially ignored gcc 8 because it\n>  was too new. But it built 'pu' ok and 8.1 was already out so the\n>  first wave of bugs should have been gone by now.\n\nI also liked the choice to ignore v8 for the same reason, but if it\nis already mature (or maturing enough), let's use it.\n"}]}