{"thread":{"id":"48362","subject":"[PATCH 0/3] enable userdiff for more things in git.git","startedAt":"2018-04-26T07:51:12Z","lastAt":"2018-04-26T09:43:30Z","messageCount":5,"participants":["Ævar Arnfjörð Bjarmason","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":3},"messages":[{"id":"345881","messageId":"20180426075058.9322-1-avarab@gmail.com","threadId":"48362","inReplyTo":null,"subject":"[PATCH 0/3] enable userdiff for more things in git.git","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2018-04-26T07:50:55Z","receivedAt":"2018-04-26T07:51:12Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"A noticed that git.git doesn't have userdiff enabled for perl files,\nand looking over some recent patches this gave better results, while\nI'm at it add one for Python too. I couldn't find anything in\ngitattributes(5) that was worth the bother of enabling this (e.g. we\njust have one Ruby file).\n\nÆvar Arnfjörð Bjarmason (3):\n .gitattributes: add *.pl extension for Perl\n .gitattributes: use the \"perl\" differ for Perl\n .gitattributes: add a diff driver for Python\n\n .gitattributes | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)\n\n-- \n2.17.0.290.gded63e768a\n\n"},{"id":"345882","messageId":"20180426075058.9322-2-avarab@gmail.com","threadId":"48362","inReplyTo":"20180426075058.9322-1-avarab@gmail.com","subject":"[PATCH 1/3] .gitattributes: add *.pl extension for Perl","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2018-04-26T07:50:56Z","receivedAt":"2018-04-26T07:51:16Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"Change the list of Perl extensions added in 00ddc9d13c (\"Fix build\nwith core.autocrlf=true\", 2017-05-09) to also include *.pl, we have\nsome of those in the tree, e.g. in t/.\n\nSigned-off-by: Ævar Arnfjörð Bjarmason \n---\n .gitattributes | 1 +\n 1 file changed, 1 insertion(+)\n\ndiff --git a/.gitattributes b/.gitattributes\nindex 8ce9c6b888..482af05a6a 100644\n--- a/.gitattributes\n+++ b/.gitattributes\n@@ -2,6 +2,7 @@\n *.[ch] whitespace=indent,trail,space diff=cpp\n *.sh whitespace=indent,trail,space eol=lf\n *.perl eol=lf\n+*.pl eof=lf\n *.pm eol=lf\n /Documentation/git-*.txt eol=lf\n /command-list.txt eol=lf\n-- \n2.17.0.290.gded63e768a\n\n"},{"id":"345883","messageId":"20180426075058.9322-3-avarab@gmail.com","threadId":"48362","inReplyTo":"20180426075058.9322-1-avarab@gmail.com","subject":"[PATCH 2/3] .gitattributes: use the \"perl\" differ for Perl","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2018-04-26T07:50:57Z","receivedAt":"2018-04-26T07:51:19Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"As noted in gitattributes(5) this gives better patch context for these\ntypes of files.\n\nSigned-off-by: Ævar Arnfjörð Bjarmason \n---\n .gitattributes | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/.gitattributes b/.gitattributes\nindex 482af05a6a..aa08dd219d 100644\n--- a/.gitattributes\n+++ b/.gitattributes\n@@ -1,9 +1,9 @@\n * whitespace=!indent,trail,space\n *.[ch] whitespace=indent,trail,space diff=cpp\n *.sh whitespace=indent,trail,space eol=lf\n-*.perl eol=lf\n-*.pl eof=lf\n-*.pm eol=lf\n+*.perl eol=lf diff=perl\n+*.pl eof=lf diff=perl\n+*.pm eol=lf diff=perl\n /Documentation/git-*.txt eol=lf\n /command-list.txt eol=lf\n /GIT-VERSION-GEN eol=lf\n-- \n2.17.0.290.gded63e768a\n\n"},{"id":"345884","messageId":"20180426075058.9322-4-avarab@gmail.com","threadId":"48362","inReplyTo":"20180426075058.9322-1-avarab@gmail.com","subject":"[PATCH 3/3] .gitattributes: add a diff driver for Python","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2018-04-26T07:50:58Z","receivedAt":"2018-04-26T07:51:20Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"Declare that the *.py files in our tree are Python for the purposes of\ndiffing, and as in 00ddc9d13c (\"Fix build with core.autocrlf=true\",\n2017-05-09) set eol=lf on them, which makes sense like with the *.perl\nfiles.\n\nSigned-off-by: Ævar Arnfjörð Bjarmason \n---\n .gitattributes | 1 +\n 1 file changed, 1 insertion(+)\n\ndiff --git a/.gitattributes b/.gitattributes\nindex aa08dd219d..1bdc91e282 100644\n--- a/.gitattributes\n+++ b/.gitattributes\n@@ -4,6 +4,7 @@\n *.perl eol=lf diff=perl\n *.pl eof=lf diff=perl\n *.pm eol=lf diff=perl\n+*.py eol=lf diff=python\n /Documentation/git-*.txt eol=lf\n /command-list.txt eol=lf\n /GIT-VERSION-GEN eol=lf\n-- \n2.17.0.290.gded63e768a\n\n"},{"id":"345888","messageId":"xmqqr2n21ex1.fsf@gitster-ct.c.googlers.com","threadId":"48362","inReplyTo":"20180426075058.9322-1-avarab@gmail.com","subject":"Re: [PATCH 0/3] enable userdiff for more things in git.git","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2018-04-26T09:43:22Z","receivedAt":"2018-04-26T09:43:30Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Ævar Arnfjörð Bjarmason writes:\n\n> A noticed that git.git doesn't have userdiff enabled for perl files,\n> and looking over some recent patches this gave better results, while\n> I'm at it add one for Python too. I couldn't find anything in\n> gitattributes(5) that was worth the bother of enabling this (e.g. we\n> just have one Ruby file).\n>\n> Ævar Arnfjörð Bjarmason (3):\n> .gitattributes: add *.pl extension for Perl\n> .gitattributes: use the \"perl\" differ for Perl\n> .gitattributes: add a diff driver for Python\n\nAll looked sane, except one minor \"Huh?\" in the titles.\n\nThe last one in the above list makes it look as if you are adding\nthe func header pattern and/or textconv filter for Python source\ncode, but the patch actually just specifies that .py is to be\nprocessed by the existing diff driver meant for Python, and at least\nto me, the wording for the second one reflects that better.\n\n"}]}