{"thread":{"id":"48247","subject":"[PATCH] configure.ac: fix botched FREAD_READS_DIRECTORIES check","startedAt":"2018-04-09T08:51:19Z","lastAt":"2018-04-09T08:51:19Z","messageCount":1,"participants":["Eric Sunshine"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"344183","messageId":"20180409085042.20215-1-sunshine@sunshineco.com","threadId":"48247","inReplyTo":null,"subject":"[PATCH] configure.ac: fix botched FREAD_READS_DIRECTORIES check","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2018-04-09T08:50:42Z","receivedAt":"2018-04-09T08:51:19Z","isPatch":true,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"3adf9fdecf (configure.ac: loosen FREAD_READS_DIRECTORIES test program,\n2017-06-14) broke the test program for the FREAD_READS_DIRECTORIES check\nby making it syntactically invalid (a dangling \")\") and by botching the\ntype returned from 'main' (a FILE* rather than int). As a consequence,\nthe test program won't even compile, thus the check fails\nunconditionally. Fix these problems.\n\nReported-by: Jonathan Primrose <jprimros@gmail.com>\nSigned-off-by: Eric Sunshine <sunshine@sunshineco.com>\n---\n\nProblem report and discussion:\nhttps://public-inbox.org/git/82c91eac-9dc4-834b-4648-3c4ba45af80d@gmail.com/\n\n configure.ac | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/configure.ac b/configure.ac\nindex 7f8415140f..a30d947e2a 100644\n--- a/configure.ac\n+++ b/configure.ac\n@@ -923,7 +923,7 @@ AC_RUN_IFELSE(\n \t[AC_LANG_PROGRAM([AC_INCLUDES_DEFAULT],\n \t\t[[\n \t\tFILE *f = fopen(\".\", \"r\");\n-\t\treturn f)]])],\n+\t\treturn f != NULL;]])],\n \t[ac_cv_fread_reads_directories=no],\n \t[ac_cv_fread_reads_directories=yes])\n ])\n-- \n2.17.0.484.g0c8726318c\n"}]}