{"thread":{"id":"48184","subject":"[PATCH v6 0/6] ref-filter: remove die() calls from formatting logic","startedAt":"2018-03-29T12:52:35Z","lastAt":"2018-03-30T06:42:16Z","messageCount":4,"participants":["Оля Тележная","Christian Couder","Eric Sunshine"],"isPatch":true,"patchVersion":6,"patchTotal":6},"messages":[{"id":"343321","messageId":"CAL21Bm=U=p+tw5FSXXBU01Bm=YCS6oQQSseB-Xv758onmxszwA@mail.gmail.com","threadId":"48184","inReplyTo":null,"subject":"[PATCH v6 0/6] ref-filter: remove die() calls from formatting logic","fromName":"Оля Тележная","fromEmail":"olyatelezhnaya@gmail.com","sentAt":"2018-03-29T12:52:28Z","receivedAt":"2018-03-29T12:52:35Z","isPatch":true,"sender":{"key":"olyatelezhnaya@gmail.com","avatar":"https://avatars.githubusercontent.com/u/11246099?v=4"},"body":"Move helper function from strbuf to ref-filter.\nGet rid of some memory leaks.\n\nThanks to everyone!\nOlga\n"},{"id":"343325","messageId":"CAP8UFD2EjZ9-qeS-3oWWS8O8ayP92aXAxAb1qK9qjKKqDh7y2g@mail.gmail.com","threadId":"48184","inReplyTo":"CAL21Bm=U=p+tw5FSXXBU01Bm=YCS6oQQSseB-Xv758onmxszwA@mail.gmail.com","subject":"Re: [PATCH v6 0/6] ref-filter: remove die() calls from formatting logic","fromName":"Christian Couder","fromEmail":"christian.couder@gmail.com","sentAt":"2018-03-29T14:41:02Z","receivedAt":"2018-03-29T14:41:09Z","isPatch":true,"sender":{"key":"christian.couder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/208954?v=4"},"body":"On Thu, Mar 29, 2018 at 2:52 PM, Оля Тележная <olyatelezhnaya@gmail.com> wrote:\n> Move helper function from strbuf to ref-filter.\n> Get rid of some memory leaks.\n\nThe above seems to be the changes since v5. Usually in a cover letter\n(patch 0/X) there is both information about the goal of the patch\nseries and the changes since last version.\n\nRepeating the goal in each version is useful for reviewers who might\nnot have time to look at the patch series before, or who might have\nforgotten about it.\n\nThanks,\nChristian.\n"},{"id":"343384","messageId":"CAPig+cTWKXrWggWO5EXA9dvpgW8rzZs=+XN3TK2GN4dM_gPiKg@mail.gmail.com","threadId":"48184","inReplyTo":"CAP8UFD2EjZ9-qeS-3oWWS8O8ayP92aXAxAb1qK9qjKKqDh7y2g@mail.gmail.com","subject":"Re: [PATCH v6 0/6] ref-filter: remove die() calls from formatting logic","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2018-03-30T00:16:50Z","receivedAt":"2018-03-30T00:16:59Z","isPatch":true,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Thu, Mar 29, 2018 at 10:41 AM, Christian Couder\n<christian.couder@gmail.com> wrote:\n> On Thu, Mar 29, 2018 at 2:52 PM, Оля Тележная <olyatelezhnaya@gmail.com> wrote:\n>> Move helper function from strbuf to ref-filter.\n>> Get rid of some memory leaks.\n>\n> The above seems to be the changes since v5. Usually in a cover letter\n> (patch 0/X) there is both information about the goal of the patch\n> series and the changes since last version.\n>\n> Repeating the goal in each version is useful for reviewers who might\n> not have time to look at the patch series before, or who might have\n> forgotten about it.\n\nAnother important way to help both returning and new reviewers is to\nprovide a link to the previous iteration (or iterations), like\nthis[1].\n\nThanks.\n\n[1]: https://public-inbox.org/git/0102016249d21c40-0edf6647-4d26-46fc-8cfd-5a446b93a5e2-000000@eu-west-1.amazonses.com/\n"},{"id":"343390","messageId":"CAL21Bm=hcvk7LUKP4PY5FgXJFBDanf-=MMzFEMv-1paUHfojYg@mail.gmail.com","threadId":"48184","inReplyTo":"CAP8UFD2EjZ9-qeS-3oWWS8O8ayP92aXAxAb1qK9qjKKqDh7y2g@mail.gmail.com","subject":"Re: [PATCH v6 0/6] ref-filter: remove die() calls from formatting logic","fromName":"Оля Тележная","fromEmail":"olyatelezhnaya@gmail.com","sentAt":"2018-03-30T06:42:10Z","receivedAt":"2018-03-30T06:42:16Z","isPatch":true,"sender":{"key":"olyatelezhnaya@gmail.com","avatar":"https://avatars.githubusercontent.com/u/11246099?v=4"},"body":"2018-03-29 17:41 GMT+03:00 Christian Couder <christian.couder@gmail.com>:\n> On Thu, Mar 29, 2018 at 2:52 PM, Оля Тележная <olyatelezhnaya@gmail.com> wrote:\n>> Move helper function from strbuf to ref-filter.\n>> Get rid of some memory leaks.\n>\n> The above seems to be the changes since v5. Usually in a cover letter\n> (patch 0/X) there is both information about the goal of the patch\n> series and the changes since last version.\n>\n> Repeating the goal in each version is useful for reviewers who might\n> not have time to look at the patch series before, or who might have\n> forgotten about it.\n\nThank you, I wasn't thinking about it that way. I agree, it's important.\n\nDescription:\nThe main idea of the patch is, if you want to format the output by\nref-filter, you should have an ability to work with errors and final\nmessage by yourself if you want to.\nSo I decided not to touch signature of show_ref_array_item(), but to\nmove all die() invocations to it. So that we could invoke\nformat_ref_array_item() and be sure that we could handle errors by\nourselves, and we also get formatted message so we could continue\nworking with it if we want to.\n\nThank you,\nOlga\n"}]}