{"thread":{"id":"48164","subject":"Windows build on Travis CI (was: Re: [PATCH v2 01/36] t/helper: add an empty test-tool program)","startedAt":"2018-03-27T15:03:05Z","lastAt":"2018-03-27T16:01:23Z","messageCount":2,"participants":["SZEDER Gábor","Johannes Schindelin"],"isPatch":true,"patchVersion":2,"patchTotal":36},"messages":[{"id":"343132","messageId":"CAM0VKjmRiOjb6Jsx1XCfGWe_9+AqJGeBvAWt2sM1_rJArdEVQA@mail.gmail.com","threadId":"48164","inReplyTo":null,"subject":"Windows build on Travis CI (was: Re: [PATCH v2 01/36] t/helper: add an empty test-tool program)","fromName":"SZEDER Gábor","fromEmail":"szeder.dev@gmail.com","sentAt":"2018-03-27T15:02:59Z","receivedAt":"2018-03-27T15:03:05Z","isPatch":true,"sender":{"key":"szeder.dev@gmail.com","avatar":"https://avatars.githubusercontent.com/u/116324?v=4"},"body":"On Tue, Mar 27, 2018 at 3:57 PM, Johannes Schindelin\n wrote:\n> Hi Gábor,\n>\n> On Tue, 27 Mar 2018, SZEDER Gábor wrote:\n>\n>> On Tue, Mar 27, 2018 at 12:14 AM, Johannes Schindelin\n>> wrote:\n>> > However, it seems that something is off, as\n>> > ba5bec9589e9eefe2446044657963e25b7c8d88e is reported as fine on Windows:\n>> > https://travis-ci.org/git/git/jobs/358260023 (while there is clearly a red\n>> > X next to that commit in\n>> > https://github.com/git/git/commits/ba5bec9589e9eefe2446044657963e25b7c8d88e,\n>> > that X is due to a hiccup on macOS).\n>> >\n>> > It seems that the good-trees feature for Travis does not quite work as\n>> > intended. Gábor?\n>>\n>> AFAICT it works as expected.\n>>\n>> When a build job encounters a commit with a tree that has previously\n>> been built and tested successfully, then first it says so, like this:\n>>\n>> https://travis-ci.org/szeder/git/jobs/347295038#L635\n>\n> But what if it has not been built successfully (as was the case here)?\n> This very commit that is \"succeeding\" on Travis fails to compile on\n> Windows.\n\nThen why has the GfW web app reported success?\n\n https://travis-ci.org/git/git/jobs/358260023#L512\n\n>> and then skips the rest of the build job (see the 'exit 0' a few lines\n>> later).\n>>\n>> In case of this Windows build job we haven't seen this tree yet:\n>>\n>> https://travis-ci.org/git/git/jobs/358260023#L467\n>>\n>> so the build job continues as usual (see the 'test -z Windows' two lines\n>> later).\n>>\n>> Unfortunately, I have no idea about how the rest of the Windows build\n>> job is supposed to work...\n>\n> Maybe Travis timed out waiting for the result, and marked it as a success?\n\nThis Windows build ran for 9 min 27 sec, i.e. not long enough for a\ntimeout on Travis CI. (OTOH, clearly not long enough to build Git and\nrun the test suite on Windows, I know.)\n\nBTW, a timeouted build job is marked as \"errored\" and the timeout is\nmentioned in its trace log:\n\n https://travis-ci.org/git/git/jobs/331669291#L509\n"},{"id":"343139","messageId":"nycvar.QRO.7.76.6.1803271758490.77@ZVAVAG-6OXH6DA.rhebcr.pbec.zvpebfbsg.pbz","threadId":"48164","inReplyTo":"CAM0VKjmRiOjb6Jsx1XCfGWe_9+AqJGeBvAWt2sM1_rJArdEVQA@mail.gmail.com","subject":"Re: Windows build on Travis CI (was: Re: [PATCH v2 01/36] t/helper: add an empty test-tool program)","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2018-03-27T16:01:07Z","receivedAt":"2018-03-27T16:01:23Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Gábor,\n\nOn Tue, 27 Mar 2018, SZEDER Gábor wrote:\n\n> On Tue, Mar 27, 2018 at 3:57 PM, Johannes Schindelin\n> wrote:\n> >\n> > On Tue, 27 Mar 2018, SZEDER Gábor wrote:\n> >\n> >> On Tue, Mar 27, 2018 at 12:14 AM, Johannes Schindelin\n> >> wrote:\n> >> > However, it seems that something is off, as\n> >> > ba5bec9589e9eefe2446044657963e25b7c8d88e is reported as fine on Windows:\n> >> > https://travis-ci.org/git/git/jobs/358260023 (while there is clearly a red\n> >> > X next to that commit in\n> >> > https://github.com/git/git/commits/ba5bec9589e9eefe2446044657963e25b7c8d88e,\n> >> > that X is due to a hiccup on macOS).\n> >> >\n> >> > It seems that the good-trees feature for Travis does not quite work as\n> >> > intended. Gábor?\n> >>\n> >> AFAICT it works as expected.\n> >>\n> >> When a build job encounters a commit with a tree that has previously\n> >> been built and tested successfully, then first it says so, like this:\n> >>\n> >> https://travis-ci.org/szeder/git/jobs/347295038#L635\n> >\n> > But what if it has not been built successfully (as was the case here)?\n> > This very commit that is \"succeeding\" on Travis fails to compile on\n> > Windows.\n> \n> Then why has the GfW web app reported success?\n> \n> https://travis-ci.org/git/git/jobs/358260023#L512\n\nOy. There was a shift in build steps, so that shows the wrong output. The\ncorrect build step ends thusly:\n\n-- snip --\n[...]\n2018-03-26T06:50:55.0000371Z Checking out files: 97% (3136/3232) \n2018-03-26T06:50:55.0106984Z Checking out files: 98% (3168/3232) \n2018-03-26T06:50:55.0223806Z Checking out files: 99% (3200/3232) \n2018-03-26T06:50:55.0227819Z Checking out files: 100% (3232/3232) \n2018-03-26T06:50:55.0228191Z Checking out files: 100% (3232/3232), done.\n2018-03-26T06:50:55.0343621Z HEAD is now at 90bbd502d Sync with Git 2.16.3\n2018-03-26T06:50:55.0759061Z Updating upstream\n2018-03-26T06:50:56.3001946Z From https://github.com/git/git\n2018-03-26T06:50:56.3002737Z * [new branch] maint -> upstream/maint\n2018-03-26T06:50:56.3003056Z * [new branch] master -> upstream/master\n2018-03-26T06:50:56.3003832Z * [new branch] next -> upstream/next\n2018-03-26T06:50:56.3354328Z * [new branch] pu -> upstream/pu\n2018-03-26T06:50:56.3354880Z * [new branch] todo -> upstream/todo\n2018-03-26T06:50:56.8219992Z fatal: Not a valid commit name 7a6a7fb7d0ab1052db113318478f9e40e66e59dc\n2018-03-26T06:50:56.8236547Z Commit 7a6a7fb7d0ab1052db113318478f9e40e66e59dc is not on branch upstream/master; skipping\n```\n\nSo as you see, by the time we fetched `pu`, it was no longer reachable\n(otherwise we would have been able to fetch it).\n\nThat's a bummer.\n\nCiao,\nDscho"}]}