{"thread":{"id":"48139","subject":"[PATCH] run-command: use strbuf_addstr() for adding a string to a strbuf","startedAt":"2018-03-25T10:57:58Z","lastAt":"2018-03-25T16:49:59Z","messageCount":3,"participants":["René Scharfe","Junio C Hamano","Duy Nguyen"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"342883","messageId":"19c993cf-7220-42e1-6a76-d257d97d6f55@web.de","threadId":"48139","inReplyTo":null,"subject":"[PATCH] run-command: use strbuf_addstr() for adding a string to a strbuf","fromName":"René Scharfe","fromEmail":"l.s.r@web.de","sentAt":"2018-03-25T10:57:50Z","receivedAt":"2018-03-25T10:57:58Z","isPatch":true,"sender":{"key":"l.s.r@web.de","avatar":"https://avatars.githubusercontent.com/u/26122331?v=4"},"body":"Patch generated with Coccinelle and contrib/coccinelle/strbuf.cocci.\n\nSigned-off-by: Rene Scharfe <l.s.r@web.de>\n---\nThat line was added by e73dd78699 (run-command.c: introduce\ntrace_run_command()).\n\n run-command.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/run-command.c b/run-command.c\nindex a483d5904a..84899e423f 100644\n--- a/run-command.c\n+++ b/run-command.c\n@@ -621,7 +621,7 @@ static void trace_run_command(const struct child_process *cp)\n \tif (!trace_want(&trace_default_key))\n \t\treturn;\n \n-\tstrbuf_addf(&buf, \"trace: run_command:\");\n+\tstrbuf_addstr(&buf, \"trace: run_command:\");\n \tif (cp->dir) {\n \t\tstrbuf_addstr(&buf, \" cd \");\n \t\tsq_quote_buf_pretty(&buf, cp->dir);\n-- \n2.16.3\n"},{"id":"342901","messageId":"xmqqbmfcf6cu.fsf@gitster-ct.c.googlers.com","threadId":"48139","inReplyTo":"19c993cf-7220-42e1-6a76-d257d97d6f55@web.de","subject":"Re: [PATCH] run-command: use strbuf_addstr() for adding a string to a strbuf","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2018-03-25T16:49:21Z","receivedAt":"2018-03-25T16:49:29Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"René Scharfe <l.s.r@web.de> writes:\n\n> Patch generated with Coccinelle and contrib/coccinelle/strbuf.cocci.\n>\n> Signed-off-by: Rene Scharfe <l.s.r@web.de>\n> ---\n> That line was added by e73dd78699 (run-command.c: introduce\n> trace_run_command()).\n\nThanks.\n\n>\n>  run-command.c | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/run-command.c b/run-command.c\n> index a483d5904a..84899e423f 100644\n> --- a/run-command.c\n> +++ b/run-command.c\n> @@ -621,7 +621,7 @@ static void trace_run_command(const struct child_process *cp)\n>  \tif (!trace_want(&trace_default_key))\n>  \t\treturn;\n>  \n> -\tstrbuf_addf(&buf, \"trace: run_command:\");\n> +\tstrbuf_addstr(&buf, \"trace: run_command:\");\n>  \tif (cp->dir) {\n>  \t\tstrbuf_addstr(&buf, \" cd \");\n>  \t\tsq_quote_buf_pretty(&buf, cp->dir);\n"},{"id":"342902","messageId":"CACsJy8C+JDqfg2a3Ju-rb8n+ovUsoXsn0P7vqJZ71PQ38Fs8gg@mail.gmail.com","threadId":"48139","inReplyTo":"19c993cf-7220-42e1-6a76-d257d97d6f55@web.de","subject":"Re: [PATCH] run-command: use strbuf_addstr() for adding a string to a strbuf","fromName":"Duy Nguyen","fromEmail":"pclouds@gmail.com","sentAt":"2018-03-25T16:49:24Z","receivedAt":"2018-03-25T16:49:59Z","isPatch":true,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"On Sun, Mar 25, 2018 at 12:57 PM, René Scharfe <l.s.r@web.de> wrote:\n> Patch generated with Coccinelle and contrib/coccinelle/strbuf.cocci.\n>\n> Signed-off-by: Rene Scharfe <l.s.r@web.de>\n> ---\n> That line was added by e73dd78699 (run-command.c: introduce\n> trace_run_command()).\n>\n>  run-command.c | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/run-command.c b/run-command.c\n> index a483d5904a..84899e423f 100644\n> --- a/run-command.c\n> +++ b/run-command.c\n> @@ -621,7 +621,7 @@ static void trace_run_command(const struct child_process *cp)\n>         if (!trace_want(&trace_default_key))\n>                 return;\n>\n> -       strbuf_addf(&buf, \"trace: run_command:\");\n> +       strbuf_addstr(&buf, \"trace: run_command:\");\n\nObviously correct. Ack.\n\n>         if (cp->dir) {\n>                 strbuf_addstr(&buf, \" cd \");\n>                 sq_quote_buf_pretty(&buf, cp->dir);\n> --\n> 2.16.3\n\n\n\n-- \nDuy\n"}]}