{"thread":{"id":"48082","subject":"multimail/p4: issues identified by lgtm.com","startedAt":"2018-03-19T11:24:39Z","lastAt":"2018-03-19T14:30:38Z","messageCount":2,"participants":["Johannes Schindelin","Matthieu Moy"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"342136","messageId":"nycvar.QRO.7.76.6.1803191217410.55@ZVAVAG-6OXH6DA.rhebcr.pbec.zvpebfbsg.pbz","threadId":"48082","inReplyTo":null,"subject":"multimail/p4: issues identified by lgtm.com","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2018-03-19T11:24:03Z","receivedAt":"2018-03-19T11:24:39Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi team,\n\nwhile Coverity was down (it still is not reachable for me, but I guess\nthat's just because everybody and their dog wants to catch up on a month\nof work delayed by their outage), I tried to find alternatives, and one of\nthem is lgtm.com. Their C/C++ support is not generally available yet, but\nthere have been a couple of issues identified in our Python scripts:\n\nhttps://lgtm.com/projects/g/git/git/alerts/?mode=list&rule=py%2Fcall%2Fwrong-arguments%2Cpy%2Fcall%2Fwrong-named-argument%2Cpy%2Fexplicit-call-to-delete%2Cpy%2Finconsistent-equality%2Cpy%2Finheritance%2Fincorrect-overridden-signature%2Cpy%2Fmissing-call-to-init%2Cpy%2Fmultiple-definition%2Cpy%2Fredundant-else%2Cpy%2Funinitialized-local-variable%2Cpy%2Funreachable-statement\n\nFrom a cursory look, it *does* seem as if there are legitimate issues\nthere that want to be fixed ;-) But then, I am far from a Python expert,\nso my impressions could be completely off the mark.\n\nCiao,\nJohannes\n"},{"id":"342189","messageId":"86d100uqbw.fsf@matthieu-moy.fr","threadId":"48082","inReplyTo":"nycvar.QRO.7.76.6.1803191217410.55@ZVAVAG-6OXH6DA.rhebcr.pbec.zvpebfbsg.pbz","subject":"Re: multimail/p4: issues identified by lgtm.com","fromName":"Matthieu Moy","fromEmail":"git@matthieu-moy.fr","sentAt":"2018-03-19T13:50:43Z","receivedAt":"2018-03-19T14:30:38Z","isPatch":false,"sender":{"key":"git@matthieu-moy.fr","avatar":"https://avatars.githubusercontent.com/u/14709?v=4"},"body":"Johannes Schindelin writes:\n\n> Hi team,\n>\n> while Coverity was down (it still is not reachable for me, but I guess\n> that's just because everybody and their dog wants to catch up on a month\n> of work delayed by their outage), I tried to find alternatives, and one of\n> them is lgtm.com. Their C/C++ support is not generally available yet, but\n> there have been a couple of issues identified in our Python scripts:\n>\n> https://lgtm.com/projects/g/git/git/alerts/?mode=list&rule=py%2Fcall%2Fwrong-arguments%2Cpy%2Fcall%2Fwrong-named-argument%2Cpy%2Fexplicit-call-to-delete%2Cpy%2Finconsistent-equality%2Cpy%2Finheritance%2Fincorrect-overridden-signature%2Cpy%2Fmissing-call-to-init%2Cpy%2Fmultiple-definition%2Cpy%2Fredundant-else%2Cpy%2Funinitialized-local-variable%2Cpy%2Funreachable-statement\n>\n> From a cursory look, it *does* seem as if there are legitimate issues\n> there that want to be fixed ;-) But then, I am far from a Python expert,\n> so my impressions could be completely off the mark.\n\nFor git-multimail, there are actually a lot of false-positive due to the\nway we use multiple-inheritance (when calling super(...).__init__(),\nlgtm assumes we're calling the superclass's constructor while we\nactually call the \"next in the method resolution order list\"), but also\nprobably valid concerns.\n\nI've set up a separate project for git-multimail:\n\n  https://lgtm.com/projects/g/git-multimail/git-multimail/alerts/?mode=list\n\nI'll have a deeper look ASAP.\n\nThanks!\n\n-- \nMatthieu Moy\nhttps://matthieu-moy.fr/\n"}]}