{"thread":{"id":"48074","subject":"[PATCH] completion: complete tags with git tag --delete/--verify","startedAt":"2018-03-18T04:01:42Z","lastAt":"2018-03-19T16:55:36Z","messageCount":2,"participants":["Todd Zullinger","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"342074","messageId":"20180318040135.30710-1-tmz@pobox.com","threadId":"48074","inReplyTo":null,"subject":"[PATCH] completion: complete tags with git tag --delete/--verify","fromName":"Todd Zullinger","fromEmail":"tmz@pobox.com","sentAt":"2018-03-18T04:01:35Z","receivedAt":"2018-03-18T04:01:42Z","isPatch":true,"sender":{"key":"tmz@pobox.com","avatar":"https://avatars.githubusercontent.com/u/806319?v=4"},"body":"Completion of tag names has worked for the short -d/-v options since\n88e21dc746 (\"Teach bash about completing arguments for git-tag\",\n2007-08-31).  The long options were not added to \"git tag\" until many\nyears later, in c97eff5a95 (\"git-tag: introduce long forms for the\noptions\", 2011-08-28).\n\nExtend tag name completion to --delete/--verify.\n\nSigned-off-by: Todd Zullinger <tmz@pobox.com>\n---\n contrib/completion/git-completion.bash | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex 6da95b8095..c7957f0a90 100644\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -2967,7 +2967,7 @@ _git_tag ()\n \twhile [ $c -lt $cword ]; do\n \t\ti=\"${words[c]}\"\n \t\tcase \"$i\" in\n-\t\t-d|-v)\n+\t\t-d|--delete|-v|--verify)\n \t\t\t__gitcomp_direct \"$(__git_tags \"\" \"$cur\" \" \")\"\n \t\t\treturn\n \t\t\t;;\n-- \n2.17.0.rc0\n\n"},{"id":"342203","messageId":"xmqqk1u8vwce.fsf@gitster-ct.c.googlers.com","threadId":"48074","inReplyTo":"20180318040135.30710-1-tmz@pobox.com","subject":"Re: [PATCH] completion: complete tags with git tag --delete/--verify","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2018-03-19T16:55:29Z","receivedAt":"2018-03-19T16:55:36Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Todd Zullinger <tmz@pobox.com> writes:\n\n> Completion of tag names has worked for the short -d/-v options since\n> 88e21dc746 (\"Teach bash about completing arguments for git-tag\",\n> 2007-08-31).  The long options were not added to \"git tag\" until many\n> years later, in c97eff5a95 (\"git-tag: introduce long forms for the\n> options\", 2011-08-28).\n>\n> Extend tag name completion to --delete/--verify.\n>\n> Signed-off-by: Todd Zullinger <tmz@pobox.com>\n> ---\n\nThanks, makes sense.\n\n>  contrib/completion/git-completion.bash | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\n> index 6da95b8095..c7957f0a90 100644\n> --- a/contrib/completion/git-completion.bash\n> +++ b/contrib/completion/git-completion.bash\n> @@ -2967,7 +2967,7 @@ _git_tag ()\n>  \twhile [ $c -lt $cword ]; do\n>  \t\ti=\"${words[c]}\"\n>  \t\tcase \"$i\" in\n> -\t\t-d|-v)\n> +\t\t-d|--delete|-v|--verify)\n>  \t\t\t__gitcomp_direct \"$(__git_tags \"\" \"$cur\" \" \")\"\n>  \t\t\treturn\n>  \t\t\t;;\n"}]}